Re: [PATCH 2/5] d3dx9_36: Improved constant table handle support (try 3)

2011-07-18 Thread Travis Athougies
On Mon, Jul 18, 2011 at 2:41 AM, Alexandre Julliard wrote: > Travis Athougies writes: > >> +static ctab_constant *is_valid_constant(ID3DXConstantTableImpl *This, >> D3DXHANDLE parameter) >> +{ >> +    UINT i; >> + >> +    for (i = 0; i < This->des

Fwd: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt (Try 5)

2011-03-29 Thread Travis Athougies
nvalid > FP bit pattern is loaded into an FP register. > If I'm casting ints to floats (and not int pointers to float pointers) I don't see how this could be an issue. Travis -- Travis Athougies

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt (Try 5)

2011-03-28 Thread Travis Athougies
egisters. > > Also I'd prefer if there would be TRACEs in each function. > > It might be useful to add the RegisterSet in the FIXME for the default case, > to see which one is missing in the special case. Okay. Travis. > > Cheers > Rico > > Am 27.03.2011 2

Re: [PATCH 2/5] d3dx9_36: Implemented ID3DXConstantTable_SetIntArray and ID3DXConstantTable_SetInt

2011-02-08 Thread Travis Athougies
On Feb 8, 2011, at 4:10 AM, Matteo Bruni wrote: + /* We need the for loop, since we need to convert the integer to a float */ +for (i = 0; i < count && i < desc.RegisterCount; i++) +{ +row[0] = (float)n[i]; The cast is unneeded, and the comment above is

Re: [PATCH 5/5] d3dx9_36/tests: Added tests for ID3DXConstantTable_Set* functions

2011-01-21 Thread Travis Athougies
Regardless, I've modified the tests a so that they should pass on windows. Can you verify that they do? Travis. On Fri, Jan 21, 2011 at 9:22 PM, Henri Verbeet wrote: > On 22 January 2011 06:11, Travis Athougies wrote: >> The failed tests worry me since it passes on linux

Re: [PATCH 5/5] d3dx9_36/tests: Added tests for ID3DXConstantTable_Set* functions

2011-01-21 Thread Travis Athougies
The failed tests worry me since it passes on linux with a native d3dx9_36 dll. Have you tried a native d3dx9_36 with wine? Do the tests still fail? Travis. On Thu, Jan 20, 2011 at 8:48 AM, Matteo Bruni wrote: > 2011/1/20 Travis Athougies : >> +static void test_setting_ba

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-21 Thread Travis Athougies
Oh I'm sorry. I now see what you mean, you were talking about the register index parameter to Set*ShaderConstantF? Yes, that should be changed. I will submit updated patches shortly. Travis. On Fri, Jan 21, 2011 at 3:22 PM, Travis Athougies wrote: > matrix + i will advance by the s

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-21 Thread Travis Athougies
Bruni wrote: > 2011/1/21 Michael Stefaniuc : >> On 01/21/2011 06:56 AM, Travis Athougies wrote: >>> On Thu, Jan 20, 2011 at 7:27 AM, Matteo Bruni >>>  wrote: >>>> >>>> 2011/1/20 Travis Athougies: >>>>> >>>>> +          

Re: [PATCH 4/5] d3dx9_36: Implemented ID3DXConstantTable_SetMatrix and ID3DXConstantTable_SetMatrixArray

2011-01-20 Thread Travis Athougies
owever, the next matrix is actually at 0x8040 (since sizeof(float) * 16 [the number of elements in the matrix] = 64). Travis. On Thu, Jan 20, 2011 at 7:27 AM, Matteo Bruni wrote: > 2011/1/20 Travis Athougies : >> +            /* D3DXMATRIX is a union, one of whose elements is an array, s

Testbot not accepting patch

2011-01-14 Thread Travis Athougies
the patch status page is apply failure). As far as I can tell, the patch looks good, it was generated by git format-patch from the latest git and I did not touch it after that, so it should apply, but it doesn't. Can you look into this? Thanks, Travis. -- Travis Athougi

Re: [PATCH] d3dcompiler_43/tests: Added error tests to HLSL test suite

2010-12-23 Thread Travis Athougies
>> On 12/22/2010 10:31 PM, Travis Athougies wrote: >>> >>> Tests to ensure the HLSL compiler won't crash on malformed input. >>> >>> --- >>>  dlls/d3dcompiler_43/tests/hlsl.c |   87 >>> ++ >>&g

Re: [PATCH 5/5] d3dcompiler_43/tests: Added trigonometric function tests to HLSL test suite

2010-11-07 Thread Travis Athougies
:20, Travis Athougies wrote: >> +/* Repeatedly call a shader 32 times with linearly varying values and test >> the results against >> +   an array of floats using the given epsilon */ > Why can't this just use the existing framework? > > > -- Travis Athougies

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite

2010-09-28 Thread Travis Athougies
On Mon, Sep 27, 2010 at 3:57 AM, Henri Verbeet wrote: > On 27 September 2010 02:22, Travis Athougies wrote: >>>> +    /* The Direct3D 9 docs state that we cannot lock a render target >>>> surface, >>>> +       instead we must copy the render target onto

Re: [PATCH 1/5] d3dcompiler_43/tests: Added HLSL test suite

2010-09-26 Thread Travis Athougies
On Sun, Sep 26, 2010 at 12:41 PM, Stefan Dösinger wrote: > > Am 26.09.2010 um 19:51 schrieb Travis Athougies: > >> +data = compute_shader_fullscreen9(device, vshader_passthru, >> pshader, quad_geometry, >> +D3DFMT_A8R8G8B8, 1, 1);

Re: Wine test bot failure?

2010-09-24 Thread Travis Athougies
Still, I would like for it to be able to be buillt.. On Fri, Sep 24, 2010 at 1:20 AM, Austin English wrote: > On Fri, Sep 24, 2010 at 12:30 AM, Travis Athougies wrote: >> Hi, >> >> I was trying to run my HLSL test suite patch through wine test bot and >> the build

Wine test bot failure?

2010-09-24 Thread Travis Athougies
mmand. The results are at https://testbot.winehq.org/JobDetails.pl?Key=5449&log_101=1#k101 How can I get this to builid and run? Travis Athougies. -- Travis Athougies

Re: [PATCH 2/7] d3dx9_36/tests: Added HLSL test suite

2010-09-11 Thread Travis Athougies
;t see a nice, > concise checklist of things to check for, so I added one at the top, and > linked to Henri's post.  Improvements welcome. > - Dan > > > -- Travis Athougies

RFC: draft HLSL test suite

2010-07-24 Thread Travis Athougies
Athougies On Thu, Jul 22, 2010 at 3:16 PM, Henri Verbeet wrote: > On 21 July 2010 23:46, Travis Athougies wrote: >> an HLSL test suite might be a good place to start, so here's a draft >> of a test framework and a few tests that use it.  It's not complete, I >> know

RFC: draft HLSL test suite

2010-07-21 Thread Travis Athougies
this the way a wine HLSL test suite should look? Is there something else I should incorporate into these tests? I'm absolutely open to suggestions. And lastly, I'd like to thank the wine developers for producing such a wonderful piece of software. We really appreciate you all! Trav

Contributing

2008-03-26 Thread Travis Athougies
Hi, I would like to help contribute to WINE because I use it so much yet I've never actually contributed to it. I was wondering if there are any simple bugs or other tasks that someone new to WINE development could undertake. Thanks. -- From: Travis Athougies 2 + 2 = 4