Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

On 10/11/2012 07:29 PM, Dmitry Timoshkov wrote: > "Vincas Miliūnas" wrote: > >> Unless you mind sharing why it is wrong, I will not be able to read your >> mind. > Just do your homework and have a look at other places that use DUMMYUNIONNAME. > Thanks for sharing knowledge with your attitude.

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

On 10/11/2012 04:30 AM, Dmitry Timoshkov wrote: > "Vincas Miliūnas" wrote: > >> * Renamed DUMMYUNIONNAME to u. > ... >> +typedef struct _FILE_ID_DESCRIPTOR { >> +DWORDdwSize; >> +FILE_ID_TYPE Type; >> +union { &

Re: [PATCH 5/5] kernel32: Added implementation for OpenFileById.

On 10/10/2012 05:45 AM, Dmitry Timoshkov wrote: > "Vincas Miliūnas" wrote: > >> +objectName.Buffer = (WCHAR >> *)&lpFileID->DUMMYUNIONNAME.FileId; > This doesn't look right. That's how the pointer to the fileid is transported, see

Re: Updated Clang static analysis results / Valgrind update

On 07/03/2011 04:33 PM, Frédéric Delanoy wrote: > 2011/7/3 Vincas Miliūnas : >>> On Sun, Jul 3, 2011 at 04:15, Austin English >> <http://www.winehq.org/mailman/listinfo/wine-devel>> wrote: >>>> / Web space usage was getting a bit high, so I've uploaded

Re: Updated Clang static analysis results / Valgrind update

> On Sun, Jul 3, 2011 at 04:15, Austin English > wrote: > >/ Web space usage was getting a bit high, so I've uploaded a tarball to > />/ a file download service: > />/ http://www.sendspace.com/file/5hot36 > />/ > />/ austin at aw21

Re: wine bug 27600

On 07/02/2011 04:21 AM, Austin Lund wrote: > On 1 July 2011 06:10, wrote: >> >> gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ >> -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing >> -Wdeclaration-after-statement -Wempty-body -Wstrict-prototypes >> -Wtype-limits -Wwrite-strings -

Re: wine bug 27600

On 06/30/2011 06:07 PM, Vincas Miliūnas wrote: > On 06/30/2011 05:57 PM, wy...@volny.cz wrote: >>> $ cd wine-git >>> $ wget http://dl.dropbox.com/u/6901628/raw.patch >>> $ patch -p1 < raw.patch >>> $ ./tools/make_requests >>> $ ./configure

Re: wine bug 27600

On 06/30/2011 05:57 PM, wy...@volny.cz wrote: >> $ cd wine-git >> $ wget http://dl.dropbox.com/u/6901628/raw.patch >> $ patch -p1 < raw.patch >> $ ./tools/make_requests >> $ ./configure >> $ make >> >> works here: > Thanks Austin for testing, but this raw.patch is already modified > and works for m

Re: wine bug 27600

On 06/30/2011 05:31 PM, wy...@volny.cz wrote: >> Ok, try with a modified header: >> > OK no problem, i will try later today. But i don't think it's a bug > in applicability of those patches. I began with wine testing 2 years > ago and did many regression tests, reverse reg.testing, found faulty > c

Re: wine bug 27600

On 06/30/2011 02:19 AM, wy...@volny.cz wrote: >> There is some garbage added to the patch code, I >> suspect that the way >> you downloaded the patch corrupted it. >> >> I wrote a bash script that will download the >> patches correctly and apply >> them: >> >> git clean -fd >> git reset --hard orig

Re: wine bug 27600

On 06/30/2011 12:22 AM, wy...@volny.cz wrote: >> The patch is rebased against today's commits - >> http://dl.dropbox.com/u/6901628/raw.patch > The good news is, that this combo patch successfully compiles here. > > The bad new is, that today's 9 newly sent patches still fails here. > I did regressi

Re: wine bug 27600

On 06/29/2011 01:25 AM, wy...@volny.cz wrote: >> It fails on the #include "winternl.h" line and >> these are standard >> includes, you can try to replace >> >> [code] >> #include >> #include >> [/code] >> >> code fragment with >> >> [code] >> #include "config.h" >> #include "wine/port.h" >> >> #i

Re: wine bug 27600

On 06/29/2011 12:28 AM, wy...@volny.cz wrote: >> Looks like there is some external interference, >> try compiling in a clean >> bash environment; some googling suggests that >> LIBRARY_PATH variable >> should be unset - >> https://bbs.archlinux.org/viewtopic.php?id=30418 >> First be sure it can com

Re: wine bug 27600

On 06/29/2011 12:10 AM, wy...@volny.cz wrote: > So i another try: > * rm -rf * in my git tree. > * git checkout -f 2497a91f6b1326988dd5ea56dc4052cbcc2e521d > * applied all nine patches > * ./tools/make_requests > * configure + make with -O2 and got again: > >> In file included from raw_input.c:28:

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)

On 06/22/2011 06:41 PM, André Hentschel wrote: > ... Done - http://source.winehq.org/patches/data/75767

Re: [PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)

On 06/22/2011 06:26 PM, André Hentschel wrote: > Am 22/06/2011 06:26, schrieb Vincas Miliūnas: >> +if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData && pGetRawInputDeviceList && >> +pGetRawInputDeviceInfoA && p

Re: [PATCH 2/3] server: Added server-side raw input function implementations (try 4)

On 06/20/2011 05:24 PM, Vitaliy Margolen wrote: > On 06/20/2011 02:55 AM, Vincas Miliūnas wrote: >> (see the message in the first part of the patch) >> +struct raw_input >> +{ >> +struct listentry; >> +unsigned short usage_page; >>

Re: [PATCH 1/6] server: Add server-side raw input functions definitions

On 06/16/2011 04:26 PM, Vitaliy Margolen wrote: > On 06/15/2011 10:37 PM, Vincas Miliūnas wrote: >> On 06/16/2011 01:00 AM, Vitaliy Margolen wrote: >>> I'm not sure I like your approach and that AJ would like it either. >>> >>> Raw input is an "

Re: [PATCH 1/6] server: Add server-side raw input functions definitions

On 06/16/2011 01:00 AM, Vitaliy Margolen wrote: > On 06/14/2011 02:45 AM, Vincas Miliūnas wrote: >> This is a partial raw input implementation for mouse and keyboard. >> >> I've read in the IRC chat, that products of tools/make_request should >> not > be incl

Re: [PATCH 1/4] msvcp90: Added basic_string::append(size_t, char) implementation.

s M. On 04/20/2011 05:24 PM, Piotr Caban wrote: > Hi, > > On 04/18/11 23:53, Vincas Miliūnas wrote: >> My remark: (The method is implemented by reusing existing code) >> this->size+countsize is the same as count< 0 and throwing a "string >> too long" exc