Re: [PATCH 2/2] d3d11.idl: Added some missing declarations.

2013-09-11 Thread Michael Stefaniuc
be __MSABI_LONG, although we may not care enough. We certainly aren't very consistent about it in a lot of other places either. I just replaced the long numeric constants with the __MSABI_LONG. But we don't need those anyway, it's mingw-w64 who needs them for C++ compatibility. bye michael

Re: Sequences in a loop

2013-08-30 Thread Michael Stefaniuc
rop++) > I know in some cases to use sequences are wiser way than pointers, > but so many of them are used in loops. > Should I change them? Optimizations should be primary for the human reader of the code. Compilers nowadays do a far better job at micro-optimization than humans. bye michael

Re: ntdll: Store all 'comClass' attributes (try3)

2013-08-28 Thread Michael Stefaniuc
max = n-1; > +else > +min = n+1; > +} > + > +WARN("unknown flag %s\n", debugstr_wn(str, len)); > +return 0; > +} bye michael

Re: Wiki is down

2013-08-23 Thread Michael Stefaniuc
On 08/23/2013 03:39 PM, Rosanne DiMesio wrote: > I'm getting an "Unable to connect" message from Firefox and "Connection > closed by remote server" from Opera. CC'ing Dimi as he might not read wine-devel so often. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
;s a reason git opts to sort the text lines. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 05:40 PM, Tae Wong wrote: > In the GIT tree, the AUTHORS file is sorted on first names. Wrong. It is sorted by the text line. The first word on the line can be the first or lastname, depending what the author used. bye michael

Re: Sort the AUTHORS file by their last names.

2013-08-16 Thread Michael Stefaniuc
On 08/16/2013 04:42 PM, Tae Wong wrote: > Julliard said that it should feel free to provide a script that sorts > by last name. > > You want to do this. Careful. It is a trap. He is fine with it if it is done *right*. Figuring out what the last name is is a hard problem. bye michael

Re: [website] Update git URL

2013-08-16 Thread Michael Stefaniuc
nd on the http://wiki.winehq.org/GitWine";>GitWine >page on the http://wiki.winehq.org";>Wine Wiki. bye michael

Re: What to do when an application misuses an API ...

2013-07-24 Thread Michael Casadevall
On Wed, Jul 24, 2013 at 1:22 AM, Damjan Jovanovic <mailto:damjan@gmail.com>> wrote: On Wed, Jul 24, 2013 at 4:17 AM, Michael Casadevall mailto:mcasadev...@ubuntu.com>> wrote: > Hey all, > I've been working on trying to get Sid Meier's C

What to do when an application misuses an API ...

2013-07-23 Thread Michael Casadevall
issue has cropped up elsewhere (figuring out the underlying cause was exceedingly annoying). Any insight in to what the most correct course of action would be most appreciated I'm perfectly willing to put the legwork in fixing this bug, but I want to make sure I'm fixing it in a way that will be accepted :-). Regards, Michael

Re: Another major milestone

2013-07-19 Thread Michael Stefaniuc
e grinding > them out really fast now" ;) Soon he'll want us to do 6 or even 3 months time based releases! ;) bye michael

Fwd: Re: RFC: Three dots or Unicode ellipsis character

2013-07-03 Thread Michael Stefaniuc
Original Message Subject: Re: RFC: Three dots or Unicode ellipsis character Date: Wed, 03 Jul 2013 19:32:15 +0200 From: Michael Stefaniuc To: Francois Gouget On 07/03/2013 04:45 PM, Francois Gouget wrote: > > Wine uses three dots (...) rather than the Unicode el

Re: winex11.drv: When skipping unknown attribute also skip it's value.

2013-06-30 Thread Michael Stefaniuc
GNED_FLOAT_TYPE_EXT: %x\n", cur, pop); >break ; > default: > - FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur]); > + FIXME("unsupported %x WGL Attribute\n", iWGLAttr[cur++]); Side effects in the debug output functions should be avoided. >break; > } > ++cur; > bye michael

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Michael Stefaniuc
> working on it anyway". Sure, fix the lines you modify and the block you're in. Avoid having whitespace only diff chunks. bye michael

Re: testbot and NT4

2013-06-03 Thread Michael Stefaniuc
emove NT4 "hacks" in the testsuite. My guess is that the same rule applies as for the Win9x test "hacks": Only remove when the culprit code is changed anyway. bye michael

Re: wineconsole screen scenarios

2013-05-16 Thread Michael Stefaniuc
fe assumption. Wine is *not* X specific anymore. On MacOSX you can use the native quartz driver. And I wouldn't wonder if Alexandre plans for a native driver for Android too. bye michael

Re: [PATCH 1/2] gdi32: Clip font glyphs to fit within text metrics. (try 2)

2013-04-26 Thread Michael Stefaniuc
gger itself suffered an internal crash as well. Can anyone else verify? Did something mess up during AJ's build? Sam, look at the size of the address. It is the 64bit build that crashes. bye michael

Re: Clang static analyzer results / wine-1.5.28-66-g6899279

2013-04-19 Thread Michael Stefaniuc
where the Wine code was bad due to that as it "passed" the tests. bye michael

Re: d3dx9 [patch 1/2, try 3]: Implement D3DXSHEvalSphericalLight

2013-03-26 Thread Michael Mc Donnell
On Tue, Mar 26, 2013 at 7:07 PM, Nozomi Kodama wrote: > Why are they not committed yet? > Alexandre is on vacation so that might explain why :-)

wiki.winehq.org is down

2013-03-07 Thread Michael Stefaniuc
Hey Dimi, the wiki is down: is the wiki down? it pings but with high latency and while port 80 connects a GET / doesn't returns thanks bye michael

Re: ntdll: make NtDelayExecution a bit more efficient

2013-03-06 Thread Michael Stefaniuc
If the ancient wisdom isn't backed by tests there's a fair chance that it might not be applicable today. Or that it was a wrong theory back then too. bye michael

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use. (try 2)

2013-03-01 Thread Michael Stefaniuc
+ stamp.QuadPart % freq.QuadPart * 1000 / freq.QuadPart; } bye michael

Re: mmdevapi: Prevent 64 bit overflow within a few days of audio device use.

2013-02-27 Thread Michael Stefaniuc
-heure-est-il/ thanks bye michael

Re: iphlpapi: Let C look like C.

2013-02-07 Thread Michael Stefaniuc
Thanks Juan, On 02/07/2013 12:54 AM, Juan Lang wrote: > Hi Michael, this isn't actually a problem with your patch, just > something I spotted: > > On Wed, Feb 6, 2013 at 3:15 PM, Michael Stefaniuc <mailto:mstef...@redhat.com>> wrote: > > On 02/06/201

Re: iphlpapi: Let C look like C.

2013-02-06 Thread Michael Stefaniuc
On 02/06/2013 11:16 PM, Austin English wrote: > On Feb 6, 2013 11:13 PM, "Michael Stefaniuc" <mailto:mstef...@redhat.de>> wrote: >> >> --- >> dlls/iphlpapi/ipstats.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >

Re: ws2_32: Use assignment instead of memcpy to copy structs.

2013-01-24 Thread Michael Stefaniuc
Forgot to add the credit for this patch series as I didn't wrote this coccinelle script: Found using the memcpy-assign.cocci script submitted for inclusion into the Linux kernel: https://systeme.lip6.fr/pipermail/cocci/2013-January/000121.html bye michael On 01/24/2013 02:21 PM, Mi

Re: Reload a DLL and _getptd returns zero

2013-01-15 Thread Michael Ost
On 01/15/2013 01:08 PM, Piotr Caban wrote: On 1/15/13 7:59 PM, Michael Ost wrote: On 01/15/2013 03:39 AM, Piotr Caban wrote: The crash is caused by incomplete FlsFree implementation. There's a comment in it's code that says what needs to be added: /* FIXME: add equivalent of ThreadZ

Re: Reload a DLL and _getptd returns zero

2013-01-15 Thread Michael Ost
On 01/15/2013 03:39 AM, Piotr Caban wrote: On 01/15/13 00:32, Michael Ost wrote: Here's a link to a zip file that includes the prebuilt .exe and .dll windows binaries that crash in wine. Plus the code. https://dl.dropbox.com/u/97386125/msvcrt-dll-problem.zip The crash is caused by incom

Re: Reload a DLL and _getptd returns zero

2013-01-14 Thread Michael Ost
On 01/12/2013 05:21 PM, Dan Kegel wrote: The library in question is using static vc runtime linkage, so _getptd() is linked in That's somewhat worrisome. So you have multiple instances of the C runtime library active in the same app? Maybe you're not unloading that dll gracefully enough. Mig

Re: Reload a DLL and _getptd returns zero

2013-01-13 Thread Michael Ost
On 1/13/13 1:17 PM, Marcus Meissner wrote: On Fri, Jan 11, 2013 at 11:24:55AM -0800, Michael Ost wrote: Hi list, Does anyone know why _getptd() calls would return zero on a DLL that has been reloaded? Does something happen to the TLS used by _getptd? At Muse Research we have been struggling

Reload a DLL and _getptd returns zero

2013-01-11 Thread Michael Ost
wrong with the values in TlsSlots. Maybe they persist for DLLs in Windows in a way they don't for Wine...? Or maybe Wine doesn't reinitialize them the same way when the DLL is reloaded? Any hints, thoughts? clues? Thanks! -- Michael Ost

Re: Patchsets that need review by experienced Wine Developers

2013-01-04 Thread Michael Ost
mes down to the WS_DLGFRAME|WS_THICKFRAME flags. If they are both present then the window is not visible. Turn on or the other off in the example and the window shows up. The second window must have a parent and have the WS_OVERLAPPED style as well." Hope that helps. -- Michael Ost Muse Research and Development

FindFirstVolume crash

2012-12-12 Thread Michael Ost
x27;m having trouble making my way through the wineserver code, so any tips or pointers would be appreciated! Thank you, Michael Ost Muse Research, Inc.

Re: [PATCH 1/3] include: Define FIELD_OFFSET to the standard offsetof macro

2012-12-11 Thread Michael Stefaniuc
On 12/11/2012 10:20 AM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >> On 12/10/2012 07:37 PM, Amine Khaldi wrote: >>> This prevents the undefined behavior (null pointer dereference) >>> diagnostics (clang with ubsan checks for example). >> This

Re: [PATCH 1/3] include: Define FIELD_OFFSET to the standard offsetof macro

2012-12-10 Thread Michael Stefaniuc
f > > #define CONTAINING_RECORD(address, type, field) \ >((type *)((PCHAR)(address) - (PCHAR)(&((type *)0)->field))) bye michael

Re: [PATCH] amstream: Initialize correctly AM_MEDIA_TYPE struct.

2012-11-15 Thread Michael Stefaniuc
29.aspx "pUnk Not used. Set to NULL." Setting that to NULL in amstream's BasePinImp_GetMediaType() fixes the crash for me. But who's responsibility is to set / check that? That function or the caller aka test_media_streams() ? bye michael

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-11 Thread Michael Stefaniuc
up > execution and simplify maintenance. > It is a hack that breaks the ABI (sizeof(interface) == sizeof(void*)), doesn't improves the generated code, doesn't simplify maintenance at all, quite the contrary. This sounds more like trolling than a serious attempt to improve Wine. bye michael

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-11 Thread Michael Stefaniuc
the Vtbl is simply a way of enforcing the > association. If you do not define a _IFACE_DATA macro, nothing > happens. bye michael

Re: [PATCH] tools/widl/header.c: Add a way to declare interface data members.

2012-11-10 Thread Michael Stefaniuc
ite_com_interface_end(FILE *header, > type_t *iface) >fprintf(header, "} %sVtbl;\n", iface->name); >fprintf(header, "interface %s {\n", iface->name); >fprintf(header, " CONST_VTBL %sVtbl* lpVtbl;\n", iface->name); > + > + write_interface_data_macro(header, iface); > + >fprintf(header, "};\n"); >fprintf(header, "\n"); >fprintf(header, "#ifdef COBJMACROS\n"); bye michael

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-08 Thread Michael Stefaniuc
On 11/08/2012 03:44 PM, Christian Costa wrote: > > > 2012/11/8 Michael Stefaniuc <mailto:mstef...@redhat.com>> > > On 11/08/2012 01:13 PM, Christian Costa wrote: > > > > > > 2012/11/8 Henri Verbeet <mailto:hverb...@gmail.com>

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-08 Thread Michael Stefaniuc
On 11/08/2012 02:50 PM, Nikolay Sivov wrote: > On 11/8/2012 15:41, Michael Stefaniuc wrote: >> On 11/08/2012 01:13 PM, Christian Costa wrote: >>> >>> 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> >>> >>> On 8 November 2012 00:22, Mi

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-08 Thread Michael Stefaniuc
On 11/08/2012 01:13 PM, Christian Costa wrote: > > > 2012/11/8 Henri Verbeet mailto:hverb...@gmail.com>> > > On 8 November 2012 00:22, Michael Stefaniuc <mailto:mstef...@redhat.com>> wrote: > > But using just the capitalized letters from the name

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-07 Thread Michael Stefaniuc
On 11/07/2012 06:40 PM, Christian Costa wrote: > 2012/11/7 Michael Stefaniuc <mailto:mstef...@redhat.com>> > On 11/07/2012 02:50 PM, Christian Costa wrote: > > I didn't write this code and I don't like the current name either > but a > > m

LPJUNK for COM Interfaces (Was: Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.)

2012-11-07 Thread Michael Stefaniuc
t; interface cast hidden there? Or maybe a cast from one interface to the other where it should instead use QueryInterface? bye michael

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-07 Thread Michael Stefaniuc
On 11/07/2012 02:50 PM, Christian Costa wrote: > > > 2012/11/7 Nikolay Sivov mailto:bungleh...@gmail.com>> > > On 11/7/2012 01:05, Christian Costa wrote: > > Le 06/11/2012 22:38, Michael Stefaniuc a écrit : > > On 11/06/201

Re: [PATCH 1/3] dmloader: COM cleanup of IDirectMusicLoader object.

2012-11-06 Thread Michael Stefaniuc
art with that as it makes the subsequent COM cleanup patch shorter as it cleans up the function header (whitespace and LPJUNK). bye michael

Re: [PATCH 5/6] dsound: rework ugly mixer logic

2012-10-24 Thread Michael Stefaniuc
old way and have dsound and winmm drivers too? That road leads to madness as it will triple the amount of sound drivers in Wine. > bang the HW, they have huge SW stacks like PA or Jack in their back. bye michael

Re: [PATCH 1/2] user32: Remove redundant sizeof check.

2012-10-24 Thread Michael Stefaniuc
On 10/24/2012 11:04 AM, Ken Thomases wrote: > On Oct 24, 2012, at 3:24 AM, Michael Stefaniuc wrote: > >> @@ -1330,9 +1330,6 @@ static HICON CURSORICON_LoadFromFile( LPCWSTR filename, >> } >> >> dir = (const CURSORICONFILEDIR*) bits; >> -if ( filesi

Re: d3dx9_36: Add tests for D3DXSHRotateZ

2012-10-22 Thread Michael Stefaniuc
> couple of places in Wine that use "CONST", and add a __ONLY_IN_WINELIB > to the #define in include/windef.h. I'm removing CONST in the lines I touch so +1 on a concerted effort to eradicate it. Though at 1.2k lines Alexandre might consider it too spammy. bye michael

Re: [PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-10 Thread Michael Stefaniuc
s. > Either > MemoryBarrier(); /* which MSDN documents but Wine does not provide in > include/*.h > Or > InterlockedExchange(&status, wmm->dwStatus); > > So if AJ is still not satisfied with try 2, I'll change all reads of > wmm->dwStatus > within the player into InterlockedExchange. > Yet I think that would be a superfluous extra memory barrier within the > player. bye michael

Re: dsound: Don't bother shrinking the secondary buffer list.

2012-09-27 Thread Michael Stefaniuc
sound -- without crashing. In general "it depends" of course. In this particular case the ERR would be useless noise as the assert is only for the last sound buffer that is removed; usually at program exit. Until then the code does what you prefer: silently drops sound buffers without crashing thus deferring the crash to the program exit. A crash on program exit does get reported, more so than an ERR on the command line. bye michael

Re: ole32: Add CoGetDefaultContext stub

2012-09-19 Thread Michael Stefaniuc
; +HRESULT CoGetDefaultContext(APTTYPE type, REFIID riid, LPVOID *ppv) bye michael

Re: [PATCH 1/2] oleaut32/tests: Don't take the size of a pointer (Clang).

2012-09-18 Thread Michael Stefaniuc
r (i = 0; i < sizeof(uarr) / sizeof(uarr[0]); i++) > +for (i = 0; i < 8; i++) > if (uarr[i] != i) > return 0; > thanks bye michael

Re: ddraw: Don't print a fixme for the flags in DirectDrawEnumerateExA; they don't change the outcome

2012-09-12 Thread Michael Stefaniuc
After talking to Henri on irc, please ignore this patch. There are patches out there to enumerate more devices than the primary one and then the flags do play a role. On 09/12/2012 11:08 PM, Michael Stefaniuc wrote: > --- > dlls/ddraw/main.c |5 + > 1 files changed, 1 inserti

Re: Moving pages to/from wiki

2012-08-30 Thread Michael Stefaniuc
If > there is consensus then I can certainly take it down. According to Alexandre it is used by http://source.winehq.org/ for the "Wine Cross Reference". bye michael

Re: [PATCH] kernel32: add support for CAL_ICALINTVALUE

2012-08-16 Thread Michael Blumenkrantz
Perhaps not, but I'll be the first to admit that I know very little about wine internals; this seemed to return the correct result in the case that I tested it. On Thu, Aug 16, 2012 at 11:39 AM, Alexandre Julliard wrote: > Michael Blumenkrantz writes: > > > @@ -656,8 +65

Re: [12/18] windowscodecs: Do not assume that vtable is the first element of the object, avoid not necessary casts.

2012-07-24 Thread Michael Stefaniuc
r_Frame_QueryInterface(IWICBitmapFrameDecode *if > IsEqualIID(&IID_IWICBitmapSource, iid) || > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > { > -*ppv = iface; > +*ppv = &This->IWICBitmapFrameDecode_iface; > } > else > { same here: not needed. bye michael

Re: [01/18] windowscodecs: Do not assume that vtable is the first element of the object.

2012-07-24 Thread Michael Stefaniuc
*iface > IsEqualIID(&IID_IWICBitmapSource, iid) || > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > { > -*ppv = iface; > +*ppv = &This->IWICBitmapFrameDecode_iface; > } > else > { this part of the change is gratuitous. As long as there is only one interface implementation in the object there is no need for impl_from_Foo(). bye michael

Re: quartz/tests: Add COM aggregation test for NullRenderer. (2nd try)

2012-07-01 Thread Michael Stefaniuc
//testbot.winehq.org/JobDetails.pl?Key=19686 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit misc) === > misc.c:60: Test failed: CoCreateInstance failed with 80040154 > misc.c:61: Test failed: pUnkOuter is NULL No quartz.dll on that box. bye michael

Re: [PATCH 2/2] qedit/tests: Add COM aggregation test for MediaDet.

2012-06-30 Thread Michael Stefaniuc
> mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 > mediadet: unhandled exception c005 at 00401587 Both hosts miss qedit.dll. bye michael

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
On 06/28/2012 01:50 PM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >>> truncating from double to float while gcc keeps silence for instance. >> I never looked at that but I assume the same holds true as above. > > The following thread has some

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
On 06/28/2012 01:00 PM, Dmitry Timoshkov wrote: > Michael Stefaniuc wrote: > >> afair the fix is to disable the int truncation warnings in MSVC. For >> whatever reason they seem to enable those bogus warnings. > > The warnings are not bogus, the PSDK compiler also emits

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.

2012-06-28 Thread Michael Stefaniuc
Dmitry, afair the fix is to disable the int truncation warnings in MSVC. For whatever reason they seem to enable those bogus warnings. bye michael On 06/28/2012 12:12 PM, Dmitry Timoshkov wrote: > --- > include/basetsd.h | 16 > 1 file changed, 8 inserti

Re: [PATCH 4/4] qedit: Support COM aggregation for SampleGrabber.

2012-06-26 Thread Michael Stefaniuc
> mediadet: unhandled exception c005 at 00401639 > > === W2KPROSP4 (32 bit mediadet) === > mediadet.c:148: Test failed: CoCreateInstance failed: 80040154 > mediadet.c:356: Test failed: CoCreateInstance failed: 80040154 > mediadet: unhandled exception c005 at 00401639 > bye michael

Re: [PATCH 3/4] qedit/tests: Add COM aggregation test for MediaDet.

2012-06-26 Thread Michael Stefaniuc
Argh! Please skip this patch, it is incomplete and just skips the rest of the tests on Wine. I'll resubmit it when I implement COM aggregation for MediaDet. Patch 4/4 can be still applied as it doesn't depends on this. bye michael On 06/26/2012 11:53 PM, Michael Stefa

Re: Wine automated testing update

2012-06-21 Thread Michael Stefaniuc
idge aka eth0 won't have an IP associated with it as the host IP would be on virtbr0. > What I typically see if I ping the host from the VM is that the echo > requests go out and the echo replies are sent. But ping on the VM sees > nothing. It could be a firewalling issue though my VMware VMs on the > same network work fine. bye michael

Re: 'Expensive' expressions in loop limits (was: Implementation of D3DXSHScale)

2012-06-19 Thread Michael Stefaniuc
ourse as always a definitive "It depends". The safe approach is to *first* optimize for the human reader; the compilers this days are better at optimizing than the average programmer. bye michael

Re: MSVCP60.dll

2012-06-15 Thread Michael Stefaniuc
work? For example, do Open the bug reports :) If there is a free downloadable version/demo that exhibits the same issues please add it to the "URL" field. bye michael

Re: msvcrt: Fix the name of the Portuguese locale alias.

2012-06-14 Thread Michael Stefaniuc
ith Windows treating Brazilian Portuguese as the "default" Portuguese language: include/winnt.rh:#define SUBLANG_PORTUGUESE_BRAZILIAN 0x01 include/winnt.rh:#define SUBLANG_DEFAULT 0x01 bye michael

Re: wined3d: Avoid sizeof on structs with variable length arrays.

2012-06-13 Thread Michael Stefaniuc
On 06/13/2012 12:56 PM, Henri Verbeet wrote: > On 13 June 2012 10:41, Michael Stefaniuc wrote: >> -object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); >> +object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, >> FIELD_OFFSET(struc

Re: A copyright question to wine developpers

2012-06-11 Thread Michael Stefaniuc
ight? The MS headers certainly come with a copyright clause: how > is it possible to redistribute these headers with wine? The Windows headers are copyrighted and Wine cannot redistribute those. Wine provides its own headers. bye michael

Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono

2012-06-05 Thread Michael Stefaniuc
27;. The Wine .net support does NOT make the .net > framework available to native linux application. (If it That's *exactly* what wine-mono *IS*. Unlike before this is the Windows version of mono and thus unusable from Linux. > IS provided a part of the wine migration library, I will > grumble but not scream about it.) bye michael

Re: quartz: COM cleanup for Parser_OutputPin

2012-05-18 Thread Michael Stefaniuc
to support application provided IPin then you'll need an unsafe_impl_from_... > HRESULT hr; > LONGLONG start, stop, rtstart, rtstop; > StreamData *stream = &This->streams[streamnumber]; bye michael

Re: mstask: Actually run a test and fix the expected behaviour.

2012-05-16 Thread Michael Stefaniuc
//testbot.winehq.org/JobDetails.pl?Key=18419 > > Your paranoid android. > > > === WNT4WSSP6 (32 bit task_trigger) === > task_trigger.c:165: Test failed: Failed to setup test_task That box has no mstask dll. bye michael

Re: Using an IDE on Wine?

2012-05-14 Thread Michael Ost
in normal operation which confuses GDB. I can send along that patch if you are interested. Of course, if you are trying to debug a straight windows application then all of this is irrelevant! But if you are doing winelib, then these tricks can help. -- Michael Ost

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
gt; trafic on wine-devel is rather low those days > what about opening a code-style flame-war ? Heh, no, that wasn't my intend. With the if and else on separate lines it would have been obvious that the curly brackets would be better placed inside the while... bye michael

Re: msxml3: avoid a dangling else (LLVM/Clang)

2012-05-14 Thread Michael Stefaniuc
o not mind terse code but that kinda overdoes it. I would put the "else" on a separate line. > +} > > xmldoc = doparse(This, (char*)ptr, strlenW(ptr)*sizeof(WCHAR), > XML_CHAR_ENCODING_UTF16LE); > if ( !xmldoc ) bye michael

Re: GSOC 2012 has started

2012-05-02 Thread Michael Mc Donnell
On Wed, May 2, 2012 at 5:28 PM, Józef Kucia wrote: > On Wed, May 2, 2012 at 10:00 PM, Michael Mc Donnell > wrote: >> I just saw you added D3DXCreateCubeTextureFromFileInMemory, will you >> be adding forwards for D3DXCreateCubeTextureFromFile too? > > So yes, I plan to i

Re: GSOC 2012 has started

2012-05-02 Thread Michael Mc Donnell
oject/google/gsoc2012/jos/58002 That sounds great! Józef which functions are you implementing? I just saw you added D3DXCreateCubeTextureFromFileInMemory, will you be adding forwards for D3DXCreateCubeTextureFromFile too? Otherwise I wont mind adding that one (need it for Sid Meier's Railroads). Cheers, Michael

Re: Patch 85420

2012-04-17 Thread Michael Stefaniuc
FrameImpl *parent". > It probably also needs explicit sign-off drom the d3d folks as it handles > funny refcounting. Not really, this is plain COM stuff. bye michael

Re: ddraw/tests: Compare the correct surface pointers.

2012-04-15 Thread Michael Stefaniuc
On 04/15/2012 10:04 PM, Marvin wrote: > While running your changed tests on Windows, I think I found new failures. Yupp, test is incorrect. Stefan is looking at it. bye michael > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but co

Re: [PATCH 1/3] browseui: Add IOleWindow to IProgressDialog

2012-04-15 Thread Michael Stefaniuc
&IID_IUnknown)) > { > *ppvOut = This; > +TRACE("(%p, IID_IUnknown, %p) -> %p\n", This, ppvOut, This); > +} > +else if (IsEqualIID(iid, &IID_IProgressDialog)) > +{ > +*ppvOut = This; this is not correct as ppvOut takes an interface and not an object. While at it please fix the above one too. thanks bye michael

Re: [PATCH 1/3] amstream: Add CLSID_AMAudioData implementation. (try 2)

2012-04-03 Thread Michael Stefaniuc
p),not found\n", This, debugstr_guid(riid), ppv); > +return E_NOINTERFACE; > +} > + bye michael

Re: [PATCH 1/4] dmime: COM cleanup for IDirectMusicPerformance8.

2012-04-02 Thread Michael Stefaniuc
ed. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 Reg. Adresse: Red Hat GmbH, Werner-von-Siemens-Ring 14, 85630 G

Re: [PATCH 3/3] d3drm: Implement CreateMesh method and stubbed IDirect3DRMMesh interface.

2012-03-29 Thread Michael Stefaniuc
> +if (IsEqualGUID(riid, &IID_IDirect3DRMMesh)) > +*ppObj = (IUnknown*)&object->IDirect3DRMMesh_iface; > +else > +*ppObj = (IUnknown*)&object->IDirect3DRMMesh_iface; both if and else code path are the same. > + > +return S_OK; > +} > + bye michael

Re: 'Pending' patches state

2012-03-28 Thread Michael Stefaniuc
ds work". That would make it more obvious what is meant. > For instance your patch 84692 says that "tests confirm that", but you > don't say which tests, and there are no new tests or fixed todos in the > patch, so it looks suspicious. Yes, I could dig out the tests myself and > investigate it in detail, but when it gets to that point I usually just > move on to the next patch, hence "pending". IMHO that should have been "Needs tests"; that would have forced Dmitry to point you to the tests. bye michael

Re: d3d10core: Standardize COM aggregation for d3d10_device.

2012-03-26 Thread Michael Stefaniuc
Now that Alexandre is back and Jacek didn't want to beat me to it it is time to finish my reply... On 03/22/2012 01:06 AM, Henri Verbeet wrote: > On 22 March 2012 00:50, Michael Stefaniuc wrote: >> -static HRESULT STDMETHODCALLTYPE d3d10_device_inner_QueryInterface(IUnknown >

Re: mscoree: Print the debug string and not the pointer to it.

2012-03-23 Thread Michael Stefaniuc
On 03/23/2012 07:50 PM, Lauri Kenttä wrote: On 2012-03-22 00:36, Michael Stefaniuc wrote: HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR pVersion, DWORD cchBuffer, DWORD *dwlength) { - TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), cchBuffer, dwlength

Re: Updating GSoC proposal

2012-03-20 Thread Michael Stefaniuc
h is not an option. > In terms of being valid... if cmd were improved it would allow firefox > and chromium to be built under wine (if reg was also improved a bit, but > that might also fall under my project...) Improving cmd should be fine as a project. Hoping to get the parser fully replaced during that isn't. bye michael

Re: Networking+wine

2012-03-19 Thread Michael Stefaniuc
referring to in Windows? > > Regarding sandboxing Wine itself, see the FAQ entry: > http://wiki.winehq.org/FAQ#head-f566a12c806a1eacaeefb7cb6419a513a773c571 > bye michael

Re: use assert etc. in Wine dlls? What is better?

2012-03-13 Thread Michael Stefaniuc
cover but crash later on it is better to assert as early as possible as that simplifies the debugging. - If the app has a chance to deal with the error then returning an error is the better approach. Add an ERR() or WARN() to that so we at least can see the issue. bye michael

Re: [PATCH] po: Remove bad characters (C2 & A0) from french translations.

2012-03-13 Thread Michael Stefaniuc
are only present in french translations. Between a > name and a ':'. > This is not nicer to me. I wondering if that would not be better to > remove them all... It doesn't matter if you consider them nicer or not. If they are required by the rules of the language then they will stay. bye michael

Re: Got Application cross-compiled with msvc11 for ARM running

2012-03-08 Thread Michael Stefaniuc
On 03/08/2012 05:54 PM, André Hentschel wrote: > Am 08.03.2012 17:52, schrieb Michael Stefaniuc: >> On 03/08/2012 05:40 PM, André Hentschel wrote: >>> Hi, >>> I cross-compiled a simple Application with the preview of MSVC 11 to ARM. >>> After some minor change

Re: Got Application cross-compiled with msvc11 for ARM running

2012-03-08 Thread Michael Stefaniuc
tic loaded functions that also worked. > > In short: > The good news: The ABI is compatible (to armel gnueabi) > The bad news: no fully win32 API on ARM Bad news? Quite the contrary. Good use case for Wine on Windows. > Maybe my small changes to Wine will make it into 1.5.1 :) At least i hope so. 1.5.1 or 1.4.1? bye michael

Re: winemenubuilder: Nothing useful is done on Mac OS X so just exit.

2012-03-01 Thread Michael Stefaniuc
ted on Mac OS X\n"); > +return 0; > +#endif > if (!init_xdg()) > return 1; > no clue if the compiler there complains but you are producing unreachable code in the #ifdef __APPLE__ case. bye michael

Re: wineapploader in wine64

2012-02-16 Thread Michael Ost
On 02/16/2012 11:57 AM, Alexandre Julliard wrote: prefix (besides, there shouldn't be any reason to run wineboot by hand). We use it with --shutdown to cleanly terminate (as in WM_CLOSE, not "kill") all wine apps from a hardware button press. Is there a preferred way? Than

wineapploader in wine64

2012-02-16 Thread Michael Ost
t can't be found since it isn't installed so the loader gives up. $ wineboot wine: cannot find L"C:\\windows\\system32\\wineboot.exe" If it used wine64 instead, it would work. There must be a reason that wine64 is starting 32bit apps, but I haven't been able to glean anything from the web. Thanks for any info, -- Michael Ost

Re: [PATCH 1/2] winmm: Avoid using SuspendThread, it can hang Wine.

2012-02-09 Thread Michael Stefaniuc
joerg-cyril.hoe...@t-systems.com wrote: > Michael Stefaniuc wrote: >> See that as an opportunity to clean up the whitespace issues in those 120 >> lines ;) > Hmm, what was the latest word on reformatting, if any? > Until now I've been careful to preserve the surrounding

Re: [PATCH 1/2] winmm: Avoid using SuspendThread, it can hang Wine.

2012-02-09 Thread Michael Stefaniuc
See that as an opportunity to clean up the whitespace issues in those 120 lines ;). Or of course to split the code out into helper functions. bye michael

Re: winecfg: Center main window on the screen.

2012-02-08 Thread Michael Stefaniuc
ent it always opens in the top right corner. There doesn't seems to be a way in Win32 land to not specify a position where to open the window. bye michael

  1   2   3   4   5   6   7   8   9   10   >