Re: [PATCH 2/2] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2346 Your paranoid

Re: dlls: Replace the remaining CONSTs.

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2342 Your paranoid

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-26 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: @@ -530,12 +591,18 @@ static BOOL CALLBACK _ImmAssociateContextExEnumProc(HWND hwnd, LPARAM lParam) */ BOOL WINAPI ImmAssociateContextEx(HWND hWnd, HIMC hIMC, DWORD dwFlags) { +IMMThreadData* thread_data = NULL; + TRACE((%p, %p,

Re: [2/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 2)

2013-09-26 Thread Alexandre Julliard
Akihiro Sagawa sagawa@gmail.com writes: @@ -6519,11 +6519,17 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, } lpgm-gmBlackBoxX = (right - left) 6; +if (lpgm-gmBlackBoxX == 0) +lpgm-gmBlackBoxX = 1; lpgm-gmBlackBoxY =

Re: [PATCH 1/6] riched20: Implement ITextDocument_fnOpen.

2013-09-26 Thread Alexandre Julliard
Jactry jactr...@gmail.com writes: +chBuffer = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size+2); +if(!chBuffer) +{ +CloseHandle(hFile); +return HRESULT_FROM_WIN32(GetLastError()); +} It's not useful to zero the buffer since you are reading into it. Also

Re: imm32: ImmGetDescriptionA return does not include NULL byte

2013-09-26 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: @@ -1684,7 +1684,7 @@ UINT WINAPI ImmGetDescriptionA( HeapFree( GetProcessHeap(), 0, buf ); - return len; + return min( len - 1, uBufLen ); } This may do the right thing on failure, but in an ugly way. A few overflow tests would be a

Re: [PATCH 1/2] gdi32: fix for rotated Arc, ArcTo, Chord and Pie drawing problem (try 2)

2013-09-26 Thread Alexandre Julliard
Daniel Wendt daniel.we...@linux.com writes: @@ -308,6 +308,11 @@ static int get_arc_points( PHYSDEV dev, const RECT *rect, POINT start, POINT end } memmove( points, points + count, (pos - count) * sizeof(POINT) ); + +if (GetGraphicsMode( dev-hdc ) == GM_ADVANCED) +{

Re: [PATCH 3/3] msvcrt: Call MSVCRT_strtoi64_l in strtoul implementation (try2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2349 Your paranoid

Re: [1/3] gdi32: Return GDI_ERROR when requested empty glyph bitmaps. (try 2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2350 Your paranoid

Re: [3/3] gdi32: Don't modify output glyph metrics unless the function succeeds. (try 2)

2013-09-26 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2352 Your paranoid

Re: [2/5] winex11: Splitted functions X11DRV_FocusOut and X11DRV_ReparentNotify

2013-09-25 Thread Alexandre Julliard
Sebastian Lackner sebast...@fds-team.de writes: --- dlls/winex11.drv/event.c | 99 +++--- 1 file changed, 58 insertions(+), 41 deletions(-) These should go in the patches that need them. Also you should start your series with reparent support, the

Re: crypt32: Support HCCE_LOCAL_MACHINE.

2013-09-25 Thread Juan Lang
Hi Ben, thanks for having a whack at this. Some tests would be nice. -static HCERTCHAINENGINE CRYPT_defaultChainEngine; +/* There are two default chain engines which correspond to HCCE_CURRENT_USER and + * HCCE_LOCAL_MACHINE. +*/ +static HCERTCHAINENGINE CRYPT_defaultChainEngine[2] = { NULL,

Re: Wine Gecko 2.24-beta1

2013-09-25 Thread Jacek Caban
On 08/18/13 04:14, Zhenbo Li wrote: I've tested some websites, and found that these pages have problems: http://mail.163.com (it will make gecko crash) http://huaban.com (nothing can be shown) http://douban.com (no pictures) http://html5test.com/ (can't load

Re: (try 4)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-25 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: --- dlls/imm32/imm.c | 153 +-- 1 file changed, 116 insertions(+), 37 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.

2013-09-25 Thread Matteo Bruni
2013/9/24 Rico Schüller kgbric...@web.de: --- dlls/d3dx9_36/effect.c | 248 +++-- 1 Datei geändert, 95 Zeilen hinzugefügt(+), 153 Zeilen entfernt(-) I definitely like the direction this patch takes. @@ -5068,6 +5009,9 @@ static HRESULT

Re: (try 5) [2/4] imm32: do not let ImmDestroyContext destroy any default contexts

2013-09-25 Thread Nikolay Sivov
On 9/25/2013 16:03, Aric Stewart wrote: defaultContext = ImmCreateContext(); +if (defaultContext) +((InputContextData*)defaultContext)-threadDefault = TRUE; I think a nicer way is to let ImmCreateContext() set this attribute.

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-25 Thread Nikolay Sivov
On 9/25/2013 16:03, Aric Stewart wrote: +if (!thread_data-defaultContext) +{ +HIMC defaultContext; +LeaveCriticalSection(threaddata_cs); +defaultContext = ImmCreateContext(); +thread_data = IMM_GetThreadData(0); Why do you need to unlock/lock around

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.

2013-09-25 Thread Rico Schüller
On 25.09.2013 14:02, Matteo Bruni wrote: 2013/9/24 Rico Schüller kgbric...@web.de: --- dlls/d3dx9_36/effect.c | 248 +++-- 1 Datei geändert, 95 Zeilen hinzugefügt(+), 153 Zeilen entfernt(-) I definitely like the direction this patch takes. @@

Re: (try 5)[1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-25 Thread Aric Stewart
On 9/25/13 7:11 AM, Nikolay Sivov wrote: On 9/25/2013 16:03, Aric Stewart wrote: +if (!thread_data-defaultContext) +{ +HIMC defaultContext; +LeaveCriticalSection(threaddata_cs); +defaultContext = ImmCreateContext(); +thread_data =

Re: (try 5) [2/4] imm32: do not let ImmDestroyContext destroy any default contexts

2013-09-25 Thread Aric Stewart
On 9/25/13 7:09 AM, Nikolay Sivov wrote: On 9/25/2013 16:03, Aric Stewart wrote: defaultContext = ImmCreateContext(); +if (defaultContext) +((InputContextData*)defaultContext)-threadDefault = TRUE; I think a nicer way is to let ImmCreateContext() set this

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-25 Thread Jacek Caban
Hi Hans, Sorry for the delay, I wanted to test it a bit more before answering. On 09/23/13 10:50, Hans Leidekker wrote: On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote: I was hoping for a test like the attached one, which shows that there is still more work to do. But it's a step in the

Re: [PATCH] d3dx9: Use struct d3dx_object for objects.

2013-09-25 Thread Henri Verbeet
On 25 September 2013 15:32, Rico Schüller kgbric...@web.de wrote: Yes. Depending on the use case we may create it on the Begin/BeginPass when the shader is needed the first time (this may also be something like isParameterUsed or GetVertexShader). We don't need the shaders for cases like

Re: [2/5] winex11: Splitted functions X11DRV_FocusOut and X11DRV_ReparentNotify

2013-09-25 Thread Sebastian Lackner
Am 25.09.2013 12:19, schrieb Alexandre Julliard: Sebastian Lackner sebast...@fds-team.de writes: --- dlls/winex11.drv/event.c | 99 +++--- 1 file changed, 58 insertions(+), 41 deletions(-) These should go in the patches that need them. Also you

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Francois Gouget
On Tue, 24 Sep 2013, Dmitry Timoshkov wrote: Marvin test...@winehq.org wrote: === w7pro64 (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test

Re: user32: Avoid using CONST.

2013-09-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2332 Your paranoid

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Dmitry Timoshkov
Francois Gouget fgou...@free.fr wrote: === w7pro64 (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY,

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Francois Gouget
On Thu, 26 Sep 2013, Dmitry Timoshkov wrote: [...] This VM is broken, How so? That is: what should I do to fix it? Investigate, find the source of failures and fix it? Note, that all other VMs pass this test just fine, moreover, this same w7pro64 VM doesn't always fail. You

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-25 Thread Dmitry Timoshkov
Francois Gouget fgou...@free.fr wrote: This VM is broken, How so? That is: what should I do to fix it? Investigate, find the source of failures and fix it? Note, that all other VMs pass this test just fine, moreover, this same w7pro64 VM doesn't always fail. You obviously

Re: [PATCH 3/5] wined3d: Introduce a function to initialize swapchain specific device state.

2013-09-24 Thread Henri Verbeet
On 23 September 2013 21:05, Alexandre Julliard julli...@winehq.org wrote: Henri Verbeet hverb...@codeweavers.com writes: --- dlls/wined3d/device.c | 51 + dlls/wined3d/stateblock.c |5 + 2 files changed, 20 insertions(+), 36

Re: add ualapi directory (try 9

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2313 Your paranoid

Re: [1/2] winhttp/tests: Remove explicit zero-intialization of static data.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2314 Your paranoid

Fwd: Re: add ualapi directory (try 9

2013-09-24 Thread Akira Nakagawa
The failure is not caused by the error from my patch,Isn't it? It seems that the number 2232. Original Message Subject:Re: add ualapi directory (try 9 Date: Tue, 24 Sep 2013 04:02:32 -0500 From: Marvin test...@winehq.org To: matyapir...@gmail.com CC:

Re: advapi32/tests: Mark a test result as broken.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2315 Your paranoid

Re: [PATCH 5/5] ddraw: Avoid VOID.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2316 Your paranoid

Re: server/protocol.def and array types

2013-09-24 Thread Hugh McMaster
Any help for this? -- I'm testing support for GetConsoleScreenBufferInfoEx. At the moment, I've extended the screen_buffer struct in server/console.c to look like this: struct screen_buffer { struct object obj;

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2317 Your paranoid

Re: [PATCH 4/5] d3d8/tests: Add a volume V16U16 test.

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2318 Your paranoid

Re: Virus spread via wine

2013-09-24 Thread Jong Bin, Chae
Thanks, Dan. No. I already have that virus sample file. For the more fun, W32:Tenga (aka Virus:Win32/Gael.D) virus behavior signature under Wine 1.7.1 attached. On Mon, Sep 23, 2013 at 11:12 PM, Dan Kegel d...@kegel.com wrote: Thanks, looks like you're doing good work there. (Are you going to

Re: server: Android has struct user in asm/user.h

2013-09-24 Thread André Hentschel
Am 24.09.2013 17:13, schrieb Huw Davies: --- configure.ac| 1 + server/ptrace.c | 8 +++- 2 files changed, 8 insertions(+), 1 deletion(-) is that for the warning about the missing casts?

Re: server: Android has struct user in asm/user.h

2013-09-24 Thread Huw Davies
On 24 Sep 2013, at 17:57, André Hentschel n...@dawncrow.de wrote: is that for the warning about the missing casts? No, this actually introduces more :-) The cast warning is about the 4th param of ptrace. Huw.

Re: (try 3) [1/4] imm32: Move thread data from TLSEntry to an internal list

2013-09-24 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: @@ -443,6 +473,28 @@ static InputContextData* get_imc_data(HIMC hIMC) return data; } +static BOOL ensure_default_imc(IMMThreadData** thread_data) +{ +if (!(*thread_data)-defaultContext) +{ +HIMC defaultContext; +

Re: [2/2] oleaut32: LoadRegTypeLib() should check actual typelib version

2013-09-24 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2330 Your paranoid

Re: add ualapi directory (try 5)

2013-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2309 Your paranoid

Re: add ualapi directory (try 7)

2013-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2310 Your paranoid

Re: add ualapi directory (try 8)

2013-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2311 Your paranoid

Re: [3/4] kernel32/tests: Add 0-length read tests for a pipe.

2013-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2250 Your paranoid

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-23 Thread Hans Leidekker
On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote: I was hoping for a test like the attached one, which shows that there is still more work to do. But it's a step in the right direction, so I'm fine with your patch. The issue here is that HTTP_ReceiveRequestData calls refill_read_buffer,

Re: Virus spread via wine

2013-09-23 Thread Jong Bin, Chae
Fun++; /* Wine Virus Database (VirusDB) http://sourceforge.net/apps/mediawiki/zerowine-tryout/index.php?title=VirusDB*/ On Mon, Sep 23, 2013 at 1:20 PM, Dan Kegel d...@kegel.com wrote: Fun times: http://bugs.winehq.org/show_bug.cgi?id=34556

Re: Virus spread via wine

2013-09-23 Thread Dan Kegel
Thanks, looks like you're doing good work there. (Are you going to ask the guy who filed 34556 for a copy of an infected file?) On Mon, Sep 23, 2013 at 6:32 AM, Jong Bin, Chae c...@trunk.so wrote: Fun++; /* Wine Virus Database (VirusDB)

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-23 Thread Henri Verbeet
On 23 September 2013 13:29, Stefan Dösinger ste...@codeweavers.com wrote: Note that Windows drivers disagree on which format they support. Nvidia has V16U16, AMD supports Q8W8V8U8, at least on r200. I am working on a more comprehensive converted format test that tests all supported signed

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-23 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-23 17:29, schrieb Henri Verbeet: On 23 September 2013 13:29, Stefan Dösinger ste...@codeweavers.com wrote: Note that Windows drivers disagree on which format they support. Nvidia has V16U16, AMD supports Q8W8V8U8, at least on r200. I am

Re: [PATCH 3/5] d3d9/tests: Add a volume V16U16 test.

2013-09-23 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-23 17:31, schrieb Stefan Dösinger: Am 2013-09-23 17:29, schrieb Henri Verbeet: On 23 September 2013 13:29, Stefan Dösinger ste...@codeweavers.com wrote: Note that Windows drivers disagree on which format they support. Nvidia has

Re: add ualapi directory (try 9

2013-09-23 Thread Jacek Caban
Hi Akira, On 09/23/13 10:00, Akira Nakagawa wrote: From 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699 Mon Sep 17 00:00:00 2001 Message-Id: 2ecc71fdb3406d3cf79ebcbd7f6d0c711b68d699.1379923234.git.matyapir...@gmail.com From: Akira Nakagawa matyapir...@gmail.com Date: Mon, 23 Sep 2013 17:00:04

Re: [1/3] winex11: Splitted functions X11DRV_FocusOut (try 2)

2013-09-23 Thread Alexandre Julliard
Sebastian Lackner sebast...@fds-team.de writes: - when virtually reparenting the plugin window as a child of a foreign window (similar to the systray code) its not possible to get the focus anymore - the focus code always tries to request the focus for the WS_POPUP parent, which is a

Fwd: [GSoC Mentors Announce] Re: GSoC 2013 Mentors/Org Admins: Pencils Down and Final Evaluation Dates Approaching

2013-09-23 Thread Austin English
-- Forwarded message -- From: Carol Smith car...@google.com Date: Mon, Sep 23, 2013 at 12:04 PM Subject: [GSoC Mentors Announce] Re: GSoC 2013 Mentors/Org Admins: Pencils Down and Final Evaluation Dates Approaching To: GSoC Mentors Announce gsoc-mentors-annou...@googlegroups.com

Re: [PATCH 3/5] wined3d: Introduce a function to initialize swapchain specific device state.

2013-09-23 Thread Alexandre Julliard
Henri Verbeet hverb...@codeweavers.com writes: --- dlls/wined3d/device.c | 51 + dlls/wined3d/stateblock.c |5 + 2 files changed, 20 insertions(+), 36 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-23 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2267 Your paranoid

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-23 Thread Dmitry Timoshkov
Marvin test...@winehq.org wrote: === w7pro64 (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0

Re: ntdll: Perform the offset checks also for a serial device.

2013-09-23 Thread Dmitry Timoshkov
Dmitry Timoshkov dmi...@baikal.ru wrote: Marvin test...@winehq.org wrote: === w7pro64 (32 bit comm) === comm.c:863: Test failed: WaitCommEvent failed with a timeout comm.c:875: recovering after WAIT_TIMEOUT... comm.c:886: Test failed: WaitCommEvent error 0 comm.c:888: Test failed:

Re: [PATCH] oleaut32: Implement ICreateTypeInfo::SetFuncDocString

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2280 Your paranoid

Re: [2/3] d3d9/tests: Test if IDirect3DSwapChain9Ex is available with IDirect3D9(Ex)

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2281 Your paranoid

Re: [3/3] d3d9/tests: Implemented tests for IDirect3DSwapChain9Ex_GetDisplayModeEx

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2282 Your paranoid

Re: ws2_32: ConnectEx should not work on unbound socket

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2286 Your paranoid

Re: [PATCH 1/5] ddraw/tests: Add a test for render target surface capabilities.

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2289 Your paranoid

Re: [PATCH 5/5] d3d9: Avoid CONST.

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2290 Your paranoid

Re: [PATCH 5/6] d3d8/tests: Add a volume V16U16 test.

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2292 Your paranoid

Re: [PATCH 4/6] d3d9/tests: Add a volume V16U16 test.

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2291 Your paranoid

Re: winebuild examples

2013-09-22 Thread André Hentschel
Am 21.09.2013 19:49, schrieb paul.clark...@btinternet.com: Hi, I am new to WINE and indeed winebuild. What I need to do is write a wrapper C part and Spec file and build a wrapper around an existing Linux shared library so that my wrapper DLL can be dynamically loaded into my program

Re: Re: add ualapi directory (try 3)

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2304 Your paranoid

Virus spread via wine

2013-09-22 Thread Dan Kegel
Fun times: http://bugs.winehq.org/show_bug.cgi?id=34556

Re: add ualapi directory (try 4)

2013-09-22 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2308 Your paranoid

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2251 Your paranoid

Re: [4/4] kernel32: Remove a 0-length read optimization from ReadFile. Resend.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2252 Your paranoid

Re: [PATCH 4/5] d3d9/tests: Add tests for block-based volume formats (try 2).

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2253 Your paranoid

Re: [PATCH 5/5] d3d9/tests: Test invalid volume lock boxes.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2254 Your paranoid

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2255 Your paranoid

Re: [3/4] imm32: use thread data from target HWND

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2256 Your paranoid

winebuild examples

2013-09-21 Thread paul.clarke85
Hi, I am new to WINE and indeed winebuild. What I need to do is write a wrapper C part and Spec file and build a wrapper around an existing Linux shared library so that my wrapper DLL can be dynamically loaded into my program running in WINE. This, I believe, is supposed to be a simple thing

Re: [4/4] imm32: Prevent assocating cross thread default contexts

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2257 Your paranoid

Re: [PATCH 2/2] d3dx9/tests: Add matrix column register count clamp test.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2259 Your paranoid

Re: (resend)[3/4] imm32: use thread data from target HWND

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2262 Your paranoid

Re: (resend)[3/4] imm32: use thread data from target HWND

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2263 Your paranoid

Re: shlwapi/tests: Fix stream test failures under some win2000 versions.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2266 Your paranoid

Re: [PATCH 1/5] d3d9/tests: Read the caps from the device.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2268 Your paranoid

Re: [PATCH 5/5] d3d8/tests: Test invalid volume lock boxes.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2270 Your paranoid

Re: [PATCH 4/5] d3d8/tests: Add tests for block-based volume formats.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2269 Your paranoid

Re: ws2_32/tests: Mark WinNT result as broken

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2271 Your paranoid

Re: add ualapi directory (try 2)

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2273 Your paranoid

Re: [PATCH 4/4] mshtml: Added external MIME handling tests.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2275 Your paranoid

Re: rsaenh: Add support for retrieving the security descriptor on key containers.

2013-09-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2276 Your paranoid

Re: [1/2] oledb32: Correct DataLinks interface for win64

2013-09-20 Thread Alexandre Julliard
Alistair Leslie-Hughes leslie_alist...@hotmail.com writes: @@ -26,6 +26,20 @@ import oledb.idl; #define vi_progid(str) #endif +#ifdef _WIN64 +cpp_quote(#ifdef _WIN64) +typedef LONGLONG COMPATIBLE_LONG; +cpp_quote(#else) +cpp_quote(typedef LONG COMPATIBLE_LONG;)

Re: (resend)[3/4] imm32: use thread data from target HWND

2013-09-20 Thread Alexandre Julliard
Aric Stewart a...@codeweavers.com writes: @@ -507,7 +524,7 @@ HIMC WINAPI ImmAssociateContext(HWND hWnd, HIMC hIMC) LeaveCriticalSection(threaddata_cs); defaultContext = ImmCreateContext(); ((InputContextData*)defaultContext)-threadDefault = TRUE; -

Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().

2013-09-20 Thread Roderick Colenbrander
That change looks suspicious. If switching to i+1 fixes a problem, the real problem is that the if-statement in question gets entered in the first place. Some bounds checking on the outer for-loop (the one which loops through nCfgs and nMaxFormats), is probably wrong then. I had issues with this

Re: [PATCH 6/6] wined3d: Use GL_APPLE_client_storage for volumes if available.

2013-09-20 Thread Henri Verbeet
On 20 September 2013 13:04, Stefan Dösinger ste...@codeweavers.com wrote: -volume-flags = ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED); +volume-flags = ~(WINED3D_VFLAG_ALLOCATED | WINED3D_VFLAG_SRGB_ALLOCATED +| WINED3D_VFLAG_CLIENT_STORAGE); Indentation looks a

Re: [PATCH 2/6] wined3d: Add support for converted volumes.

2013-09-20 Thread Henri Verbeet
On 20 September 2013 13:04, Stefan Dösinger ste...@codeweavers.com wrote: +static BOOL wined3d_volume_can_evict(const struct wined3d_volume *volume) +{ +if (volume-resource.pool != WINED3D_POOL_MANAGED) +return FALSE; +if (volume-download_count 10) +return FALSE;

Re: D3D command stream patches for testing

2013-09-20 Thread Forest
Stefan, are these patches already present in the wine 1.7.2 release? Now that the official 1.7.2 Ubuntu packages have been published, I'm trying to figure out how to get your CSMT changes into the PPA that I maintain.

Re: winex11: Don't trace a garbage value or read past end of caller's array in X11DRV_wglChoosePixelFormatARB().

2013-09-20 Thread Ken Thomases
On Sep 20, 2013, at 9:44 AM, Roderick Colenbrander wrote: That change looks suspicious. If switching to i+1 fixes a problem, the real problem is that the if-statement in question gets entered in the first place. Some bounds checking on the outer for-loop (the one which loops through nCfgs and

Re: [PATCH 2/3] iphlpapi: Add interface enumeration for Android.

2013-09-19 Thread Bruno Jesus
On Thu, Sep 19, 2013 at 10:06 AM, Huw Davies h...@codeweavers.com wrote: --- configure.ac | 3 +- dlls/iphlpapi/ifenum.c | 199 - 2 files changed, 200 insertions(+), 2 deletions(-) Hi, Huw. I'm not sure this is an issue but in the

Re: [PATCH 2/3] iphlpapi: Add interface enumeration for Android.

2013-09-19 Thread Huw Davies
On 19 Sep 2013, at 15:07, Bruno Jesus wrote: Hi, Huw. I'm not sure this is an issue but in the android implementation of get_interface_indexes you are not setting +if (table) *table = NULL; Hi Bruno, Good catch! Resent. Thanks, Huw.

Re: wininet: Don't assume that end of chunk means end of stream. (try 2)

2013-09-19 Thread Jacek Caban
Hi Hans, On 09/18/13 13:40, Hans Leidekker wrote: diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c index bf57223..2526681 100644 --- a/dlls/wininet/tests/http.c +++ b/dlls/wininet/tests/http.c @@ -4777,8 +4777,37 @@ static const struct notification

<    1   2   3   4   5   6   7   8   9   10   >