Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-06-04 Thread Frédéric Delanoy
On Sat, Jun 4, 2011 at 23:50, Henri Verbeet wrote: > Conceptually I think it makes sense to have a distinction between > wined3d types and e.g. ddraw types. For things like D3DPOOL that's not > strictly required since it has the same values in all d3d versions > where it exists, but e.g. format ID

Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-06-04 Thread Henri Verbeet
On 31 May 2011 12:50, Alexandre Julliard wrote: > I mean using D3DPOOL in wined3d, not by including the d3d9 headers, but > by defining it when necessary, i.e. if neither d3d8types.h nor > d3d9types.h have been included already. > > This way d3d8 uses the d3d8 definition, d3d9 uses the d3d9 defini

Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-05-31 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 31.05.2011 um 12:50 schrieb Alexandre Julliard: > I mean using D3DPOOL in wined3d, not by including the d3d9 headers, but > by defining it when necessary, i.e. if neither d3d8types.h nor > d3d9types.h have been included already. This would lead to

Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-05-31 Thread Alexandre Julliard
Stefan Dösinger writes: > Am 31.05.2011 um 12:12 schrieb Alexandre Julliard: >> Most enums are identical, or just have an extra value or two. I don't >> see why you can't pass either type to wined3d since they have the same >> name. > Do you mean the status quo? Or do you mean using the D3DPOOL t

Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-05-31 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 31.05.2011 um 12:12 schrieb Alexandre Julliard: > Most enums are identical, or just have an extra value or two. I don't > see why you can't pass either type to wined3d since they have the same > name. Do you mean the status quo? Or do you mean usin

Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-05-31 Thread Alexandre Julliard
Stefan Dösinger writes: > Am 31.05.2011 um 11:10 schrieb Alexandre Julliard: >> I still don't see the point of that kind of switch statement. To be >> honest I don't see either why we even need different enum types in the >> first place. > Because for most enums the d3d8 ones differ from the d3d9

Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-05-31 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 31.05.2011 um 11:10 schrieb Alexandre Julliard: > I still don't see the point of that kind of switch statement. To be > honest I don't see either why we even need different enum types in the > first place. Because for most enums the d3d8 ones diffe

Re: [1/8] d3d8: Use D3DPOOL <-> WINED3DPOOL enum conversion functions instead of implicit conversions (clang)

2011-05-31 Thread Alexandre Julliard
Frédéric Delanoy writes: > +static inline D3DPOOL d3dpool_from_wined3dpool(WINED3DPOOL type) > +{ > +switch (type) > +{ > +case WINED3DPOOL_DEFAULT: return D3DPOOL_DEFAULT; > +case WINED3DPOOL_MANAGED: return D3DPOOL_MANAGED; > +case WINED3DPOOL_SYSTEMMEM: return D