Re: [PATCH] gdi32: Don't enumerate fonts when OpenFontFace fails (try 2).

2012-12-07 Thread Alexandre Julliard
Qian Hong writes: > IMO the best solution is to correctly implement RemoveFontResource() > so Bug 8292 will be fixed, then we don't need to worry about the > broken test in usp10, which is the original reason for this patch. > > Would you like me send this patch which is still an improvement, or

Re: [PATCH] gdi32: Don't enumerate fonts when OpenFontFace fails (try 2).

2012-12-07 Thread Qian Hong
Hello, On Fri, Dec 7, 2012 at 6:28 AM, Alexandre Julliard wrote: > ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p > gdiplus_test.exe.so font.c && touch font.ok > font.c:400: Test failed: Expected 0, got 3 > font.c:401: Test failed: got NULL font collection > make[1]: *** [font.

Re: [PATCH] gdi32: Don't enumerate fonts when OpenFontFace fails (try 2).

2012-12-06 Thread Alexandre Julliard
Qian Hong writes: > dlls/gdi32/freetype.c | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) It's causing a test failure: ../../../tools/runtest -q -P wine -M gdiplus.dll -T ../../.. -p gdiplus_test.exe.so font.c && touch font.ok font.c:400: Test failed: Expected 0,