Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > What I have done is a comparison of screenshots of the affected application > > produced under Windows and Wine. If there will be a need in futher > > improvements > > I'll certainly have a look what can be enhanced. > > Once again, have you explicitly tested 32-pi

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: >> Have you actually tested it with characters 32-pixel wide, and confirmed >> that Windows messes them up the same way? > > What I have done is a comparison of screenshots of the affected application > produced under Windows and Wine. If there will be a need in futher >

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> You did get a comment from Huw that you need to allocate extra bytes, > >> you still haven't done that AFAICS. > > > > That was a just a question, to which I had answered. There are the tests, > > and the app which needs this functionality (and uses various fonts wi

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > Any chance for at least a comment? >> >> You did get a comment from Huw that you need to allocate extra bytes, >> you still haven't done that AFAICS. > > That was a just a question, to which I had answered. There are the tests, > and t

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > Any chance for at least a comment? > > You did get a comment from Huw that you need to allocate extra bytes, > you still haven't done that AFAICS. That was a just a question, to which I had answered. There are the tests, and the app which needs this functionality (

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Any chance for at least a comment? You did get a comment from Huw that you need to allocate extra bytes, you still haven't done that AFAICS. -- Alexandre Julliard julli...@winehq.org