[PATCH 5] winmm/tests: Add MCI waveaudio tests.

2009-10-28 Thread Joerg-Cyril.Hoehle
Paul Virnes wrote: >> What I'm missing is sort of the converse of skip: >> Perform a test on all platforms *except* Wine >Isn't there anything in your current test suite that succeeds on Windows >but fails on Wine? This is it! So simple, right in front of my eyes. Thanks, Jörg Höhle.

Re: [PATCH 5] winmm/tests: Add MCI waveaudio tests.

2009-10-27 Thread Paul Vriens
On 10/27/2009 10:13 AM, joerg-cyril.hoe...@t-systems.com wrote: Reece dunn wrote: Once the fix has been added, the todo_wine bit can be removed. I know about it and skip and win_skip thanks to Michael Karcher's excellent text: http://www.winehq.org/pipermail/wine-devel/2008-October/069721.ht

[PATCH 5] winmm/tests: Add MCI waveaudio tests.

2009-10-27 Thread Joerg-Cyril.Hoehle
Reece dunn wrote: >Once the fix has been added, the todo_wine bit can be removed. I know about it and skip and win_skip thanks to Michael Karcher's excellent text: http://www.winehq.org/pipermail/wine-devel/2008-October/069721.html The problem is that running the full tests crashes or hangs Win

Re: [PATCH 5] winmm/tests: Add MCI waveaudio tests.

2009-10-26 Thread Reece Dunn
2009/10/26 : > Hi, > >> +/* Some tests hang or crash Wine. Enable once fixed. */ >> +#define FULL_TEST 0 > >>Please don't introduce dead code. If the tests really can't work then >>don't add them at all until you have the corresponding fixes. > > Will do.  Although I'd very much prefer having test

[PATCH 5] winmm/tests: Add MCI waveaudio tests.

2009-10-26 Thread Joerg-Cyril.Hoehle
Hi, > +/* Some tests hang or crash Wine. Enable once fixed. */ > +#define FULL_TEST 0 >Please don't introduce dead code. If the tests really can't work then >don't add them at all until you have the corresponding fixes. Will do. Although I'd very much prefer having tests than no tests. I've bee

Re: [PATCH 5] winmm/tests: Add MCI waveaudio tests.

2009-10-26 Thread Alexandre Julliard
writes: > -START_TEST(mci) > +#ifndef FULL_TEST > +/* Some tests hang or crash Wine. Enable once fixed. */ > +#define FULL_TEST 0 > +#endif Please don't introduce dead code. If the tests really can't work then don't add them at all until you have the corresponding fixes. -- Alexandre Julliard