Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James McKenzie
James Hawkins wrote: > On Fri, Oct 10, 2008 at 3:49 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > >> We know my implementation and Windows implementation behave identically and >> this is documented in tests. At this >> point you and me both happy about the comment in tests and tests in general

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 3:49 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > > We know my implementation and Windows implementation behave identically and > this is documented in tests. At this > point you and me both happy about the comment in tests and tests in general, > right? > Now back to the

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread Andrey Turkin
James Hawkins wrote: > On Fri, Oct 10, 2008 at 2:51 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > >> James Hawkins wrote: >> >> On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin <[EMAIL PROTECTED]> >> wrote: >> >> >> I can't see any value in commented out test or sort-of-meaningless code >> comme

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 2:51 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: > > On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin <[EMAIL PROTECTED]> > wrote: > > > I can't see any value in commented out test or sort-of-meaningless code > comment. > > > > The tests serve as docum

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread Andrey Turkin
James Hawkins wrote: > On Fri, Oct 10, 2008 at 3:17 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > >> Imagine broken application which for some reason, e.g. non-allocated memory, >> supply NULL to this function, and then catch, eat and spew an exception >> somewhere in different place. Joe the D

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 3:17 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > > Imagine broken application which for some reason, e.g. non-allocated memory, > supply NULL to this function, and then catch, eat and spew an exception > somewhere in different place. Joe the Developer start searching for

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread Andrey Turkin
James Hawkins wrote: > On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > >> I can't see any value in commented out test or sort-of-meaningless code >> comment. >> >> > > The tests serve as documentation of the API. In many cases, that > documentation is far super

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-10 Thread James Hawkins
On Fri, Oct 10, 2008 at 12:59 AM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: > > On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <[EMAIL PROTECTED]> > wrote: > > > [now with tests, fixed and reformatted as per James' suggestions] > > Implement CredReadDomainCredentialsA and CredR

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-09 Thread Andrey Turkin
James Hawkins wrote: > On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > >> [now with tests, fixed and reformatted as per James' suggestions] >> >> Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW >> stubs and few tests for them. Required for MSN Mess

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests

2008-10-09 Thread James Hawkins
On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > > [now with tests, fixed and reformatted as per James' suggestions] > > Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW > stubs and few tests for them. Required for MSN Messenger 7.0 > --- > dlls/advapi