Attached are some cursor patches I have been working on. These
patches store the cursor in the wineserver, clean up user32 a little
bit, draw .ani cursors more completely, and ultimately implement
themed cursors. I am sending them here for some last review (big
thanks to Henri for taking some
Regenerated against git HEAD for whoever cares about these.
Changes since last time:
- user: format warning fixes
- user: initialise cursor16 to 0 in destroy_cursor()
- user: fix a small compile problem in the 6th patch, caused by
splitting things up. (The 8th patch removes the relevant block)
-
On 25/07/06, H. Verbeet <[EMAIL PROTECTED]> wrote:
On 25/07/06, H. Verbeet <[EMAIL PROTECTED]> wrote:
> Another update.
Ignore that. It doesn't actually work.
In riff_find_chunk():
*((DWORD *)ptr) + 2 == chunk_id
Should be:
*((DWORD *)ptr + 2) == chunk_id
On 25/07/06, H. Verbeet <[EMAIL PROTECTED]> wrote:
Another update.
Ignore that. It doesn't actually work.
Another update.
- The patches don't use INVALID_HANDLE_VALUE anymore (I was using
that in some of the other patches as well).
- riff_find_chunk() compares DWORDs
- Code using get_cursor_frame() now has some error handling, in case
the handle is invalid
- Warnings should be fixed now, although
Hi,
These are the warnings i get when i compile ur patch
os kubuntu, gcc 4.0.3
cursoricon.c: In function 'CURSORICON_Load':
cursoricon.c:1289: warning: 'frame_bits' may be used uninitialized in
this function
mouse.c: In function 'create_cursor':
mouse.c:566: warning: pointer targets in passing a
"H. Verbeet" <[EMAIL PROTECTED]> wrote:
Attached is a slightly updated version of the patchset. I got rid of
the winmm import, and it should now destroy cursors / icons when the
process is destroyed. The changes are in parts 1 & 9, the rest should
be pretty much unchanged.
I've looked only at
On 07/07/06, Robert Shearman <[EMAIL PROTECTED]> wrote:
However, I did find two things that I think need consideration or
improvement:
From 01_server_cursoricon.diff.txt:
> +/* Destroy a cursor */
> +DECL_HANDLER(destroy_cursor)
> +{
> +unsigned int i;
> +cursor_t *cursor = free_user_h
On 07/07/06, Robert Shearman <[EMAIL PROTECTED]> wrote:
This appears to be the only place where a cursor is destroyed. Thus, a
bad application could end up wineserver to leak memory. I think you need
to investigate when Windows frees cursors that have not had
DestroyCursor called on them. My gues
"Robert Shearman" <[EMAIL PROTECTED]> wrote:
-DELAYIMPORTS = imm32
+DELAYIMPORTS = imm32 winmm
EXTRALIBS = $(LIBUNICODE)
SPEC_SRCS16 = \
I'm not sure it is acceptable to import winmm from user32, even if it is
a delay import.
Rob is right, native user32 doesn't import winmm by any mean
H. Verbeet wrote:
Attached to this mail are a couple of patches that should fix some
issues with mouse cursors. It would be nice if some people could have
a look and see if the patches break anything. Patches 1-4 move cursors
into the server, 5 adds support for Xcursor cursors, 6 & 7 are
cleanup
Attached to this mail are a couple of patches that should fix some
issues with mouse cursors. It would be nice if some people could have
a look and see if the patches break anything. Patches 1-4 move cursors
into the server, 5 adds support for Xcursor cursors, 6 & 7 are
cleanups, 8 fixes loading o
12 matches
Mail list logo
