2009/8/13 Stefan Dösinger :
> I'd say give wine-patches a try :-) Make sure Alexandre can see how these
> patches will work together with the wpp ones and the actual implementation of
> D3DXAssembleShader
>
If you do, try to split it up a bit more where possible, it's still a
pretty large patch to
Am Wednesday 12 August 2009 21:57:36 schrieb Matteo Bruni:
> > I think it doesn't need two include files, especially since both of them
> > are d3dx9-private anyway. The question is, is it better to just merge
> > them into d3dx9_36_private.h, or have assembler things in a separate
> > file? I tend
2009/8/10 Stefan Dösinger :
> Hi,
> A few comments - mostly things I haven't spotted earlier.
Hi,
I fixed the code, almost completely following your reviews (thank you,
of course).
I'm reporting the differences with your suggestions:
>
>> --- /dev/null
>> +++ b/dlls/d3dx9_36/asmshader.h
>> --- /d
I only looked at the first patch.
2009/8/9 Matteo Bruni :
> +static void asmparser_instr(struct asm_parser *This, DWORD opcode,
...
> +if(srcs) {
> +for(i=0; inr; i++) {
...
> +if(srcs && (srcs->nr != expectednsrcs)) {
...
> +if(srcs) {
> +for(i=0; inr; i++) {
You can s
Hi,
A few comments - mostly things I haven't spotted earlier.
> --- /dev/null
> +++ b/dlls/d3dx9_36/asmshader.h
> --- /dev/null
> +++ b/dlls/d3dx9_36/asmshader_private.h
I think it doesn't need two include files, especially since both of them are
d3dx9-private anyway. The question is, is it bette
