Re: Fix error checking in dlls/ddraw/executebuffer.c

2009-06-20 Thread Paul Vriens
Gerald Pfeifer wrote: I believe, after looking at the ranges of D3DLIGHTSTATETYPE, that the below is the actual intention of this code (to ensure we are in range). Gerald ChangeLog: Fix error checking in IDirect3DExecuteBufferImpl_Execute(). diff --git a/dlls/ddraw/executebuffer.c

Re: Fix error checking in dlls/ddraw/executebuffer.c

2009-06-20 Thread Gerald Pfeifer
On Sat, 20 Jun 2009, Paul Vriens wrote: - if (!ci-u1.dlstLightStateType (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) +if (!ci-u1.dlstLightStateType || (ci-u1.dlstLightStateType D3DLIGHTSTATE_COLORVERTEX)) Would: if ((ci-u1.dlstLightStateType