Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-25 Thread Henri Verbeet
On 25 August 2010 14:31, Misha Koshelev wrote: > for some reason were from Paulo Lesgaz. > For what it's worth, "Paulo Lesgaz" is an (obvious) pseudonym, as is "Jérémie Lapurée". See e.g. http://fr.wikipedia.org/wiki/Joe_Bar_Team for reference.

Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-25 Thread Misha Koshelev
s. I'll probably send > it in tomorrow. Thank you so much. My apologies - for some reason I got confused and thought that the patches in http://wine.1045685.n5.nabble.com/Re-d3dx9-Implement-D3DXDeclaratorFromFVF-tp260p2644552.html for some reason were from Paulo Lesgaz. Thank you for your help with this! Misha

Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-25 Thread Henri Verbeet
On 25 August 2010 04:04, misha680 wrote: > What do you think about this one on top of those? I will wait to send to > wine-patches until your patches have been committed. > http://wine.1045685.n5.nabble.com/file/n2652101/0004-d3dx9-Implement-D3DXDeclaratorFromFVF.txt Still not quite right, I'm af

Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-24 Thread misha680
think about this one on top of those? I will wait to send to wine-patches until your patches have been committed. http://wine.1045685.n5.nabble.com/file/n2652101/0004-d3dx9-Implement-D3DXDeclaratorFromFVF.txt 0004-d3dx9-Implement-D3DXDeclaratorFromFVF.txt Thank you Misha -- View this message in c

Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

2010-08-24 Thread Henri Verbeet
On 24 August 2010 05:05, Misha Koshelev wrote: > +elements[idx].Stream = 0xFF; > +elements[idx].Offset = D3DXGetDeclVertexSize(elements, 0); > +elements[idx].Stream = 0; That's ugly. > +memcpy(Declaration, elements, size * sizeof(D3DVERTEXELEMENT9)); That's unnecessary

Re: Re : Re : d3dx9: Implement D3DXDeclaratorFromFVF.

2010-08-23 Thread Henri Verbeet
On 23 August 2010 19:02, paulo lesgaz wrote: > Both patches work very well (they passed the todo_wine tests) > But, I think that  the second one does not answer to Julliard 's complain > about tons of if...then I'm not sure I remember reading that specific comment. I know there was one about the

Re : Re : d3dx9: Implement D3DXDeclaratorFromFVF.

2010-08-23 Thread paulo lesgaz
z Cc : wine-devel@winehq.org Envoyé le : Lun 23 août 2010, 14h 01min 01s Objet : Re: Re : d3dx9: Implement D3DXDeclaratorFromFVF. On 23 August 2010 13:49, paulo lesgaz wrote: > I already sent such a patch. Julliard did not like the gazillions of > conditions if then. > I never found a way

Re: Re : d3dx9: Implement D3DXDeclaratorFromFVF.

2010-08-23 Thread Henri Verbeet
On 23 August 2010 13:49, paulo lesgaz wrote: > I already sent such a patch. Julliard did not like the gazillions of > conditions if then. > I  never found a way to avoid them. > The offset can be computed thanks to the function  D3DXGetDeclVertexSize > You know, just give the attached patches

Re : d3dx9: Implement D3DXDeclaratorFromFVF.

2010-08-23 Thread paulo lesgaz
Envoyé le : Lun 23 août 2010, 12h 03min 16s Objet : Re: d3dx9: Implement D3DXDeclaratorFromFVF. On 20 August 2010 21:16, Misha Koshelev wrote: > Thank you for your helpful feedback on my tests. > > This is based mostly on dlls/d3d9/vertexdeclaration.c with some > changes

Re: d3dx9: Implement D3DXDeclaratorFromFVF.

2010-08-23 Thread Henri Verbeet
On 20 August 2010 21:16, Misha Koshelev wrote: > Thank you for your helpful feedback on my tests. > > This is based mostly on dlls/d3d9/vertexdeclaration.c with some > changes specific to D3DXDeclaratorFromFVF. > > Again, if there are any suggested changes please let me know. > As you already ment

Re: d3dx9: Implement D3DXDeclaratorFromFvF

2010-05-31 Thread James Mckenzie
>Hi, > >I think I solved problems with this patch: > >Use the already implemented D3DXGetDeclVertexSize to compute the offset. >This saves to introduce new internal functions. >Simplify the checks for the index. >Clean a little bit the code > David: It is customary to label retries of patch submis

D3DX9: how to implement D3DXDeclaratorFromFVF

2010-05-20 Thread David Adam
Hello, I would like to implement the function D3DXDeclaratorFromFVF. My numerous attempts to do this were rejected (specially my copy/paste of the function vdecl_convert_fvf from d3d9/vertexdeclaration.c. Does anyone know a way to implement it? Thanks in advance David

Re: Re : d3dx9: Implement D3DXDeclaratorFromFVF with tests

2010-04-12 Thread Henri Verbeet
On 12 April 2010 12:10, paulo lesgaz wrote: > What do you mean? > > I think I kept the file format. > > And what are the other things ? ;) > Sorry, but I really think these are things you should be able to figure out on your own.

Re : d3dx9: Implement D3DXDeclaratorFromFVF with tests

2010-04-12 Thread paulo lesgaz
What do you mean? I think I kept the file format. And what are the other things ? ;) A+ David De : Henri Verbeet À : wine-devel@winehq.org Envoyé le : Lun 12 avril 2010, 11 h 52 min 15 s Objet : Re: d3dx9: Implement D3DXDeclaratorFromFVF with tests

Re: d3dx9: Implement D3DXDeclaratorFromFVF with tests

2010-04-12 Thread Henri Verbeet
Formatting, among others.

Re: d3dx9: Implement D3DXDeclaratorFromFVF with tests

2010-04-11 Thread winetestbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://winetestbot.geldorp.nl/JobDetails.pl?Key=1361 Your paranoid andr

Implement D3DXDeclaratorFromFVF

2010-02-05 Thread paulo lesgaz
The patch is a copy/paste from the file d3d9/verdeclaration.c. So this file should be simplified too, if we simplify the d3dx9_36/mesh.c implementation. Obviously, to compute the size of the vertex, we can use D3DXGetDeclVertexSize, but we gain very few. So, what do you think about this? A+ D

Re: d3dx9: Implement D3DXDeclaratorFromFVF

2010-02-05 Thread Henri Verbeet
On 5 February 2010 05:09, David Adam wrote: >  This patch is from Tony Wasserka. It comes from  his  git repertory. He > authorized to pick up patches (see Wine-devel) to submit to Wine. > I just cleanup it a little bit. I let Tony as the author of this patch. All > the tests pass in a real Window