Re: Progress Bar: Fix Class Style & Repainting (resend2)

2004-09-29 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > The problem with Rob's patch is that it causes entire background of > the progress bar to be repainted. Some time ago (3 years or like that) > I wrote tests for progress bar and found that it invalidates background > only when (oldPos < newPos) and

Re: Progress Bar: Fix Class Style & Repainting (resend2)

2004-09-29 Thread Robert Shearman
Dimitrie O. Paun wrote: On Tue, Sep 28, 2004 at 12:12:09PM -0700, Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: Changelog: - Fix class style to include the hbrBackground member. - Fix repainting issues introduced by this change. - Add WM_ERASEBKGND handler and remove

Re: Progress Bar: Fix Class Style & Repainting (resend2)

2004-09-29 Thread Robert Shearman
Alexandre Julliard wrote: Robert Shearman <[EMAIL PROTECTED]> writes: Changelog: - Fix class style to include the hbrBackground member. - Fix repainting issues introduced by this change. - Add WM_ERASEBKGND handler and remove background drawing code from the WM_PAINT handler. Isn't that goi

Re: Progress Bar: Fix Class Style & Repainting (resend2)

2004-09-28 Thread Dmitry Timoshkov
"Alexandre Julliard" <[EMAIL PROTECTED]> wrote: > Isn't that going to cause a lot of flicker? This was the reason for > the existing code, because otherwise it looks really bad with apps > that update the progress bar a lot. The problem with Rob's patch is that it causes entire background of the

Re: Progress Bar: Fix Class Style & Repainting (resend2)

2004-09-28 Thread Dimitrie O. Paun
On Tue, Sep 28, 2004 at 12:12:09PM -0700, Alexandre Julliard wrote: > Robert Shearman <[EMAIL PROTECTED]> writes: > > > Changelog: > > - Fix class style to include the hbrBackground member. > > - Fix repainting issues introduced by this change. > > - Add WM_ERASEBKGND handler and remove background

Re: Progress Bar: Fix Class Style & Repainting (resend2)

2004-09-28 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Changelog: > - Fix class style to include the hbrBackground member. > - Fix repainting issues introduced by this change. > - Add WM_ERASEBKGND handler and remove background drawing code from > the WM_PAINT handler. Isn't that going to cause a lot of f