Re: patchwatcher status: online but no email

2008-11-06 Thread Dimi Paun
On Thu, 2008-11-06 at 09:29 -0800, Dan Kegel wrote: > > Would you settle for static alternating colors? > I'm kind of anti hover highlight. IIRC there was a recent study claiming that alternating row colors are not all that useful in practice, the on-hover has the advantage of focusing your att

Re: patchwatcher status: online but no email

2008-11-06 Thread Dan Kegel
On Thu, Nov 6, 2008 at 9:07 AM, Dimi Paun <[EMAIL PROTECTED]> wrote: > One suggestion that I have is changing the background color > of the row on hover so you can easily match the result on the > RHS to the Subject, right now that is a bit difficult to > do visually on a wide-screen monitor. Woul

Re: patchwatcher status: online but no email

2008-11-06 Thread Dimi Paun
On Thu, 2008-11-06 at 08:32 -0800, Dan Kegel wrote: > You should see your patch appear at > http://kegel.com/wine/patchwatcher/results Very nice! One suggestion that I have is changing the background color of the row on hover so you can easily match the result on the RHS to the Subject, right

Re: Patchwatcher status

2008-11-01 Thread IneedAname
On Thu, 4 Sep 2008 09:45:52 -0700 "Dan Kegel" <[EMAIL PROTECTED]> wrote: > The new machine has a fairly modern nvidia card, so > more of the tests are actually run. Where can I find the spec of the new machine ? Are you using the closed source driver ? I want to see the full system spec hardware

Re: Patchwatcher status

2008-10-26 Thread Dan Kegel
On Sun, Oct 26, 2008 at 8:56 PM, Dmitry Timoshkov <[EMAIL PROTECTED]> wrote: >> I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716 >> more and more often. We really need to set up mock >> servers so test cases don't need to rely on the public >> internet. > > If a test fails due to mis

Re: Patchwatcher status

2008-10-26 Thread Dmitry Timoshkov
From: "Dan Kegel" <[EMAIL PROTECTED]> wrote: > I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716 > more and more often. We really need to set up mock > servers so test cases don't need to rely on the public > internet. If a test fails due to missing internet access that's a bug in t

Re: Patchwatcher status

2008-10-26 Thread Dan Kegel
Kai wrote: > Dan Kegel <[EMAIL PROTECTED]> wrote: >> I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716 >> more and more often. We really need to set up mock >> servers so test cases don't need to rely on the public >> internet. > > Samba has a socket wrapper library that fakes network

Re: Patchwatcher status

2008-10-26 Thread James McKenzie
Dan Kegel wrote: > I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716 > more and more often. We really need to set up mock > servers so test cases don't need to rely on the public > internet. > > I'm slowly bringing up a second patchwatcher using > the newly refactored code. I even wr

Re: Patchwatcher status

2008-10-26 Thread Kai Blin
On Sunday 26 October 2008 23:00:51 Dan Kegel wrote: > I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716 > more and more often. We really need to set up mock > servers so test cases don't need to rely on the public > internet. Samba has a socket wrapper library that fakes network acce

Re: Patchwatcher status

2008-09-04 Thread Dan Kegel
On Thu, Sep 4, 2008 at 10:39 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Are there any changes compared to the email notification a week ago? > > I've received several emails about a failure with my patches but it turns > out they were marked as "ignore" or "Patch already in git.". I'm not sure I

Re: Patchwatcher status

2008-09-04 Thread Paul Vriens
Dan Kegel wrote: > Patchwatcher is almost recovered from its move > to the new machine. I expect to turn email > notifications back on tomorrow. > Hi Dan, Are there any changes compared to the email notification a week ago? I've received several emails about a failure with my patches but it t

Re: Patchwatcher status

2008-09-04 Thread Jeff Zaroyko
On Fri, Sep 5, 2008 at 2:45 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Patchwatcher is almost recovered from its move > to the new machine. I expect to turn email > notifications back on tomorrow. > > The old machine could only just barely keep up with > the patch flow. The new machine is two or

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 23:58:17 Scott Ritchie wrote: > James Hawkins wrote: > > On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > >> Something else... I sometimes reply to patches, and right now that > >> seems to cause patchwatcher to complain that my mail doesn't conta

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread James McKenzie
Dan Kegel wrote: > On Mon, Aug 25, 2008 at 2:05 PM, Kai Blin <[EMAIL PROTECTED]> wrote: > #patchwatcher approve Such a directive would only be recognized if it's alone on a line. >>> The usual positive reply is 'ACK'. I believe it would be simplest to >>> grep the r

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread James Hawkins
On Mon, Aug 25, 2008 at 4:58 PM, Scott Ritchie <[EMAIL PROTECTED]> wrote: > James Hawkins wrote: >> On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: >>> Something else... I sometimes reply to patches, and right now that >>> seems to cause patchwatcher to complain that my ma

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Scott Ritchie
James Hawkins wrote: > On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: >> Something else... I sometimes reply to patches, and right now that >> seems to cause patchwatcher to complain that my mail doesn't contain a >> patch. Would it be possible to do something about that?

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 23:20:40 Dan Kegel wrote: > Around where I work, LGTM (looks good to me) is the reply that > denotes approval. And then there's the Apache convention of +1. > Anyway, I'll recognize one or more of those if and when I get around > to adding a wine-devel listener. Might b

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Dan Kegel
On Mon, Aug 25, 2008 at 2:05 PM, Kai Blin <[EMAIL PROTECTED]> wrote: >> > #patchwatcher approve >> > >> > Such a directive would only be recognized if it's alone on a line. >> >> The usual positive reply is 'ACK'. I believe it would be simplest to >> grep the reply message for ACK to see if a repl

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 20:46:51 James Hawkins wrote: > On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote: > > > > #patchwatcher approve > > > > Such a directive would only be recognized if it's alone on a line. > > The usual positive reply is 'ACK'. I believe it would be si

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Chris Morgan
On Mon, Aug 25, 2008 at 2:46 PM, James Hawkins <[EMAIL PROTECTED]> wrote: > On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote: >> On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote: >> >>> "Dan Kegel" <[EMAIL PROTECTED]> writes: >>> On Mon, Aug 25, 2008 at 8:47 AM, Ale

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread James Hawkins
On Mon, Aug 25, 2008 at 1:11 PM, Ken Thomases <[EMAIL PROTECTED]> wrote: > On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote: > >> "Dan Kegel" <[EMAIL PROTECTED]> writes: >> >>> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard >>> <[EMAIL PROTECTED]> wrote: patchwatcher should watch for

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Ken Thomases
On Aug 25, 2008, at 1:08 PM, Alexandre Julliard wrote: > "Dan Kegel" <[EMAIL PROTECTED]> writes: > >> On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard >> <[EMAIL PROTECTED]> wrote: >>> patchwatcher should watch for replies on wine-devel, and >>> link the reply to the patch >> >> Yes. The ot

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Alexandre Julliard
"Dan Kegel" <[EMAIL PROTECTED]> writes: > On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: >> patchwatcher should watch for replies on wine-devel, and >> link the reply to the patch > > Yes. The other similar patchwatching systems I found do this, > and ours should,

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Dan Kegel
On Mon, Aug 25, 2008 at 8:47 AM, Alexandre Julliard <[EMAIL PROTECTED]> wrote: > patchwatcher should watch for replies on wine-devel, and > link the reply to the patch Yes. The other similar patchwatching systems I found do this, and ours should, too. > and mark the patch as needing further act

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Paul Vriens
Alexandre Julliard wrote: > Kai Blin <[EMAIL PROTECTED]> writes: > >> On Monday 25 August 2008 00:06:29 Henri Verbeet wrote: >>> Something else... I sometimes reply to patches, and right now that >>> seems to cause patchwatcher to complain that my mail doesn't contain a >>> patch. Would it be poss

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Alexandre Julliard
Kai Blin <[EMAIL PROTECTED]> writes: > On Monday 25 August 2008 00:06:29 Henri Verbeet wrote: >> Something else... I sometimes reply to patches, and right now that >> seems to cause patchwatcher to complain that my mail doesn't contain a >> patch. Would it be possible to do something about that? >

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-25 Thread Kai Blin
On Monday 25 August 2008 00:06:29 Henri Verbeet wrote: > Something else... I sometimes reply to patches, and right now that > seems to cause patchwatcher to complain that my mail doesn't contain a > patch. Would it be possible to do something about that? I've got to agree with James on that one. R

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread James Hawkins
On Sun, Aug 24, 2008 at 5:06 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > Something else... I sometimes reply to patches, and right now that > seems to cause patchwatcher to complain that my mail doesn't contain a > patch. Would it be possible to do something about that? I suppose > patchwatcher

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread Henri Verbeet
Something else... I sometimes reply to patches, and right now that seems to cause patchwatcher to complain that my mail doesn't contain a patch. Would it be possible to do something about that? I suppose patchwatcher could ignore replies without patch.

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread Henri Verbeet
2008/8/24 Dan Kegel <[EMAIL PROTECTED]>: > On Sun, Aug 24, 2008 at 9:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> The script now forwards patches that pass all tests to the mailing list >> http://groups.google.com/group/wine-patches-filtered >> so potentially Alexandre could start looking only at

Re: Patchwatcher status: regenerates configure, notifies authors on failure, filtered patches mailing list

2008-08-24 Thread Dan Kegel
On Sun, Aug 24, 2008 at 9:38 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > The script now forwards patches that pass all tests to the mailing list > http://groups.google.com/group/wine-patches-filtered > so potentially Alexandre could start looking only at that > list Hmm. At the moment, patchwatche

Re: Patchwatcher status

2008-08-19 Thread Paul Vriens
Dan Kegel wrote: > On Tue, Aug 19, 2008 at 1:35 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Looks like there is something (else?) wrong with checking the patch series. >> >> None of the last patch series (by Juan, James, Rob, Stefan to name a few) >> are shown on the results page. > > Thanks for

Re: Patchwatcher status

2008-08-19 Thread Dan Kegel
On Tue, Aug 19, 2008 at 1:35 AM, Paul Vriens <[EMAIL PROTECTED]> wrote: > Looks like there is something (else?) wrong with checking the patch series. > > None of the last patch series (by Juan, James, Rob, Stefan to name a few) > are shown on the results page. Thanks for pointing that out. It got

Re: Patchwatcher status

2008-08-19 Thread Paul Vriens
Dan Kegel wrote: > Patchwatcher falsely complained that > [2/17] richedit: Removed assumption about the order of rtf indent > didn't apply because the regexp I used to detect > the end of a patch series falsely matched the > first patch in a series of 1x patches. Here's the fix: > > --- patchwat

Re: Patchwatcher status

2008-08-17 Thread Kai Blin
On Thursday 14 August 2008 16:38:40 Dan Kegel wrote: > What to do, what to do... how about this: are there any python users > on the list who would be willing to help adapt buildbot to our needs? I've subscribed to the buildbot list as well, and I'll start looking over the code once I figured ou

Re: Patchwatcher status

2008-08-14 Thread Dan Kegel
On Thu, Aug 14, 2008 at 7:37 AM, Stefan Dösinger <[EMAIL PROTECTED]> wrote: > You mentioned sporadic test failures in the d3d9:visual and ddraw:visual > tests earlier, but I did not have time to look at it back then. Can you send > me logs of the failures and successes? > > I am afraid that the d3d

Re: Patchwatcher status

2008-08-14 Thread Dan Kegel
On Thu, Aug 14, 2008 at 2:49 AM, Darragh Bailey <[EMAIL PROTECTED]> wrote: > I currently use buildbot at work for managing builds, and it looks like > that it could handle many of your tasks if patchwatcher could be > integrated into it. Good idea. Even Mozilla, home of http://www.mozilla.org/tin

RE: Patchwatcher status

2008-08-14 Thread Stefan Dösinger
> Patchwatcher is online and giving reasonably good > feedback on the patch stream. The bug that caused > every patch to be marked 'failed tests' is fixed, and > the blacklist is expanded enough that false regressions > seem to be rare. You mentioned sporadic test failures in the d3d9:visual and d

Re: Patchwatcher status

2008-08-14 Thread Darragh Bailey
Have you considered using some of the tools out there for automated builds and looking to integrate patchwatcher to extend them to suit your purpose. A number of the features you suggest below are most likely already implemented within existing automated builds. I currently use buildbot at work f