RE: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

2008-09-03 Thread Stefan Dösinger
The real problems are that the ffp description structure still contains 3 uninitialized padding bytes, and that a HeapFree is missing. I'm going to send patches for those

Re: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

2008-09-03 Thread Alexandre Julliard
"Jeff Zaroyko" <[EMAIL PROTECTED]> writes: > None as such since difference in performance is so large. I can say > that without a doubt using HeapAlloc and HeapFree in this function > causes noticeable delays such that in Battlefield 1942 the framerate > is falls so much that it is unplayable, ch

Re: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

2008-09-03 Thread Jeff Zaroyko
On Wed, Sep 3, 2008 at 10:25 PM, Henri Verbeet <[EMAIL PROTECTED]> wrote: > 2008/9/3 Jeff Zaroyko <[EMAIL PROTECTED]>: >> Please ignore the previous patch sent two days ago, this one fixes a >> performance regression as well as removing the memory leak. >> >> -Jeff >> > Do you have some kind of ben

Re: wined3d: fix a memory leak and a performance regression in gen_arbfp_ffp_shader

2008-09-03 Thread Henri Verbeet
2008/9/3 Jeff Zaroyko <[EMAIL PROTECTED]>: > Please ignore the previous patch sent two days ago, this one fixes a > performance regression as well as removing the memory leak. > > -Jeff > Do you have some kind of benchmark data for this change? I don't think allocating relatively large buffers like