Re: RFC [PATCH] ddraw: Prevent refcount underflow

2010-09-26 Thread Stefan Dösinger
Am 26.09.2010 um 12:01 schrieb Vincent Pelletier: > Points on which I would like opinions: > - getting rid of the magic number ~0U or ~((unsigned long) 0) > - couldn't it actually hide a refcount problem in wine ? Very likely > - if not, then would it be good to extend to other refcounts aswell

RFC [PATCH] ddraw: Prevent refcount underflow

2010-09-26 Thread Vincent Pelletier
Hi. Attached patch fixes a problem with Beetle Crazy Cup's VideoSetup.exe, which hangs at exit because some code tries to free ddraw surface on which a refcount underflow happened earlier in the execution. Executing it with winedbg shows that the first call causing the underflow is triggered f