Re: Duplicate relocations in DLL

2013-05-19 Thread Jonas Maebe
On 17 May 2013, at 13:40, Alessandro Pignotti wrote: Wine does not seem to even try to load DLLs at their preferred address. Still, I'm not sure this is actually bad and I think Win8 forces randomization of the layout anyway, Afaik an application can tell the OS that it should not

Re: Duplicate relocations in DLL

2013-05-18 Thread Alexandre Julliard
Alessandro Pignotti alexpigna@gmail.com writes: Wine does not seem to even try to load DLLs at their preferred address. Still, I'm not sure this is actually bad and I think Win8 forces randomization of the layout anyway, We definitely try, but for high addresses there's a chance

Re: Duplicate relocations in DLL

2013-05-17 Thread Alessandro Pignotti
I think it's actually the second case you mentioned. I'm pasting an excerpt from 'objdump -x' of the dll. The issue happens with bgm.dll from the game Hotline Miami. Regards and sorry for the long paste below, Alessandro Pignotti --- bgm.dll:

Re: Duplicate relocations in DLL

2013-05-17 Thread Jonas Maebe
On 16 May 2013, at 19:03, Alessandro Pignotti wrote: On 16 May 2013, at 16:47, Jonas Maebe wrote: Addendum: he just realised that you may be talking about multiple base relocation arrays for a single page (arrays that contain the offsets of the instructions that need fixing up), which would

Re: Duplicate relocations in DLL

2013-05-17 Thread Alessandro Pignotti
Wine does not seem to even try to load DLLs at their preferred address. Still, I'm not sure this is actually bad and I think Win8 forces randomization of the layout anyway, Alessandro He believes that this was done on purpose to break Wine and other non- Windows environments. It's an

Re: Duplicate relocations in DLL

2013-05-16 Thread Jonas Maebe
On 15 May 2013, at 16:31, Alessandro Pignotti wrote: Packaged with a game, I found a peculiar DLL which has duplicate blocks in the relocation table. I mean that the same pages are relocated twice and this of course breaks the DLL. I'm not sure about what could be a right way to support

Re: Duplicate relocations in DLL

2013-05-16 Thread Jonas Maebe
On 16 May 2013, at 16:34, Jonas Maebe wrote: On 15 May 2013, at 16:31, Alessandro Pignotti wrote: Packaged with a game, I found a peculiar DLL which has duplicate blocks in the relocation table. I mean that the same pages are relocated twice and this of course breaks the DLL. I'm not sure