Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-12 Thread Alexandre Julliard
Erich Hoover ehoo...@mines.edu writes: Maybe I'm missing something, but the only case I found that required extra wineserver work was for handling asynchronous ReadFile requests (since these requests don't go through the ws2_32 path, see patch 6). Using ReadFile like that is technically

Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-10 Thread Kai Blin
On Saturday 10 October 2009 01:15:17 Juan Lang wrote: Hi Eric, it seems to me that if this is the best we can do, we're fixing it at the wrong layer. Surely putting the fix in the Linux kernel would be much smaller in code size, and higher performing, as we wouldn't have to filter packets

Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-10 Thread Alexandre Julliard
Erich Hoover ehoo...@mines.edu writes: The maintainer has pretty much put his foot down on the matter (several times actually, here's a nicer one): http://www.mail-archive.com/linux-...@vger.kernel.org/msg01306.html This is rather embarrasing, but apparently I left server/protocol.def out of

Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-10 Thread Reece Dunn
2009/10/9 Erich Hoover ehoo...@mines.edu: I've been a bit busy lately, but I sent in a patchset at the end of September to fix the CC3 LAN networking bug.  If I could get some feedback on these patches then I would greatly appreciate it:

Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-10 Thread Erich Hoover
Maybe I'm missing something, but the only case I found that required extra wineserver work was for handling asynchronous ReadFile requests (since these requests don't go through the ws2_32 path, see patch 6). Using ReadFile like that is technically something you're not supposed to do, but we all

Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-09 Thread Erich Hoover
I've been a bit busy lately, but I sent in a patchset at the end of September to fix the CC3 LAN networking bug. If I could get some feedback on these patches then I would greatly appreciate it: http://www.winehq.org/pipermail/wine-patches/2009-September/079193.html[1/6]

Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-09 Thread Juan Lang
Hi Eric, it seems to me that if this is the best we can do, we're fixing it at the wrong layer. Surely putting the fix in the Linux kernel would be much smaller in code size, and higher performing, as we wouldn't have to filter packets in user space. --Juan

Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-09 Thread Erich Hoover
On Fri, Oct 9, 2009 at 5:15 PM, Juan Lang juan.l...@gmail.com wrote: Hi Eric, it seems to me that if this is the best we can do, we're fixing it at the wrong layer. Surely putting the fix in the Linux kernel would be much smaller in code size, and higher performing, as we wouldn't have to

Re: Requesting comments on patchset to fix Bug 7929 (CC 3 network does not work)

2009-10-09 Thread Juan Lang
This is rather embarrasing, but apparently I left server/protocol.def out of the patchset.  I could have sworn I tested these patches on a clean git, but apparently I made a mistake.  Is there any chance that this mistake is the reason for the rejection? It very well could be, but you'll have