://www.nabble.com/RE%3A-Spore-patch-to-fix-UI-and-Part-descriptions-tp19090264p19216692.html
Sent from the Wine - Devel mailing list archive at Nabble.com.
I see what you mean now with regards to there always being a
ScissorRect value. I tried testing for all kinds of invalid values but
there doesn't seem to be any.
Also setting ScissorRect to NULL seems to kill the program on windows
rather then return invalid so I don't know what should be done in
Andrew Fenn schrieb:
> I'm alittle confused, are you suggesting that if SetScissorRect
> receives a null value that if should default to the window size? or do
> you mean that perhaps GetScissorRect should call SetScissorRect and
> return a correct value instead of null?
>
No. {0,0,0,0} is a val
I'm alittle confused, are you suggesting that if SetScissorRect
receives a null value that if should default to the window size? or do
you mean that perhaps GetScissorRect should call SetScissorRect and
return a correct value instead of null?
If I understand you correctly it sounds like another pr
Andrew Fenn schrieb:
> I made a new patch this time including a test.
>
> I put in some extra checking in SetScissorRect making sure that if
> rect was null or it was an invalid rectangle that it was returned as
> invalid as it should be.
>
> I'm not able to do a test on windows so if anyone does o
ht direction.
> -Original Message-
> From: [EMAIL PROTECTED] [mailto:wine-patches-
> [EMAIL PROTECTED] On Behalf Of Andrew Fenn
> Sent: Friday, August 22, 2008 2:52 AM
> To: H. Verbeet; Stefan Dösinger
> Cc: [EMAIL PROTECTED]
> Subject: Re: Spore patch to fix UI and Part des
On Fri, Aug 22, 2008 at 02:51:56PM +0700, Andrew Fenn wrote:
> I made a new patch this time including a test.
>
> I put in some extra checking in SetScissorRect making sure that if
> rect was null or it was an invalid rectangle that it was returned as
> invalid as it should be.
>
> I'm not able t
On Thu, Aug 21, 2008 at 9:41 PM, Stefan Dösinger <[EMAIL PROTECTED]>wrote:
> These changes may be correct, but they need a test. Take a look at
> dlls/d3d9/tests/device.c to see how the other tests look. I guess the
> changes are likely to be correct, but they have to be tested
I'll add a test
>
> diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c
> index ddeaca3..dfbf818 100644
> --- a/dlls/d3d9/device.c
> +++ b/dlls/d3d9/device.c
> @@ -746,7 +746,8 @@ static HRESULT WINAPI
> IDirect3DDevice9Impl_GetDepthStencilSurface(LPDIRECT3DDE
> }
> } else {
> WARN("Cal
2008/8/21 Stefan Dösinger <[EMAIL PROTECTED]>:
> These changes may be correct, but they need a test. Take a look at
> dlls/d3d9/tests/device.c to see how the other tests look. I guess the changes
> are likely to be correct, but they have to be tested
>
Not in its current form, there's a C++ comme
These changes may be correct, but they need a test. Take a look at
dlls/d3d9/tests/device.c to see how the other tests look. I guess the changes
are likely to be correct, but they have to be tested
11 matches
Mail list logo
