Hello Maarten,
On Fri, Apr 15, 2011 at 12:05 PM, Maarten Lankhorst wrote:
> Hello,
>
> Op 14-04-11 10:37, Loďc Maury schreef:
>
> Hello,
>>
>> From what was said from the last comments, I have modified the code and
>> I have added the test patch.
>>
>> What do you think ?
>>
> You're doing all
Hello,
Op 14-04-11 10:37, Loïc Maury schreef:
Hello,
From what was said from the last comments, I have modified the code and
I have added the test patch.
What do you think ?
You're doing all the HeapFrees manually, is there a destruction function
you can use?
Cheers,
Maarten
Hello,
From what was said from the last comments, I have modified the code and
I have added the test patch.
What do you think ?
Thank you
Loïc
---
dlls/winspool.drv/tests/info.c | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/dlls/wins
On 4/8/11 5:54 AM, Loïc Maury wrote:
Hello,
I try always to implement my first stub function - AbortPrinter.
One nice comment here, very efficient use of the local label end.
James McKenzie
Hello Andrew,
Hi Loïc,
On 04/08/2011 07:54 AM, Loïc Maury wrote:
I try always to implement my first stub function - AbortPrinter.
It's looking good. Before you submit this, you should add some tests.
Take a look in . Demonstrate that
AbortPrinter() on Windows behaves the same way as your fu
Hi Loïc,
On 04/08/2011 07:54 AM, Loïc Maury wrote:
I try always to implement my first stub function - AbortPrinter.
It's looking good. Before you submit this, you should add some tests.
Take a look in . Demonstrate that
AbortPrinter() on Windows behaves the same way as your function does.
M
Hello,
I try always to implement my first stub function - AbortPrinter.
The last time, I send into Wine patch mailling list, but the patch was
not correct.
Now I think the format for the patch is correct (no whitespace, etc…).
More over, I have modified the value if(!job->portname) by if(!po
Hello Mr.Eikum,
On 09/02/11 16:30, Andrew Eikum wrote:
On 02/09/2011 09:09 AM, Loïc Maury wrote:
The indentation looks fine to me now. You've got an extra newline
after the "if(printer->doc)" block and before the "else." The
formatting on the TRACE statement is still bizarre. Fix the commas
On 02/09/2011 09:09 AM, Loïc Maury wrote:
The indentation looks fine to me now. You've got an extra newline
after the "if(printer->doc)" block and before the "else." The
formatting on the TRACE statement is still bizarre. Fix the commas and
put it on just a couple of lines. No reason for one
Hello Mr.Le Cam
On Tue, Feb 8, 2011 at 10:07 PM, Nicolas Le Cam wrote:
>
>
> 2011/2/8 Loïc Maury
>
>
>> Hello Mr.Timoshkov,
>>
>> Thank you for your reply.
>>
>>> Loīc Maury wrote:
>>>
>>>
>>> After the various comments, I have modified the patch.
>>> First of all set your tab size to 8,
Hello Mr.Eikum,
Thank you for your reply.
On 08/02/11 18:13, Andrew Eikum wrote:
On 02/08/2011 10:48 AM, Loïc Maury wrote:
First of all set your tab size to 8, and ask your editor to not use
tabs
at all.
I have modified my editor, but I don't know if it 's correct now ?
The indentation l
2011/2/8 Loïc Maury
>
> Hello Mr.Timoshkov,
>
> Thank you for your reply.
>
>> Loīc Maury wrote:
>>
>>
>> After the various comments, I have modified the patch.
>>>
>> First of all set your tab size to 8, and ask your editor to not use tabs
>> at all.
>>
> I have modified my editor, but I don't
On 02/08/2011 10:48 AM, Loïc Maury wrote:
First of all set your tab size to 8, and ask your editor to not use tabs
at all.
I have modified my editor, but I don't know if it 's correct now ?
The indentation looks fine to me now. You've got an extra newline after
the "if(printer->doc)" block
Hello Mr.Timoshkov,
Thank you for your reply.
Loïc Maury wrote:
After the various comments, I have modified the patch.
First of all set your tab size to 8, and ask your editor to not use tabs
at all.
I have modified my editor, but I don't know if it 's correct now ?
+ TRACE("(%s, %s
Loïc Maury wrote:
> After the various comments, I have modified the patch.
First of all set your tab size to 8, and ask your editor to not use tabs
at all.
> + TRACE("(%s, %s, %p, %d, %d)\n",debugstr_w(printer->name)
> + ,debugstr_w(printer->printername)
> + ,pri
Hello,
After the various comments, I have modified the patch.
What do you think ?
Thank You
Loïc
---
dlls/winspool.drv/info.c | 97 +-
1 files changed, 95 insertions(+), 2 deletions(-)
diff --git a/dlls/winspool.drv/info.c b/dlls/winspool.drv/in
On 4 February 2011 15:30, Charles Davis wrote:
> Probably. Every UNIX I've seen uses CUPS (short for Common UNIX Printing
CUPS is probably pretty common these days, but LPD has been around for
a long time. If it's really CUPS specific it should check for CUPS
though, not OS X. Also note that the c
On 2/4/11 6:53 AM, Loïc Maury wrote:
> On 03/02/11 12:02, Nikolay Sivov wrote:
>> Why it's Mac specific?
> In fact I don't know if I need this, but I am on Mac with CUPS, I don't
> know if it the same
> issue for the other platform ?
Probably. Every UNIX I've seen uses CUPS (short for Common UNIX P
Hello Mr.Sivov and Wine community,
On 03/02/11 12:02, Nikolay Sivov wrote:
On 2/3/2011 13:51, Loïc Maury wrote:
Hello,
I try to implement my first stub function - *AbortPrinter()*.
But before to make a patch, I need your advice.
For what I understood, AbortPrinter(), remove the document
On 2/3/2011 13:51, Loïc Maury wrote:
Hello,
I try to implement my first stub function - *AbortPrinter()*.
But before to make a patch, I need your advice.
For what I understood, AbortPrinter(), remove the document
spool file for a printer, created by StartDocPrinter(), who indicate
that a
Hello,
I try to implement my first stub function - *AbortPrinter()*.
But before to make a patch, I need your advice.
For what I understood, AbortPrinter(), remove the document
spool file for a printer, created by StartDocPrinter(), who indicate
that a document was spooled.
I saw that the API
21 matches
Mail list logo
