Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Sergey Khodych
Nikolay Sivov пишет: It looks like you need to add a simple test like that: - add band with empty string and RBBIM_TEXT mask of course; - query band data back with RB_GETBANDINFO and check this lpText field. If it's really NULL (e.g. your buffer didn't change) instead of empty string you

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Nikolay Sivov
Sergey Khodych wrote: Nikolay Sivov пишет: It looks like you need to add a simple test like that: - add band with empty string and RBBIM_TEXT mask of course; - query band data back with RB_GETBANDINFO and check this lpText field. If it's really NULL (e.g. your buffer didn't change) instead

Re: [1/2] comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. (try 2)

2009-05-28 Thread Nikolay Sivov
Sergey Khodych wrote: From 37cd774e71f8d260d94bd672715b1eab879c4b2d Mon Sep 17 00:00:00 2001 From: Sergey Khodych khod...@gmail.com Date: Thu, 28 May 2009 04:52:45 +0300 Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. --- dlls/comctl32/rebar.c | 12

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Sergey Khodych
Nikolay Sivov пишет: If a band has an empty string, wine allocates a padding space in lpBand-rcCapText that causes an offset in a band. It looks like a workaround, if get/set text behaves ok now (no tests exist I suppose) then the only place to be changed is this rectangle dimensions. Why

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-28 Thread Nikolay Sivov
Sergey Khodych wrote: Nikolay Sivov пишет: If a band has an empty string, wine allocates a padding space in lpBand-rcCapText that causes an offset in a band. It looks like a workaround, if get/set text behaves ok now (no tests exist I suppose) then the only place to be changed is this

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-26 Thread Nikolay Sivov
Sergey Khodych wrote: From a2bf101f7ede3937373b7b8f9e2a8ea032b7790d Mon Sep 17 00:00:00 2001 From: Sergey Khodych khod...@gmail.com Date: Mon, 25 May 2009 02:21:39 +0300 Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT. --- dlls/comctl32/rebar.c | 12

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-26 Thread Sergey Khodych
Nikolay Sivov пишет: Where did you test that it isn't stored? The patch fixes a bug when wine allocates an extra space for a band with an empty string. I replaced NULL by in the size test to show the native realization doesn't change its behavior unlike wine in this case.

Re: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.

2009-05-26 Thread Nikolay Sivov
Sergey Khodych wrote: Nikolay Sivov пишет: Where did you test that it isn't stored? The patch fixes a bug when wine allocates an extra space for a band with an empty string. I replaced NULL by in the size test to show the native realization doesn't change its behavior unlike wine in this