Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > What I have done is a comparison of screenshots of the affected application > > produced under Windows and Wine. If there will be a need in futher > > improvements > > I'll certainly have a look what can be enhanced. > > Once again, have you explicitly tested 32-pi

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: >> Have you actually tested it with characters 32-pixel wide, and confirmed >> that Windows messes them up the same way? > > What I have done is a comparison of screenshots of the affected application > produced under Windows and Wine. If there will be a need in futher >

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> You did get a comment from Huw that you need to allocate extra bytes, > >> you still haven't done that AFAICS. > > > > That was a just a question, to which I had answered. There are the tests, > > and the app which needs this functionality (and uses various fonts wi

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > Any chance for at least a comment? >> >> You did get a comment from Huw that you need to allocate extra bytes, >> you still haven't done that AFAICS. > > That was a just a question, to which I had answered. There are the tests, > and t

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > Any chance for at least a comment? > > You did get a comment from Huw that you need to allocate extra bytes, > you still haven't done that AFAICS. That was a just a question, to which I had answered. There are the tests, and the app which needs this functionality (

Re: [PATCH 2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-06-01 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Any chance for at least a comment? You did get a comment from Huw that you need to allocate extra bytes, you still haven't done that AFAICS. -- Alexandre Julliard julli...@winehq.org

Re: [2/2] gdi32: Add support for emulating bold faces of bitmap fonts. Take 2. Resend.

2012-05-22 Thread Bruno Jesus
On Mon, Apr 30, 2012 at 6:52 AM, Dmitry Timoshkov wrote: > --- >  dlls/gdi32/freetype.c   |   35 +++- >  dlls/gdi32/tests/font.c |   83 > ++- >  2 files changed, 116 insertions(+), 2 deletions(-) I don't know if this patch was directly

Re: gdi32: Add support for emulating bold faces of bitmap fonts.

2012-04-24 Thread Dmitry Timoshkov
Hello, Any feedback on this patch? -- Dmitry.

Re: gdi32: Add support for emulating bold faces of bitmap fonts.

2012-04-16 Thread Dmitry Timoshkov
Huw Davies wrote: > > > Don't we need to add some bytes if glyph_width % 32 == 0 ? > > > > Well, I didn't see in my tests a need for that. > > That may be because your tests are just looking at the font metrics > and not at the glyphs themselves... I have an application that actually needs tha

Re: gdi32: Add support for emulating bold faces of bitmap fonts.

2012-04-16 Thread Huw Davies
On Mon, Apr 16, 2012 at 05:51:20PM +0900, Dmitry Timoshkov wrote: > Huw Davies wrote: > > > Don't we need to add some bytes if glyph_width % 32 == 0 ? > > Well, I didn't see in my tests a need for that. That may be because your tests are just looking at the font metrics and not at the glyphs th

Re: gdi32: Add support for emulating bold faces of bitmap fonts.

2012-04-16 Thread Dmitry Timoshkov
Huw Davies wrote: > Don't we need to add some bytes if glyph_width % 32 == 0 ? Well, I didn't see in my tests a need for that. -- Dmitry.

Re: gdi32: Add support for emulating bold faces of bitmap fonts.

2012-04-16 Thread Huw Davies
On Mon, Apr 16, 2012 at 04:37:39PM +0900, Dmitry Timoshkov wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 0a5d3c3..eb3f9b5 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -5669,12 +5669,27 @@ static inline BYTE get_max_level( UINT format ) >