"Dan Kegel" <[EMAIL PROTECTED]> writes:
>> I don't want to claim ownership for the patch you wrote.
>
> Don't worry, Alexandre usually gets that right.
Maybe, but I don't like it. I really prefer for people to send their own
patches instead of having others do it for them.
--
Alexandre Julliard
On Wed, Mar 26, 2008 at 6:38 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
> > The first step, as Alexandre says, is to add the test with a todo_wine
> > around the negative destlen test.
> > I would have done it but I'm more than happy to let you run with it.
>
> Please go ahead and resubmit
Dan Kegel wrote:
> On Wed, Mar 26, 2008 at 4:04 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
>> > This would require reviewing all uses of WideCharToMultiByte in Wine,
>> > many places get this wrong. Unless you have an app that requires this
>> > fix I'd suggest to leave the test as todo_wi
On Wed, Mar 26, 2008 at 4:04 AM, Michael Stefaniuc <[EMAIL PROTECTED]> wrote:
> > This would require reviewing all uses of WideCharToMultiByte in Wine,
> > many places get this wrong. Unless you have an app that requires this
> > fix I'd suggest to leave the test as todo_wine for now.
>
> Would
Michael Stefaniuc <[EMAIL PROTECTED]> writes:
> Would that be a good janitorial work to be done before Wine 1.0? I feel
> like I'm getting tired of translating ...
Sure, if you feel like doing it go ahead. I'm not sure the fix will go
in before 1.0, but already fixing as many callers as possible
Alexandre Julliard wrote:
> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>
>> While investigating a crash in gs-auftrag in bug 9039, noticed
>> WideCharToMultiByte wasn't quite conformant for negative destlen.
>> Fixed, with tests. Passes for me in Wine and Win XP.
>
> This would require reviewing al
"Dan Kegel" <[EMAIL PROTECTED]> writes:
> While investigating a crash in gs-auftrag in bug 9039, noticed
> WideCharToMultiByte wasn't quite conformant for negative destlen.
> Fixed, with tests. Passes for me in Wine and Win XP.
This would require reviewing all uses of WideCharToMultiByte in Wine
On Mon, Mar 24, 2008 at 10:54 AM, Maarten Lankhorst
<[EMAIL PROTECTED]> wrote:
> Hello Dan and AJ,
>
> 2008/3/24, Alexandre Julliard <[EMAIL PROTECTED]>:
>
>
> > "Dan Kegel" <[EMAIL PROTECTED]> writes:
> >
> > > +static void test_negative_dest_length(void)
> > > +{
> > > +int len;
> >
Hello Dan and AJ,
2008/3/24, Alexandre Julliard <[EMAIL PROTECTED]>:
> "Dan Kegel" <[EMAIL PROTECTED]> writes:
>
> > +static void test_negative_dest_length(void)
> > +{
> > +int len;
> > +char buf[10];
> > +
> > +/* Test return on negative dest length */
> > +SetLastError( 0
"Dan Kegel" <[EMAIL PROTECTED]> writes:
> +static void test_negative_dest_length(void)
> +{
> +int len;
> +char buf[10];
> +
> +/* Test return on negative dest length */
> +SetLastError( 0xdeadbeef );
> +memset(buf,'x',sizeof(buf));
> +len = WideCharToMultiByte(CP_ACP, 0, f
On Fri, Mar 21, 2008 at 7:12 PM, James Hawkins <[EMAIL PROTECTED]> wrote:
> > +#include
>
> Leftover from a previous version of the patch?
Whoops, yes. I'll resend it Monday.
On Fri, Mar 21, 2008 at 6:43 PM, Dan Kegel <[EMAIL PROTECTED]> wrote:
> While investigating a crash in gs-auftrag in bug 9039, noticed
> WideCharToMultiByte
> wasn't quite conformant for negative destlen. Fixed, with tests.
>
> diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c
> inde
12 matches
Mail list logo
