Re: new old winetests

2003-12-20 Thread Ferenc Wagner
David Laight <[EMAIL PROTECTED]> writes: > Just tell the Solaris user to put /usr/xpg4/bin on $PATH > before /usr/bin. Then 'sh' will be 'ksh' and posix > compliant... We are talking about #!/bin/sh now. $PATH is out of consideration here, I'm afraid. Feri.

Re: new old winetests

2003-12-20 Thread Dimitrie O. Paun
On December 20, 2003 05:08 pm, David Laight wrote: > Just tell the Solaris user to put /usr/xpg4/bin on $PATH before /usr/bin. > Then 'sh' will be 'ksh' and posix compliant... This would be just us trying to be nasty. There absolutely _zero_ reason to not use expr in this case. And don't tell me t

Re: new old winetests

2003-12-20 Thread David Laight
On Sat, Dec 20, 2003 at 08:57:29PM +0100, Ferenc Wagner wrote: > David Laight <[EMAIL PROTECTED]> writes: > > >> BTW, there's no need to make the script bash specific, > >> we can use expr instead: > >> > >> -i=$(($i+1)) > >> +i=`expr $i + 1` > > > > That isn't a bashism, it is required t

Re: new old winetests

2003-12-20 Thread Ferenc Wagner
David Laight <[EMAIL PROTECTED]> writes: >> BTW, there's no need to make the script bash specific, >> we can use expr instead: >> >> -i=$(($i+1)) >> +i=`expr $i + 1` > > That isn't a bashism, it is required to be supported by > any shell that claims to be Posix compliant. That > probably

Re: new old winetests

2003-12-03 Thread Michael Stefaniuc
Dimitrie O. Paun wrote: On December 2, 2003 11:10 am, Brian Vincent (C) wrote: It came out shortly after as an add-on and was likely first included in OSR2. Not a big deal, we'd be hard pressed to find a Win95 pre OSR2 system these days anyway. We can live with it. Well, i have one at home :). I

Re: new old winetests

2003-12-03 Thread Francois Gouget
On Wed, 3 Dec 2003, Ferenc Wagner wrote: [...] > Sure, we need very basic functionality only: socket, > connect, send and recv for TCP streams. It's just I didn't > find any documentation on it. Can you recommend something? > Or just change the version to MAKEWORD(1,1), don't #include > and link

Re: new old winetests

2003-12-03 Thread Ferenc Wagner
Francois Gouget <[EMAIL PROTECTED]> writes: > On Wed, 3 Dec 2003, Dimitrie O. Paun wrote: > >> On December 2, 2003 11:10 am, Brian Vincent (C) wrote: >> >>> It came out shortly after as an add-on and was likely >>> first included in OSR2. >> >> Not a big deal, we'd be hard pressed to find a Win95

Re: new old winetests

2003-12-03 Thread Francois Gouget
On Wed, 3 Dec 2003, Dimitrie O. Paun wrote: > On December 2, 2003 11:10 am, Brian Vincent (C) wrote: > > It came out shortly after as an add-on and > > was likely first included in OSR2. > > Not a big deal, we'd be hard pressed to find a Win95 > pre OSR2 system these days anyway. We can live with

Re: new old winetests

2003-12-02 Thread Dimitrie O. Paun
On December 2, 2003 11:10 am, Brian Vincent (C) wrote: > It came out shortly after as an add-on and > was likely first included in OSR2. Not a big deal, we'd be hard pressed to find a Win95 pre OSR2 system these days anyway. We can live with it. -- Dimi.

Re: new old winetests

2003-12-02 Thread Ferenc Wagner
"Brian Vincent (C)" <[EMAIL PROTECTED]> writes: >>> -- we're linking against ws2_32 >>> Is this DLL available on all versions of Windows we >>> want to run on? >> >> As far I know >> >> yes. > >

Re: new old winetests

2003-12-02 Thread Brian Vincent (C)
Title: Re: new old winetests >>   -- we're linking against ws2_32 >>  Is this DLL available on all versions of Windows we >>  want to run on? > >As far I know ><http://msdn.microsoft.com/library/en-us/winsock/winsock/windows_sockets_start_page_2.as

Re: new old winetests

2003-12-02 Thread Dimitrie O. Paun
On December 2, 2003 02:39 pm, Alexandre Julliard wrote: > Without modifying the app I don't know, but in this case you could use > CreateDirectory instead. Of course we can, for whatever reason we go stuck into using the std C lib. Not a problem. > The crosstest stuff is a hack that's here to mak

Re: new old winetests

2003-12-02 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > Well, unfortunately, the mkdir() bit is a ugly wart. I've run > into it in other projects (wxWindows comes to mind). If anyone > can figure out a solution that doesn't involve modifying the > app, let me know. Until then this should do. Without mod

Re: new old winetests

2003-12-02 Thread Dimitrie O. Paun
On December 2, 2003 05:48 am, Ferenc Wagner wrote: > "Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > > -- the mkdir() issue is still not 100% solved. We currently have: > > #ifndef _WIN32 > > # define mkdir(d) mkdir (d, 0777) > > #endif > > [...] Why don't we just link with msvcrt? > > "Di

Re: new old winetests

2003-12-02 Thread Ferenc Wagner
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > -- the mkdir() issue is still not 100% solved. We currently have: > #ifndef _WIN32 > # define mkdir(d) mkdir (d, 0777) > #endif > [...] Why don't we just link with msvcrt? "Dimitrie O. Paun" <[EMAIL PROTECTED]> also wrote: > "Doctor, it hu

Re: new old winetests

2003-12-02 Thread Dimitrie O. Paun
On November 25, 2003 02:53 pm, Ferenc Wagner wrote: > State of affairs attached. I didn't use popen() because Wine > doesn't support it. OK, This looks a lot cleaner. Very, very nice! There are still a few nits, but I think it should go in so we can send small incremental patches. Here are the f

Re: new old winetests

2003-11-30 Thread Ferenc Wagner
Alexandre Julliard <[EMAIL PROTECTED]> writes: > Ferenc Wagner <[EMAIL PROTECTED]> writes: > >> #ifdef _WIN32 >> # include >> # include >> #else >> # include "config.h" >> # include "wine/port.h" >> # define mkdir(d) mkdir (d, 0777) >> #endif > > I'm not sure why you don't want to use the n

Re: new old winetests

2003-11-30 Thread Alexandre Julliard
Ferenc Wagner <[EMAIL PROTECTED]> writes: > Is not > > #ifdef _WIN32 > # include > # include > #else > # include "config.h" > # include "wine/port.h" > # define mkdir(d) mkdir (d, 0777) > #endif > > an acceptable workaround? This should be compilable even > with MSVC after all, and Dimi ha

Re: new old winetests

2003-11-28 Thread Ferenc Wagner
Alexandre Julliard <[EMAIL PROTECTED]> writes: > Ferenc Wagner <[EMAIL PROTECTED]> writes: > >> Has a problem, indeed: >> ../../include/wine/port.h:87: dlfcn.h: No such file or directory > > That's because if you want to cross-compile you need to > cross-configure too. The crosstest stuff is a hac

Re: new old winetests

2003-11-27 Thread Alexandre Julliard
Ferenc Wagner <[EMAIL PROTECTED]> writes: > Has a problem, indeed: > ../../include/wine/port.h:87: dlfcn.h: No such file or directory That's because if you want to cross-compile you need to cross-configure too. The crosstest stuff is a hack that works because the tests don't use Wine-specific fea

Re: new old winetests

2003-11-27 Thread Ferenc Wagner
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: >-- cross compilation not tested at this point Has a problem, indeed: ../../include/wine/port.h:87: dlfcn.h: No such file or directory Understandable, as gcc has dlfcn.h, but the MinGW gcc does not. But commenting out the offending #define in c

Re: new old winetests

2003-11-26 Thread Ferenc Wagner
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On November 25, 2003 02:09 pm, Ferenc Wagner wrote: > >> I am sending a tarball of the present state to this >> thread shortly. > > ... the suspense it's killin' me! :) Sorry, I really sent everything a long time ago, but a spam flood seemingly br

Re: new old winetests

2003-11-26 Thread Dimitrie O. Paun
On November 25, 2003 02:09 pm, Ferenc Wagner wrote: > I am sending a tarball of the present state to this > thread shortly. ... the suspense it's killin' me! :) -- Dimi.

Re: new old winetests

2003-11-25 Thread Ferenc Wagner
Alexandre Julliard <[EMAIL PROTECTED]> writes: > Ferenc Wagner <[EMAIL PROTECTED]> writes: > >> What about this: >> >> makename="$BINDIR/`dirname $test`/Makefile.in" >> [...] >> sed -n '/^CTESTS =/,/[^\]$/{s/^CTESTS >> =//;s/\\$//;s/\([0-9a-zA-Z_]*\)\.c/"\1",/g;p;}' $makename

Re: new old winetests

2003-11-24 Thread Alexandre Julliard
Ferenc Wagner <[EMAIL PROTECTED]> writes: > What about this: > > makename="$BINDIR/`dirname $test`/Makefile.in" > [...] > sed -n '/^CTESTS =/,/[^\]$/{s/^CTESTS > =//;s/\\$//;s/\([0-9a-zA-Z_]*\)\.c/"\1",/g;p;}' $makename > > that is, extracting the subtest names from the corres

Re: new old winetests

2003-11-23 Thread Ferenc Wagner
Alexandre Julliard <[EMAIL PROTECTED]> writes: > "Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > >> Here is the fix for this one (to maketests): >> >> - wine $filename | sed '1,/^Valid/d;s/\(.*\)/"\1",/' >> + wine $filename | sed '1,/^Valid/d;s/\([0-9a-zA-Z_]*\)/

Re: new old winetests

2003-11-23 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > Here is the fix for this one (to maketests): > > - wine $filename | sed '1,/^Valid/d;s/\(.*\)/"\1",/' > + wine $filename | sed '1,/^Valid/d;s/\([0-9a-zA-Z_]*\)/"\1",/' This should really be done at run time, you

Re: new old winetests

2003-11-23 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > On November 22, 2003 12:32 pm, Ferenc Wagner wrote: >> Thanks for the detailed explanations; I never use implicit >> rules (prefer static patters). > > Same here, but Alexandre prefers them. Why is that Alexandre? Portability, some versions of make

Re: new old winetests

2003-11-22 Thread Dimitrie O. Paun
On November 22, 2003 12:32 pm, Ferenc Wagner wrote: > Thanks for the detailed explanations; I never use implicit > rules (prefer static patters). Same here, but Alexandre prefers them. Why is that Alexandre? > I didn't want to bother with this until we decide on the > interface. I don't know wha

Re: new old winetests

2003-11-22 Thread David Laight
> BTW, there's no need to make the script bash specific, > we can use expr instead: > > -i=$(($i+1)) > +i=`expr $i + 1` That isn't a bashism, it is required to be supported by any shell that claims to be Posix compliant. That probably means everything except an AT&T/SYSV bourne shell. If

Re: new old winetests

2003-11-22 Thread Ferenc Wagner
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > For unknown reasons, for msvcrt I get this: > const char* subtests_for_test5[] = { > "cpp^M", > "file^M", > "heap^M", > "scanf^M", > }; Oh, silly me, I forgot that I already noticed this problem and get rid of it by putting sed '1,/

Re: new old winetests

2003-11-22 Thread Dimitrie O. Paun
On November 22, 2003 11:45 am, Dimitrie O. Paun wrote: > Yes, there was a problem. For unknown reasons, for msvcrt > I get this: > const char* subtests_for_test5[] = { > "cpp^M", > "file^M", > "heap^M", > "scanf^M", > }; Here is the fix for this one (to maketests): - win

Re: new old winetests

2003-11-22 Thread Dimitrie O. Paun
On November 22, 2003 11:07 am, Ferenc Wagner wrote: > Btw, if it's you who ran the program > under Wine, you may be interested in the results: Speaking of which, I find the program too quite. I wasn't sure (until I got your email) that it ran at all! We should print the name of the currently runn

Re: new old winetests

2003-11-22 Thread Dimitrie O. Paun
On November 22, 2003 11:07 am, Ferenc Wagner wrote: >Hi Dimi, > > I appreciate your support very much. Now it's just a quick > reflection on the patch you sent, before I can take a closer > look and testing. Btw, if it's you who ran the program > under Wine, you may be interested

Re: new old winetests

2003-11-22 Thread Ferenc Wagner
Hi Dimi, I appreciate your support very much. Now it's just a quick reflection on the patch you sent, before I can take a closer look and testing. Btw, if it's you who ran the program under Wine, you may be interested in the results: Tests from build Sat Nov 22 03:29:11 EST 2003

Re: new old winetests

2003-11-22 Thread Dimitrie O. Paun
On November 21, 2003 12:16 pm, Ferenc Wagner wrote: > I would be grateful for a review. OK, One more time, this round with a patch incorporating most of my suggestions. What it does: -- better integration in the build system -- supports out of tree builds -- cleans up file when winetests

Re: new old winetests

2003-11-21 Thread Dimitrie O. Paun
On November 21, 2003 12:16 pm, Ferenc Wagner wrote: > I've got a more or less standalone version which can run the > tests and submit the results to a CGI script, if possible. > It also differentiates between libwine and cross builds. I > would be grateful for a review. One week point is its > in

new old winetests

2003-11-21 Thread Ferenc Wagner
Hi there, I've got a more or less standalone version which can run the tests and submit the results to a CGI script, if possible. It also differentiates between libwine and cross builds. I would be grateful for a review. One week point is its integration into the build system: I h