Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Alexandre Julliard
Vincent Povirk madewokherd+8...@gmail.com writes: To abstract what you're saying here, you're suggesting to extend the wineprefix ownership test to include $HOME when $WINEPREFIX is not set and $HOME/.wine does not exist? That doesn't sounds like a bad idea to me. But I'm not so sure about

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Steve Brown
On Tue, 10 Feb 2009, Vitaliy Margolen wrote: Ben Klein wrote: This is not a problem with Wine, this is OpenSUSE breaking the environment when sudo is called. Remember, Wine is not the only X11 app out there. Others will need $DISPLAY working! This is something called security No, the

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Marcus Meissner
On Wed, Feb 11, 2009 at 09:35:26AM -0500, Steve Brown wrote: On Tue, 10 Feb 2009, Vitaliy Margolen wrote: Ben Klein wrote: This is not a problem with Wine, this is OpenSUSE breaking the environment when sudo is called. Remember, Wine is not the only X11 app out there. Others will need

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread James Mckenzie
Steve Brown sbro...@umbc.edu wrote: On Tue, 10 Feb 2009, Vitaliy Margolen wrote: Ben Klein wrote: This is not a problem with Wine, this is OpenSUSE breaking the environment when sudo is called. Remember, Wine is not the only X11 app out there. Others will need $DISPLAY working! This is

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Vincent Povirk
No we don't want Wine to function in those cases, and it is part of the ownership test already. wine: '/home/sudotest' is not owned by you, refusing to create a configuration directory there So it is. Well then, there's no need for an additional warning as far as I'm concerned. When was this

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Austin English
On Wed, Feb 11, 2009 at 11:02 AM, Vincent Povirk madewokherd+8...@gmail.com wrote: No we don't want Wine to function in those cases, and it is part of the ownership test already. wine: '/home/sudotest' is not owned by you, refusing to create a configuration directory there So it is. Well

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Vincent Povirk
$ wine setup.exe # program doesn't work/error about admin rights/etc. $ sudo wine setup.exe wine: '/home/user/.wine' is not owned by you, refusing to create a configuration directory there $ sudo su # wine setup.exe Ok, if I understand you, one of the following things happens after that:

Re: ntdll: add a warning about running wine as root (resend)

2009-02-11 Thread Austin English
On Wed, Feb 11, 2009 at 11:40 AM, Vincent Povirk madewokherd+8...@gmail.com wrote: $ wine setup.exe # program doesn't work/error about admin rights/etc. $ sudo wine setup.exe wine: '/home/user/.wine' is not owned by you, refusing to create a configuration directory there $ sudo su # wine

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Alexandre Julliard
Vitaliy Margolen wine-de...@kievinfo.com writes: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people reporting problems that may or may not have anything to do with this. Will this work? BTW default Open

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Francois Gouget
On Tue, 10 Feb 2009, Ben Klein wrote: [...] Application tried to create a window, but no driver could be loaded. Make sure that your X server is running and that $DISPLAY is set correctly. Interesting. xauth problem. Again, I'd be surprised if this happened with sudo. Not so surprised if it

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vitaliy Margolen
Alexandre Julliard wrote: Vitaliy Margolen wine-de...@kievinfo.com writes: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people reporting problems that may or may not have anything to do with this. Will

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Austin English
On Tue, Feb 10, 2009 at 8:38 AM, Vitaliy Margolen wine-de...@kievinfo.com wrote: Alexandre Julliard wrote: Vitaliy Margolen wine-de...@kievinfo.com writes: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Alexandre Julliard
Austin English austinengl...@gmail.com writes: That's not the (main) problem. The main problem is people installing stuff as root when they have no reason to do so. Alexandre, how would you feel about a one time warning, e.g., by setting a registry key, a la wineboot when run on a

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Austin English
On Tue, Feb 10, 2009 at 10:44 AM, Alexandre Julliard julli...@winehq.org wrote: Austin English austinengl...@gmail.com writes: That's not the (main) problem. The main problem is people installing stuff as root when they have no reason to do so. Alexandre, how would you feel about a one time

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Alexandre Julliard
Austin English austinengl...@gmail.com writes: On Tue, Feb 10, 2009 at 10:44 AM, Alexandre Julliard julli...@winehq.org wrote: No, a warning that will get drowned in a bunch of other fixmes is not useful. We could make it a popup warning, again, only on first run. No, warning message boxes

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Ben Klein
2009/2/10 Francois Gouget fgou...@free.fr: On Tue, 10 Feb 2009, Ben Klein wrote: [...] Application tried to create a window, but no driver could be loaded. Make sure that your X server is running and that $DISPLAY is set correctly. Interesting. xauth problem. Again, I'd be surprised if this

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vincent Povirk
How about this: If uid = 0, SUDO_USER is set to a valid username, HOME is owned by that user, and WINEPREFIX is not set, then refuse to start, printing a message explaining the situation. Perhaps the message can be something like You're running Wine for the first time as root, but your home

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Ben Klein
2009/2/11 Vincent Povirk madewokherd+8...@gmail.com: How about this: If uid = 0, SUDO_USER is set to a valid username, HOME is owned by that user, and WINEPREFIX is not set, then refuse to start, printing a message explaining the situation. To abstract what you're saying here, you're

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vitaliy Margolen
Ben Klein wrote: This is not a problem with Wine, this is OpenSUSE breaking the environment when sudo is called. Remember, Wine is not the only X11 app out there. Others will need $DISPLAY working! This is something called security

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Vincent Povirk
To abstract what you're saying here, you're suggesting to extend the wineprefix ownership test to include $HOME when $WINEPREFIX is not set and $HOME/.wine does not exist? That doesn't sounds like a bad idea to me. But I'm not so sure about specifically testing on UID=0 or SUDO_USER. This

Re: ntdll: add a warning about running wine as root (resend)

2009-02-10 Thread Ben Klein
2009/2/11 Vitaliy Margolen wine-de...@kievinfo.com: Ben Klein wrote: This is not a problem with Wine, this is OpenSUSE breaking the environment when sudo is called. Remember, Wine is not the only X11 app out there. Others will need $DISPLAY working! This is something called security This

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Alexandre Julliard
Austin English austinengl...@gmail.com writes: Didn't receive any feedback on this one last time. Been seeing this a bit recently in the forums, so adding a warning. No actual functionality lost. We've been through this before. There are legitimate reasons for running as root, and we don't

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread James Mckenzie
Alexandre Julliard julli...@winehq.org Sent: Feb 9, 2009 5:56 AM To: Austin English austinengl...@gmail.com Cc: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) Austin English austinengl...@gmail.com writes: Didn't receive any feedback on this one last

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Alexandre Julliard
James Mckenzie jjmckenzi...@earthlink.net writes: Second, the problem is that newbies, figuring that their favorite program will not run as an ordinary user, gets a wiff that root has more privileges, will attempt run as root totally hosing their Wine directory. This then starts the 'you

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Austin English
On Mon, Feb 9, 2009 at 8:17 AM, James Mckenzie jjmckenzi...@earthlink.net wrote: Alexandre Julliard julli...@winehq.org Sent: Feb 9, 2009 5:56 AM To: Austin English austinengl...@gmail.com Cc: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) Austin

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread James Mckenzie
Alexandre Julliard julli...@winehq.org wrote: Sent: Feb 9, 2009 7:26 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: Austin English austinengl...@gmail.com, wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) James Mckenzie jjmckenzi...@earthlink.net

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Michael Stefaniuc
James Mckenzie wrote: Alexandre Julliard julli...@winehq.org wrote: Sent: Feb 9, 2009 7:26 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: Austin English austinengl...@gmail.com, wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) James Mckenzie

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread David Gerard
2009/2/9 James Mckenzie jjmckenzi...@earthlink.net: Thus, the need for the warning. Experts tend to know what they are doing, newbies don't for the most part. And yes, I borked many a system as a newbie and as an expert (building kernels for RedHat/Fedora for my Thinkpad. Yep. The

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Aurimas Fišeras
James Mckenzie wrote: Alexandre Julliard julli...@winehq.org wrote: [...] New wine installation: su (no dash so root's environment is not picked up) wine notepad install various programs and use them. exit User logs in a second time after learning how to properly use Wine. Attempt to

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Alexandre Julliard
James Mckenzie jjmckenzi...@earthlink.net writes: New wine installation: su (no dash so root's environment is not picked up) wine notepad install various programs and use them. exit This shouldn't hurt anything. Please specify the exact platform and show us the exact commands you are

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread James Mckenzie
David Gerard dger...@gmail.com wrote: Sent: Feb 9, 2009 7:45 AM To: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) 2009/2/9 James Mckenzie jjmckenzi...@earthlink.net: Thus, the need for the warning. Experts tend to know what they are doing

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread James Mckenzie
Alexandre Julliard julli...@winehq.org wrote: Sent: Feb 9, 2009 7:53 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: Austin English austinengl...@gmail.com, wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) James Mckenzie jjmckenzi...@earthlink.net

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Chris Howe
It would seem to me that the right place for this to go would be not in Wine itself but in the likes of Crossover and Cedega - the distributions and value added apps built around Wine. I can't reconcile in my head the case where you have a newbie running the latest GIT of Wine needing this kind

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread David Gerard
2009/2/9 Chris Howe mrmess...@gmail.com: I can't reconcile in my head the case where you have a newbie running the latest GIT of Wine needing this kind of thing at all. It's frequently newbies running the WineHQ versions. Again, I suggest reading the user forum to get an idea of why this

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Alexandre Julliard
James Mckenzie jjmckenzi...@earthlink.net writes: It does not hurt anything but Wine's reputation. I don't know, but the phrase I would rather be run over rather than run down does apply here. In other words, we should be getting positive responses to user experiences, rather than dealing

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Steve Brown
On Mon, 9 Feb 2009, James Mckenzie wrote: Alexandre Julliard julli...@winehq.org wrote: Please explain how running as root will screw their Wine directory. If that's really true, surely it should be fixed instead of simply throwing out a warning and proceeding. New wine installation: su

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Austin English
On Mon, Feb 9, 2009 at 9:19 AM, Alexandre Julliard julli...@winehq.org wrote: James Mckenzie jjmckenzi...@earthlink.net writes: It does not hurt anything but Wine's reputation. I don't know, but the phrase I would rather be run over rather than run down does apply here. In other words, we

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread James Mckenzie
Chris Howe mrmess...@gmail.com wrote: Sent: Feb 9, 2009 8:06 AM To: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) It would seem to me that the right place for this to go would be not in Wine itself but in the likes of Crossover and Cedega

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Ben Klein
2009/2/10 Steve Brown sbro...@umbc.edu: On Mon, 9 Feb 2009, James Mckenzie wrote: Alexandre Julliard julli...@winehq.org wrote: Please explain how running as root will screw their Wine directory. If that's really true, surely it should be fixed instead of simply throwing out a warning and

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread James Mckenzie
Aurimas Fišeras auri...@gmail.com wrote: Sent: Feb 9, 2009 7:45 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) James Mckenzie wrote: Alexandre Julliard julli...@winehq.org wrote: [...] New wine

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Ben Klein
Just realised something ... 2009/2/10 Ben Klein shackl...@gmail.com: In the case of sudo wine whatever, $HOME is the originating user's home directory, and `id -u` is 0. So this means that root-owned files will appear in $HOME/.wine (assuming no WINEPREFIX is set). In the case that there is

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Austin English
On Mon, Feb 9, 2009 at 9:58 AM, James Mckenzie jjmckenzi...@earthlink.net wrote: Aurimas Fišeras auri...@gmail.com wrote: Sent: Feb 9, 2009 7:45 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) James

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread James Mckenzie
Michael Stefaniuc mstef...@redhat.com wrote: Sent: Feb 9, 2009 7:39 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running wine as root (resend) sudo rm -rf .wine Solution is sudo chmod -R $username.$groupname .wine Correct

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread IneedAname
On Mon, 9 Feb 2009 07:35:20 -0700 (GMT-07:00) James Mckenzie jjmckenzi...@earthlink.net wrote: Yes, there are legit reasons to run as root, one of them is the now famous ICMP 'Ping' unavailability issue in Linux. Experts know about this and how to work around it. Newbies, used to Windows

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Vitaliy Margolen
Austin English wrote: On Mon, Feb 9, 2009 at 9:58 AM, James Mckenzie jjmckenzi...@earthlink.net wrote: Aurimas Fišeras auri...@gmail.com wrote: Sent: Feb 9, 2009 7:45 AM To: James Mckenzie jjmckenzi...@earthlink.net Cc: wine-devel@winehq.org Subject: Re: ntdll: add a warning about running

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Vitaliy Margolen
Alexandre Julliard wrote: James Mckenzie jjmckenzi...@earthlink.net writes: It does not hurt anything but Wine's reputation. I don't know, but the phrase I would rather be run over rather than run down does apply here. In other words, we should be getting positive responses to user

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Ben Klein
2009/2/10 Vitaliy Margolen wine-de...@kievinfo.com: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people reporting problems that may or may not have anything to do with this. Will this work? BTW default Open

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Vitaliy Margolen
Ben Klein wrote: 2009/2/10 Vitaliy Margolen wine-de...@kievinfo.com: Alexandre Julliard wrote: Again, please demonstrate the exact sequence that leads to an actual problem, not just vague hearsay of people reporting problems that may or may not have anything to do with this. Will this work?

Re: ntdll: add a warning about running wine as root (resend)

2009-02-09 Thread Kai Blin
On Monday 09 February 2009 17:29:19 IneedAname wrote: On Mon, 9 Feb 2009 07:35:20 -0700 (GMT-07:00) James Mckenzie jjmckenzi...@earthlink.net wrote: Yes, there are legit reasons to run as root, one of them is the now famous ICMP 'Ping' unavailability issue in Linux. Experts know about

ntdll: add a warning about running wine as root (resend)

2009-02-06 Thread Austin English
Didn't receive any feedback on this one last time. Been seeing this a bit recently in the forums, so adding a warning. No actual functionality lost. -- -Austin diff --git a/dlls/ntdll/server.c b/dlls/ntdll/server.c index 145540f..17e685e 100644 --- a/dlls/ntdll/server.c +++ b/dlls/ntdll/server.c