Re: D3D command stream patches for testing

2013-09-20 Thread Forest
Stefan, are these patches already present in the wine 1.7.2 release? Now that the official 1.7.2 Ubuntu packages have been published, I'm trying to figure out how to get your CSMT changes into the PPA that I maintain.

Re: D3D command stream patches for testing

2013-09-15 Thread Forest
In the past months I have been working on a command stream / worker thread for wined3d. It moves most OpenGL calls into a separate thread to improve performance (bug 11674) and fix some bugs that are otherwise hard to fix (24684). Thank you, Stefan! I applied your patches to the Ubuntu PPA

Re: D3D command stream patches for testing

2013-09-15 Thread Henri Verbeet
On 15 September 2013 21:47, Forest win...@tibit.com wrote: I wonder if the 80%+ gains reported in other games are not to be seen in Guild Wars 2, or if they're heavily dependent on CPU, GPU, graphics driver, and screen resolution. For the record, I'm using an Intel i5-3570K (stock speeds),

Re: D3D command stream patches for testing

2013-09-15 Thread Forest
awful frame rates when running on wine/linux compared to the same hardware on windows. I look forward to seeing results from more GW2 players using these patches. For anyone interested, a few players have begun to post their results in the AppDB comments: http://appdb.winehq.org/objectManager.php

Re: D3D command stream patches for testing

2013-09-15 Thread Stefan Dösinger
hard to fix (24684). Thank you, Stefan! I applied your patches to the Ubuntu PPA that I maintain for Guild Wars 2 players: You are fairly lucky with Guild Wars 2. I didn't see any improvement in this game myself. But as Henri said, it depends a lot on the game and your GPU and CPU. Afair GW2

Re: D3D command stream patches for testing

2013-09-09 Thread LOMBARD Maxime
Hi Stefan, I've tested two games FarCry3 and Splinter Cell Blacklist with : - Wine 1.7.1 + CS patch + CSMT On/Off - Wine 1.7.1 clean - CSMT On = CSMT enabled + StrictDrawOrdering disabled - CSMT Off = CSMT disabled + StrictDrawOrdering enabled I run the game by *WINEDEBUG=fps,err-all,fixme-all

RFC: Completely revised SIO_ADDRESS_LIST_CHANGE patches

2013-09-06 Thread Erich E. Hoover
As some of you know I've been working on fixing SIO_ADDRESS_LIST_CHANGE in order to fix some problems with Silverlight on a variety of streaming sites. Due to some feedback I've received I've gone to the effort to completely revise these patches to work inside of the server instead of using

Re: D3D command stream patches for testing

2013-09-05 Thread Prot Secret
Hi, I am interested in your work, but after patching wine171 of this patch and enabled csmt, i have seen this in SC2 http://postimg.org/gallery/1w8y6jbg I use nvidia GTX 680 with proprietary i386 nvidia driver 319.49. Where I could be wrong, or what else can be set that would be normalized image

Re: D3D command stream patches for testing

2013-09-05 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-04 20:11, schrieb Prot Secret: Hi, I am interested in your work, but after patching wine171 of this patch and enabled csmt, i have seen this in SC2 http://postimg.org/gallery/1w8y6jbg I use nvidia GTX 680 with proprietary i386 nvidia

D3D command stream patches for testing

2013-09-05 Thread Pierre Franco
I've tested some games (wine 1.7.1 64-bit for Guild Wars 2 and SCII, 32-bit for Skyrim, no wined3d/d3d patch except the patchset for CSMT). I have a GTX660 (slightly overclocked, +10 Mhz or so) with the 325.15 Nvidia blob and an Intel i5 2500K (overclocked to 4.2 Ghz). #Guild Wars 2(in the

RE: D3D command stream patches for testing

2013-09-04 Thread Vedran Rodic
Hello, I was not subscribed to wine-devel, so I can't reply to Stefan's mail directly, but here are some of my observations with Dota 2 on an Intel HD4000 GPU. Intel Mesa driver doesn't seem to like glBufferSubData in a way this patchset uses it. I get many many messages like these per frame

Re: D3D command stream patches for testing

2013-09-04 Thread Stefan Dösinger
that won't go away until I've moved all GL calls into the worker thread. Are you GPU or CPU limited? If you're GPU limited, those patches won't change anything. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net

Re: D3D command stream patches for testing

2013-09-03 Thread Rosanne DiMesio
On Mon, 02 Sep 2013 15:55:18 +0200 Stefan Dösinger stefandoesin...@gmail.com wrote: You can test the attached patches by applying them (git am /path/to/patches/*) Third patch doesn't apply: Applying: wined3d: Don't mess with the device in buffer_create_buffer_object Applying: wined3d: Don't

Re: D3D command stream patches for testing

2013-09-03 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-03 15:57, schrieb Rosanne DiMesio: On Mon, 02 Sep 2013 15:55:18 +0200 Stefan Dösinger stefandoesin...@gmail.com wrote: You can test the attached patches by applying them (git am /path/to/patches/*) Third patch doesn't apply

Re: D3D command stream patches for testing

2013-09-03 Thread Rosanne DiMesio
On Tue, 3 Sep 2013 08:57:48 -0500 Rosanne DiMesio dime...@earthlink.net wrote: Third patch doesn't apply: Nevermind. I figured out my mistake (overlooked the part about applying to 1.7.1). -- Rosanne DiMesio dime...@earthlink.net

Re: Synchronization-patches of widl

2013-08-08 Thread André Hentschel
Am 08.08.2013 10:56, schrieb Kai Tietz: All these changes were necessary to support the VLC-people to begin with their WinRT port. By this we began on mingw-w64 to improve - thanks to Jacek - our IDL-generated header-sources. So you are on a good way with WinRT, nice. What about Windows RT,

Wine 1.6 list of deferred patches

2013-07-22 Thread Bruno Jesus
This is the list of (hopefully) all deferred patches for wine 1.6, all authors are in bcc. I hope it's useful for developers. 97187 DeferredDmitry Timoshkov[3/3] kernel32: GetShortPathName for a non-existent short file name should fail. 97131 DeferredRosen Diankov

Re: Patches I maintain

2013-07-18 Thread Rico Schüller
Hi Roland, I'm not exactly sure what your goal is... but there is a rule one patch per mail only! There is likely no chance to get something like that mixture committed. You may have a look here: http://wiki.winehq.org/SubmittingPatches On 18.07.2013 01:23, Roland Haeder wrote: +HRESULT

Re: Patches I maintain

2013-07-18 Thread Nozomi Kodama
Hello for this one, I have a patch in my tree. I will send it after my patches for the spherical harmonics. Nozomi Hi Roland, I'm not exactly sure what your goal is... but there is a rule one patch per mail only! There is likely no chance to get something like that mixture committed. You

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-03 Thread Rosen Diankov
you are right again, i'll be more careful. now, i've addressed every problem except creating the patches with git. any help would be appreciated. . 2013/7/2 Hans Leidekker h...@codeweavers.com: On Mon, 2013-07-01 at 18:08 +0900, Rosen Diankov wrote: you are right, i'm attaching a new patch

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-03 Thread Hans Leidekker
On Tue, 2013-07-02 at 20:34 +0900, Rosen Diankov wrote: you are right again, i'll be more careful. now, i've addressed every problem except creating the patches with git. any help would be appreciated. See http://wiki.winehq.org/GitWine --- wine-1.6-rc4-old/dlls/wbemprox/builtin.c2013-06

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-02 Thread Rosen Diankov
03:24:01.0 +0900 +++ wine-1.6-rc3/dlls/wbemprox/builtin.c2013-06-27 23:04:20.170154454 +0900 Please use git to generate patches. @@ -168,6 +168,8 @@ {'M','a','n','u','f','a','c','t','u','r','e','r',0}; static const WCHAR prop_maxclockspeedW[] = {'M','a','x','C

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-02 Thread Hans Leidekker
On Mon, 2013-07-01 at 18:08 +0900, Rosen Diankov wrote: you are right, i'm attaching a new patch. You didn't address all comments.

Re: [wbemprox] Patches for adding currentclockspeed in record_processor

2013-07-01 Thread Hans Leidekker
:04:20.170154454 +0900 Please use git to generate patches. @@ -168,6 +168,8 @@ {'M','a','n','u','f','a','c','t','u','r','e','r',0}; static const WCHAR prop_maxclockspeedW[] = {'M','a','x','C','l','o','c','k','S','p','e','e','d',0}; +static const WCHAR prop_currentclockspeedW

Patches 96314 96328

2013-05-22 Thread Christian Costa
Hi, Is there any problem with these patches? http://source.winehq.org/patches/data/96314 http://source.winehq.org/patches/data/96328 Christian

Patches 96113 96114

2013-05-09 Thread Christian Costa
Hi, Is there anything wrong with these patches? http://source.winehq.org/patches/data/96113 http://source.winehq.org/patches/data/96114 Christian

wine-patches

2013-05-02 Thread Daniel Jeliński
Hello, I sent a ~200KB patch to wine-patches last night and it disappeared without a trace. I'm wondering if it got lost or just went to moderation. Regards, Daniel PS.I just resent it, still no luck.

Re: wine-patches

2013-05-02 Thread Marcus Meissner
On Thu, May 02, 2013 at 08:12:53AM +0200, Daniel Jeliński wrote: Hello, I sent a ~200KB patch to wine-patches last night and it disappeared without a trace. I'm wondering if it got lost or just went to moderation. Regards, Daniel PS.I just resent it, still no luck. If you are subscribed

Patches for winspool.drv and other locations

2013-01-14 Thread Detlef Riekenberg
Hi Tatyana Welcome to Wine. Wine has a test suite to make sure, that new code is correct. Example, what you never tested: -if(!pDeviceName) { +if(!pDeviceName !*pDeviceName) { Your code will crash, when pDeviceName is NULL. I expect, you want to use a logical OR, but i did not test

Re: Help Splitting Patches

2012-12-31 Thread Eric Pouech
Le 30/12/2012 22:52, Adam Martinson a écrit : Looking for some help splitting patch 3, not sure how I can cut it down any more without breaking stuff. I'm guessing patch 9 will need splitting too, same problem. I haven't checked whether it's really possible, but one way to go would be to: -

Re: Mail problems for wine-patches

2012-12-31 Thread Jeremy White
I also unsubscribed and subscribed again to the wine-patches list. Any ideas? Has wine-patches a whitelist? We use an exim rule to screen out IP addresses flagged in the SORBS database. Unfortunately, the outbound mailer for your domain is listed; here is the exim error report

Help Splitting Patches

2012-12-30 Thread Adam Martinson
Looking for some help splitting patch 3, not sure how I can cut it down any more without breaking stuff. I'm guessing patch 9 will need splitting too, same problem. ~Adam patches.tar.gz Description: GNU Zip compressed data

Mail problems for wine-patches

2012-12-26 Thread Detlef Riekenberg
I send several patches the last days with git and with the webmail interface from web.de, but nothing arrived at the wine-patches archive or the patches queue page. I also unsubscribed and subscribed again to the wine-patches list. Any ideas? Has wine-patches a whitelist? -- By by ... Detlef

cmd patches - please ignore them

2012-12-16 Thread Ann and Jason Edmeades
Dont know what's happened, need to investigate further - Had 100% pass rate in job 23438 only to fail on submission... Needs some investigation so will work on it later in the week Jason

wine-patches mailinglist problem

2012-12-01 Thread André Hentschel
Hi, The wine-patches mailing list seems to stopped working. As you can see at http://www.winehq.org/pipermail/wine-patches/ there's no December 2012, but i sent a patch hours ago. I'm not aware of a mailing list memberships reminder from that list. -- Best Regards, André Hentschel

Re: some patches to read files faster (especially for baldur's gate and infinity engine games)

2012-07-10 Thread Austin English
On Mon, Jul 9, 2012 at 2:06 PM, Emmanuel Anne emmanuel.a...@gmail.com wrote: Hello, I installed baldur's gate lately and noticed it was still slow in wine, especially if I install a few mods. See the description of the bug here : http://bugs.winehq.org/show_bug.cgi?id=17956 So after reading

App bundle patches for OS X

2012-07-08 Thread Per Johansson
Hi, I think I've reached a committable stage for the application bundle code I took over from Steven Edwards last summer. But there are some controversial parts so I figured I'd ask the list first. The patch extracts all XDG specific parts of winemenubuilder into a separate file, and there is

Re: League of Legends patches

2012-07-04 Thread Dan Kegel
On Wed, Jul 4, 2012 at 12:15 AM, Andrea Canciani ranm...@gmail.com wrote: Do you think you could write a test that (semi-)reliably causes the deadlock you're fixing? Yes, I guess it should be possible. Could you point me to a test which triggers a deadlock (in particular, how should the

Re: League of Legends patches

2012-07-04 Thread Jonas Maebe
Dan Kegel wrote on Wed, 04 Jul 2012: (https://code.google.com/p/winezeug/source/browse/trunk/buildbot/dotests_blacklist.txt has a list of all the tests that the buildbot failed on while it was running The ones annotated with http://xquartz.macosforge.org/trac/ticket/512 should work with

Re: League of Legends patches

2012-07-04 Thread Andrea Canciani
On Tue, Jul 3, 2012 at 3:45 PM, Dan Kegel d...@kegel.com wrote: On Tue, Jul 3, 2012 at 1:08 AM, Andrea Canciani ranm...@gmail.com wrote: I tried to follow the http://wiki.winehq.org/SubmittingPatches guidelines, but this is my first submission to wine, so I guess the patches might need further

Re: League of Legends patches

2012-07-03 Thread Dan Kegel
On Tue, Jul 3, 2012 at 1:08 AM, Andrea Canciani ranm...@gmail.com wrote: I tried to follow the http://wiki.winehq.org/SubmittingPatches guidelines, but this is my first submission to wine, so I guess the patches might need further improvement. Please point out any issues that need fixing

Re: Examples of AJ silently improving patches?

2012-06-21 Thread Stefan Dösinger
Hi, Here's another one where AJ implemented a suggestion I sent 3 days later: http://source.winehq.org/git/wine.git/commitdiff/5523820b810d16fd17da86fcf7930fd3f27acdf4 http://www.winehq.org/pipermail/wine-patches/2012-June/115180.html Am Mittwoch, 20. Juni 2012, 17:52:31 schrieb Daniel Lehman

Examples of AJ silently improving patches?

2012-06-20 Thread Dan Kegel
AJ sometimes kindly fixes problems in patches while committing them (I guess it's easier than rejecting the patch for small issues). I wonder if these silent improvements would be worth collecting as a sort of style-guide-by-example. Anyone remember any good examples? I've started a list at http

Re: Examples of AJ silently improving patches?

2012-06-20 Thread Alex Henrie
Here is an example: http://www.winehq.org/pipermail/wine-patches/2011-December/109805.html http://www.winehq.org/pipermail/wine-devel/2011-December/093517.html http://source.winehq.org/git/wine.git/commitdiff/6e5bba1b60f97fce34415ea30ebecd5bd20dae20 -Alex

RE: Examples of AJ silently improving patches?

2012-06-20 Thread Daniel Lehman
Another example: http://www.winehq.org/pipermail/wine-patches/2012-January/110398.html http://source.winehq.org/git/wine.git/commit/b1f04e23bf361e06d239e03693c904a597b9a32d I had added a redundant null check in both A and W paths. he simplified it by making just the W path handle the null

Patches 85862 85862

2012-04-30 Thread Christian Costa
What's wrong with these patches : - http://source.winehq.org/patches/data/85862 - http://source.winehq.org/patches/data/85862 There are marked as pending but can't see anything wrong. Maybe I'm missing something. Christian

Re: 'Pending' patches state

2012-04-10 Thread Dmitry Timoshkov
in the form of a test case, may help. ... or may not help. http://wiki.winehq.org/SubmittingPatches suggests If your patch disappears from http://source.winehq.org/patches/ without being committed, improve it (perhaps by adding more tests) and resend. The patch disappears from the patch tracker

Re: 'Pending' patches state

2012-04-10 Thread Marcus Meissner
glance... Q: What can I do? A: Making a more convincing argument, preferably in the form of a test case, may help. ... or may not help. http://wiki.winehq.org/SubmittingPatches suggests If your patch disappears from http://source.winehq.org/patches/ without being committed, improve

Re: 'Pending' patches state

2012-04-10 Thread Dmitry Timoshkov
Marcus Meissner mar...@jet.franken.de wrote: Also Alexandre to some parts comments on bad patches these days. :) If by 'bad patches' you mean patches in the rejected state that's not the subject of this thread. -- Dmitry.

Re: 'Pending' patches state

2012-04-09 Thread Dmitry Timoshkov
comments/explanations/tests/etc. and more actively discuss possible ways to fix a particular bug), but also code quality and help developers better understand what could be improved in future submissions. Silently marking a patch as 'pending' doesn't help with that at all. Consider that if two my patches

Re: 'Pending' patches state

2012-04-09 Thread Jeff Latimer
ways to fix a particular bug), but also code quality and help developers better understand what could be improved in future submissions. Silently marking a patch as 'pending' doesn't help with that at all. Consider that if two my patches for SetParent would be accepted one year ago but not one

Re: 'Pending' patches state

2012-03-30 Thread Dmitry Timoshkov
Alexandre Julliard julli...@winehq.org wrote: WM_SHOWWINDOW at the start and at the end of every message sequence means that ShowWindow() should be used to hide and show the window during SetParent call processing. That's the sort of explanation you should have included in your patch,

Re: 'Pending' patches state

2012-03-28 Thread Alexandre Julliard
a silent case of 'Reject', but without any obligation to explain why. I find myself on somewhat shaky ground when I see a bunch of my patches in the pending state, especially if they already contain the tests and main developer in the area I'm changing is Alexandre :). Is it possible to get

Re: 'Pending' patches state

2012-03-28 Thread Dmitry Timoshkov
in bugzilla, I think that developers deserve at least small fraction of friendliness as well (Alexandre, you are nice and friendly all the time, but at least I sometimes feel like sending the patches to a blackwhole). For instance your patch 84692 says that tests confirm that, but you don't say which

Re: 'Pending' patches state

2012-03-28 Thread Alexandre Julliard
of recent discussions about friendliness to users in bugzilla, I think that developers deserve at least small fraction of friendliness as well (Alexandre, you are nice and friendly all the time, but at least I sometimes feel like sending the patches to a blackwhole). If you want to write a script

Re: 'Pending' patches state

2012-03-28 Thread Michael Stefaniuc
of feedback, while 'Pending' doesn't. To me 'Pending' looks like a silent case of 'Reject', but without any obligation to explain why. I find myself on somewhat shaky ground when I see a bunch of my patches in the pending state, especially if they already contain the tests and main developer

Re: 'Pending' patches state

2012-03-28 Thread Dmitry Timoshkov
, instead of expecting me to dig through the source or the list archive to find it. Plus of course some explanation as to why the test can't be marked as succeeding despite the change. There are other things inside of SetParent that break message sequences, that's why the patches were prepended

Re: 'Pending' patches state

2012-03-28 Thread Alexandre Julliard
. Not necessarily. Patches are automatically marked pending as soon as I look at them, until they get a more permanent resolution. There can be many different reasons why they don't get one. Iff one knows you and knows to read in between the lines then the above can be reworded as: Current

Re: 'Pending' patches state

2012-03-28 Thread Jerome Leclanche
to still make up their mind on the patch but that's not the case, it is a done deal. Not necessarily. Patches are automatically marked pending as soon as I look at them, until they get a more permanent resolution. There can be many different reasons why they don't get one. Iff one knows you

'Pending' patches state

2012-03-27 Thread Dmitry Timoshkov
Hello, http://source.winehq.org/patches has the following legend for the Pending patch status: Pending * The patch is not obviously correct at first glance. Making a more convincing argument, preferably in the form of a test case, may help. * Waiting for feedback from the main developer

Re: po: Spanish translation update (this patch supersedes previous patches fixing fuzzies)

2012-03-14 Thread Frédéric Delanoy
On Wed, Mar 14, 2012 at 22:57, Eduardo García eduardo.gar...@gmx.com wrote: This patch fixes fuzzies and remove obsolete comments. With regards. Eduardo You may also remove the #| msgid ... lines: these only indicate the former msgid, so you can see the difference quickly. Also, add (try N)

Regarding my dinput patches

2012-01-17 Thread Lucas Zawacki
I want to get my dinput patches in before the code freeze, and besides the ones that I tried to commit last week I have some patches touching EnumDevicesBySemantics and ConfigureDevices, but I can't commit them before the DIPROP_USERNAME and configuration file patches are in too. Seeing that I'll

Re: Regarding my dinput patches

2012-01-17 Thread Vitaliy Margolen
On 01/17/2012 11:19 AM, Lucas Zawacki wrote: I want to get my dinput patches in before the code freeze, and besides the ones that I tried to commit last week I have some patches touching EnumDevicesBySemantics and ConfigureDevices, but I can't commit them before the DIPROP_USERNAME

Palettized ddraw surface patches

2011-10-09 Thread Stefan Dösinger
Hi, I'll start sending my patches for blitting palettized surfaces with opengl. There are quite a few patches and I won't send them all in one, so this mail shows where I am headed. Palettized surfaces are in a bad shape right now, both in terms of code quality and functionality. My patches

Re: Old imagehlp patches

2011-09-19 Thread Thomas Kluyver
On 19 September 2011 02:37, Juan Lang juan.l...@gmail.com wrote: I wouldn't hold your breath expecting these patches to go in as-is: if they weren't good enough in 2004-5, they're not any better now. You'd want someone who has an active interest in this area to have a go at them, I believe

Re: Old imagehlp patches

2011-09-19 Thread Henri Verbeet
On 19 September 2011 03:37, Juan Lang juan.l...@gmail.com wrote: weren't good enough in 2004-5, they're not any better now.  You'd want someone who has an active interest in this area to have a go at them, I believe, unless you can convince the original author to take them up again. AFAIK

Re: Old imagehlp patches

2011-09-18 Thread Juan Lang
Hi Thomas, wrong mailing list. You wanted wine-devel instead (now cc'ed.) I don't know about wine development, but are these patches still likely to work? What would need to happen for them to be merged in? To your first question, try them and see! To your second question, a lot. They're

Re: About cmd patches

2011-08-19 Thread Nowres Rafid
On 19/08/2011 03:14, Dan Kegel wrote: Hi Nowres, it's awesome that you're digging into cmd like this! The rule with Wine is that Each patch you submit shall pass tests. That means that your patch series [1/2] cmd: fixing an error with redirection operators [2/2] cmd/tests: fixing an error

Re: About cmd patches

2011-08-19 Thread Dan Kegel
will fail after the first patch. i queued these patch in my email client, but when I sent them they were sent in bad order. It doesn't matter what order they were sent in, I think. There's no way that applying one of those patches would yield working tests. If you want to do a two patch series

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches

2011-07-29 Thread Alexandre Julliard
Bernhard Loos bernhardl...@googlemail.com writes: On Thu, Jul 28, 2011 at 7:46 PM, Alexandre Julliard julli...@winehq.org wrote: Bernhard Loos bernhardl...@googlemail.com writes: @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event,      if

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches

2011-07-28 Thread Alexandre Julliard
Bernhard Loos bernhardl...@googlemail.com writes: @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event, if (wait_handle) { -NtWaitForSingleObject( wait_handle, (options FILE_SYNCHRONOUS_IO_ALERT), NULL ); -status =

Re: [PATCH 2/8] ntdll: rework the handling of server ioctls a little bit to avoid a crash with later patches

2011-07-28 Thread Bernhard Loos
On Thu, Jul 28, 2011 at 7:46 PM, Alexandre Julliard julli...@winehq.org wrote: Bernhard Loos bernhardl...@googlemail.com writes: @@ -1273,10 +1282,16 @@ static NTSTATUS server_ioctl_file( HANDLE handle, HANDLE event,      if (wait_handle)      { -        NtWaitForSingleObject(

Re: wined3d performance patches

2011-06-14 Thread Henri Verbeet
I only looked over about half of this, doesn't look too crazy. You do have trailing spaces in a couple of places though. Here are some comments: Subject: [PATCH 04/14] wined3d: Don't set FBO attachment filtering to GL_NEAREST As far as I'm concerned you can just submit this. I was going to do

Re: wined3d performance patches

2011-06-14 Thread Stefan Dösinger
Hi, Thanks for the comments, I've some replies inlined below. The bigger concern I have is that the patches don't improvement by a lot yet, about 1% on AMD GPUs and 1.5% to 2.5% on Nvidia GPUs(in real apps, my benchmarks are a different issue). Because of that my plan is to do more testing

Re: wined3d performance patches

2011-06-14 Thread Henri Verbeet
for that or help improve the nouveau driver for that card. Besides, it is probably not necessary for the other patches. The consideration was that we'd have to verify the filter each draw, but I don't think setting a texture as sampler and render target simultaneously is allowed in d3d. I'm not so

Re: wined3d performance patches

2011-06-14 Thread Stefan Dösinger
On Tuesday 14 June 2011 16:15:35 Henri Verbeet wrote: Yes, but I think that by now GF7 GPUs are marginal enough that it's not worth keeping the code around for. The Steam HW survey for example reports over 90% D3D10+ cards. Even if it does regress something, I think it makes more sense to tell

wined3d performance patches

2011-06-06 Thread Stefan Dösinger
Hi, This is intended mostly for the other d3d developers, but since we have quite a number of them now so individual CCs are a lot of work :-) I attached the patches I currently have in my tree to give an update on what I've been working on recently. The main aim of those patches is to reduce

Re: wined3d performance patches

2011-06-06 Thread Matteo Bruni
that was with your FBO dirty patches from your previous wined3d performance wine-devel email, so it should more or less match what happens with your current 0005 + 0006 patches (I didn't recheck with the newer ones though). I got a small but measurable (1 - 1.5%) overall improvement in d3d9 performances, so

Style updates for source.winehq/patches

2011-04-24 Thread Jerome Leclanche
Attached patch to tools.git/patches/patches.css adds the necessary styling for a WineHQ-style patch status page: http://i.imgur.com/5ToSc.png The div class=main needs to be replaced by the html attached in the other file. I can write a patch for it if it's to be included, but I cannot test

Sorry about the duplicate patches.

2011-04-05 Thread Joel Teichroeb
When trying to submit my first patch I did not do it correctly, and on http://source.winehq.org/patches/ it shows up 5 times. The correct patch is http://www.winehq.org/pipermail/wine-patches/2011-April/100677.html Thanks for your patience. Joel Teichroeb

Patches to fix GetDIBits for top down destination bitmaps

2011-02-27 Thread John Edmonds
Please ignore the patches http://source.winehq.org/patches/data/71716 and http://source.winehq.org/patches/data/71711. I was having trouble with my mail client and accidentally sent the same code 3 times.

the patches around ok()

2011-02-04 Thread Joris Huizer
Hello Henri Verbeet, and André Hentschel I wasn't (actively) on the mailing list, that's why I couldn't reply directly to your messages. I will try and make sure I have better titles for such patches in future! Regards, Joris

Re: the patches around ok()

2011-02-04 Thread André Hentschel
Am 04.02.2011 20:00, schrieb Joris Huizer: Hello Henri Verbeet, and André Hentschel I wasn't (actively) on the mailing list, that's why I couldn't reply directly to your messages. I will try and make sure I have better titles for such patches in future! Regards, Joris Great, but you

wine-patches

2011-01-25 Thread Vincent Hardy
Hi, I sent this email on wine-patch but... nothing. Am I doing something wrong ? Am I blacklisted ? Vincent ---BeginMessage--- From bdf47b42a1560e9e097770f54d8f36a234f6d686 Mon Sep 17 00:00:00 2001 From: Vincent Hardy vincent.hardy...@gmail.com Date: Mon, 24 Jan 2011 10:33:36 +0100 Subject:

Re: wine-patches

2011-01-25 Thread Juan Lang
Hi Vincent, I sent this email on wine-patch but... nothing. Am I doing something wrong ? Sorry, I should have replied earlier. The patch doesn't appear to fix anything, so it's unclear where you're going with it. It'd be better to send a more complete patch series. For example, +static

RE: TestBot messing up patches

2011-01-13 Thread Greg Geldorp
From: Andrew Nguyen On 01/11/2011 05:32 AM, Marvin wrote: === WINEBUILD (build) === Patch failed to apply Patch failed to apply Again, the bot seems to screw up patch application for some reason. Greg, could you take a look at the situation? Should be fixed now. Greg.

TestBot messing up patches

2011-01-12 Thread Greg Geldorp
From: Andrew Nguyen On 01/11/2011 05:32 AM, Marvin wrote: === WINEBUILD (build) === Patch failed to apply Patch failed to apply Again, the bot seems to screw up patch application for some reason. Greg, could you take a look at the situation? Yeah, sorry about that. It appears that

Translation patches for wine-1.2.2

2010-11-30 Thread Michael Stefaniuc
Hello Alexandre, attached is the list of translation patches for wine-1.2.2. This time I manually checked the changes to the En.rc files if they are indeed a wine-1.2 incompatible change. Thus there are some patches in the list that I missed for wine-1.2.1 with the automatic stop at first

Re: Translation patches for wine-1.2.1

2010-10-06 Thread Sven Baars
Michael Stefaniuc wrote: Hello Alexandre, attached is the list with the translation patches to cherry-pick for wine-1.2.1. The list was generated with the attached crud patch (modified from the version I used for 1.0.1) and then I have manually removed all my janitorial patches that didn't

Re: Translation patches for wine-1.2.1

2010-10-06 Thread Michael Stefaniuc
On 10/06/2010 10:29 PM, Sven Baars wrote: Michael Stefaniuc wrote: Hello Alexandre, attached is the list with the translation patches to cherry-pick for wine-1.2.1. The list was generated with the attached crud patch (modified from the version I used for 1.0.1) and then I have manually removed

Translation patches for wine-1.2.1

2010-10-03 Thread Michael Stefaniuc
Hello Alexandre, attached is the list with the translation patches to cherry-pick for wine-1.2.1. The list was generated with the attached crud patch (modified from the version I used for 1.0.1) and then I have manually removed all my janitorial patches that didn't produce conflicts. Though

[tools PATCH] patches: Mention Windows test failures as a cause for 'Test failure' status

2010-10-01 Thread Andrew Eikum
/2010 02:59 PM, Andrew Eikum wrote: These tests don't fail for me. What failures are you seeing? The testbot is complaining. Okay, I'll look into it. Thanks. diff --git a/patches/update b/patches/update index e18d32d..4b2532e 100755 --- a/patches/update +++ b/patches/update @@ -77,7 +77,8

Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Frédéric Delanoy
I've tried for some time to specify the wine-devel Reply-To using git-send-email, with little success so far Any idea how this might be done? Here's how my git config looks like: [sendemail] smtp server config from = user email to = wine-patches wine-patc...@winehq.org assume8bitEncoding = UTF-8

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread GOUJON Alexandre
://wiki.winehq.org/GitWine#head-4051a521ff163340844bba9c78036cd8c594a980 and according to my .git/config, I think you're missing [format] headers = To: wine-patches wine-patc...@winehq.org\nReply-To: wine-devel wine-devel@winehq.org\n

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Frédéric Delanoy
= false thread = false suppressfrom = true From http://wiki.winehq.org/GitWine#head-4051a521ff163340844bba9c78036cd8c594a980 and according to my .git/config, I think you're missing [format]        headers = To: wine-patches wine-patc...@winehq.org\nReply-To: wine-devel wine-devel@winehq.org\n

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Octavian Voicu
2010/8/21 GOUJON Alexandre ale.gou...@gmail.com: [format]        headers = To: wine-patches wine-patc...@winehq.org\nReply-To: wine-devel wine-devel@winehq.org\n As the name of the section suggests, this adds header lines to files generated with `git format-patch'. If you then send those files

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread GOUJON Alexandre
On 08/21/2010 03:35 PM, Frédéric Delanoy wrote: This is used for git imap-send, and does not work for git-send-email (I checked). Following the relevant git send-email section (http://wiki.winehq.org/GitWine#head-f09f3498e5910648468960a60ecf0f51b0fd4815 - Sending the patches using smtp), I set

Re: Specifying Reply-To header in patches email using git-send-email?

2010-08-21 Thread Frédéric Delanoy
2010/8/21 Octavian Voicu octavian.vo...@gmail.com: 2010/8/21 GOUJON Alexandre ale.gou...@gmail.com: [format]        headers = To: wine-patches wine-patc...@winehq.org\nReply-To: wine-devel wine-devel@winehq.org\n As the name of the section suggests, this adds header lines to files generated

Re: Sending patches for bug #22918

2010-07-17 Thread Misha Koshelev
On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote: Misha Koshelev wrote: Dear All: Congrats on 1.2! I have begun sending my patches from my repository: http://github.com/misha680/wine/commits/master Misha: Might I make a tiny suggestion: Send in one set of patches

Re: Sending patches for bug #22918

2010-07-17 Thread Frédéric Delanoy
On Sat, Jul 17, 2010 at 14:43, Misha Koshelev misha...@gmail.com wrote: On Fri, 2010-07-16 at 20:08 -0700, James McKenzie wrote: Misha Koshelev wrote: p.s. Do I remember correctly AJ does not commit on weekends? Exactly. 5 times a week should be sufficient ;)

  1   2   3   4   5   6   >