Re: widl: Do not generate C structure for empty interfaces. (try 2)

2013-07-02 Thread Jacek Caban
On 06/30/13 23:14, Thomas Faber wrote: > On 2013-06-27 13:33, Jacek Caban wrote: >> That >> said, if such interfaces are just obscure special case, I would say we >> shouldn't care. We may easily avoid them (I just sent a patch avoiding >> it in mshtml). > Ah, I hadn't even considered changing the

Re: widl: Do not generate C structure for empty interfaces. (try 2)

2013-06-30 Thread Thomas Faber
On 2013-06-27 13:33, Jacek Caban wrote: > That > said, if such interfaces are just obscure special case, I would say we > shouldn't care. We may easily avoid them (I just sent a patch avoiding > it in mshtml). Ah, I hadn't even considered changing the interface. Seemed like it was something mandat

Re: widl: Do not generate C structure for empty interfaces. (try 2)

2013-06-27 Thread Jacek Caban
Hi Thomas, I tested what midl does in this case and I think the solution should be different. When I tried to compile an empty interface, I got an error saying that '[object] interface must derive from another [object] interface'. That requirement is mostly enough to avoid empty vtbl. I was wonde

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Thomas Faber
On 2013-06-26 22:49, André Hentschel wrote: > On 26.06.2013 22:06, Thomas Faber wrote: >> On 2013-06-26 21:47, André Hentschel wrote: >>> The whitespace changes are bad, please don't do that. >> >> Ok, I can take them out no problem. >> Why's it bad though? I thought the rule was "fix it while you'

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Michael Stefaniuc
On 06/26/2013 10:06 PM, Thomas Faber wrote: > On 2013-06-26 21:47, André Hentschel wrote: >> The whitespace changes are bad, please don't do that. > > Ok, I can take them out no problem. > Why's it bad though? I thought the rule was "fix it while you're > working on it anyway". Sure, fix the lines

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread André Hentschel
On 26.06.2013 22:06, Thomas Faber wrote: > On 2013-06-26 21:47, André Hentschel wrote: >> The whitespace changes are bad, please don't do that. > > Ok, I can take them out no problem. > Why's it bad though? I thought the rule was "fix it while you're > working on it anyway". > Mostly because you

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread Thomas Faber
On 2013-06-26 21:47, André Hentschel wrote: > The whitespace changes are bad, please don't do that. Ok, I can take them out no problem. Why's it bad though? I thought the rule was "fix it while you're working on it anyway".

Re: widl: Do not generate C structure for empty interfaces.

2013-06-26 Thread André Hentschel
Hi, The whitespace changes are bad, please don't do that.