Re: wined3d: Check with "&& FALSE"

2008-03-18 Thread Paul Vriens
Stefan Dösinger wrote: > Am Montag, 17. März 2008 13:48:30 schrieb Paul Vriens: >> H. Verbeet wrote: >>> On 17/03/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: Is this line correct? Doesn't this alway return FALSE? >>> Looks like leftover debug code to me. > Yes, this is leftover debugging cod

Re: wined3d: Check with "&& FALSE"

2008-03-17 Thread Paul Vriens
Stefan Dösinger wrote: > Am Montag, 17. März 2008 13:48:30 schrieb Paul Vriens: >> H. Verbeet wrote: >>> On 17/03/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: Is this line correct? Doesn't this alway return FALSE? >>> Looks like leftover debug code to me. > Yes, this is leftover debugging cod

Re: wined3d: Check with "&& FALSE"

2008-03-17 Thread Stefan Dösinger
Am Montag, 17. März 2008 13:48:30 schrieb Paul Vriens: > H. Verbeet wrote: > > On 17/03/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: > >> Is this line correct? Doesn't this alway return FALSE? > > > > Looks like leftover debug code to me. Yes, this is leftover debugging code. Feel free to send a p

Re: wined3d: Check with "&& FALSE"

2008-03-17 Thread Paul Vriens
H. Verbeet wrote: > On 17/03/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: >> Hi, >> >> In the past we had some occurrences of comparisons with NULL flags. I had >> this >> check run again today and it came back with: >> >> ./dlls/wined3d/arb_program_shader.c:316: if(max_constantsF + >>

Re: wined3d: Check with "&& FALSE"

2008-03-17 Thread H. Verbeet
On 17/03/2008, Paul Vriens <[EMAIL PROTECTED]> wrote: > Hi, > > In the past we had some occurrences of comparisons with NULL flags. I had > this > check run again today and it came back with: > > ./dlls/wined3d/arb_program_shader.c:316: if(max_constantsF + > extra_constants_needed + 1

wined3d: Check with "&& FALSE"

2008-03-17 Thread Paul Vriens
Hi, In the past we had some occurrences of comparisons with NULL flags. I had this check run again today and it came back with: ./dlls/wined3d/arb_program_shader.c:316: if(max_constantsF + extra_constants_needed + 1 < GL_LIMITS(pshader_constantsF) && FALSE) { Is this line correct? Does