Re: wininet: let automated testers force all DNS lookups to return localhost

2008-11-03 Thread Detlef Riekenberg
On So, 2008-11-02 at 10:58 -0800, Dan Kegel wrote: This approach won't help users of the Wine conformance tests running on Windows, Sure it would; just make the test server setup script run on cygwin properly. require an installed cygwin is broken by design. winetest.exe is a standalone

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-11-03 Thread Dan Kegel
On Mon, Nov 3, 2008 at 1:50 PM, Detlef Riekenberg [EMAIL PROTECTED] wrote: This approach won't help users of the Wine conformance tests running on Windows, Sure it would; just make the test server setup script run on cygwin properly. require an installed cygwin is broken by design.

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-11-03 Thread Kai Blin
On Friday 31 October 2008 16:11:58 Hans Leidekker wrote: On Friday 31 October 2008 15:52:43 James Mckenzie wrote: What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. This would not work on Macs as /etc/hosts is locked to admins

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-11-02 Thread Rob Shearman
2008/10/31 Dan Kegel [EMAIL PROTECTED]: The public internet can (and does) go pear-shaped in the middle of test runs, which means any test that tries to access the public internet is de facto flaky, even if it tries to protect itself by skipping if the internet is down. So let's provide a

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-11-02 Thread Dan Kegel
Rob wrote: Later we should provide a script to set up a local test server that can handle all of our conformance tests' requests, but for now, just letting patchwatcher or winetest redirect everything to localhost will let tests fail reliably instead of randomly. This approach won't help

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Hans Leidekker
On Friday 31 October 2008 12:45:58 Dan Kegel wrote: The public internet can (and does) go pear-shaped in the middle of test runs, which means any test that tries to access the public internet is de facto flaky, even if it tries to protect itself by skipping if the internet is down. So

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker [EMAIL PROTECTED] wrote: What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. But the disadvantage that we need to know which servers the test code is going to look up. I guess I should

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Hans Leidekker
On Friday 31 October 2008 13:39:36 Dan Kegel wrote: On Fri, Oct 31, 2008 at 5:32 AM, Hans Leidekker [EMAIL PROTECTED] wrote: What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. But the disadvantage that we need to know which

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread James Mckenzie
Hans Leidekker [EMAIL PROTECTED] at Oct 31, 2008 5:32 AM wrote about Re: wininet: let automated testers force all DNS lookups to return localhost Only include this in debugging builds. What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Henri Verbeet
2008/10/31 James Mckenzie [EMAIL PROTECTED]: This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. I don't see how that's a problem, or how that's different from eg. Linux. More on-topic, I don't think it would be hard to do some LD_PRELOAD

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Hans Leidekker
On Friday 31 October 2008 15:52:43 James Mckenzie wrote: What happened to your /etc/hosts proposal? It has the advantage that we don't need changes to Wine source code. This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. That's true for

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 6:15 AM, Hans Leidekker [EMAIL PROTECTED] wrote: Yes, I think this could use a bit of standardization. Perhaps we could have a scheme like this: http.test.winehq.org ftp.test.winehq.org ldap.test.winehq.org pop3.test.winehq.org ... And mandate that networked

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 8:11 AM, Henri Verbeet [EMAIL PROTECTED] wrote: 2008/10/31 James Mckenzie [EMAIL PROTECTED]: This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. I don't see how that's a problem, or how that's different from eg.

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Henri Verbeet
2008/10/31 Dan Kegel [EMAIL PROTECTED]: How would we do this on Windows? (We need the winetest results to be reliable, too.) That was the main reason I didn't go for LD_PRELOAD... I guess we do some sort of DLL injection, but I haven't done it personally before. - Dan You could patch the

Re: wininet: let automated testers force all DNS lookups to return localhost

2008-10-31 Thread Dan Kegel
On Fri, Oct 31, 2008 at 8:51 AM, Henri Verbeet [EMAIL PROTECTED] wrote: 2008/10/31 Dan Kegel [EMAIL PROTECTED]: How would we do this on Windows? (We need the winetest results to be reliable, too.) That was the main reason I didn't go for LD_PRELOAD... I guess we do some sort of DLL