Re: ws2_32: ioctlsocket should try to check if argp is valid

Hi Jeff, I have a stylistic complaint about your tests in this patch: +if(sock == INVALID_SOCKET) +{ +ok(0, Creating the socket failed: %d, skipping test\n, WSAGetLastError()); +return; +} If you intend to skip a test, shouldn't you use skip instead? +ret =

Re: ws2_32: ioctlsocket should try to check if argp is valid

On Wed, Sep 10, 2008 at 2:57 AM, Juan Lang [EMAIL PROTECTED] wrote: Hi Jeff, I have a stylistic complaint about your tests in this patch: +if(sock == INVALID_SOCKET) +{ +ok(0, Creating the socket failed: %d, skipping test\n, WSAGetLastError()); +return; +} If

Re: ws2_32: ioctlsocket should try to check if argp is valid (try 2)

Hi Jeff, +if(sock == INVALID_SOCKET) +skip(Creating the socket failed: %d, skipping test.\n, WSAGetLastError()); skip needs a return too. +ret = ioctlsocket(sock, cmds[i], (u_long *)1); +if(ok(ret == SOCKET_ERROR, ioctlsocket succeeded unexpectedly\n)) +{ I

Re: ws2_32: ioctlsocket should try to check if argp is valid (try 2)

On Wed, Sep 10, 2008 at 4:55 AM, Juan Lang [EMAIL PROTECTED] wrote: Hi Jeff, +if(sock == INVALID_SOCKET) +skip(Creating the socket failed: %d, skipping test.\n, WSAGetLastError()); skip needs a return too. +ret = ioctlsocket(sock, cmds[i], (u_long *)1); +