Re: [Wireshark-dev] [Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions.

2014-12-19 Thread Guy Harris
On Dec 19, 2014, at 7:51 PM, Stephen Fisher wrote: > ui/libui.a(libui_a-time_shift.o): In function `time_string_to_nstime': > /usr/local/src/wireshark/ui/time_shift.c:260: undefined reference to > `floorl' Is it compiling wsutil/floorl.c? Is it linking with -lm? Does the configure script thi

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-19 Thread Bill Meier
On 12/19/2014 4:19 PM, Bill Meier wrote: On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote: Change subject: Remove unneeded #includes from epan/dissectors .. Remove unneeded #includes from epan/dissectors Martin:

Re: [Wireshark-dev] [Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions.

2014-12-19 Thread Guy Harris
On Dec 19, 2014, at 7:08 PM, Stephen Fisher wrote: > Thanks for correcting this. I see now that there are other functions > defined the way you re-defined floorl(). The example I randomly picked > to follow was wsutil/tempfile.[ch], which is done with just > AC_CHECK_FUNCS() and #ifndef HAV

Re: [Wireshark-dev] [Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions.

2014-12-19 Thread Stephen Fisher
My build, on a system without floorl(), is now failing here (I'm building --with-gtk2 and --without-qt currently): gmake[2]: Entering directory '/usr/local/src/wireshark' CCLD wireshark-gtk ui/libui.a(libui_a-time_shift.o): In function `time_string_to_nstime': /usr/local/src/wireshark/ui/t

Re: [Wireshark-dev] [Wireshark-commits] master b736896: Handle floorl() the same way we handle other not-on-all-platforms functions.

2014-12-19 Thread Stephen Fisher
Thanks for correcting this. I see now that there are other functions defined the way you re-defined floorl(). The example I randomly picked to follow was wsutil/tempfile.[ch], which is done with just AC_CHECK_FUNCS() and #ifndef HAVE_MKSTEMP. Does that need to be corrected too then? On Sat,

Re: [Wireshark-dev] Feedback about Multipath TCP support

2014-12-19 Thread Guy Harris
On Dec 19, 2014, at 4:24 PM, Matt wrote: > I believe wireshark may need to implement some data structures/GUIs > helping with upcoming multipath protocols such as TRILL, SCTP, LISP, > MPTCP... This is not new. For example, there's a certain protocol developed back in the mid 1980's in which "

[Wireshark-dev] Feedback about Multipath TCP support

2014-12-19 Thread Matt
Hi, Upstream wireshark can display Multipath TCP (MPTCP) options. I work on MPTCP for my studies and I have improved MPTCP support in my wireshark branch in various ways. I am looking for some feedback on the overall direction to follow for converting this *prototype* code (relatively untested yet

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-19 Thread Martin Mathieson
This makes good sense to me, Bill. I was having too much fun with my python script to look carefully look at the bigger picture. I didn't realise how many header files already pulls in. In particular, it indirectly includes glib.h (through column-utils.h), so we should remove #include from pack

Re: [Wireshark-dev] Change in wireshark[master]: [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in co...

2014-12-19 Thread Alexis La Goutte
On Fri, Dec 19, 2014 at 9:14 PM, Pascal Quantin wrote: > 2014-12-19 21:03 GMT+01:00 Bill Meier : >> >> On 12/18/2014 4:19 PM, Alexis La Goutte (Code Review) wrote: >> >>> >>> [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in commit log >>> >>> It will be reused form generate AUTHORS file

Re: [Wireshark-dev] Change in wireshark[master]: Remove unneeded #includes from epan/dissectors

2014-12-19 Thread Bill Meier
On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote: Change subject: Remove unneeded #includes from epan/dissectors .. Remove unneeded #includes from epan/dissectors Martin: Obviously, #includes usage in dissectors

Re: [Wireshark-dev] Change in wireshark[master]: [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in co...

2014-12-19 Thread Pascal Quantin
2014-12-19 21:03 GMT+01:00 Bill Meier : > > On 12/18/2014 4:19 PM, Alexis La Goutte (Code Review) wrote: > >> >> [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in commit log >> >> It will be reused form generate AUTHORS file >> >> > If the AUTHORS file is to be autogenerated: > > I vaguely

Re: [Wireshark-dev] Change in wireshark[master]: [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in co...

2014-12-19 Thread Bill Meier
On 12/18/2014 4:19 PM, Alexis La Goutte (Code Review) wrote: [WIP] Add .mailmap: fix duplicate/wrong e-mail or name in commit log It will be reused form generate AUTHORS file If the AUTHORS file is to be autogenerated: I vaguely remember that there may have been cases where someone explici

Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig version 0.28 so we can use th...

2014-12-19 Thread Stephen Fisher
On Fri, Dec 19, 2014 at 09:05:17AM +, Anders Broman wrote: > -Original Message- > From: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Stephen Fisher > Sent: den 19 december 2014 00:45 > To: wireshark-dev@wireshark.org > Subject: Re: [W

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Peter Wu
On Friday 19 December 2014 17:07:20 Dario Lombardo wrote: > On Fri, Dec 19, 2014 at 12:35 PM, Peter Wu wrote: > > > The Capture -> Options > > dialog is another place where these stats are visible. > > > > Is it visible during capture? No, it is not visible during capture. The options menu item

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Dario Lombardo
On Fri, Dec 19, 2014 at 12:35 PM, Peter Wu wrote: > The Capture -> Options > dialog is another place where these stats are visible. > Is it visible during capture? ___ Sent via:Wireshark-dev mailing list Archives:ht

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Peter Wu
On Friday 19 December 2014 11:55:47 Dario Lombardo wrote: > On Fri, Dec 19, 2014 at 11:44 AM, Peter Wu wrote: > > Nope, it won't work at the moment. The problem is that NFLOG can only be > > opened by one user which is a kernel limitation. From > > net/netfilter/nfnetlink_log.c: > > > > i

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Dario Lombardo
On Fri, Dec 19, 2014 at 11:44 AM, Peter Wu wrote: > > > If I need to perform a capture, i just overwrite dumpcap with: > ln -sfv /usr/bin/dumpcap /tmp/wsbuild/run/ > > It looks like you also avoid overwriting this file/symlink by disabling > dumpcap building: > > cmake -DBUILD_dumpcap=0 ... >

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Peter Wu
On Friday 19 December 2014 11:08:01 Dario Lombardo wrote: > On Thu, Dec 18, 2014 at 4:29 PM, Peter Wu wrote: > > > > > > You should not run Wireshark with sudo, instead set the appropriate > > privileges on the dumpcap binary as described at > > http://wiki.wireshark.org/CaptureSetup/CapturePrivil

Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig version 0.28 so we can use th...

2014-12-19 Thread Alexis La Goutte
On Fri, Dec 19, 2014 at 10:05 AM, Anders Broman wrote: > > > > -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto: > wireshark-dev-boun...@wireshark.org] On Behalf Of Stephen Fisher > Sent: den 19 december 2014 00:45 > To: wireshark-dev@wireshark.org > Subject: Re: [Wir

Re: [Wireshark-dev] nflog in qt and gtk

2014-12-19 Thread Dario Lombardo
On Thu, Dec 18, 2014 at 4:29 PM, Peter Wu wrote: > > > You should not run Wireshark with sudo, instead set the appropriate > privileges on the dumpcap binary as described at > http://wiki.wireshark.org/CaptureSetup/CapturePrivileges > > Generally speaking, you are right, and it's waht I do with my

Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig version 0.28 so we can use th...

2014-12-19 Thread Anders Broman
-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Stephen Fisher Sent: den 19 december 2014 00:45 To: wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] Change in wireshark[master]: Bring pkg.m4 in from pkgconfig