Re: [Wireshark-dev] Some planned cleanups of the 802.11 dissector

2016-06-26 Thread Simon Barber
great idea. I'll wait for your changes before adding a feature - I'd like to be able to filter out beacons by writing wlan.beacon, probes by wlan.probe_request, etc. Simon On Sun, Jun 26, 2016 at 3:07 PM, Joerg Mayer wrote: > Hello, > > I plan to do some cleanups to > -

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-06-26 Thread Guy Harris
On Jun 26, 2016, at 6:16 PM, Jim Young wrote: > Time for a Petri Dish for OS X? I'd say "time for a Petri dish that tests with several optional packages enabled and disabled, including libpcap and GeoIP", GeoIP being the issue here (builds without warnings with GeoIP, gets

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-06-26 Thread Jim Young
>> Buildslave for this Build: osx-10.6-x64 >> >> Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered >> this build >> Build Source Stamp: [branch master] b84637b4f6a1f3f910b97c21264ff6132a9c19c4 >> Blamelist: Jörg Mayer >> >> BUILD FAILED: failed

Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64

2016-06-26 Thread Joerg Mayer
On Sun, Jun 26, 2016 at 05:30:56PM +, buildbot-no-re...@wireshark.org wrote: > The Buildbot has detected a new failure on builder OSX 10.6 x64 while > building wireshark. Full details are available at: > >

[Wireshark-dev] Some planned cleanups of the 802.11 dissector

2016-06-26 Thread Joerg Mayer
Hello, I plan to do some cleanups to - somewhat improve the readability of the code 1) Get rid of reduntant author entries and code comments, see https://code.wireshark.org/review/16154 2) Get rid of those fixed field functions that only add one of two items. Call the remaining