Re: [Wireshark-dev] Do Lua Postdissectors still work with the most recent versions of Wireshark

2020-10-16 Thread chuck c
I'm not a Mac person (yet) so best I can offer is to try and if it breaks open an Gitlab issue or Ask question. On Fri, Oct 16, 2020 at 7:22 PM Richard Sharpe wrote: > On Fri, Oct 16, 2020 at 5:08 PM chuck c wrote: > > > > This was a Friday project a couple weeks ago: > > https://gitlab.com/wir

Re: [Wireshark-dev] Do Lua Postdissectors still work with the most recent versions of Wireshark

2020-10-16 Thread Richard Sharpe
On Fri, Oct 16, 2020 at 5:08 PM chuck c wrote: > > This was a Friday project a couple weeks ago: > https://gitlab.com/wireshark/wireshark/-/wikis/Lua/Examples/filtcols Great. Thanks. Maybe I can use this approach to do what I want. Are there any problems with Lua and Wireshark on Mac OS X? --

Re: [Wireshark-dev] Do Lua Postdissectors still work with the most recent versions of Wireshark

2020-10-16 Thread chuck c
This was a Friday project a couple weeks ago: https://gitlab.com/wireshark/wireshark/-/wikis/Lua/Examples/filtcols On Fri, Oct 16, 2020 at 5:34 PM Richard Sharpe wrote: > Hi folks, > > I was looking around for a quick way to add some stuff to an existing > protocol that we have extended in one w

Re: [Wireshark-dev] [Outreachy] Introduction

2020-10-16 Thread Jonathan Nieder
Hi Joey, Joey S wrote: > Hi everyone, > > I'm Joey Salazar, an Outreachy 2020 applicant certified in CCNA and > Linux+, with some experience in C for both private and open source > repositories (BIND at gitlab.isc.org/Joey), community code reviews, > and automated tests in bash. I'd like to contr

[Wireshark-dev] Possible regression in Version 3.3.1 (v3.3.1-0-gd64aca7966e2)

2020-10-16 Thread Richard Sharpe
Hi folks, I got a report from a coworker that 'Apply as column' was not working correctly. I showed the person how to right-click on a field in the details pane and then select Apply as column. However, what happened in their case was they got a column with no values in it. When we went to Edit

[Wireshark-dev] Do Lua Postdissectors still work with the most recent versions of Wireshark

2020-10-16 Thread Richard Sharpe
Hi folks, I was looking around for a quick way to add some stuff to an existing protocol that we have extended in one way, and thought Lua might help. I found Lua postdissectors and it looks like they will help me do what I want. Are they still supported as of Wireshark 3.2.x? -- Regards, Rich

Re: [Wireshark-dev] proto_tree_add_item() calls where length doesn't match type of hf item

2020-10-16 Thread Guy Harris
On Oct 16, 2020, at 2:54 PM, Martin Mathieson wrote: > There might be some protocols where there was (say) a 7 byte integer field, > so the dissector writer had to round it up to the nearest supported size, but > again I didn't see that. That's because the nearest supported size is FT_{U}INT5

Re: [Wireshark-dev] proto_tree_add_item() calls where length doesn't match type of hf item

2020-10-16 Thread Martin Mathieson via Wireshark-dev
Yes, I thought I might see some cases where the field was longer than most usages, because at least 1 usage required the full size, but in my limited checking didn't see this. This probably wouldn't be too hard to track in the script (the checker works on one file at a time), but I'd probably want

Re: [Wireshark-dev] proto_tree_add_item() calls where length doesn't match type of hf item

2020-10-16 Thread Guy Harris
On Oct 16, 2020, at 2:38 PM, Martin Mathieson via Wireshark-dev wrote: > I made a quick change to have tools/check_typed_proto_items.py to check calls > to proto_tree_add_item() - in particular if the length field in the call > matches the length implied by the FT_ type. The fewI've looked at

[Wireshark-dev] [Outreachy] Introduction

2020-10-16 Thread Joey via Wireshark-dev
Hi everyone, I'm Joey Salazar, an Outreachy 2020 applicant certified in CCNA and Linux+, with some experience in C for both private and open source repositories (BIND at https://gitlab.isc.org/Joey), community code reviews, and automated tests in bash. I'd like to contribute to the "Add Git prot

Re: [Wireshark-dev] lua decoder accessing info from layers above

2020-10-16 Thread Graham Bloice
On Fri, 16 Oct 2020 at 03:36, Fulko Hew wrote: > > > On Mon, Oct 12, 2020 at 8:34 PM John Thacker > wrote: > >> >> On Mon, Oct 12, 2020, 8:00 PM Fulko Hew wrote: >> >>> >>> I'm trying to update/improve someone else's decoder written in Lua. >>> It's for a simple UDP (and TCP) based protocol. >>