Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Guy Harris
On Apr 13, 2021, at 5:36 PM, Vincent Randal wrote: > If it’s important not to break wireshark-2.6.20 It's not. All I'm saying there is that there are different levels of support: for Windows and macOS, we do CI builds, so we know Wireshark builds and runs, and supply binaries;

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
Guy, I want keep my promise to update the Wireshark documentation for the simple ASN.1 UDP-based dissector example so that it more accurately reflects the current build method that starts with cmake. I will do a better job now with input and help I’ve received. If it’s important not to break

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Guy Harris
On Apr 13, 2021, at 9:21 AM, Pascal Quantin wrote: > 13 avr. 2021 17:36:20 John Thacker : > > > Depending on your build system, the other ASN.1 dissectors can be > > regenerated with either > > > > ninja asn1 > > Or > > make asn1 > > > > without starting the full build process. > >

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Guy Harris
On Apr 13, 2021, at 6:03 AM, Vincent Randal wrote: > I'm building Wireshark on Linux. Wireshark documentation refers to it as UNIX > or UNIX-like. Linux is one of the UNIX-like systems we support, yes. We also officially support macOS, and the build process may also work on FreeBSD, NetBSD,

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
With everyone's help I have successfully built the simple ASN.1 UDP-based dissector in Linux (Ubuntu 18.04). And it is available in my Wireshark build for use in the display filter as shown in the screenshot below. I made my changes against wireshark-3.4.4, but I did not use

Re: [Wireshark-dev] Hitting a weird error in a MR pipeline

2021-04-13 Thread Pascal Quantin
Le mar. 13 avr. 2021 à 18:49, Pascal Quantin a écrit : > This is because of > https://gitlab.com/wireshark/wireshark/-/merge_requests/2689 > that was merged despite a Windows failure. need to fix it. > Fix attempt here, to be reviewed by Jirka:

Re: [Wireshark-dev] Hitting a weird error in a MR pipeline

2021-04-13 Thread Pascal Quantin
This is because of https://gitlab.com/wireshark/wireshark/-/merge_requests/2689 that was merged despite a Windows failure. need to fix it. Pascal. 13 avr. 2021 18:42:29 Richard Sharpe : > Hi folks, > > In my latest MR pipeline: > https://gitlab.com/wireshark/wireshark/-/pipelines/285790755 >

[Wireshark-dev] Hitting a weird error in a MR pipeline

2021-04-13 Thread Richard Sharpe
Hi folks, In my latest MR pipeline: https://gitlab.com/wireshark/wireshark/-/pipelines/285790755 I see these errors in the Windows build portion: --- C:\builds\wireshark\wireshark\ui\qt\rtp_player_dialog.cpp(671,22): error C2220: the following warning is treated as an error

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Graham Bloice
Keyboard and brain got a little misconnected there. The first 2 sentences of item 3, which are missing some things I meant to fill in, can be replaced with the text from item 5. On Tue, 13 Apr 2021 at 16:45, Graham Bloice wrote: > Just to reset what I think are some misconceptions here: > > >

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Pascal Quantin
13 avr. 2021 17:36:20 John Thacker : > Depending on your build system, the other ASN.1 dissectors can be regenerated > with either > > ninja asn1 >   Or > make asn1 > > without starting the full build process. Those commands will regenerate all the ASN.1 dissectors. The command I gave allows

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Graham Bloice
Just to reset what I think are some misconceptions here: 1. CMake, despite having the verb "Make" in its name, doesn't make the application. CMake makes something (depends on the platform, i.e. a Makefile or ninja build file or Visual Studio solution\project files) that then allows

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread John Thacker
Depending on your build system, the other ASN.1 dissectors can be regenerated with either ninja asn1 Or make asn1 without starting the full build process. I do it all the time, last did it a week ago when developing on Linux and just did it two minutes ago before writing this email to check

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
Before or After running cmake (in Linux) there are no files containing "generate_dissector" in the filename in asn1/foo. And they do not exist anywhere in the source tree. How did the other asn1 dissectors get generated in Linux? When was the last time anyone generated or updated a dissector in

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Pascal Quantin
Hi Vicent, Le mar. 13 avr. 2021 à 16:53, Vincent Randal a écrit : > I should give that a try. What version of Windows and tools are you using? > I’m beat. I need to do something that works soon. > No need to install Windows; it works the same way on Linux. Go to your build folder and run:

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
I should give that a try. What version of Windows and tools are you using? I’m beat. I need to do something that works soon. On Tue, Apr 13, 2021 at 8:47 AM Anders Broman via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > Hi, > > I don’t think they are generated what will be generated are

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Anders Broman via Wireshark-dev
Hi, I don’t think they are generated what will be generated are the files needed to DO the generation. On windows the next step is to run msbuild /m /p:Configuration=RelWithDebInfo epan\dissectors\asn1\h248\generate_dissector-h248.vcxproj which will the generate the .c and .h files Regards

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
Correct insofar as there are no generated files associated with asn1/foo directory. Namely, packet-foo.c and packet-foo.h did not get generated. But maybe that's not definitive proof that asn1/foo dissector did not get built. How else can I confirm the dissector was or was not built? Open

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Anders Broman via Wireshark-dev
Hi, So you are saying that if you create foo dir like epan/dissectors/asn1/foo/ Rename and update the custom cmake file to set(CUSTOM_ASN1_SRC_DIR foo ) And place your source file and cmake.txt in the foo dir then rerun the cmake process Nothing happens? Try to

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
I tried renaming ./epan/dissectors/asn1/CMakeListsCustom.txt.example to CMakeListsCustom.txt with an entry as follows: # Add a list of your custom asn1 dissectors here set(CUSTOM_ASN1_SRC_DIR foo ) Again, the build did not update any targets even with that change. But this is progress because

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread John Thacker
On Tue, Apr 13, 2021, 8:32 AM Vincent Randal wrote: > Hello everyone, > > I need help building the simple ASN.1 UDP-based dissector example (foo); > specifically, I need help building the generate_dissector-*proto* target > (Step #6 below). I'm certainly missing something here. > > > (c) I

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
I'm building Wireshark on Linux. Wireshark documentation refers to it as UNIX or UNIX-like. At the moment I'm using Ubuntu 18.04 LTS to build wireshark-3.4.4 On Tue, Apr 13, 2021 at 6:38 AM Anders Broman via Wireshark-dev < wireshark-dev@wireshark.org> wrote: > Hi, > > On what OS are you doing

Re: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Anders Broman via Wireshark-dev
Hi, On what OS are you doing this? Regards Anders From: Wireshark-dev On Behalf Of Vincent Randal Sent: den 13 april 2021 14:32 To: Developer support list for Wireshark Subject: [Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo) Hello everyone, I

[Wireshark-dev] How to build the simple ASN.1 UDP-based dissector example (foo)

2021-04-13 Thread Vincent Randal
Hello everyone, I need help building the simple ASN.1 UDP-based dissector example (foo); specifically, I need help building the generate_dissector-*proto* target (Step #6 below). I'm certainly missing something here. I'm following the Step by Step instructions (shown below) to create the simple

Re: [Wireshark-dev] ASN.1 dissector Wireshark

2021-04-13 Thread Vincent Randal
Thank you. As for the second part I will post as a new separate question in the morning. On Mon, Apr 12, 2021 at 11:43 PM Guy Harris wrote: > On Apr 12, 2021, at 10:08 PM, Vincent Randal wrote: > > > Thank you (John) for delving into a nice description of the overall > process. I do have a