Re: [Wireshark-dev] Removal of reedsolomon code

2014-02-11 Thread Didier
to be in linux kernel and I doubt it's GPL1, moreover he has LGPL code at http://www.ka9q.net/ Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] speed optimizations

2013-11-01 Thread Didier
subdissectors or only call them via wireshark API If this is similar to a previous patch it requres changes to many dissectors. They was a lot of thing in this patch :) Regards Didier ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] multiple parsing of the same packets

2013-11-01 Thread Didier
scratch. Every time we do a dissection it is more-or-less from scratch. The This kind of massive DRS is spread on ~300 1500 bytes TCP packets. That's not a big packet :) Didier ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] speed optimizations

2013-10-31 Thread Didier
with no 'interesting fields'. I'm not sure this one is worth it without the AOT transform which convert a dissector to a bunch of get_tvb..., offset += .., new_tvb_subset ..., call_dissector(next_dissector) Regards Didier ___ Sent via

Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-18 Thread didier
Hi, Le lundi 14 octobre 2013 à 10:41 +0200, Pascal Quantin a écrit : Hi Didier, this is fixed in r52597. If you spotted other regressions, please notify us. thanks, a bit slow though, it's look like check_col() had its use after all :) Regards Didier Thanks

Re: [Wireshark-dev] r52604: Adding to col info is probably useless as next dissector will overwrite it.

2013-10-17 Thread didier
col_add_fstr() like ethertype do. There's a corner case: if a sub dissector throw an exception before clearing colinfo but it should be rare. Have to change dissect_802_03 a little though, it must use dissector_only() and call proto_data itself rather than calling dissector() Comments? Didier

Re: [Wireshark-dev] [Wireshark-commits] rev 52578: /trunk/epan/ /trunk/epan/: proto.c tvbuff.c tvbuff.h

2013-10-13 Thread didier
it? There's so many bugs, Personally I gave up on it. One example with tshark, without a tree tcp flags aren't set anymore in colinfo (cf packet-tcp.c around line 4228, since dfa2156e301539929a12dda54752c778c3ee7a39 remove 'check_colinfo') and so on... Didier

Re: [Wireshark-dev] Idea for faster dissection on second pas

2013-10-11 Thread didier
for packets without leaf dissectors. I think I also extended conversation semantic for not calling heuristic_try in most cases. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] Automatic test for a dissector DLL

2010-12-13 Thread didier
that only my dissector's output is reported. How can I limit the output to one protocol level. As an example the TCP level would be great (without IP, Ethernet, Frame)? tshark -T pdml -r file.pcap and filter the xml output ? Didier

Re: [Wireshark-dev] non-ASCII stuff in manuf

2010-11-10 Thread didier
It will be automatically run on Sunday... On the other hand after all this hard work it'd be nice to fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4102 g_strlcpy doesn't work with UTF8 and these 'Pango-WARNING **: Invalid UTF-8 string passed to pango...' are a pain. Didier

Re: [Wireshark-dev] Changing dissector based on TCP options

2010-08-31 Thread didier
? ); conversation = find_conversation(pinfo-fd-num, pinfo-src, pinfo-dst, pinfo-ipproto, I think pinfo-ipproto isn't the right value, can you try with pinfo-ptype? Didier ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Lua Tvb and escape caracter

2010-03-29 Thread didier
something like: local msgbufferarray = buffer(ofs, plen):bytes() local temparray=ByteArray.new() temparray.append(msgbufferarray:subset(0,plen)) But get the following error: Lua Error: [string /tmp/eris.lua]:307: bad argument #2 to 'append' (userdata expected, got no value) Thanks Didier

Re: [Wireshark-dev] emem.c:732: failed assertion [sort-of-SOLVED]

2010-03-01 Thread didier
here, data is copied in g_byte_array_append. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman

Re: [Wireshark-dev] Dissecting a portion of a protocol owned by anotherdissector

2010-02-23 Thread didier
Hi, Le mardi 23 février 2010 à 14:50 -0500, Jeremy O'Brien a écrit : Hmm... I was trying to avoid touching any existing dissectors to allow my plugin to be as modular as possible. There's no other (easy) way? a lua script? Didier

Re: [Wireshark-dev] [Wireshark-commits] rev 31774: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-clnp.c packet-p_mul.c packet-tcp.c packet-x25.c

2010-02-03 Thread didier
be helpful when a PDU isn't fully reassembled. It's an issue when a heuristic dissector wrongly grab a conversation, often it finds a big PDU length and there's no easy way to know which dissector is the culprit. Didier ___ Sent

Re: [Wireshark-dev] Wireshark won't compile on PPC64 boxes

2010-01-27 Thread didier
, rrc.midambleAllocationMode, ... Is it possible to compress it to the pseudo code: const foo = rrc.midambleAllocationMode { foo +4, foo, ? It should be faster on all platforms. Don't know if it's enough. Didier

Re: [Wireshark-dev] Wireshark won't compile on PPC64 boxes

2010-01-27 Thread didier
Hi, Le mercredi 27 janvier 2010 à 14:56 +0100, Radek Vokál a écrit : On 01/27/2010 09:32 AM, didier wrote: Hi, Le mercredi 27 janvier 2010 à 00:54 -0700, Stephen Fisher a écrit : On Tue, Jan 26, 2010 at 06:40:38PM +0100, Radek Vokál wrote: The wireshark package cannot be build on ppc64

Re: [Wireshark-dev] Wireshark won't compile on PPC64 boxes

2010-01-27 Thread didier
a full powerpc 64bits setup thus I can only compile not link 64 bits code. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] pinfo-fd-flags.visited and NFS

2010-01-13 Thread didier
' and reloading the file with CTRL R. in packet-nfs.c a lot of: if (fitem) looks suspicious to me as a null tree == proto_tree_add_xxx return null Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] pinfo-fd-flags.visited and NFS

2010-01-13 Thread didier
Hi, Le jeudi 14 janvier 2010 à 17:37 +1100, Ian Schorr a écrit : Hi Didier, On Thu, Jan 14, 2010 at 4:54 PM, didier dgauthe...@magic.fr wrote: Hi, The whole file is first dissected sequentially with pinfo-fd-flags.visited set to FALSE. The most common error for what you're seeing

Re: [Wireshark-dev] Need advice on modifying tvb

2009-11-24 Thread didier
create a new tvb. Did you add a new data source? It might work but it won't be pretty. Somehow have to change that checksum of the frame that I am forwarding to the builtin dissector. Another option would be to add a new preference to the standard dissector: disable checksum. Didier

Re: [Wireshark-dev] Optimization - accumulative filters?

2009-11-17 Thread didier
unknown 2 Only have to decode packet if S == 2 Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] Diet Libwireshark

2009-11-02 Thread didier
would like it to only be a few MB if at all possible) I would remove them from Makefile.common rather than Makefile.in and rerun autogen.sh, Makefile.in is a generated file, it's possible that your change has been overwritten. Didier

Re: [Wireshark-dev] problem in adding message in wireshark tree

2009-10-29 Thread didier
, is not the case with 1.3. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Wireshark memory handling

2009-10-11 Thread didier
Hi, Le vendredi 09 octobre 2009 à 09:15 +0200, Erlend Hamberg a écrit : On Friday 9. October 2009 03.47.16 didier wrote: A modified Tshark should be able to upload a capture at around 30,000 packets/second. Very interesting. By uploading, I presume you mean to the database? Yes I do

Re: [Wireshark-dev] Wireshark memory handling

2009-10-11 Thread didier
. One could imagine having different allocators (like ep_ and se_ today) that use malloc friends (for core stuff) or go to the mmap'd pool (for packet data, etc.). A better layout between write once and read/write data may help a lot too. It will obfuscate the code though. Didier

Re: [Wireshark-dev] New packet list - out of memory?

2009-10-08 Thread didier
) pad = emem_canary_pad(size); else - pad = 8; + pad = ((8 - (size 0x7)) 0x7); size += pad; Didier ___ Sent via:Wireshark

Re: [Wireshark-dev] New packet list - out of memory?

2009-10-08 Thread didier
Hi, Le jeudi 08 octobre 2009 à 09:58 -0400, Jeff Morriss a écrit : didier wrote: But are canaries used at all? In my understanding without DEBUG_INTENSE_CANARY_CHECKS they are never checked and it's unset by default. Erm, emem_free_all() checks that the canaries haven't been corrupted

Re: [Wireshark-dev] New packet list - out of memory?

2009-10-08 Thread didier
Hi, Le mercredi 07 octobre 2009 à 13:59 +0200, Anders Broman a écrit : Didier More or less vanilla Wireshark, no colors. Enclosed proto Hierarchy. I can't share this file unfortunatly. The reason why I chose it is just that it caused 'Out of memmory' with the new packet list. Thanks, Are you

Re: [Wireshark-dev] Wireshark memory handling

2009-10-08 Thread didier
on such big data set would be useful though, at some point more data is just noise. Note: A simple expression is a filter expression with only protocols or previous expressions. ex: llc !arp is a simple expression tcp.stream == 0 is not but after that afp !(tcp.stream == 0) is one. Didier

Re: [Wireshark-dev] New packet list - out of memory?

2009-10-06 Thread didier
? Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] New packet list - out of memory?

2009-10-06 Thread didier
) and we are allocating a lot of them so yes using g_slice_new or g_malloc here make sense. Using a g_string_chunk for frame data col_text too but it's not a problem here loading a file doesn't initialize a lot of them. Didier Should we have a new allocator without the canaries

Re: [Wireshark-dev] Modifying the Decode of Previous Packets

2009-09-28 Thread didier
numbers to re-parse. Currently it's not possible. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman

Re: [Wireshark-dev] [Wireshark-commits] rev 29427: /trunk/ /trunk/epan/dissectors/: packet-bthci_acl.c packet-btl2cap.c packet-btrfcomm.c /trunk/epan/: packet.c packet.h reassemble.c reassemble_test.c

2009-09-27 Thread didier
be other places where it's used as well. Hum, does it means that all dissectors using if (tree) {...; call_dissector(data_handle,...) } Have to be modified? Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] RTCP Heuristic decoder

2009-09-11 Thread didier
you're initialisation code is executed? If yes run it under a debuger, put a breakpoint in the RTCP dissector, a backtrace will show you the culprit. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] New packet list

2009-09-02 Thread didier
doesn't work. But it doesn't seem to dump core or leak. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] New packet list

2009-09-02 Thread didier
Hi, Le mercredi 02 septembre 2009 à 20:01 +0200, Anders Broman a écrit : Coould you try revision 29673 to see if packets without color are randomly colorized Are fixed ? Yes it works for me now. Regards Didier ___ Sent

Re: [Wireshark-dev] Using treads for init routines at startup?

2009-09-01 Thread didier
Hi, Le mardi 01 septembre 2009 à 11:11 +0200, Anders Broman a écrit : Hi, Could startup of Wireshark be speeded up by using treads for the init routines in epan_init()? Is Wireshark startup really CPU bound? Didier

Re: [Wireshark-dev] dissector bug

2009-08-31 Thread didier
, with add_item it's only valid for type proto, strings, byte and none. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] behavior of tcp_dissect_pdus when protocol pdu is across tcp segments

2009-08-25 Thread didier
). Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Custom dissector causing wireshark to crash

2009-08-25 Thread didier
for message in dBm, 0x0, NULL, HFILL } }, Should be { hf_abc_txPower, { txPower, abc.txPower, FT_UINT8, BASE_DEC, NULL,0x0, Transmit power for message in dBm, , HFILL } }, Didier

Re: [Wireshark-dev] expert_comp_table.c uses g_string_chunk_clear (introduced in glib 2.14)

2009-08-23 Thread didier
Hi, Le jeudi 20 août 2009 à 21:53 +0100, Martin Mathieson a écrit : expert_comp_table.c uses g_string_chunk_clear Can you try patches in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3929 Didier ___ Sent via

Re: [Wireshark-dev] buildbot failure in Wireshark (development) on Solaris-10-SPARC

2009-08-19 Thread didier
not something we can enforce. Maybe it should use a string_chunk too. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

[Wireshark-dev] svn r29431 doesn't look right to me.

2009-08-16 Thread didier
like? - FT_UINT8, 16, NULL, 0x0, NULL, 0x000F, 0, 0, NULL, NULL } + FT_UINT8, 16, NULL, 0x0F, NULL, HFILL } Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] custom decryption function

2009-08-05 Thread didier
for try_decrypt_wep and add_new_data_source Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options

Re: [Wireshark-dev] Need to if a packet is dissected for the first time

2009-07-21 Thread didier
actions when a packet is captured (or in other words: the first time it appears in the packet pane). pinfo-fd-flags.visited is false the first time a packet is dissected. Didier ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-13 Thread didier
core). The drawback of course is the disk usage but it shouldn't matter for small files and for big file wireshark is slow and next to unusable. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org

Re: [Wireshark-dev] New packet list: Optimize memory usage

2009-07-13 Thread didier
(doesn't load in svn Wireshark): 557 MB 1.4M packets virt res 470MB 420MB after sorting 600MB 518MB Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] New experimental feature: GTK2 based packet list(svn rev 28892)

2009-07-06 Thread didier
New packet list with patch ~11s, old WS (SVN Rev 27374) ~16s Are you sure it's not because you've disabled coloring? Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] [Wireshark-bugs] [Bug 3611] New: Buildbot crash output: fuzz-2009-06-26-23834.pcap

2009-06-27 Thread didier
tshark: packet 55581, null col info in print_packet() in packet-hip.c: col_set_str(pinfo-cinfo, COL_INFO, match_strval(hiph_packet_type, pinfo_vals)); Can set col info to NULL. Didier ___ Sent via:Wireshark-dev mailing

Re: [Wireshark-dev] Enhancement to Flow graph in Wireshark

2009-06-11 Thread didier
Hi, Le jeudi 11 juin 2009 à 16:24 +0530, BANDARU, Govindarao (Govindarao) a écrit : Didier, Thanks a lot for quick response. I will give a try now. Where I can see text output of flow graph? Please let me know. Huh? Are we speaking about the same thing? Here both in 1.0 and HEAD

Re: [Wireshark-dev] Enhancement to Flow graph in Wireshark

2009-06-09 Thread didier
is, can we save flow in a readable format (could be in pdf format)? There's a text output, no idea if it's readable though :) Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http

Re: [Wireshark-dev] On Copy as Filter

2009-06-06 Thread didier
Hi, Le vendredi 05 juin 2009 à 17:26 -0700, Guy Harris a écrit : On Jun 5, 2009, at 4:29 PM, didier wrote: This would presumably be combined with a complete removal of the col_expr field from the frame_data structure, right? Yes absolutely but for testing purpose this patch is a lot smaller

Re: [Wireshark-dev] On Copy as Filter

2009-06-05 Thread didier
decide later to make it either optional of write code that dynamically generate the filter string on use (if that is at all possible). Anyone remember why it was changed from dynamically generate? The SVN log msg doesn't make sense to me. Didier

Re: [Wireshark-dev] On Copy as Filter

2009-06-05 Thread didier
Le samedi 06 juin 2009 à 00:26 +0200, Sake Blok a écrit : On Fri, Jun 05, 2009 at 11:55:02PM +0200, didier wrote: Le dimanche 31 mai 2009 à 11:56 +0200, Sake Blok a écrit : Hi Jaap ( list), As the father of the copy as filter functionality, I would vote for it to be present

Re: [Wireshark-dev] Cross compile wireshark for OpenWRT

2009-05-29 Thread didier
, not enough RAM. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] check_col() depcreated?

2009-05-13 Thread didier
, g_snprintf(buf+bufpos, MAX_BUF_SIZE-bufpos, %s%s, val_to_str(opcode, opcode_vals, Unknown (%u)), (flagsF_RESPONSE)? response:)); ... col_add_str(pinfo-cinfo, COL_INFO, buf); cinfo = pinfo-cinfo; } else { cinfo = NULL; } Didier

Re: [Wireshark-dev] one possible way to speed up filtering

2009-05-10 Thread didier
Hi, Le dimanche 10 mai 2009 à 15:22 +0200, Kovarththanan Rajaratnam a écrit : Hello, didier wrote: Hi, Le mardi 24 mars 2009 à 19:46 +0800, yami a écrit : Hi I've tried Didier's patch in Windows (compiled in MSVC 2005 Express with a few code tweak). Great, I think you

Re: [Wireshark-dev] Adding Buffer Stream View

2009-04-23 Thread didier
the tvb_set_child_real_data_tvbuff() call or you leak tvb buffer. Didier (_AppendMultiMsg)( target, bnpLength ); multiMsgSize = (_GetMultiMsgSize)(); free(target); target = ep_alloc(multiMsgSize); memcpy(target, (_GetMultiMsg)(), multiMsgSize); target = (_GetMultiMsg

Re: [Wireshark-dev] one possible way to speed up filtering

2009-04-22 Thread didier
Hi, Le lundi 23 mars 2009 à 20:54 +0100, Joerg Mayer a écrit : On Mon, Mar 23, 2009 at 06:29:11PM +0100, didier wrote: There's still some small stuff which could go but It would only improve wireshark speed by 20-40%, I'm not sure it's worth the time. It most likely is. As usual it's

Re: [Wireshark-dev] Adding Buffer Stream View

2009-04-22 Thread didier
keeping (freeing and so on): tvb_set_child_real_data_tvbuff(tvb, next_tvb); and then create a new data source: add_new_data_source(pinfo, next_tvb, my data); Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev

Re: [Wireshark-dev] Adding Buffer Stream View

2009-04-22 Thread didier
() is called when next_tvb is freed. for example if data is a g_malloc buffer, g_free will do it. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists

Re: [Wireshark-dev] How to turn off optimization while compiling Wireshark on linux?

2009-04-07 Thread didier
-tipc.c is at address 0x1590c24 tipc_defragment_init but contains no code. Am I missing something? Did you export CFLAGS? Another way which works here: configure CFLAGS=g Didier ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-24 Thread didier
and the new syntax tree nodes data point to same address and the solver finds a match. I don't know the proper way to fix this one, for testing I've commented FVALUE_FREE call in dfvm_value_free() Didier ___ Sent via

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-23 Thread didier
using the right tool and so on, but it's surprisingly useful. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-22 Thread didier
Hi, Le dimanche 22 mars 2009 à 02:13 +0800, yami a écrit : Hi Didier, Thank you for trying the patch :) and all the good comments given. I've attached a new patch to the wiki. Please see my detailed reply below. - If compiled without NDEBUG defined I get a failed assert

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-19 Thread didier
) !(tcp.stream eq 2) -- H2 !H3 may be good enough. Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org

Re: [Wireshark-dev] question related to create a statistics

2009-03-17 Thread didier
tcp_dissect_pdus reliably. It doesn't work if in the same tcp segment you have: heart beatlong packet With hear beat size = 4 and long packet size 8 For long packet you must use 8 as tcp_dissect_pdus parameter, and so on. There's no easy workaround though. Didier

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-17 Thread didier
/Development) Didier ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] Performance issues with the new rtp-analysis.c

2009-02-24 Thread didier
Hi, Le mardi 24 février 2009 à 13:54 +0100, Anders Broman a écrit : Hi, I tried reseisable=FALSE without any noticable improvment. The bug report now has a test file. Where? Thanks Didier ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] Crash on Edit Preferences

2008-12-03 Thread didier
a re-dissection because the dialog box selects the first displayed column which emits a changed signal. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org https://wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] wireshark with speed optimizations.

2008-11-07 Thread didier
faster than svn code, only tested on i386 and ppc. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org https://wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] How to append two tvb buffers?

2008-10-17 Thread didier
); tvb_composite_append(tvb1 , tvb2); Look at epan/dissectors/packet-rtmpt.c, it's the only dissector using tvb_composite(). I don't know if it's working though (cf. comment in packet-http.c). Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org https

Re: [Wireshark-dev] Expert info not in front after redisecting packets

2008-10-11 Thread didier
to the front. I would like to get the Expert info screen back in front when rescanning is finised. Or should cf_redissect_packets(cfile); be called before gtk_widget_show_all(ss-win); Many taps use gdk_window_raise() Didier ___ Wireshark-dev mailing list

Re: [Wireshark-dev] displaying TLV parameters - proto_tree_add_item_hidden for type no longer available, now have one line for type, one line for value

2008-10-08 Thread didier
ett_foo Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org https://wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Overriding CC from command line

2008-07-26 Thread didier
with: make all CC=ccc ... AFAICT, libtool (1.5.26-1ubuntu1) doesn't seem to invoke the given ccc script. Any hints? Did you try: export CC=ccc ./configure make Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org https://wireshark.org

Re: [Wireshark-dev] Out of Memory issue

2008-07-25 Thread didier
(temp_str) is 4 or 8 not STRING_BUFFER, maybe you did the same mistake elsewhere and smashed the stack, heap, whatever. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org https://wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Another one with dissector questions

2008-04-23 Thread didier
dissector you also have to use a different type, not pinfo-ptype in find_conversation/conversation_new or you'll get the conversation created by the TCP disssector or break various tcp analysis. Didier ___ Wireshark-dev mailing list Wireshark-dev

[Wireshark-dev] SVN change 24611 (packet-bootp.c)

2008-03-13 Thread Didier
Hi, There's something strange around line 3357 it calls proto_tree_add_xxx functions with bp_tree before initializing it. ? Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] NFS4 stream has malformed packes

2007-12-19 Thread Didier
commands: n22_uml ~ # mount /mnt/nfs/n22_tmp n22_uml ~ # ls /mnt/nfs/n22_tmp n22_uml ~ # umount /mnt/nfs/n22_tmp http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1998 Fixed? Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

Re: [Wireshark-dev] Filtering using DHCP and SSDP throws error

2007-12-02 Thread Didier
Hi, [UTF-8?]On Fri, 30 Nov 2007 16:37:55 +0100, Stig Bjørlykke wrote 2007/11/29, Didier [EMAIL PROTECTED]: The filter value somewhere in the Protocol hierarchy stat would be nice too. You should try svn r23686 or later :) Interesting but it's not what I had in mind: cf patch attached

Re: [Wireshark-dev] Filtering using DHCP and SSDP throws error

2007-12-02 Thread Didier
Hi [UTF-8?]On Sun, 2 Dec 2007 22:48:12 +0100, Stig Bjørlykke wrote On 2. des.. 2007, at 16.49, Didier wrote: cf patch attached. Ah, I see. But I think the Protocol column is a bit harder to read with the filter appended like this. I agree. I suppose you want to use this to create

Re: [Wireshark-dev] How to mark a bug as Review for check-in?

2007-11-29 Thread Didier
Details | Diff Click on Details It's on the left: Flags: review_for_checkin Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Filtering using DHCP and SSDP throws error

2007-11-29 Thread Didier
. The filter value somewhere in the Protocol hierarchy stat would be nice too. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Startup speed up - remove dissectors?!

2007-11-22 Thread Didier
G4). So maybe lazy init these functions would be enough? Enforcing name there would be easy. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Startup speed up - assembler usage

2007-11-21 Thread Didier
1582,290 to 371,999? Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-20 Thread Didier
[UTF-8?]On Tue, 20 Nov 2007 11:42:12 +0100, Stig Bjørlykke wrote 2007/11/20, Didier [EMAIL PROTECTED]: Can you share a small capture? http://wiki.wireshark.org/SampleCaptures?action=AttachFiledo=gettarget=dmp-examples.pcap.gz Add port 24209 in the preferences. Thanks. My problem

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Didier
file.c rescan_packets() Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Optimization patches - GUI

2007-11-16 Thread Didier
http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1876 Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] lenght

2007-11-14 Thread Didier
the idea.   { hf_data_nbyte,    { DATA,  lon.datum,    FT_BYTES, BASE_HEX, NULL, 0,     DATA, HFILL }   } Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Is there a good way of handling per pdu info ?

2007-11-13 Thread Didier
table for both directions you may have duplicate if TCP relative sequence number is set. cf bug: http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1392 Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman

Re: [Wireshark-dev] Small performance improvements to packet-http.c

2007-11-07 Thread Didier
=POST And you can precompute (headers[i].namelen - 1) BTW if you're in optimization mood you can play with http://wiki.wireshark.org/Development/Optimization I'm not sure it compiles for Window though. Didier ___ Wireshark-dev mailing list Wireshark

Re: [Wireshark-dev] About a faster wireshark

2007-10-10 Thread Didier
On Tue, 09 Oct 2007 08:08:29 +0200, Jaap Keuter wrote When trying to attach a one line patch. Hmm, better follow the suggestion of Anders and post it on the Wiki. Done at http://wiki.wireshark.org/Development/Optimization, currently only the patch, writing some stuff about it. Didier

[Wireshark-dev] About a faster wireshark

2007-10-07 Thread Didier
faster. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Alternative to USBPcap and Possibility of

2007-10-02 Thread Didier
know what additional restrictions that'd put on, say, somebody re- packaging WinPcap. Or you can ask Benoit, I know him and I don't see how it could be an issue. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http

Re: [Wireshark-dev] Single TCP segment having multiple PDUs not working

2007-09-27 Thread Didier
Hi On Thu, 27 Sep 2007 12:02:32 -0700, Zongjun wrote Hey guys, According to my capture, I don't have situations where ONE PDU spans over multiple TCP segment. In stead, mine is the other round: Single segment having multiple PDUs. But using the folling code, what I observed is

Re: [Wireshark-dev] Single TCP segment having multiple PDUs not working

2007-09-27 Thread Didier
Hi On Thu, 27 Sep 2007 12:02:32 -0700, Zongjun wrote Hey guys, According to my capture, I don't have situations where ONE PDU spans over multiple TCP segment. In stead, mine is the other round: Single segment having multiple PDUs. But using the folling code, what I observed is

[Wireshark-dev] svn 21618 HTTP is not decoded at all.

2007-07-30 Thread Didier
Hi Sorry but I can't use bugzilla. https (bug 192) it's revision 21618 the culprit. pref reinit callbacks are only called if prefs are changed or aren't the default so sometime http dissector doesn't register itself. Didier ___ Wireshark-dev mailing

Re: [Wireshark-dev] Memory leak

2007-07-22 Thread Didier
On Fri, 20 Jul 2007 03:11:20 +0200, Didier wrote On Thu, 19 Jul 2007 14:16:49 -0400, Jeff Morriss wrote Didier wrote: [That's not to say I don't see memory usage growing when I reload a capture file, but I'm not convinced this is the source.] Attached a small patch which replace

Re: [Wireshark-dev] Memory leak

2007-07-19 Thread Didier
On Thu, 19 Jul 2007 14:16:49 -0400, Jeff Morriss wrote Didier wrote: Hi, 1) It seems that since some glib 2.0 version g_mem_chunk_destroy doesn't free The docs certainly seem to indicate that the memory should actually be freed: http://www.gtk.org/api/2.6/glib/glib-Memory-Chunks.html

  1   2   >