Re: [Wireshark-dev] Should I add new commits to address review comments?

2017-07-11 Thread Graham Bloice
gt; keep the original change-id in the commit? > > -- > Regards, > Richard Sharpe > (何以解憂?唯有杜康。--曹操) > As per the wiki, amend your original commit, keeping the Change-Id: https://wiki.wireshark.org/Development/SubmittingPatch

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

2017-07-06 Thread Graham Bloice
On 6 July 2017 at 22:47, Guy Harris wrote: > On Jul 6, 2017, at 1:39 PM, Graham Bloice > wrote: > > > Careful, I only know enough git to work out things have gone wrong and > very specific ways of getting out of trobule. Glad to be of help. > > https://xkcd.

Re: [Wireshark-dev] Build error with VS2013 Ultimate

2017-07-06 Thread Graham Bloice
ing that file i.e. "cmake ... ">&1 >cmake.txt" 3. Similarly, can you attach the output of the msbuild step, i.e. "msbuild ... 2>&1 >build.txt" -- Graham Bloice ___

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

2017-07-06 Thread Graham Bloice
ree” solution. > > > > Thanks and regards…Paul > > Careful, I only know enough git to work out things have gone wrong and very specific ways of getting out of trobule. Glad to be of help. > > > *From:* Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] *On &

Re: [Wireshark-dev] Gerrit Patch Set Submission Problem

2017-07-05 Thread Graham Bloice
Update master (git pull) 4. Delete your branch (git branch -D "review/unknown/syncro", I think this is the branch name you have) 5. Get a new copy of the branch (git review -d 19666) 6. Rebase the branch to the latest master (git rebase master) 7. Copy your saved files fro

Re: [Wireshark-dev] Problem while compiling wireshark master

2017-07-04 Thread Graham Bloice
ll warnings being treated as errors", > "make[2]: *** [caputils/CMakeFiles/caputils.dir/iface_monitor.c.o] > Error 1", > "make[1]: *** [caputils/CMakeFiles/caputils.dir/all] Error 2", > "make[1]: *** Waiting for unfinished jobs...

Re: [Wireshark-dev] The "right" Qt header files

2017-06-28 Thread Graham Bloice
eader files, they aren't normally added to a virtual folder. You could add the headers to a file list with a GLOB (possibly recursive) and add them to the files for a target ( https://stackoverflow.com/questions/34007099/cmake-how-to-show-headers-in-header-files-in-visual-studio-project )

Re: [Wireshark-dev] Waiting for something to happen on a pipe/socket on Windows

2017-06-28 Thread Graham Bloice
gWaitForMultipleObjects(). I think that's what's used in the GUI event >> loops of GTK+ and Qt on Windows. >> >> So doing the equivalent of select()/poll() on Windows appears to be a >> challenge. >> >> If anybody has more information than wha

Re: [Wireshark-dev] My Windows build seemed to be going so well until ...

2017-06-19 Thread Graham Bloice
ays caused problems whenever I've encountered it and I've strongly recommended folks do NOT do this for a long time. Another thing to note with CMake builds is that once CMake has located an external library or function call it will cache that info in CMakeCache.txt in the

Re: [Wireshark-dev] My Windows build seemed to be going so well until ...

2017-06-19 Thread Graham Bloice
On 19 June 2017 at 19:40, Richard Sharpe wrote: > On Mon, Jun 19, 2017 at 11:12 AM, Richard Sharpe > wrote: > > On Mon, Jun 19, 2017 at 8:08 AM, Graham Bloice > > wrote: > >> > >> > >> On 19 June 2017 at 15:02, Jeff Morriss > wrote: > &g

Re: [Wireshark-dev] My Windows build seemed to be going so well until ...

2017-06-19 Thread Graham Bloice
whatever package supplies `htmlhelp.xsl`. > > Or you can remove the "--nonet" option which is what is preventing it from > trying to get the file off the 'net (there was recently some > discussion--but no resolution that I'm aware of--of the wis

Re: [Wireshark-dev] Building Wireshark on Windows 10 with VS2013 ...

2017-06-18 Thread Graham Bloice
On 18 June 2017 at 19:19, Richard Sharpe wrote: > Hi folks, > > I can't seem to find the Visual Studio Command Prompt on my Windows 10 > system with VS-2013 installed. > > Does anyone know how to find or install that thing? > > >From the start menu, locate the Visual Studio 2013 item under the "V

Re: [Wireshark-dev] Go to Qt 5.9 on Windows build bots?

2017-06-14 Thread Graham Bloice
> easily. I think Stig has tried it on > > MAC OS too if we want to update that too. > > Regards > > Anders > > -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https

Re: [Wireshark-dev] Does it take a while before a public key becomes available on Gerrit?

2017-06-13 Thread Graham Bloice
On 13 June 2017 at 14:18, Richard Sharpe wrote: > On Tue, Jun 13, 2017 at 6:13 AM, Richard Sharpe > wrote: > > On Tue, Jun 13, 2017 at 6:01 AM, Graham Bloice > > wrote: > >> > >> > >> On 13 June 2017 at 13:37, Richard Sharpe > >> wrote

Re: [Wireshark-dev] Does it take a while before a public key becomes available on Gerrit?

2017-06-13 Thread Graham Bloice
Richard Sharpe > (何以解憂?唯有杜康。--曹操) > The commands are different because they're intended for two different purposes. The ssh command attempts to open a remote shell connection to the gerrit server, the git clone command uses ssh to clone the wireshark repository. -- Graham Bloice __

Re: [Wireshark-dev] Switch master and master-2.4 to Visual Studio 2015?

2017-06-07 Thread Graham Bloice
On 7 June 2017 at 18:52, Graham Bloice wrote: > > > On 7 June 2017 at 18:45, Gerald Combs wrote: > >> On 6/7/17 2:03 AM, Graham Bloice wrote: >> > >> > >> > On 7 June 2017 at 00:11, Gerald Combs > > <mailto:ger...@wireshark.org>>

Re: [Wireshark-dev] Switch master and master-2.4 to Visual Studio 2015?

2017-06-07 Thread Graham Bloice
On 7 June 2017 at 18:45, Gerald Combs wrote: > On 6/7/17 2:03 AM, Graham Bloice wrote: > > > > > > On 7 June 2017 at 00:11, Gerald Combs > <mailto:ger...@wireshark.org>> wrote: > > > > We currently build all of our Windows packages using Visu

Re: [Wireshark-dev] Switch master and master-2.4 to Visual Studio 2015?

2017-06-07 Thread Graham Bloice
objections, although I was considering a jump straight to 2017 once I work out how to get the Qt 5.9 build for 2017. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org

Re: [Wireshark-dev] Troubles with ASN generated code

2017-05-21 Thread Graham Bloice
On 21 May 2017 at 23:00, Guy Harris wrote: > On May 21, 2017, at 2:54 PM, Graham Bloice > wrote: > > > It would appear not in a static initializer list. I can do it piecemeal, > e.g. foo.member = &fff. > > Does "piecemeal" really mean "in executable c

Re: [Wireshark-dev] Troubles with ASN generated code

2017-05-21 Thread Graham Bloice
On 21 May 2017 at 23:00, Guy Harris wrote: > On May 21, 2017, at 2:54 PM, Graham Bloice > wrote: > > > It would appear not in a static initializer list. I can do it piecemeal, > e.g. foo.member = &fff. > > Does "piecemeal" really mean "in executable

Re: [Wireshark-dev] Devices in tshark versus dumpcap

2017-04-29 Thread Graham Bloice
On 29 April 2017 at 10:29, Gisle Vanem wrote: > Graham Bloice wrote: > > Unsure whether this is related, but MSVC2015 support is regarded as >> "experimental". The official builds are still using >> VS2013. >> > > Really. MSVC-2015 is much better rega

Re: [Wireshark-dev] Devices in tshark versus dumpcap

2017-04-29 Thread Graham Bloice
whether this is related, but MSVC2015 support is regarded as "experimental". The official builds are still using VS2013. > The above "read 21 indicator: S empty value" for me indicates a problem in > the pipe I/O between tshark and dumpcap. No? > > Are you

Re: [Wireshark-dev] Nsis installer build location

2017-04-26 Thread Graham Bloice
coordination with the buildbots for the new location. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/opt

Re: [Wireshark-dev] Visual Studio 2013/2015/2017 compatibility and libraries

2017-04-24 Thread Graham Bloice
On 24 April 2017 at 16:59, Peter Wu wrote: > On Mon, Apr 24, 2017 at 04:41:27PM +0100, Graham Bloice wrote: > > On 24 April 2017 at 15:28, Pascal Quantin > wrote: > > > > > > > > > > > 2017-04-24 16:25 GMT+02:00 Graham Bloice >: > > &g

Re: [Wireshark-dev] Visual Studio 2013/2015/2017 compatibility and libraries

2017-04-24 Thread Graham Bloice
On 24 April 2017 at 15:28, Pascal Quantin wrote: > > > 2017-04-24 16:25 GMT+02:00 Graham Bloice : > >> >> >> On 24 April 2017 at 14:56, Pascal Quantin >> wrote: >> >>> Hi Peter >>> >>> 2017-04-24 15:43 GMT+02:00 Peter Wu :

Re: [Wireshark-dev] Visual Studio 2013/2015/2017 compatibility and libraries

2017-04-24 Thread Graham Bloice
ill-advised static linking to the CRT). The Universal CRT was introduced with Windows 10\VS 2015 to allow Windows Updates to service a portion of the runtime [1]. The part of the CRT that deals with heaps is now serviced by the OS, so theoretically apps built with VS2015 or later (with the Wind

Re: [Wireshark-dev] Error in Wireshark (tshark.c:646)

2017-04-20 Thread Graham Bloice
exp_pdu_filename = NULL; > ^ > Is a fix on the way? How could this bug passed through CI ? > > Best regards > > Rémy > > Caused by commit bce5ec919e2fd197e0042dfabf5186d0d6f6eb47 on change 21239 which didn't go

Re: [Wireshark-dev] Adding libxml2 as optional Wireshark dependency

2017-04-16 Thread Graham Bloice
Has there been any progress on building and testing libxml2 using OpenSUSE? On 5 April 2017 at 17:52, Graham Bloice wrote: > > > On 5 April 2017 at 14:48, Pascal Quantin wrote: > >> Hi Ahmad and Graham, >> >> 2017-04-05 15:38 GMT+02:00 Graham Bloice : >>

Re: [Wireshark-dev] Debugging an assertion failure

2017-04-14 Thread Graham Bloice
x27;) { int dummy = 0; // breakpoint here. } > > *From:* wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-bounces@ > wireshark.org] *On Behalf Of *Graham Bloice > *Sent:* 14 April 2017 11:55 > *To:* Developer support list for Wireshark > *Subject:* Re: [Wireshark-dev

Re: [Wireshark-dev] Debugging an assertion failure

2017-04-14 Thread Graham Bloice
the > exception? > > > > Thanks and regards…Paul > > I haven't tried this for g_assert() exceptions, but usually you need to open up Debug -> Windows -> Exception Settings and check more boxes. -- Graham Bloice __

Re: [Wireshark-dev] buildbot down?

2017-04-11 Thread Graham Bloice
mspx?mfr=true> > > s/en-us/taskkill.mspx?mfr=true > > > > - Chris > > > > > -Original Message- > > > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > > > boun...@wireshark.org] On Behalf Of Gerald Combs > > >

Re: [Wireshark-dev] buildbot down?

2017-04-09 Thread Graham Bloice
quot;})) to get the processes owned by the user account running the command, but there's still too many in there that shouldn't be stopped. Maybe Get-Process | Where-Object -Property ProcessName -match ".*(Process1|Process2|P

Re: [Wireshark-dev] Diameter SH-Interface User Data (AVP 702) is not decoded

2017-04-07 Thread Graham Bloice
er supported, can you try a supported version, i.e. 2.0 or later? See https://wiki.wireshark.org/Development/LifeCycle for supported release info. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:http

Re: [Wireshark-dev] Adding libxml2 as optional Wireshark dependency

2017-04-05 Thread Graham Bloice
On 5 April 2017 at 14:48, Pascal Quantin wrote: > Hi Ahmad and Graham, > > 2017-04-05 15:38 GMT+02:00 Graham Bloice : > >> >> >> On 5 April 2017 at 14:11, Ahmad Fatoum wrote: >> >>> Hello everyone, >>> >>> I was advised on Gerrit

Re: [Wireshark-dev] Adding libxml2 as optional Wireshark dependency

2017-04-05 Thread Graham Bloice
ments/action/open-download/download/epsg-311-v110-ds-xml-device- > description/?no_cache=1 > [2] https://github.com/epl-viz/dissector (Needs to be converted back to a > static dissector) > > On Wed, Apr 5, 2017 at 3:38 PM, Graham Bloice > wrote: > >> >> >> On

Re: [Wireshark-dev] Adding libxml2 as optional Wireshark dependency

2017-04-05 Thread Graham Bloice
oduce XML device description files for the EPL dissector such that choosing XML as the input format is the most sensible choice, or would another format be just as applicable? [1]: https://www.zlatkovic.com/libxml.en.html [2]:

Re: [Wireshark-dev] Where to report Bugs

2017-04-04 Thread Graham Bloice
wn again to where I was last looking. > > > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wi

Re: [Wireshark-dev] cannot install - damaged .pkg - OSX 2.2.5 & 2.1.1

2017-03-21 Thread Graham Bloice
Serial ATA Device: APPLE SSD SM0256F, 251 GB > USB Device: Internal Memory Card Reader > USB Device: Apple Internal Keyboard / Trackpad > USB Device: BRCM20702 Hub > USB Device: Bluetooth USB Host Controller > Thunderbolt Bus: MacBook Pro, Apple Inc., 17.2 > >

Re: [Wireshark-dev] [Wireshark-users] R13 S1AP message "Reroute NAS Request" is not decoding completely using 2.3.0

2017-03-17 Thread Graham Bloice
> >> *Subject:* [Wireshark-users] R13 S1AP message "Reroute NAS Request" is >> not decoding completely using 2.3.0 >> >> >> >> Hi, >> >> R13 baseline S1AP message "RerouteNASRequest" is not decoding completely >> using 2.3.0. C

Re: [Wireshark-dev] [Wireshark-announce] Wireshark 2.2.5 is now available

2017-03-15 Thread Graham Bloice
eshark-annou...@wireshark.org> wrote: > >> >> > > -- > *Jean-Christophe Manciot* > > Not at all, the GitHub repo is a read only mirror of the main repo at https://code.wireshark.org/review/wireshark and the mirroring has been temporarily s

Re: [Wireshark-dev] Buildiing with Qt 5.8 fails on Windows

2017-03-09 Thread Graham Bloice
_ > ___ > Sent via:Wireshark-dev mailing list > Archives:https://www.wireshark.org/lists/wireshark-dev > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev > mailto:wireshark-dev-requ...@wireshark.org?subject= >

Re: [Wireshark-dev] Bugzilla SSL Issue?

2017-01-20 Thread Graham Bloice
I'd manually typed the (correct) URL. Never click on links in email -:) > >> >> On 01/20/2017 02:55 PM, Pascal Quantin wrote: >> >>> >>> >>> 2017-01-20 15:46 GMT+01:00 Graham Bloice >> <mailto:graham.blo...@trihedral.com>>: >

Re: [Wireshark-dev] Bugzilla SSL Issue?

2017-01-20 Thread Graham Bloice
e short lifetime of the cert you see is typical of a Let's Encrypt cert (90 days) and that's what Gerrit is using (for me). -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https:/

Re: [Wireshark-dev] git-review fails with an SSL error

2017-01-18 Thread Graham Bloice
ommit and > tools/commit-msg files in the .git/hooks folder of your Wireshark clone. > > Pascal. > > > > I think this has me beat. If anyone wants to submit the fix for bug 12973 > I’ll happily provide the details. > > > > Thanks to Graham and Pascal for the help.

Re: [Wireshark-dev] git-review fails with an SSL error

2017-01-17 Thread Graham Bloice
morning and then created my own > branch: > > > > C:\Development\wireshark>git branch > > * bug12973 > > master > > > > > > *From:* wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-bounces@ > wireshark.org ] *On Behalf Of *Graham > Bloice > *S

Re: [Wireshark-dev] git-review fails with an SSL error

2017-01-17 Thread Graham Bloice
> > > C:\Development\wireshark>git branch > > * bug12973 > > master > > > > > > *From:* wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-bounces@ > wireshark.org ] *On Behalf Of *Graham > Bloice > *Sent:* 17 January 2017 18:37 > *To:* Developer s

Re: [Wireshark-dev] git-review fails with an SSL error

2017-01-17 Thread Graham Bloice
On 17 January 2017 at 18:32, Graham Bloice wrote: > > > On 17 January 2017 at 18:04, Paul Offord wrote: > >> I’m trying to get git-review working. I think I’ve done everything >> necessary but this is what I get: >> >> >> >> C:\Developme

Re: [Wireshark-dev] git-review fails with an SSL error

2017-01-17 Thread Graham Bloice
? What does "git branch" show? Have you checked your git\ssh connection to Gerrit? see https://wiki.wireshark.org/Development/SubmittingPatches/GitForWindows, but note you'll need to supply the path to the git version of ssh, i.e. (from PowerShell) & "C:\Program Files\Git\usr\bin\ssh

Re: [Wireshark-dev] main_toolbar.c in code tree but not in solution

2017-01-17 Thread Graham Bloice
R2%20x64/builds/420/steps/compile_1/logs/stdio and look for main_toolbar.c I suspect you've somehow generated a solution without gtk being enabled. > > > Best regards…Paul > > > > *From:* wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-bounces@ > wireshark.org]

Re: [Wireshark-dev] main_toolbar.c in code tree but not in solution

2017-01-17 Thread Graham Bloice
still used (see UI\gtkui\Source Files in the solution explorer) and yes, preferably fix both. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsub

Re: [Wireshark-dev] VS 2015 or not

2017-01-06 Thread Graham Bloice
one with VS2013 so that's the safe bet. You can install both side-by-side. Pro-tip, create a VM using the technology of your choice and use that for Wireshark Dev (and only Wireshark Dev). This means that when you get a

Re: [Wireshark-dev] RTP player redesign in 2.x makes it worse than the legacy one

2017-01-03 Thread Graham Bloice
utput for same input. Therefore it will take a time before I >> will change features you mentioned. >> >> Sincerely yours, >> >> Jirka Novak >> > > -- Graham Bloice _

Re: [Wireshark-dev] QT DLLs missing from build environment

2016-12-27 Thread Graham Bloice
t; __ > This email has been scanned by the Symantec Email Security.cloud service. > For more information please visit http://www.symanteccloud.com > ___

Re: [Wireshark-dev] Build with VS 2013 on Windows 7

2016-12-26 Thread Graham Bloice
the same "setup" for the command shell you were using previously? 3. Delete your build directory and run the CMake generation step again (or just delete CMakeCache.txt in the build dir). This is necessary whenever any of the CMake cached paths to libraries and exec

Re: [Wireshark-dev] Building latest Wireshark using VS2013

2016-12-24 Thread Graham Bloice
t; These could be avoided but don't affect the ability to build Wireshark > at all. > > The only warnings you should be getting are those as seen on the x64 buildbot which are actually all pdf doc generation warnings. The current master has no "code" build warnings on VS2013,

Re: [Wireshark-dev] Building latest Wireshark using VS2013

2016-12-23 Thread Graham Bloice
>> >>> I assume this command should be executed with bash instead of cmd.exe, >>> what is the magic how commands are executed by cygwin bash instead of >>> the windows command processore? >>> Is it legal to set WIRESHARK_CYGWIN_INSTALL_PATH not pointing to >>>

Re: [Wireshark-dev] Packet sample repository/library?

2016-12-20 Thread Graham Bloice
a to allow skip a sample from automatic testing >> (because it is for GUI demonstration)? >> > For GUI stuff, a idea will be to use Extensive Testing ( > http://www.extensivetesting.org/ ) > it is on my TODO list but never found time to implement... > > With a Window

Re: [Wireshark-dev] Redhat binaries

2016-12-16 Thread Graham Bloice
> On Thu, Dec 15, 2016 at 4:52 PM, > > <mailto:joseph.til...@l-3com.com>> wrote: >> > >> > __ __ >> > >> > I can’t locate the binaries for the Redhat distribution of >> wireshark. >> > I tried getting it for

Re: [Wireshark-dev] Unable to Build 2.2 Stable from Source on Windows 7

2016-11-11 Thread Graham Bloice
runa2x.sh using a non Cygwin bash? Please re-run your CMake generation step, redirecting the output to a file and then post the contents of that file. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] GUI Change for Wireshark Remote Interfaces

2016-10-27 Thread Graham Bloice
title be "RPCap Remote interfaces" ? The current dialog has a "Show" column, I'm assuming that allows users to show\hide an interface, that doesn't seem to be an option on the new dialogs. -- Graham Bloice __

Re: [Wireshark-dev] Replacing AsciiDoc by Asciidoctor for faster documentation?

2016-10-26 Thread Graham Bloice
ther script language runtime to install and therefore more manual steps in the Windows build env setup. While the time saving might be attractive is there that much churn in the docs that you actually rebuild them a lot? -- Graham Bloice _

Re: [Wireshark-dev] Changes to the Wireshark Wiki

2016-10-24 Thread Graham Bloice
e website Retrospective page as soon as you’re able post-event. If they’re not forthcoming within a week after the conference ends, be prepared for relentless pursuit until we have them! -- Graham Bloice ___ Sent

Re: [Wireshark-dev] Linking on OSX Sierra

2016-10-12 Thread Graham Bloice
the build? > > Completely blowing away the build directory and starting again seems > to have fixed it. That was really weird, especially since (to my > knowledge) I don't even have a source build of libpcap on this > machine. > > Anywho, thanks everyone for the help! >

Re: [Wireshark-dev] Changes to internal Lua classes implementation (Pinfo, TvbRange, etc.)

2016-10-03 Thread Graham Bloice
help is appreciated > in these tasks :-) > -- > Kind regards, > Peter Wu > As a non-lua programmer most of that goes straight over my head, but I'm intrigued\concerned about methods that are class based (i.e. similar to C++ class static methods ??) and instance based that diffe

Re: [Wireshark-dev] smb2.msg_id defined as signed 64-bit integer - bug?

2016-09-17 Thread Graham Bloice
MessageId should be an unsigned 64-bit integer. Although the > [MS-SMB2] document isn’t specific, Microsoft Message Analyzer defines the > field as UInt64. > > > > It’s not a big deal but it does mean that filtering for a range of > MessageIds won’t work as expected for very l

Re: [Wireshark-dev] TRANSUM Program Logic Notes

2016-09-17 Thread Graham Bloice
I get contributor rights on the wiki? > > > > Best regards…Paul > > > The Wiki would be suitable, probably linked off the ProtocolReference page ( https://wiki.wireshark.org/ProtocolReference). For editing permissions, see the notices on the Wiki fron

Re: [Wireshark-dev] Correct procedure for pushing a new dissector to Gerrit

2016-09-16 Thread Graham Bloice
oks/ > > remote: And then amend the commit: > > remote: git commit --amend > > remote: > > To https://pauloff...@code.wireshark.org/review/wireshark > > ! [remote rejected] HEAD -> refs/for/master/bug12892 (missing Change-Id in > comm > > it message footer)

Re: [Wireshark-dev] Recommended QT version to build Wireshark Master ?

2016-09-15 Thread Graham Bloice
therefore releases. > > Gilbert > > On Mon, Sep 12, 2016 at 5:06 PM, Graham Bloice < > graham.blo...@trihedral.com> wrote: > >> >> >> On 12 September 2016 at 20:22, Bill Meier wrote: >> >>> On 9/12/2016 3:11 PM, Bill Meier wrote: >>>

Re: [Wireshark-dev] Recommended QT version to build Wireshark Master ?

2016-09-12 Thread Graham Bloice
t now from Qt. I don't think you get the choice of non Open GL for 5.6 onwards. The docs could be cleaned up a bit here, they should list the recommended Qt versions for each release and all the examples should be consistent. Windows i

Re: [Wireshark-dev] Enable extcap by default or not

2016-09-08 Thread Graham Bloice
t of the users I support as they are for "niche" purposes. I don't follow the argument that a user actually needing an extcap interface for their "niche" purpose will find enabling it at all difficult

Re: [Wireshark-dev] VS 2013 Local Windows Debugger shows Qt5Core.dll is missing

2016-09-05 Thread Graham Bloice
e.g. for PowerShell: cd path\to\run\Debug $env:Path += ";path\to\Qt\Bin\dir" windeployqt --dry-run --debug wireshark.exe if the output looks reasonable, then try without the "--dry-run". -- Graham Bloice

Re: [Wireshark-dev] TRANSUM C Port

2016-09-02 Thread Graham Bloice
ew helps a lot here, highly recommended. If you do decide to submit before it's complete, prefix the commit message with "[WIP]" so that it won't accidentally be merged, the prefix can be removed from the message when ready. A bugzilla entry (referenced in the commit message

Re: [Wireshark-dev] Allowing use of more C99 features

2016-09-02 Thread Graham Bloice
mbo is Ctrl + K, Ctrl + C. Use Ctrl + K, Ctrl + U. > > > > > *From:* wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-bounces@ > wireshark.org] *On Behalf Of *Graham Bloice > *Sent:* 02 September 2016 08:54 > *To:* Developer support list for Wireshark > *Subjec

Re: [Wireshark-dev] Allowing use of more C99 features

2016-09-02 Thread Graham Bloice
> so, in addition to > > > - flexible array members > > - trailing comma in enum declarations > > - inline function keyword > > we also can use // comments and, apparently, variable declarations in for > loops, assuming there's no bug that gets in the way

Re: [Wireshark-dev] IEEE 802.15.4 Payload IE Handling

2016-09-01 Thread Graham Bloice
this > would only work in cases where no encryption is used. > > > > Best regards, > > > > Klaus > > > > > Thanks for your observations, please see the wiki page on submitting patches (https://wiki.wireshark.org/Development/SubmittingPatches) for info on how to submi

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 17:13, Graham Bloice wrote: > On 5 August 2016 at 17:01, Dario Lombardo > wrote: > >> I updated qt to 5.6.1. After cmake, I get >> >> -- The following OPTIONAL packages have not been found: >> * CAP >&g

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
.git> > * SETCAP > * YAPP > * HTMLHelp > > is it correct? Should't I have Qt5Core the the "found" list? > Have you updated the QT5_BASE_DIR env var for the new location? > > On Fri, Aug 5, 2016 at 4:19 PM, Graham Bloice > wrote: > >&

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 14:56, Dario Lombardo wrote: > What Qt version? I think I've seen that one before. >>> >> >> > 5.3.2. > On Windows we're using 5.6.1 -- Graham Bloice ___

Re: [Wireshark-dev] dissecting TCP packets with multiple PDUs

2016-08-05 Thread Graham Bloice
start a new dissection. > > > > Is there an example plugin that someone can suggest that I can investigate > to see how this scenario is handled? > > > > Thanks, > > John D. > > > Is your dissector returning the number of bytes it dissected? -- Graham Bloice

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
uot; (default target) > (112) -> >(ClCompile target) -> > C:\Program Files (x86)\Microsoft Visual Studio > 12.0\VC\include\algorithm(3050): error C2220: warning treated as error - > no 'object >' file generated [c:\Development\wsbuild64\u

Re: [Wireshark-dev] Windows compilation fails

2016-08-05 Thread Graham Bloice
[c:\Development\wsbuild64\epa >n\dfilter\dfilter.vcxproj] > C:\Development\wireshark\epan\dfilter\dfilter.c(322): error > C2065: 'scanner' : undeclared identifier [c:\Development\wsbuild64\epa >n\dfilter\dfilter.vcxproj] > > >"c:\

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 11:21, Guy Harris wrote: > On Aug 5, 2016, at 2:52 AM, Graham Bloice > wrote: > > > I did look a bit for licensecheck and it appears to be a Perl script > available as a Debian (and RPM) package devscripts as suggested by João, a > package for Debian pac

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Graham Bloice
On 5 August 2016 at 10:52, Graham Bloice wrote: > > > On 5 August 2016 at 10:45, Guy Harris wrote: > >> On Aug 5, 2016, at 2:00 AM, João Valverde > .pt> wrote: >> >> > On 08/05/2016 08:56 AM, Alexis La Goutte wrote: >> >> I confirm ;-) (too s

Re: [Wireshark-dev] checklicenses.py

2016-08-05 Thread Graham Bloice
th OS X, either.) > > I did look a bit for licensecheck and it appears to be a Perl script available as a Debian (and RPM) package devscripts as suggested by João, a package for Debian package maintainers. As such, it isn't available for Windows. The checklicenses.py script should

Re: [Wireshark-dev] Adding Qt5 libs via VS Additional Dependencies

2016-08-05 Thread Graham Bloice
to copy the required Qt DLL to the staging directory and the update the packaging scripts to put it into an installer (packaging\nsis\custom_plugins.txt). -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archi

Re: [Wireshark-dev] Multiple UAC requests when starting/using Wireshark with Npcap's "Admin-only" mode ON

2016-06-28 Thread Graham Bloice
fecycle? > > > Cheers, > Yang > > > I think a solution similar to that used by Linux could be used, i.e. "Admin-only" mode could be changed to require membership of a local group, e.g. "Npcap-users", and then NPcapHelper could check that the calling user

Re: [Wireshark-dev] PCAP-NG Block Formats

2016-06-10 Thread Graham Bloice
l > > I think you should raise an issue, whether thats on the doc or wireshark I'm not sure. > > *From:* wireshark-dev-boun...@wireshark.org [mailto: > wireshark-dev-boun...@wireshark.org] *On Behalf Of *Graham Bloice > *Sent:* 10 June 2016 13:28 > *To:* Developer suppor

Re: [Wireshark-dev] PCAP-NG Block Formats

2016-06-10 Thread Graham Bloice
al Length value? > > ·Is this a Wireshark bug (writing incorrect format PCAP-NG files)? > > > > Thanks and regards…Paul > > > > -- Graham Bloice ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Use Npcap as the default Windows capture library for Wireshark

2016-06-06 Thread Graham Bloice
- Other stuff I haven't thought of yet. Note that I'm not trying to be negative, just trying to make sure we offer Wireshark users the best possible software. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Extracting field values in a C post-dissector

2016-06-03 Thread Graham Bloice
field extractor interface is defined in the C code. > > *From:* wireshark-dev-boun...@wireshark.org [mailto: > wireshark-dev-boun...@wireshark.org] *On Behalf Of *Graham Bloice > *Sent:* 03 June 2016 09:16 > *To:* Developer support list for Wireshark > *Subject:* Re: [Wireshark-dev] Extr

Re: [Wireshark-dev] Extracting field values in a C post-dissector

2016-06-03 Thread Graham Bloice
multiple PDU's in a single segment. This is where tcp reassembly/desegmentation is used. -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscr

Re: [Wireshark-dev] Copy error during build of copy_cli_dlls

2016-06-01 Thread Graham Bloice
run the following command to prep for the build: > > > > C:\Development\Wireshark\build>cmake -D ENABLE_CHM_GUIDES=on -G "Visual > Studio 12 Win64" ..\ > > > > Any advice much appreciated. > > > > Best regards…Paul > > > > Paul Off

Re: [Wireshark-dev] newbie question about dissection specifications

2016-05-31 Thread Graham Bloice
• C++ functions that create an appropriate Wireshark > dissector. > > • Etc. > > ...your work is intended for more purposes than just Wireshark dissection, > such as protocol implementations,

Re: [Wireshark-dev] Export ssl_starttls_ack for plugins

2016-05-31 Thread Graham Bloice
ere a reason for those functions (all of the > packet-ssl-utils.h) not to be exported? Or its just because nobody has > requested it so far? > > > The latter. Submit a change it it will be merged. -- Graham Bloice ___

Re: [Wireshark-dev] Windows dev, gerrit, git-review, etc.

2016-05-26 Thread Graham Bloice
o doesn't really cover patch submission. The Wiki page on patch submission ( https://wiki.wireshark.org/Development/SubmittingPatches) has much more help in that area, and for Windows folks in particular, the sub-page GitForWindows ( https://wiki.wireshark.org/Development/SubmittingPatche

Re: [Wireshark-dev] Does it make any sense to supply Radiotap + 802.11 headers for packets captured on wireless adapter for managed mode?

2016-04-26 Thread Graham Bloice
o a >> message indicating that you can't capture in non-monitor mode as there's a >> monitor-mode capture in progress. >> >> If opt.rfmon *is* set, and one or more instances of the code *above* >> NWIFI are running (mea

[Wireshark-dev] Windows buildslaves

2016-04-25 Thread Graham Bloice
All the Windows buildslaves seem to be offline. Something happened at the hosting site? -- Graham Bloice ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/lists/wireshark-dev Unsubscribe

Re: [Wireshark-dev] Commits 13dc91f5b or 9fbd4e6fc: addr_resolv.c fail to compile (async_dns_queue_head)

2016-04-25 Thread Graham Bloice
On 25 April 2016 at 15:35, Graham Bloice wrote: > On 25 April 2016 at 15:04, Uli Heilmeier wrote: > >> >> Hi list, >> >> my build system has failed to compile current master branch since commits >> 13dc91f5b or 9fbd4e6fc. >> >> The error is:

Re: [Wireshark-dev] Commits 13dc91f5b or 9fbd4e6fc: addr_resolv.c fail to compile (async_dns_queue_head)

2016-04-25 Thread Graham Bloice
Any ideas to fix it? > > Cheers > Uli > > Probably surround lines 2659 & 2660 with a #ifdef HAVE_C_ARES\#endif pair, and if it works then submit a change to Gerrit. -- Graham Bloice ___ Sent via:Wiresh

Re: [Wireshark-dev] How to download required libraries when using Cmake?

2016-04-25 Thread Graham Bloice
On 25 April 2016 at 11:53, Graham Bloice wrote: > > On 25 April 2016 at 11:38, Anders Broman > wrote: > >> Hi, >> >> How are you to download the required support libraries with cmake? >> >> With nmake you get a warning if they are out of date and yo

<    1   2   3   4   5   6   7   8   9   10   >