[Wireshark-dev] Header field (hf_) in packet-ieee80211.c

2011-01-21 Thread Alexis La Goutte
Hi, I work on the file packet-ieee80211.c and I found that some header field ( tag_interpretation, cf_version ...) will not begin by hf_ There is a historic reason ? Because if I'm not mistaken, The checkhf.pl file only verified header fields starting with hf_ ? Regards,

Re: [Wireshark-dev] Header field (hf_) in packet-ieee80211.c

2011-01-21 Thread Anders Broman
Alexis La Goutte skrev 2011-01-21 17:32: Hi, I work on the file packet-ieee80211.c and I found that some header field (tag_interpretation, cf_version ...) will not begin by hf_ There is a historic reason ? Yes, the historic reason being that it slipped trough ;-) There is a lot of stuff that

Re: [Wireshark-dev] Header field (hf_) in packet-ieee80211.c

2011-01-21 Thread Stephen Fisher
On Fri, Jan 21, 2011 at 06:55:51PM +0100, Anders Broman wrote: I think the hf variables should be prefixed with hf_ieee80211 to follow the style of other dissectors, unfortunately that's a bit long, hf_80211, hf_wifi? if hf_ieee80211 is used throughout it's ease to shorten it later. How