Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-11 Thread Sultan, Hassan via Wireshark-dev
.@euronet.nl> > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potential > offenders > > > > Le 10 août 2017 10:56, "Stig Bjørlykke" <s...@bjorlykke.org > <mailto:s...@bjorlykke.org> > a écrit : > > > On We

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-10 Thread Pascal Quantin
Le 10 août 2017 10:56, "Stig Bjørlykke" a écrit : On Wed, Aug 9, 2017 at 7:05 PM, Pascal Quantin wrote: > What about marking it as PROTO_ITEM_SET_GENERATED() as a first step? Tis > value is inferred from the tvb length and not a real field. It's

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-10 Thread Pascal Quantin
Le 10 août 2017 00:03, "Alexis La Goutte" a écrit : On Wed, Aug 9, 2017 at 7:05 PM, Pascal Quantin wrote: > Hi Stig (and Sake), > > 2017-08-02 22:24 GMT+02:00 Stig Bjørlykke : > >> On Wed, Aug 2, 2017 at 10:03 PM,

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-09 Thread Alexis La Goutte
On Wed, Aug 9, 2017 at 7:05 PM, Pascal Quantin wrote: > Hi Stig (and Sake), > > 2017-08-02 22:24 GMT+02:00 Stig Bjørlykke : > >> On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev >> wrote: >> > Regarding

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-09 Thread Pascal Quantin
Hi Stig (and Sake), 2017-08-02 22:24 GMT+02:00 Stig Bjørlykke : > On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev > wrote: > > Regarding tcp.payload, I don't think tcp.payload in itself has any > problems. I think the issue lies

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-08 Thread Sultan, Hassan via Wireshark-dev
wireshark.org > <mailto:wireshark-dev-boun...@wireshark.org> ] On Behalf Of Sultan, Hassan > via Wireshark-dev > Sent: Wednesday, August 02, 2017 2:09 PM > To: Developer support list for Wireshark <wireshark-dev@wireshark.org > <mailto:wireshark-dev@wireshark.org>

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-08 Thread Alexis La Goutte
Hassan via Wireshark-dev > Sent: Wednesday, August 02, 2017 2:09 PM > To: Developer support list for Wireshark <wireshark-dev@wireshark.org> > Cc: Sultan, Hassan <sul...@amazon.com> > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potent

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-07 Thread Sultan, Hassan via Wireshark-dev
, Hassan via Wireshark-dev Sent: Wednesday, August 02, 2017 2:09 PM To: Developer support list for Wireshark <wireshark-dev@wireshark.org> Cc: Sultan, Hassan <sul...@amazon.com> Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders So if this n

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-03 Thread Sultan, Hassan via Wireshark-dev
shark-dev] Hierarchy of fields & offsets again, more > potential > offenders > > > > 2017-08-02 21:24 GMT+02:00 Pascal Quantin <pascal.quan...@gmail.com > <mailto:pascal.quan...@gmail.com> >: > > > Hi Hassan, > [...] >

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Sultan, Hassan via Wireshark-dev
org> > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potential > offenders > > On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev d...@wireshark.org> wrote: > > Regarding tcp.payload, I don't think tcp.payload in itself has any >

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Stig Bjørlykke
On Wed, Aug 2, 2017 at 10:03 PM, Sultan, Hassan via Wireshark-dev wrote: > Regarding tcp.payload, I don't think tcp.payload in itself has any problems. > I think the issue lies in tcp showing a length of 32 only, even though it has > tcp.payload as its child. The

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Pascal Quantin
PM > > To: Developer support list for Wireshark <wireshark-dev@wireshark.org> > > Cc: Sultan, Hassan <sul...@amazon.com> > > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potential > > offenders > > >

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Sultan, Hassan via Wireshark-dev
August 02, 2017 12:41 PM > To: Developer support list for Wireshark <wireshark-dev@wireshark.org> > Cc: Sultan, Hassan <sul...@amazon.com> > Subject: Re: [Wireshark-dev] Hierarchy of fields & offsets again, more > potential > offenders > > > > 20

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Pascal Quantin
2017-08-02 21:24 GMT+02:00 Pascal Quantin : > Hi Hassan, > > 2017-08-02 1:05 GMT+02:00 Sultan, Hassan via Wireshark-dev < > wireshark-dev@wireshark.org>: > >> Hi all, >> >> So I've started adding checks to my wrapper and am finding some >> interesting cases (they all

Re: [Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-02 Thread Pascal Quantin
Hi Hassan, 2017-08-02 1:05 GMT+02:00 Sultan, Hassan via Wireshark-dev < wireshark-dev@wireshark.org>: > Hi all, > > So I've started adding checks to my wrapper and am finding some > interesting cases (they all look like issues that need to be fixed to me, > but again, I might be missing

[Wireshark-dev] Hierarchy of fields & offsets again, more potential offenders

2017-08-01 Thread Sultan, Hassan via Wireshark-dev
Hi all, So I've started adding checks to my wrapper and am finding some interesting cases (they all look like issues that need to be fixed to me, but again, I might be missing something), would someone please take a look and tell me which you think are ok / bugs so I can start sending patches