Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-19 Thread Bill Meier
Peter Johansson wrote: > > Still, (as I said earlier) I feel that it is not a good idea to go with > the patch that has been applied to oids.c since this will make all > Windows based versions to leak allocated memory. This should not have to > be an issue for users of the officially released

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-19 Thread Peter Johansson
2008/3/19, Andrew Hood <[EMAIL PROTECTED]>: > > Peter Johansson wrote: > > 2008/3/19, Bill Meier <[EMAIL PROTECTED] >: > > > > Guy Harris wrote: > > > > > > If it's not already exported, perhaps the libsmi developers > weren't > > > aware of the wonderful "

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-19 Thread Andrew Hood
Peter Johansson wrote: > 2008/3/19, Bill Meier <[EMAIL PROTECTED] >: > > Guy Harris wrote: > > > > If it's not already exported, perhaps the libsmi developers weren't > > aware of the wonderful "feature" of the Windows development > > environment where

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-19 Thread Stig Bjørlykke
On 19. mars. 2008, at 01.48, Bill Meier wrote: > I suggest implementing the patch now so that this fix can be part of > the > 1.0 release. Committed revision 24693. Marked for pending to 1.0.0. I also opened bug 2372 so we won't forget about it. -- Stig Bjørlykke _

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-19 Thread Peter Johansson
2008/3/18, Stig Bjørlykke <[EMAIL PROTECTED]>: > > > I have no win32 experience to fix this, so if nobody can make this > work correctly I will propose the attached patch. This will leak some > memory on win32, but it's better than not working... > > > -- > Stig Bjørlykke I modified your patch

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-18 Thread Peter Johansson
2008/3/19, Bill Meier <[EMAIL PROTECTED]>: > > Guy Harris wrote: > > > > If it's not already exported, perhaps the libsmi developers weren't > > aware of the wonderful "feature" of the Windows development > > environment wherein a library uses the version of the C runtime > > library with which it'

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-18 Thread Bill Meier
Guy Harris wrote: > > If it's not already exported, perhaps the libsmi developers weren't > aware of the wonderful "feature" of the Windows development > environment wherein a library uses the version of the C runtime > library with which it's built rather than the version with which the >

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-18 Thread Guy Harris
On Mar 16, 2008, at 9:17 PM, Bill Meier wrote: > (Obviously it would be much cleaner if smiFree were available > as part of the API so that it could be used on any > platform. Or: maybe there's another better way . > Possibly we could ask upstream if someth

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-18 Thread Bill Meier
Stig Bjørlykke wrote: > > I have no win32 experience to fix this, so if nobody can make this work > correctly I will propose the attached patch. This will leak some memory > on win32, but it's better than not working... > > > I suggest implementing the patch now so that this fix can be part

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-18 Thread Stig Bjørlykke
I have no win32 experience to fix this, so if nobody can make this work correctly I will propose the attached patch. This will leak some memory on win32, but it's better than not working... -- Stig Bjørlykke oids.c.patch Description: Binary data __

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-17 Thread Graham Bloice
Peter Johansson wrote: > 2008/3/17, Peter Johansson <[EMAIL PROTECTED] > >: > > 2008/3/17, Bill Meier <[EMAIL PROTECTED] > >: > > Peter Johansson wrote: > > 2008/3/13, Luis EG Ontanon <[EMAIL PROTECTED] >

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-17 Thread Peter Johansson
2008/3/17, Peter Johansson <[EMAIL PROTECTED]>: > > 2008/3/17, Bill Meier <[EMAIL PROTECTED]>: > > > > Peter Johansson wrote: > > > 2008/3/13, Luis EG Ontanon <[EMAIL PROTECTED] > >>: > > > > > > On Thu, Mar 13, 2008 at 2:38 PM, Stig Bjørlykke < > > [EMAIL PROTECTED]

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-16 Thread Peter Johansson
2008/3/17, Bill Meier <[EMAIL PROTECTED]>: > > Peter Johansson wrote: > > 2008/3/13, Luis EG Ontanon <[EMAIL PROTECTED] >: > > > > On Thu, Mar 13, 2008 at 2:38 PM, Stig Bjørlykke <[EMAIL PROTECTED] > > > wrote: > > > I suppose we hav

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-16 Thread Bill Meier
Peter Johansson wrote: > 2008/3/13, Luis EG Ontanon <[EMAIL PROTECTED] >: > > On Thu, Mar 13, 2008 at 2:38 PM, Stig Bjørlykke <[EMAIL PROTECTED] > > wrote: > > I suppose we have to leave them allocated if we don't know how > lib

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-16 Thread Peter Johansson
2008/3/16, Jaap Keuter <[EMAIL PROTECTED]>: > > Hi, > > It talks about updated MIBs in 0.4.6, nothing about 0.4.7. No functional > changes/bug fixes are described either. > > Debian testing repository also is on 0.4.5, no activity seen to update the > code here. > > FTP site is unresponsive, so can

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-16 Thread Jaap Keuter
Hi, It talks about updated MIBs in 0.4.6, nothing about 0.4.7. No functional changes/bug fixes are described either. Debian testing repository also is on 0.4.5, no activity seen to update the code here. FTP site is unresponsive, so can't check the tarball myself. Thanx, Jaap Peter Johansson

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-16 Thread Peter Johansson
2008/3/16, Andrew Hood <[EMAIL PROTECTED]>: > > Jaap Keuter wrote: > > Hi, > > > > Could you point us to these newer versions? > > > > Thanx, > > Jaap > > > > ftp://ftp.ibr.cs.tu-bs.de/pub/local/libsmi/libsmi-0.4.7.tar.gz > > -- > There's no point in being grown up if you can't be childish sometime

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-16 Thread Andrew Hood
Jaap Keuter wrote: > Hi, > > Could you point us to these newer versions? > > Thanx, > Jaap > ftp://ftp.ibr.cs.tu-bs.de/pub/local/libsmi/libsmi-0.4.7.tar.gz -- There's no point in being grown up if you can't be childish sometimes. -- Dr. Who

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-16 Thread Jaap Keuter
Hi, Could you point us to these newer versions? Thanx, Jaap Peter Johansson wrote: > 2008/3/15, Andrew Hood <[EMAIL PROTECTED] >: > > Stig Bjørlykke wrote: > > On 13. mars. 2008, at 15.51, Peter Johansson wrote: > > > >> Could this then be of the sam

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-15 Thread Peter Johansson
2008/3/15, Andrew Hood <[EMAIL PROTECTED]>: > > Stig Bjørlykke wrote: > > On 13. mars. 2008, at 15.51, Peter Johansson wrote: > > > >> Could this then be of the same type of issue that is with adns, hence > >> it is required to recompile libsmi too if using another compiler for > >> Wireshark on

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-14 Thread Andrew Hood
Stig Bjørlykke wrote: > On 13. mars. 2008, at 15.51, Peter Johansson wrote: > >> Could this then be of the same type of issue that is with adns, hence >> it is required to recompile libsmi too if using another compiler for >> Wireshark on Windows than MSVC 6. Developer Studio 2005EE for instanc

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-14 Thread Stig Bjørlykke
On 13. mars. 2008, at 15.51, Peter Johansson wrote: Could this then be of the same type of issue that is with adns, hence it is required to recompile libsmi too if using another compiler for Wireshark on Windows than MSVC 6. Developer Studio 2005EE for instance? Does it work correctly on

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-13 Thread Andrew Hood
Luis EG Ontanon wrote: >>Did you compile it using MSVC 6? Could this then be of the same type of >>issue that is with adns, hence it is required to recompile libsmi too if >>using another compiler for Wireshark on Windows than MSVC 6. Developer >>Studio 2005EE for instance? > > > I cannot swear o

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-13 Thread Luis EG Ontanon
> Did you compile it using MSVC 6? Could this then be of the same type of > issue that is with adns, hence it is required to recompile libsmi too if > using another compiler for Wireshark on Windows than MSVC 6. Developer > Studio 2005EE for instance? I cannot swear on it but I would bet high that

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-13 Thread Peter Johansson
2008/3/13, Luis EG Ontanon <[EMAIL PROTECTED]>: > On Thu, Mar 13, 2008 at 2:38 PM, Stig Bjørlykke <[EMAIL PROTECTED]> > wrote: > > I suppose we have to leave them allocated if we don't know how libsmi > > is compiled? > > I have almost no experience on Windows, do we compile this our self? > >

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-13 Thread Luis EG Ontanon
On Thu, Mar 13, 2008 at 2:38 PM, Stig Bjørlykke <[EMAIL PROTECTED]> wrote: > I suppose we have to leave them allocated if we don't know how libsmi > is compiled? > I have almost no experience on Windows, do we compile this our self? I compiled it, I just made changes to the makefile (and build

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-13 Thread Stig Bjørlykke
2008/3/13, Peter Johansson <[EMAIL PROTECTED]>: > The problems are due to the changes applied to oids.c March 5 (SVN 24569), > not from Jan 30 as I said before. Oops. I found this when looking for memory leakage on Ubuntu, and this functions returned malloc'ed memory which was not free'd. I supp

Re: [Wireshark-dev] Problems with epan\oids.c

2008-03-13 Thread Peter Johansson
2008/3/13, Peter Johansson <[EMAIL PROTECTED]>: > > The recent changes (since Jan 30) that have been applied to epan\oids.c > causes problems, at least on Windows. > I ran into the problem today when I thought I should have a go at bug > #2356. > > I opened wireshark-gtk2\wireshark.exe as the solut

[Wireshark-dev] Problems with epan\oids.c

2008-03-13 Thread Peter Johansson
The recent changes (since Jan 30) that have been applied to epan\oids.c causes problems, at least on Windows. I ran into the problem today when I thought I should have a go at bug #2356. I opened wireshark-gtk2\wireshark.exe as the solution to use in Developer Studio 2005 (not EE), just to be able