Re: [Wireshark-dev] New openSAFETY dissector

2011-03-22 Thread Roland Knall
On Sun, Mar 20, 2011 at 2:41 AM, Guy Harris wrote: > > On Mar 18, 2011, at 7:14 AM, Anders Broman wrote: > >> Unfortunatly there is no telling when it will be reviewed though - someone >> will have to find the time to do it. > > I've reviewed it - and already have a version with most of the sugge

Re: [Wireshark-dev] setting up for win32

2011-03-22 Thread Roland Knall
Hi Another issue, at least for me, has been the Windows file endings. In the file win-setup.sh, there are several file-endings written with \r\n, which is Windows specific. The cygwin bash can not handle this file with those endings. Open the file with a text-editor which allows you to change the

Re: [Wireshark-dev] New openSAFETY dissector

2011-03-24 Thread Roland Knall
Hello The dissectory has now been fuzz-tested as well, with nearly 250 MB worth of various capture files. It passed. The updated version of the patch is online. kind regards, Roland ___ Sent via:Wireshark-dev mailing lis

[Wireshark-dev] Modbus/TCP hookup for subdissector

2011-03-25 Thread Roland Knall
Hello As I need it for daily work, I have integrated subdissector code into the Modbus/TCP dissector. Find the patch for this attached to https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5786 But here I have a question. All the information I need for the subdissector is the actual payload of

Re: [Wireshark-dev] Modbus/TCP hookup for subdissector

2011-03-25 Thread Roland Knall
Am 25.03.2011 um 17:06 schrieb Chris Maynard : > Roland Knall writes: > >> 1. Is there a way to provide additional information to the >> subdissector? Someone could use private_data, but that field I need >> somewhere else, therefore can not be used here. > > I

Re: [Wireshark-dev] Modbus/TCP hookup for subdissector

2011-04-01 Thread Roland Knall
.@wireshark.org] On Behalf Of Roland Knall > Sent: den 25 mars 2011 17:10 > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] Modbus/TCP hookup for subdissector > > Am 25.03.2011 um 17:06 schrieb Chris Maynard : > >> Roland Knall writes: >>

Re: [Wireshark-dev] New openSAFETY dissector

2011-04-01 Thread Roland Knall
Guy, could you give me a short update, if the new version of the patch is meeting your expectations, or if there are any parts of it, where I could further improve the patch? kind regards, Roland On Thu, Mar 24, 2011 at 8:01 AM, Roland Knall wrote: > Hello > > The dissectory has now

[Wireshark-dev] Short question for modus operandi

2011-04-13 Thread Roland Knall
Hello I have provided some time ago a patch for submission into wireshark (Bug #5753). Over the course of the next two weeks a new version of this patch would be completed, which would enable the dissector to talk Modbus/TCP as well. But this version would be very preliminary, and not stable for a

Re: [Wireshark-dev] Short question for modus operandi

2011-04-13 Thread Roland Knall
Hi On Wed, Apr 13, 2011 at 5:40 PM, Chris Maynard wrote: > Roland Knall writes: > >> I have provided some time ago a patch for submission into wireshark >> (Bug #5753). Over the course of the next two weeks a new version of >> this patch would be completed, which would

Re: [Wireshark-dev] Wireshark's source question: list devices and their MAC Addresses

2011-04-20 Thread Roland Knall
Hi This would be more suited for Google, but for example: Linux: http://stackoverflow.com/questions/4937529/polling-interface-names-via-siocgifconf-in-linux Windows: http://stackoverflow.com/questions/1070351/getadaptersinfo-and-getadaptersaddressess-bufferlength-param regards, Roland On Wed,

[Wireshark-dev] Adding new protocol to Wireshark SVN

2011-05-18 Thread Roland Knall
Hi Some time ago, I have proposed and provided patches for the support of a new safety protocol called openSAFETY. I've noticed today, that the rc version of 1.6.0 has been locked, so I was wondering, what the chances are, getting this dissector into the new SVN tree. The bug-entry for the dissec

Re: [Wireshark-dev] New openSAFETY dissector

2011-05-31 Thread Roland Knall
Hello On Wed, Jun 1, 2011 at 5:27 AM, Guy Harris wrote: > However, if this is the cause of > >         > http://buildbot.wireshark.org/trunk/builders/Ubuntu-10.04-x64/builds/1452/steps/fuzz-menagerie/logs/stdio > > then that raises the question "why isn't the SERCOS III plugin being loaded > whe

Re: [Wireshark-dev] New openSAFETY dissector

2011-06-01 Thread Roland Knall
A patch for fixing this issue has been submitted via bugzilla: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5977 kind regards, Roland On Wed, Jun 1, 2011 at 7:51 AM, Roland Knall wrote: > Hello > > On Wed, Jun 1, 2011 at 5:27 AM, Guy Harris wrote: >> However, if this

[Wireshark-dev] Adding broadcast messages to a conversation

2011-06-06 Thread Roland Knall
Hello I am currently trying to add conversations to the openSAFETY dissector, and I am running into some behavioural issues. A normal openSAFETY network consists of a Master Node and many Slave Nodes. The relationship of their conversational pattern depends on the state each node is currently in.

[Wireshark-dev] Starting Wireshark SVN Version - warning about plugin

2011-06-08 Thread Roland Knall
Hi When I start the latest wireshark (#37614), I get the warning "The plugin libwiretap.so has no version symbol" Same for libwsutil.so and libwireshark.so Anyone got an idea, what causes the issue? Sitting here on a Ubuntu 11.04 64-bit machine. kind regards, Roland ___

Re: [Wireshark-dev] build issue on new ubuntu machine prefs_dlg.c: In function ?pref_check?

2011-06-08 Thread Roland Knall
Hi Works like a charm on my PC, which is a Ubuntu 11.04 - 64bit. But only without -werror. Interestingly enough, my build fails when building iax2_analysis.c also with unused_result warning. Btw, I would recommend the cmake interface, which I normally use. But I tested using your steps, and they

Re: [Wireshark-dev] wireshark svn build is broken due to : warnings being treated as errors

2011-06-10 Thread Roland Knall
Hi Is on purpose. Remove -werror (search the wiki or devlist) to compile. kind regards, Roland 2011/6/10 Toralf Förster : > Happens since few days now : > > ... > cc1: warnings being treated as errors > iax2_analysis.c: In function ‘iax2_packet_save_payload’: > iax2_analysis.c:715: error: ignori

Re: [Wireshark-dev] plugins to builtins

2011-06-19 Thread Roland Knall
Hi Personally, I would prefer changing more or all plugins into built-in dissectors. It would help those dissectors, who have to use functionality only provided by a plug-in, as the whole openSAFETY-SercosIII mix-up showed. My next favorite would be the ProfiNet plug-in. If no one else would like

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Roland Knall
> specifically as 'the original plugin'[1] > > So, the standing Best Common Practice is to roll simple dissectors (usually > single source file) into the build in set, while keeping the complicated, > more messy stuff isolated in their own little space called plugin. > > T

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Roland Knall
Hi There is nothing technically wrong with dissectors being developed as plugins. There might be some technical questions that arise from that fact, if another dissector is using them, but for now, those issues seemed to be dealt with correctly (for reference see the whole openSAFETY vs. SercosIII

Re: [Wireshark-dev] plugins to builtins

2011-06-21 Thread Roland Knall
Hi On Tue, Jun 21, 2011 at 1:55 AM, Ulf Lamping wrote: > Am 21.06.2011 00:27, schrieb Roland Knall: >> There is nothing technically wrong with dissectors being developed as >> plugins. There might be some technical questions that arise from that >> fact, if another dissect

[Wireshark-dev] Profinet: remaining register_dissector_filter

2011-06-21 Thread Roland Knall
Hi Just wandering around code, and came across the function register_dissector_filter The Profinet plugin is the only code, where this function is apparently in use, but I can not see any immediate use for it? Can it be safely removed, or is the plugin dependant on it? kind regards, Roland

Re: [Wireshark-dev] Procedure to compile wireshark dissector on linux

2011-07-11 Thread Roland Knall
Hi Way easier method: Checkout the SVN version, or any source download into one dir called src. Create a same directory called build on the same level, so that your directory looks like that: - src - - build then goto build, and call cmake ../src cmake is a software distributed with al

Re: [Wireshark-dev] stable release 1.6.1 is core dumped on Fedora 13, 15

2011-08-04 Thread Roland Knall
There should be a file called core in the directory you called Wireshark from. Please send this file. Regards Roland Am 04.08.2011 um 18:25 schrieb Ngo Hoang Thang : Hi bros, After building release 1.6.1 successful, I run "./wireshark" (not install) And it presents: *ERROR:packet.c:1531:heur_

Re: [Wireshark-dev] stable release 1.6.1 is core dumped on Fedora 13, 15

2011-08-04 Thread Roland Knall
An exception in packet.c can be nearly anything. The backtrace is what I am looking for, as it would tell which dissector caused the underlying issue. Roland Am 04.08.2011 um 21:23 schrieb Guy Harris : > > On Aug 4, 2011, at 10:47 AM, Roland Knall wrote: > >> There should b

Re: [Wireshark-dev] Built-in dissector depends on a plugin dissector in 1.6.x

2011-09-07 Thread Roland Knall
Hi The problem could be solved, by explicitly checking, if the plugin exists, but I would prefer adding the solution already added to the trunk, meaning, moving the sercosiii plugin to a built-in dissector. otherwise, if preferred, i could provide a small patch to fix the problem temporarily. re

Re: [Wireshark-dev] OpenSafety bug - how to fix?

2011-09-20 Thread Roland Knall
The fix is correct. Are there any other Coverty hits for openSafety, or just the one? Regards, Roland Am 20.09.2011 um 15:53 schrieb Chris Maynard : > Coverity reports the following in CID 1204 against the OpenSafety dissector: > > 1466firstByte = ( tvb_get_guint8(message_tvb, 0) <

Re: [Wireshark-dev] catching [Malformed Packet]

2011-09-24 Thread Roland Knall
On a similar topic, how can you mark a package as malformed? Especially generated packages often fail the openSAFETY dissector, and marking them as malformed seems to make sense in such cases. Roland Am 24.09.2011 um 18:21 schrieb Chris Maynard : > writes: > >> Is it possible to setup a displ

Re: [Wireshark-dev] catching [Malformed Packet]

2011-09-24 Thread Roland Knall
On Sat, Sep 24, 2011 at 9:09 PM, Guy Harris wrote: > > On Sep 24, 2011, at 9:58 AM, Chris Maynard wrote: > >> Roland Knall writes: >> >>> On a similar topic, how can you mark a package as malformed? >>> Especially generated packages often fail the openSA

Re: [Wireshark-dev] OpenSafety bug - how to fix?

2011-09-28 Thread Roland Knall
Patch has been submitted https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6400 regards, Roland On Tue, Sep 20, 2011 at 7:39 PM, Chris Maynard wrote: > Roland Knall writes: > >> >> The fix is correct. Are there any other Coverty hits for openSafety, >> or jus

Re: [Wireshark-dev] Is it still ok to create hidden items ?

2011-10-31 Thread Roland Knall
Hi As I just came across something regarding this issue, there is a counter argument to the whole "if it is not there, the user may not find it" idea. Looking at the way the IP dissector is used, hidden fields have their merits. ip.addr is a more generic way of avoiding ( ip.src == x || ip.dest ==

Re: [Wireshark-dev] Is it still ok to create hidden items ?

2011-10-31 Thread Roland Knall
ote: > Hi, > I'd say using a generated field is more elegant :-) > /Anders > > -Original Message- > From: wireshark-dev-boun...@wireshark.org > [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Roland Knall > Sent: den 31 oktober 2011 10:51 > To

Re: [Wireshark-dev] ERROR:packet.c:1531:heur_dissector_add: assertion failed: (sub_dissectors != NULL) Aborted

2011-11-02 Thread Roland Knall
Hi Could you please just write, how you want to start wireshark? Have you downloaded it from the net, or did you compile the svn version? Usually the message can appear, if wireshark is not able to load the plugins correctly. If you have compiled wireshark for Linux yourself, you usually can avoi

Re: [Wireshark-dev] ERROR:packet.c:1531:heur_dissector_add: assertion failed: (sub_dissectors != NULL) Aborted

2011-11-02 Thread Roland Knall
@Jaap Normally I would agree, but if you are using 1.6.x and wireshark can not find it's plug-ins, the message can be thrown by the openSAFETY dissector. It is fixed in svn, and the fix for 1.6.x is waiting in bugzilla. regards, Roland On Wed, Nov 2, 2011 at 12:25 PM, Jaap Keuter wrote: > Hi,

Re: [Wireshark-dev] ERROR:packet.c:1531:heur_dissector_add: assertion failed: (sub_dissectors != NULL) Aborted

2011-11-02 Thread Roland Knall
#x27;t provide much context, so him writing to -dev leaded me to > believe he's hacking himself. > We just won't know until he tells us. > > PS: what's the bug number for the bugzilla entry regarding this issue? > > Thanks, > Jaap > > On Wed, 2 Nov 2011 12

Re: [Wireshark-dev] ERROR:packet.c:1531:heur_dissector_add: assertion failed: (sub_dissectors != NULL) Aborted

2011-11-02 Thread Roland Knall
Ok, some more information How do you write the dissector, in epan/dissectors or as a plugin? Which version of wireshark are you using? Just trunk, or a specific release version (e.g. trunk-1.6)? But my guess would be, that you either you built your dissector as a plugin, or the versions of wiresh

Re: [Wireshark-dev] ERROR:packet.c:1531:heur_dissector_add: assertion failed: (sub_dissectors != NULL) Aborted

2011-11-02 Thread Roland Knall
011 13:18:53 +0100, Roland Knall wrote: >> >> Ok, some more information >> >> How do you write the dissector, in epan/dissectors or as a plugin? >> Which version of wireshark are you using? Just trunk, or a specific >> release version (e.g. trunk-1.6)? >> >&g

[Wireshark-dev] Question regarding QT/future Wireshark version

2012-01-05 Thread Roland Knall
Hi Great job so far on the QT version. Although there is clearly some way to go still, I think it is a step in the right direction. I do have a question though. Is there a point in the forseeable future, where new development for the GTK version will cease to exist (and just focus on bug-fixing)

Re: [Wireshark-dev] Question regarding QT/future Wireshark version

2012-01-06 Thread Roland Knall
On Fri, Jan 6, 2012 at 1:46 AM, Gerald Combs wrote: > On 1/5/12 12:22 PM, Guy Harris wrote: >> If the add-ons are in the dissecting code, there's no GUI code there; >> Wireshark handles the GUI display, and TShark handles the text output.  I >> doubt that we'll be linking TShark with Qt, so I do

Re: [Wireshark-dev] Question regarding QT/future Wireshark version

2012-01-11 Thread Roland Knall
Hi On Wed, Jan 11, 2012 at 10:38 AM, Guy Harris wrote: > > On Jan 6, 2012, at 6:15 AM, Roland Knall wrote: > >> Ok, let me clarify the idea. Let's for instance say, that you want to >> have a graphical representation of the inner-workings of a >> communication

Re: [Wireshark-dev] Question regarding QT/future Wireshark version

2012-01-11 Thread Roland Knall
On Wed, Jan 11, 2012 at 11:25 AM, Guy Harris wrote: > > On Jan 11, 2012, at 2:02 AM, Roland Knall wrote: >> The same goes for the "Conversation List", "IO Graph" as well as the >> "Endpoint List". Also, following a specific conversation could be &

[Wireshark-dev] Updating fuzz-menagerie?

2012-02-08 Thread Roland Knall
Hi Short question, two actually. First, there are some entries in the fuzz-menagerie, which do not work, as they are patches. Shouldn't they be removed from the test all together? And my second question, I have added some example capture files to http://wiki.wireshark.org/SampleCaptures#openSAFETY

[Wireshark-dev] How to import the sample captures from SampleCaptures to the menagerie?

2012-02-17 Thread Roland Knall
Hi Uploaded 3 sample captures to the SampleCaptures page on wiki last week. Now some days later, the captures are not appearing in the buildbot waterfall for the CLANG buildbot. I am wondering if I made some mistake, or named the files wrong. Could someone who has access to the system check it ou

Re: [Wireshark-dev] Building 64 vs. 32-bit question

2012-05-09 Thread Roland Knall
On Wed, May 9, 2012 at 4:55 PM, Beth wrote: > I know there is a target type selection at the top of config.nmake, does > that apply to everything being built?  E.g. > not only the wireshark.exe and other apps, but the plugins as well?  (Is > there a way to set different targets for plugins?) Shor

[Wireshark-dev] Problem getting Eclipse working

2012-06-28 Thread Roland Knall
Hi Little off-topic. Wireshark Development is kind of fried on my PC, as I cannot get Eclipse to acknowledge the GLib datatypes. Could someone who is using Eclipse under Linux and has a working project with C/C++ indexeer send me his include path list? Rebuilding, recreating, all things tried a

Re: [Wireshark-dev] license question

2012-07-22 Thread Roland Knall
Hi It is good practice and a positive example, if you upload the code or provide it to the main distribution. But nothing prevents you in the GPL to distribute your work to your client, and ask him to pay for it, as long as you provide the sourcecode with the compiled version of the plugin. You do

Re: [Wireshark-dev] RFD: Creating subdirectories in epan/dissectors/

2012-08-30 Thread Roland Knall
Hi Would you like to enforce a value for the minimum number of subsequent files in the subdirectories? As I wrote the opensafety package, I would like to split it up a little bit to make it more maintainable, as well as include two new subdissectors, which use the openSAFETY protocol, but are not

Re: [Wireshark-dev] Qt compilation.

2012-11-07 Thread Roland Knall
Hi Try not to run cmake but instead run cmake-gui, using the same parameters. Additionally, it is useful to create a separate build directory. therefore, build-files wil not clutter up the src space. So, checkout wireshark, make a goto wireshark, create a directory named "build" cd into it and ca

Re: [Wireshark-dev] Fwd: Google Summer of Code 2013

2013-02-14 Thread Roland Knall
Hi I do actually have several ideas, all surrounding the two dissectors for POWERLINK (epl_v2) and openSAFETY (openSAFETY). First, let me explain, I am working for the Austrian company, which invented both protocols and is pushing it behind the user organization EPSG, among several others. I am a

[Wireshark-dev] Google Summer of Code

2013-02-27 Thread Roland Knall
Hi As the last discussion towards the GSoC application resulted in a rather long off-topic discussion, I want to restart it. Is there a way / method / wiki-page where we could collect all ideas, and have a vote on them? Therefore we could at least collect some ideas, and if we reach a certain num

Re: [Wireshark-dev] Google Summer of Code

2013-02-27 Thread Roland Knall
Thanks, I will add my stuff today kind regards, Roland On Thu, Feb 28, 2013 at 7:39 AM, Gerald Combs wrote: > On 2/27/13 6:06 PM, Roland Knall wrote: >> Hi >> >> As the last discussion towards the GSoC application resulted in a >> rather long off-topic discussion, I w

Re: [Wireshark-dev] Fwd: Now Accepting Applications for Mentoring Organizations for GSoC 2013

2013-03-23 Thread Roland Knall
Hi I could act as backup as well, if no one else steps up. I will also amend the wiki page today with my projects. Kind regards, Roland Am Samstag, 23. März 2013 schrieb Alexis La Goutte : > > > On Mon, Mar 18, 2013 at 9:57 PM, Gerald Combs > > > wrote: > >> Google has opened up applications

[Wireshark-dev] Source Build using Mac OSX?

2013-03-23 Thread Roland Knall
Hi Can someone point me in the right direction on how to build wireshark successfully using Mountain Lion? So far I am failing spectacularly. Using MacPorts for the necessary libraries and dev-dependencies, and deactivating everything I can not compile (Airpcap amongst those) I tried using cmake

Re: [Wireshark-dev] Source Build using Mac OSX?

2013-03-23 Thread Roland Knall
; > On Mar 23, 2013, at 7:51 AM, Roland Knall wrote: > >> Can someone point me in the right direction on how to build wireshark >> successfully using Mountain Lion? So far I am failing spectacularly. >> Using MacPorts for the necessary libraries and dev-dependencies, and >>

[Wireshark-dev] Question for data argument of dissector_try_heuristic

2013-03-25 Thread Roland Knall
Hi Under Mac OS X some warnings came up, and among them is a repeated warning about an unused *data parameter for every call to a heuristic dissector. As I do use the heuristic dissector, but do not use the data argument, I looked up every occurence, where dissection is passed to a heuristic disse

[Wireshark-dev] Request for submission

2013-04-04 Thread Roland Knall
Hello Could I please kindly ask some of the main developers to commit the patch in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8505 ? Evan Huus, who kindly lend me an ear in getting the patch ready is busy at the moment with exams, but has already cleared the patch. All there is left to

Re: [Wireshark-dev] Request for submission

2013-04-09 Thread Roland Knall
Thu, Apr 4, 2013 at 2:50 PM, Roland Knall wrote: >> Hello >> >> Could I please kindly ask some of the main developers to commit the >> patch in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8505 ? >> Evan Huus, who kindly lend me an ear in getting the patch re

Re: [Wireshark-dev] Request for submission

2013-04-10 Thread Roland Knall
Ok, > > Who has time to review this 100kB patch? > > Thanks, > Jaap > > On 04/09/2013 03:00 PM, Roland Knall wrote: > > Hi > > > > Could I please bump my request one more time on the buglist? I am > > starting to work on some topics for new features on the

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Roland Knall
Hi As I am somewhat converse in cmake, I can give you a few pointers, if you like. In general for each package a cmake system should look for, a Find.cmake file should exist in either one of two places: - The local directory (in wireshark underneath /cmake/modules/Find - Or the global cmake

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Roland Knall
013 at 11:35 AM, Graham Bloice wrote: > > On 26 June 2013 10:10, Roland Knall wrote: >> >> Hi >> >> As I am somewhat converse in cmake, I can give you a few pointers, if you >> like. >> >> In general for each package a cmake system should look for,

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Roland Knall
tically in such a case. kind regards Roland On Wed, Jun 26, 2013 at 1:31 PM, Graham Bloice wrote: > On 26 June 2013 11:29, Graham Bloice wrote: >> >> On 26 June 2013 11:07, Roland Knall wrote: >>> >>> Hi >>> >>> GLOB and GLOB_RECURSE should norm

<    1   2   3   4   5