Re: PowerPC Icon Fix Patch [wmaker-crm]

2012-01-16 Thread Carlos R. Mafra
On Mon, 16 Jan 2012 at 19:22:14 -0500, GhostlyDeath wrote: > On my PowerPC Debian Squeeze System, the icons are colored > incorrectly. This patch removes the swapping of the data on Big Endian > systems, thus causing the icons to be colored correctly. > > Please check the patch on your big endian

PowerPC Icon Fix Patch [wmaker-crm]

2012-01-16 Thread GhostlyDeath
On my PowerPC Debian Squeeze System, the icons are colored incorrectly. This patch removes the swapping of the data on Big Endian systems, thus causing the icons to be colored correctly. Please check the patch on your big endian systems and see if it either fixes or breaks things. It may only be a

Re: [PATCH] wtext killing spree

2012-01-16 Thread Rodolfo kix Garcia
On 16/01/12 18:22, Carlos R. Mafra wrote: > On Mon, 16 Jan 2012 at 19:06:07 +0200, Rodolfo kix Garcia wrote: >>> >>> So the end result of being able to rename workspaces using non-ascii >>> characters using WINGs is that 600 lines of code can be removed in >>> two patches! >> >> Probably is a good

Re: [PATCH] wtext killing spree

2012-01-16 Thread Carlos R. Mafra
On Mon, 16 Jan 2012 at 19:06:07 +0200, Rodolfo kix Garcia wrote: > > > >So the end result of being able to rename workspaces using non-ascii > >characters using WINGs is that 600 lines of code can be removed in > >two patches! > > Probably is a good option. I like it. Less code, less problems. Av

Re: [PATCH] wtext killing spree

2012-01-16 Thread Rodolfo kix Garcia
On Mon, 16 Jan 2012 16:22:49 +, Carlos R. Mafra wrote: On Mon, 16 Jan 2012 at 8:31:33 +0100, Rodolfo kix Garcia wrote: IMO the new code is better than the current code, and we remove "low-level" code (X11 functions like XGrab,...) , therefore I like this change. I've just noticed that

[PATCH] wtext killing spree

2012-01-16 Thread Carlos R. Mafra
On Mon, 16 Jan 2012 at 8:31:33 +0100, Rodolfo kix Garcia wrote: > > IMO the new code is better than the current code, and we remove > "low-level" code (X11 functions like XGrab,...) , therefore I like this > change. I've just noticed that it's possible to get rid of src/wtext.[ch] if we use WING

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-16 Thread Rodolfo kix Garcia
On Mon, 16 Jan 2012 12:51:50 +, Carlos R. Mafra wrote: On Mon, 16 Jan 2012 at 8:31:33 +0100, Rodolfo kix Garcia wrote: > [snip] > + char buffer[128]; I don't like this things, I prefer "char buffer[DOCK_NAME_LEN]" and set DOCK_NAME_LEN in dock.h Probably we should find i

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-16 Thread Carlos R. Mafra
On Mon, 16 Jan 2012 at 8:31:33 +0100, Rodolfo kix Garcia wrote: > > > [snip] > > + char buffer[128]; > > > I don't like this things, I prefer "char buffer[DOCK_NAME_LEN]" and set > DOCK_NAME_LEN in dock.h Probably we should find if this length is used > in other places in the

Re: [PATCH 5/6] getstyle: Get rid of abortar()

2012-01-16 Thread Carlos R. Mafra
On Mon, 16 Jan 2012 at 13:43:35 +0200, Rodolfo kix Garcia wrote: > On Sun, 15 Jan 2012 22:47:00 +0100, Paul Seelig wrote: > >On 01/15/2012 08:22 PM, Carlos R. Mafra wrote: > >>Is there a way to see them? If not, isn't this something we should > >>do something about? -- like writing those warnings t

Re: [PATCH 5/6] getstyle: Get rid of abortar()

2012-01-16 Thread Rodolfo kix Garcia
On Sun, 15 Jan 2012 22:47:00 +0100, Paul Seelig wrote: On 01/15/2012 08:22 PM, Carlos R. Mafra wrote: Is there a way to see them? If not, isn't this something we should do something about? -- like writing those warnings to ~/GNUstep/warnings.txt or something? Both in Debian and Ubuntu, but a

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-16 Thread Rodolfo kix Garcia
On 16/01/12 08:31, Rodolfo kix Garcia wrote: > On 16/01/12 06:56, Carlos R. Mafra wrote: > >> On Tue, 10 Jan 2012 at 0:34:53 +0100, Rodolfo kix Garcia wrote: >>> >>> Why we can change the name using right click on the Clip. Why? because >>> the clip is using the functions of WINGs. Can we change