Hi,
Carlos, don't apply these patches.
Patch 1 only: wmaker crash.
Patches 1+2: wmaker crash.
Patches 1+2+3: wmaker crash.
Patches 1+2+3+4: The workspace list is not updated when change to
workspace 1. No problem with other workspaces.
Problems 1,2,3 with my original patches worked. I need check
From: "Rodolfo García Peñas (kix)"
This patch checks if the menu entries exist in the function
wWorkspaceRestoreState. scr->workspace_menu could be "not NULL"
and therefore it crash if the entries don't exits. So we
need check it first. I used the variable "menu" to make the lines
shorter and cl
From: "Rodolfo García Peñas (kix)"
This patch adds a comment and removes son extra curly brackets.
---
src/workspace.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/workspace.c b/src/workspace.c
index 29aab12..a9a978b 100644
--- a/src/workspace.c
+++ b/src/wor
From: "Rodolfo García Peñas (kix)"
When the screen is created, it creates the initial
workspace. This workspace could not be created, because
is not used. The workspaces are created later, so we can
avoid to create this initial workspace here.
This is good because this initial workspace creates
From: "Rodolfo García Peñas (kix)"
The function wWorkspaceMenuUpdate() udpates the menu entries
using the scr->current_workspace variable. The problem is that
variable could be NULL, so wmaker will crash.
This patch include a new check to verify that scr->current_workspace
exists before use it.
On 20/04/2013 16:14, Rodolfo García Peñas (kix) wrote:
> From: "Rodolfo García Peñas (kix)"
>
> When the screen is created, it creates the initial
> workspace. This workspace could not be created, because
> is not used. The workspaces are created later, so we can
F*ck!!%4$1~
forget this ser
From: "Rodolfo García Peñas (kix)"
This patch checks if the menu entries exist in the function
wWorkspaceRestoreState. scr->workspace_menu could be "not NULL"
and therefore it crash if the entries don't exits. So we
need check it first. I used the variable "menu" to make the lines
shorter and cl
From: "Rodolfo García Peñas (kix)"
This patch adds a comment and removes son extra curly brackets.
---
src/workspace.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/workspace.c b/src/workspace.c
index 29aab12..a9a978b 100644
--- a/src/workspace.c
+++ b/src/wor
From: "Rodolfo García Peñas (kix)"
When the screen is created, it creates the initial
workspace. This workspace could not be created, because
is not used. The workspaces are created later, so we can
avoid to create this initial workspace here.
This is good because this initial workspace creates
On Sat, 20 Apr 2013 at 15:57:16 +0200, "Rodolfo García Peñas (kix)" wrote:
> On 20/04/2013 15:33, Carlos R. Mafra wrote:
> > On Sat, 20 Apr 2013 at 14:05:00 +0200, Rodolfo García Peñas (kix) wrote:
> >> From: "Rodolfo García Peñas (kix)"
> >>
> >> This patch avoid update (create) the Workspace Men
On 20/04/2013 15:33, Carlos R. Mafra wrote:
> On Sat, 20 Apr 2013 at 14:05:00 +0200, Rodolfo García Peñas (kix) wrote:
>> From: "Rodolfo García Peñas (kix)"
>>
>> This patch avoid update (create) the Workspace Menu when wmaker
>> is starting. When wmaker is starting, the scr->current_workspace
>>
On Sat, 20 Apr 2013 at 14:05:00 +0200, Rodolfo García Peñas (kix) wrote:
> From: "Rodolfo García Peñas (kix)"
>
> This patch avoid update (create) the Workspace Menu when wmaker
> is starting. When wmaker is starting, the scr->current_workspace
> is NULL, so we can check it in wWorkspaceMenuUpdat
From: "Rodolfo García Peñas (kix)"
When the screen is created, it creates the initial
workspace. This workspace could not be created, because
is not used. The workspaces are created later, so we can
avoid to create this initial workspace here.
This is good because this initial workspace creates
From: "Rodolfo García Peñas (kix)"
The function wWorkspaceMenuUpdate() udpates the menu entries
using the scr->current_workspace variable. The problem is that
variable could be NULL, so wmaker will crash.
This patch include a new check to verify that scr->current_workspace
exists before use it.
On Sat, 20 Apr 2013, Rodolfo kix Garcia escribió:
> From: "Rodolfo García Peñas (kix)"
>
> The new function create_new_workspace() creates a workspace when
> the user request it, using the menu, or using the clip button to
> the next workspace and is in the last and the flag to create a new
> wo
On Sat, 20 Apr 2013, Carlos R. Mafra escribió:
> On Sat, 20 Apr 2013 at 14:04:59 +0200, Rodolfo García Peñas (kix) wrote:
> > From: "Rodolfo García Peñas (kix)"
> >
> > When the screen is created, it creates the initial
> > workspace. This workspace could not be created, because
> > is not used.
On Sat, 20 Apr 2013 at 14:04:59 +0200, Rodolfo García Peñas (kix) wrote:
> From: "Rodolfo García Peñas (kix)"
>
> When the screen is created, it creates the initial
> workspace. This workspace could not be created, because
> is not used. The workspaces are created later, so we can
> avoid to crea
On Sat, 20 Apr 2013 at 14:04:59 +0200, Rodolfo García Peñas (kix) wrote:
> From: "Rodolfo García Peñas (kix)"
>
> When the screen is created, it creates the initial
> workspace. This workspace could not be created, because
> is not used. The workspaces are created later, so we can
> avoid to crea
From: "Rodolfo García Peñas (kix)"
This patch removes the icon Creation in wWorkspaceNew. Then, the icon
creation is done in the function where wWorkspaceNew() is called.
wWorkspaceNew() is used in three functions:
- wWorkspaceMake: Used to create multiple workspaces.
- create_new_workspace: Us
From: "Rodolfo García Peñas (kix)"
The new function create_new_workspace() creates a workspace when
the user request it, using the menu, or using the clip button to
the next workspace and is in the last and the flag to create a new
workspace is selected.
Then, the code in the functions newWSComm
From: "Rodolfo García Peñas (kix)"
The function update_workspace_clip() can get the Clip proplist using
their own wks_state. So, the WProplist argument could be removed.
---
src/workspace.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/src/workspace.c
From: "Rodolfo García Peñas (kix)"
The code to restore the Clip is moved to a standalone function.
The code is the same, and some variables are provided as arguments.
---
src/workspace.c | 105 +++
1 file changed, 59 insertions(+), 46 deletion
From: "Rodolfo García Peñas (kix)"
When the screen is created, it creates the initial
workspace. This workspace could not be created, because
is not used. The workspaces are created later, so we can
avoid to create this initial workspace here.
This is good because this initial workspace creates
From: "Rodolfo García Peñas (kix)"
These patches creates the Clip only when is needed. This series replaces
the old patch number 6, but is more clear.
This series first removes the multiple calls to the workspace creation
function wWorkspaceNew(), moving it to the workspace.c file. Now the
funct
From: "Rodolfo García Peñas (kix)"
This patch avoid update (create) the Workspace Menu when wmaker
is starting. When wmaker is starting, the scr->current_workspace
is NULL, so we can check it in wWorkspaceMenuUpdate() and do nothing.
--8<--
25 matches
Mail list logo