Re: [PATCH 1/4] wWorkspaceMenuUpdate checks current_workspace

2013-04-20 Thread Rodolfo García Peñas (kix)
Hi, Carlos, don't apply these patches. Patch 1 only: wmaker crash. Patches 1+2: wmaker crash. Patches 1+2+3: wmaker crash. Patches 1+2+3+4: The workspace list is not updated when change to workspace 1. No problem with other workspaces. Problems 1,2,3 with my original patches worked. I need check

[PATCH 4/4] Check if menu entries exist

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" This patch checks if the menu entries exist in the function wWorkspaceRestoreState. scr->workspace_menu could be "not NULL" and therefore it crash if the entries don't exits. So we need check it first. I used the variable "menu" to make the lines shorter and cl

[PATCH 3/4] workspace.c small code clean

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" This patch adds a comment and removes son extra curly brackets. --- src/workspace.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/workspace.c b/src/workspace.c index 29aab12..a9a978b 100644 --- a/src/workspace.c +++ b/src/wor

[PATCH 2/4] Screen initialization doesn't create workspace

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" When the screen is created, it creates the initial workspace. This workspace could not be created, because is not used. The workspaces are created later, so we can avoid to create this initial workspace here. This is good because this initial workspace creates

[PATCH 1/4] wWorkspaceMenuUpdate checks current_workspace

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" The function wWorkspaceMenuUpdate() udpates the menu entries using the scr->current_workspace variable. The problem is that variable could be NULL, so wmaker will crash. This patch include a new check to verify that scr->current_workspace exists before use it.

Re: [PATCH 1/3] Screen initialization doesn't create workspace

2013-04-20 Thread Rodolfo García Peñas (kix)
On 20/04/2013 16:14, Rodolfo García Peñas (kix) wrote: > From: "Rodolfo García Peñas (kix)" > > When the screen is created, it creates the initial > workspace. This workspace could not be created, because > is not used. The workspaces are created later, so we can F*ck!!%4$1~ forget this ser

[PATCH 3/3] Check if menu entries exist

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" This patch checks if the menu entries exist in the function wWorkspaceRestoreState. scr->workspace_menu could be "not NULL" and therefore it crash if the entries don't exits. So we need check it first. I used the variable "menu" to make the lines shorter and cl

[PATCH 2/3] workspace.c small code clean

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" This patch adds a comment and removes son extra curly brackets. --- src/workspace.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/workspace.c b/src/workspace.c index 29aab12..a9a978b 100644 --- a/src/workspace.c +++ b/src/wor

[PATCH 1/3] Screen initialization doesn't create workspace

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" When the screen is created, it creates the initial workspace. This workspace could not be created, because is not used. The workspaces are created later, so we can avoid to create this initial workspace here. This is good because this initial workspace creates

Re: [PATCH 2/6] Avoid create WorkspaceMenuUpdate on wmaker start

2013-04-20 Thread Carlos R. Mafra
On Sat, 20 Apr 2013 at 15:57:16 +0200, "Rodolfo García Peñas (kix)" wrote: > On 20/04/2013 15:33, Carlos R. Mafra wrote: > > On Sat, 20 Apr 2013 at 14:05:00 +0200, Rodolfo García Peñas (kix) wrote: > >> From: "Rodolfo García Peñas (kix)" > >> > >> This patch avoid update (create) the Workspace Men

Re: [PATCH 2/6] Avoid create WorkspaceMenuUpdate on wmaker start

2013-04-20 Thread Rodolfo García Peñas (kix)
On 20/04/2013 15:33, Carlos R. Mafra wrote: > On Sat, 20 Apr 2013 at 14:05:00 +0200, Rodolfo García Peñas (kix) wrote: >> From: "Rodolfo García Peñas (kix)" >> >> This patch avoid update (create) the Workspace Menu when wmaker >> is starting. When wmaker is starting, the scr->current_workspace >>

Re: [PATCH 2/6] Avoid create WorkspaceMenuUpdate on wmaker start

2013-04-20 Thread Carlos R. Mafra
On Sat, 20 Apr 2013 at 14:05:00 +0200, Rodolfo García Peñas (kix) wrote: > From: "Rodolfo García Peñas (kix)" > > This patch avoid update (create) the Workspace Menu when wmaker > is starting. When wmaker is starting, the scr->current_workspace > is NULL, so we can check it in wWorkspaceMenuUpdat

[PATCH 2/2] Screen initialization doesn't create workspace

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" When the screen is created, it creates the initial workspace. This workspace could not be created, because is not used. The workspaces are created later, so we can avoid to create this initial workspace here. This is good because this initial workspace creates

[PATCH 1/2] wWorkspaceMenuUpdate checks current_workspace

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" The function wWorkspaceMenuUpdate() udpates the menu entries using the scr->current_workspace variable. The problem is that variable could be NULL, so wmaker will crash. This patch include a new check to verify that scr->current_workspace exists before use it.

Re: [PATCH 5/6] New function create_new_workspace

2013-04-20 Thread Rodolfo García Peñas
On Sat, 20 Apr 2013, Rodolfo kix Garcia escribió: > From: "Rodolfo García Peñas (kix)" > > The new function create_new_workspace() creates a workspace when > the user request it, using the menu, or using the clip button to > the next workspace and is in the last and the flag to create a new > wo

Re: [PATCH 1/6] Screen initialization doesn't create workspace

2013-04-20 Thread Rodolfo García Peñas
On Sat, 20 Apr 2013, Carlos R. Mafra escribió: > On Sat, 20 Apr 2013 at 14:04:59 +0200, Rodolfo García Peñas (kix) wrote: > > From: "Rodolfo García Peñas (kix)" > > > > When the screen is created, it creates the initial > > workspace. This workspace could not be created, because > > is not used.

Re: [PATCH 1/6] Screen initialization doesn't create workspace

2013-04-20 Thread Carlos R. Mafra
On Sat, 20 Apr 2013 at 14:04:59 +0200, Rodolfo García Peñas (kix) wrote: > From: "Rodolfo García Peñas (kix)" > > When the screen is created, it creates the initial > workspace. This workspace could not be created, because > is not used. The workspaces are created later, so we can > avoid to crea

Re: [PATCH 1/6] Screen initialization doesn't create workspace

2013-04-20 Thread Carlos R. Mafra
On Sat, 20 Apr 2013 at 14:04:59 +0200, Rodolfo García Peñas (kix) wrote: > From: "Rodolfo García Peñas (kix)" > > When the screen is created, it creates the initial > workspace. This workspace could not be created, because > is not used. The workspaces are created later, so we can > avoid to crea

[PATCH 6/6] Create clip only if needed

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" This patch removes the icon Creation in wWorkspaceNew. Then, the icon creation is done in the function where wWorkspaceNew() is called. wWorkspaceNew() is used in three functions: - wWorkspaceMake: Used to create multiple workspaces. - create_new_workspace: Us

[PATCH 5/6] New function create_new_workspace

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" The new function create_new_workspace() creates a workspace when the user request it, using the menu, or using the clip button to the next workspace and is in the last and the flag to create a new workspace is selected. Then, the code in the functions newWSComm

[PATCH 4/6] update_workspace_clip handles the Clip proplist

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" The function update_workspace_clip() can get the Clip proplist using their own wks_state. So, the WProplist argument could be removed. --- src/workspace.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/workspace.c

[PATCH 3/6] Clip restore moved out of the Workspace Restore

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" The code to restore the Clip is moved to a standalone function. The code is the same, and some variables are provided as arguments. --- src/workspace.c | 105 +++ 1 file changed, 59 insertions(+), 46 deletion

[PATCH 1/6] Screen initialization doesn't create workspace

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" When the screen is created, it creates the initial workspace. This workspace could not be created, because is not used. The workspaces are created later, so we can avoid to create this initial workspace here. This is good because this initial workspace creates

[PATCH 0/6] Create clip only if needed

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" These patches creates the Clip only when is needed. This series replaces the old patch number 6, but is more clear. This series first removes the multiple calls to the workspace creation function wWorkspaceNew(), moving it to the workspace.c file. Now the funct

[PATCH 2/6] Avoid create WorkspaceMenuUpdate on wmaker start

2013-04-20 Thread kix
From: "Rodolfo García Peñas (kix)" This patch avoid update (create) the Workspace Menu when wmaker is starting. When wmaker is starting, the scr->current_workspace is NULL, so we can check it in wWorkspaceMenuUpdate() and do nothing. --8<--