[PATCH 00/11] A few random improvments here and there

2013-11-10 Thread Christophe
From: Christophe CURIS Hello, This series of patch provide no major stuff, just a few things in misceleanous places. Christophe. WINGs/wfilepanel.c | 28 +-- WPrefs.app/Appearance.c | 71 ++ configure.ac| 30 +-- src/actions.c

[PATCH 06/11] wmaker: Avoid multiple calls to gettext

2013-11-10 Thread Christophe
From: Christophe CURIS The original code called gettext twice every time, the new code calls it only once. Signed-off-by: Christophe CURIS --- src/workspace.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/workspace.c b/src/workspace.c index 4e619ef..1365cc

[PATCH 03/11] WINGs: Minor improvments in 'closestListItem' function

2013-11-10 Thread Christophe
From: Christophe CURIS The check on length of string before comparing is not necessary because this will be checked as part of strcmp; the check won't save time and may actually cost. As the number of element in the array is not going to change during the loop, took the call to 'WMGetArrayItemCo

[PATCH 01/11] configure: Minor changes to option parsing for consistency

2013-11-10 Thread Christophe
From: Christophe CURIS The idea is to: - have a consistent looking file by using autoconf macros - provide better feedback on improper option usage Signed-off-by: Christophe CURIS --- configure.ac | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git

[PATCH 02/11] configure: Add check on function prototypes when debug is enabled

2013-11-10 Thread Christophe
From: Christophe CURIS Signed-off-by: Christophe CURIS --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 5c32ca8..bbcdcbb 100644 --- a/configure.ac +++ b/configure.ac @@ -125,6 +125,10 @@ AS_IF([test "x$debug" = "xyes"], dnl d

[PATCH 07/11] wmaker: Do not allocate memory for a short lived string in 'selectSpecification'

2013-11-10 Thread Christophe
From: Christophe CURIS It is not only not very efficient, but in present case it also participates in memory fragmentation. This patch replaces this with a stack allocated buffer with a buffer which is way too large. Signed-off-by: Christophe CURIS --- src/winspector.c | 16 +---

[PATCH 05/11] wmaker: Minor improvements to function 'shade_animate' when empty on purpose

2013-11-10 Thread Christophe
From: Christophe CURIS When animations are disabled, we still create the function but we make it empty to keep the rest of the code simple. This patch does: - mark the function inline, to increase the probability that the compiler will not generate the function at all; - mark arguments as unuse

[PATCH 04/11] WINGs: Do not allocate memory for a fixed-size short-lived buffer

2013-11-10 Thread Christophe
From: Christophe CURIS Allocating memory with 'malloc' has a cost and participate to memory fragmentation, so for a temporary buffer that has a fixed size let's prefer allocating it on the stack. Signed-off-by: Christophe CURIS --- WINGs/wfilepanel.c | 18 +- 1 file changed, 9

[PATCH 08/11] wmaker: Created an array to hold the maximize menu entries

2013-11-10 Thread Christophe
From: Christophe CURIS The idea is that an array is easier to work with, when it's about to add, remove or change entries, because all data end up stored in one place instead of dispatched around the code. It also makes code smaller as it avoids repetitions. Signed-off-by: Christophe CURIS ---

[PATCH 11/11] WPrefs: Make the label internationalised for the texture option in dialog window

2013-11-10 Thread Christophe
From: Christophe CURIS As this label is being displayed in the window, it is a good idea to make it translatable to the user's locale. Signed-off-by: Christophe CURIS --- WPrefs.app/Appearance.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/WPrefs.app/App

[PATCH 10/11] WPrefs: Changed array of strings 'textureOptions' into a struct for explicitness

2013-11-10 Thread Christophe
From: Christophe CURIS The parameters for the textures were stored all together in an array which made its usage error prone; now there a struct to clearly identify which string is what, so it is clear in the source what's being done. Signed-off-by: Christophe CURIS --- WPrefs.app/Appearance.c

[PATCH 09/11] WPrefs: Changed array of strings 'colorOptions' into a struct for explicitness

2013-11-10 Thread Christophe
From: Christophe CURIS The parameters for the theme colors were stored all together in an array which made its usage error prone; now there a struct to clearly identify which string is what, so it the source is clearer on what's being done. Signed-off-by: Christophe CURIS --- WPrefs.app/Appear

Re: [PATCH 07/11] wmaker: Do not allocate memory for a short lived string in 'selectSpecification'

2013-11-10 Thread Carlos R. Mafra
On Sun, 10 Nov 2013 at 17:41:09 +0100, Christophe wrote: > From: Christophe CURIS > > It is not only not very efficient, but in present case it also participates > in memory fragmentation. > > This patch replaces this with a stack allocated buffer with a buffer which > is way too large. "Too la

Re: [PATCH 07/11] wmaker: Do not allocate memory for a short lived string in 'selectSpecification'

2013-11-10 Thread Christophe
- Carlos R. Mafra a écrit : > On Sun, 10 Nov 2013 at 17:41:09 +0100, Christophe wrote: > > From: Christophe CURIS > > > > It is not only not very efficient, but in present case it also participates > > in memory fragmentation. > > > > This patch replaces this with a stack allocated buffer

Re: [PATCH 07/11] wmaker: Do not allocate memory for a short lived string in 'selectSpecification'

2013-11-10 Thread Carlos R. Mafra
On Sun, 10 Nov 2013 at 18:10:14 +0100, Christophe wrote: > > - Carlos R. Mafra a écrit : > > On Sun, 10 Nov 2013 at 17:41:09 +0100, Christophe wrote: > > > From: Christophe CURIS > > > > > > It is not only not very efficient, but in present case it also > > > participates > > > in memory f

[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-186-gfab03fd

2013-11-10 Thread crmafra
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via fab03fd0f6aa80e9f2eff1813f553f64340120e4 (commit) via 90c7b582d1acad57e

New fork? Was: Re: [PATCH] Basic WINGs theming

2013-11-10 Thread Rodolfo García Peñas
Thanks again for your reply. As you can see in their last mail, about the idea of include more commiters ("Bad idea"), things doesn't change too much. For me is unacceptable. If more people thinks that is good moment to make a fork and create a new repo with more than one commiter, more democra

Dock covers icons and vice versa

2013-11-10 Thread Josip Deanovic
Greetings everyone especially authors, maintainers, developers and other contributors! I can't promise a short message but I'll do my best. :-) I have been using Windowmaker almost from the day of it's first release. For many years a version 0.80.2 covered all my windowmanaging needs but recent

Re: [PATCH] Basic WINGs theming

2013-11-10 Thread kix
"Carlos R. Mafra" escribió: >On Sat, 9 Nov 2013 at 21:55:16 +, Rodolfo García Peñas (kix) >wrote: >> >> "Carlos R. Mafra" escribió: >> >> >On Sat, 9 Nov 2013 at 19:19:21 +, Rodolfo García Peñas (kix) >wrote: >> >> >> >>The question is: "Could you accept a patch in the git that you

Re: Dock covers icons and vice versa

2013-11-10 Thread Amadeusz Sławiński
On Sun, 10 Nov 2013 22:21:16 +0100 Josip Deanovic wrote: > Greetings everyone especially authors, maintainers, developers and > other contributors! > > > I can't promise a short message but I'll do my best. :-) > > I have been using Windowmaker almost from the day of it's first > release. For

Re: Dock covers icons and vice versa

2013-11-10 Thread Josip Deanovic
On Sunday 2013-11-10, Amadeusz Sławiński wrote: > > Hey, > > I hope I understood you correctly, are miniaturized windows placed > properly (not under dock) when you in preferences on second panel > (maximization) check "...do not cover dock" and save. > > Amadeusz Hi Amadeusz! You are talking a

Re: New fork? Was: Re: [PATCH] Basic WINGs theming

2013-11-10 Thread Yaroslav Fedevych
On Nov 10, 2013, at 6:58 PM, Rodolfo García Peñas wrote: > Thanks again for your reply. > > As you can see in their last mail, about the idea of include more commiters > ("Bad idea"), things doesn't change too much. For me is unacceptable. > > If more people thinks that is good moment to make

Re: [PATCH] Basic WINGs theming

2013-11-10 Thread Carlos R. Mafra
On Sat, 9 Nov 2013 at 23:43:35 +0100, Rodolfo García Peñas (kix) wrote: > > > "Carlos R. Mafra" escribió: > > >On Sat, 9 Nov 2013 at 21:55:16 +, Rodolfo García Peñas (kix) > >wrote: > >> > >> "Carlos R. Mafra" escribió: > >> > >> >On Sat, 9 Nov 2013 at 19:19:21 +, Rodolfo García

Re: [PATCH] Basic WINGs theming

2013-11-10 Thread Rodolfo García Peñas (kix)
On 10/11/2013 23:32, Carlos R. Mafra wrote: > > On Sat, 9 Nov 2013 at 23:43:35 +0100, Rodolfo García Peñas (kix) wrote: >> >> >> "Carlos R. Mafra" escribió: >> >>> On Sat, 9 Nov 2013 at 21:55:16 +, Rodolfo García Peñas (kix) >>> wrote: "Carlos R. Mafra" escribió: > On Sa

Re: Dock covers icons and vice versa

2013-11-10 Thread Amadeusz Sławiński
On Sun, 10 Nov 2013 23:07:03 +0100 Josip Deanovic wrote: > On Sunday 2013-11-10, Amadeusz Sławiński wrote: > > > > Hey, > > > > I hope I understood you correctly, are miniaturized windows placed > > properly (not under dock) when you in preferences on second panel > > (maximization) check "...do

[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.5-187-g26581ff

2013-11-10 Thread crmafra
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via 26581ffb5881bf7ab9caaa791f141631e975ac7e (commit) from fab03fd0f6aa80e9f

Re: [PATCH] Basic WINGs theming

2013-11-10 Thread Yury Tarasievich
I think we have the gist of the problem right there, in the lines quoted. I see a plain clash of perspectives there. We *might* benefit from the new ideas, generated in the way of hobbie or otherwise. We *would* benefit from general production going forward. I won't go so far as to declare

Re: Dock covers icons and vice versa

2013-11-10 Thread Josip Deanovic
> On Sun, 10 Nov 2013 23:07:03 +0100 > > Yes I noticed this when I started to look at code, anyway I attach a quick > patch which fixes this. Thank you very much. I'll try the patch during the day. > I fix this in minimization code, however I wonder if it's not better > idea to change how area is

Re: Dock covers icons and vice versa

2013-11-10 Thread Josip Deanovic
> On Sun, 10 Nov 2013 23:07:03 +0100 > > Yes I noticed this when I started to look at code, anyway I attach a quick > patch which fixes this. Thank you very much. I'll try the patch during the day. > I fix this in minimization code, however I wonder if it's not better > idea to change how area is