[PATCH 02/13] WINGs: add const to return value that must not be modified

From: Christophe CURIS christophe.cu...@free.fr If the user modifies the string returned by the new function 'WMGetButtonText' the widget will not see that and may lead to incorrect display (or worse, crash if the user happens to 'free' it, as it is usual for most of the other API functions). By

[PATCH 00/13] A bunch of small stuff for #next

From: Christophe CURIS christophe.cu...@free.fr Hello, These 13 patches are small improvements to the patches that are currently the #next branch. As I believe none of these deserve a separated commit, I have listed in each message the reference commit to witch the patch could be merged into.

[PATCH 04/13] wmaker: re-indent struct and de-camelcase new functions to follow project's coding style

From: Christophe CURIS christophe.cu...@free.fr (merge with 025923a6d80012c21e0fce6232ec18f8c7a9e142) --- src/moveres.c | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/src/moveres.c b/src/moveres.c index 0ad1a52..e00b3ed 100644 ---

[PATCH 01/13] WINGs: fix possible crash with Pango reported by Zoltan BALATON

From: Christophe CURIS christophe.cu...@free.fr (merge with 21a882ef9abc115812e11f9a0f40f30018228b24) --- WINGs/wfont.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/WINGs/wfont.c b/WINGs/wfont.c index 32bb613..a5cff07 100644 --- a/WINGs/wfont.c +++

[PATCH 03/13] wmaker: use 'strchr' which is more appropriate considering what the code tries to do

From: Christophe CURIS christophe.cu...@free.fr (merge with e11199d9cf45efcd52505da90c5430646de4ea26) --- src/defaults.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/defaults.c b/src/defaults.c index 36bd41a..6ea935e 100644 --- a/src/defaults.c +++ b/src/defaults.c @@

[PATCH 06/13] fix NEWS aeration

From: Christophe CURIS christophe.cu...@free.fr For consistency with the general file, 2 empty lines separate features (merge with ff54edb25ac4bfaca64981c3c1cf7a336a31fd2f) --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index bb6f15b..2bfcdde 100644 --- a/NEWS +++

[PATCH 11/13] minor improvements to the NEWS on the 0.95.6 info

From: Christophe CURIS christophe.cu...@free.fr (merge with fc5a262f939cbac80e0f3a38bbe8936450e6c90a) --- NEWS | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 2bfcdde..889d019 100644 --- a/NEWS +++ b/NEWS @@ -69,20 +69,19 @@ $ wdwrite WindowMaker

[PATCH 07/13] wmaker: clarify comment

From: Christophe CURIS christophe.cu...@free.fr (merge with f39a3200d49bd5de70286c1efd5131d5b8e96a4e) --- src/WindowMaker.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WindowMaker.h b/src/WindowMaker.h index 82188bd..220b912 100644 --- a/src/WindowMaker.h +++

[PATCH 09/13] wmaker: fix coding practice

From: Christophe CURIS christophe.cu...@free.fr it is a bad habit to rely on a default value to make the work right, it is safer to keep the assigned value in the same place of the code so a future reviewer would not have to search for stuff (although the present case is trivial). (merge with

[PATCH 05/13] fix NEWS aeration

From: Christophe CURIS christophe.cu...@free.fr For consistency with the general file, 2 empty lines separate versions (merge with 1cabdcfb85945967edccda1211a16d5d08811347) --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index b3fcced..bb6f15b 100644 --- a/NEWS +++

[PATCH 13/13] wmaker: fix constness for new internal function wXModifierToShortcutLabel

From: Christophe CURIS christophe.cu...@free.fr (merge to 5d09a25297e134f6aaf2cfa0a546cfe1cfba708e) --- src/misc.c | 2 +- src/xmodifier.c | 4 ++-- src/xmodifier.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/misc.c b/src/misc.c index 8663ed8..f3ff543 100644

[PATCH 12/13] wrlib: aerate code to make it more clear that 4 pixels are handled in the loop

From: Christophe CURIS christophe.cu...@free.fr (merge with d446597817f804b65e6dc525048dd67724bdbdfc) --- wrlib/gradient.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/wrlib/gradient.c b/wrlib/gradient.c index 9f24f84..a537959 100644 --- a/wrlib/gradient.c +++ b/wrlib/gradient.c @@

[PATCH 08/13] util: clarify error message in wmaker.inst in case of directory creation failure

From: Christophe CURIS christophe.cu...@free.fr Previously, the directory was expected to already exist, but as now it is automatically created it is a good idea in case of problem to have the message clearer. Took opportunity to indent properly that part of code. Signed-off-by: Christophe

[PATCH 10/13] wmaker: fix alignement of code

From: Christophe CURIS christophe.cu...@free.fr (merge with 996dd1e35b0bf9055ba4b81c2cddc980cefafbc0) --- src/WindowMaker.h | 10 +- src/event.c | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/WindowMaker.h b/src/WindowMaker.h index 220b912..0515b42

[PATCH 0/5] A few fixes for portability

From: Christophe CURIS christophe.cu...@free.fr Hello, This serie of patches fixes the compilation problem reported by Milan Čermák when trying to compile on Solaris platform (excluding the wmiv case). It also fixes the libgif issue reported by Andrew, because the libgif guys managed to change

[PATCH 4/5] util: removed usage of external '__progname' because it is not portable

From: Christophe CURIS christophe.cu...@free.fr As reported by Milan Čermák, using this variable breaks compilation on Solaris, because it is a hack which is not standard. To ensure portability, we now rely on main's argv[0] which is always available. Signed-off-by: Christophe CURIS

[PATCH 2/5] wmaker: remove call to internal X11 header

From: Milan Čermák mcer...@chello.cz The header 'Xarch' is not part of the standard, it is an internal header that is already included by the other headers; furthermore it is not needed directly by the code in wmspec.c. As it breaks compilation on some platforms (namely Solaris 10), its call is

[PATCH 1/5] wrlib: fix usage of deprecated attribute for gcc 3.x

From: Milan Čermák mcer...@chello.cz It seems that the argument to the attribute 'deprecated' is a novelty of gcc 4.x, the attribute introduced in gcc 3.x did not take any parameter. As Solaris 10 is providing gcc 3.4.3, this patch updates the detection in the public API header to make it

[PATCH 5/5] wrlib: add support for release 5.1.0 of the libgif

From: Christophe CURIS christophe.cu...@free.fr As reported by Andrew, the compilation of the WRaster broke because there was an API change in libgif v5.1 versus the v5.0 (something had been forgotten for DGifCloseFile to be easily used in wrappers for dynamic languages). Now, if we have