[PATCH 1/1] util: fix parsing of XDG menus with multiple groups

The specification for XDG menu files allows having more than one group and assumes no constraint on their order. The original code assumed that once the proper group marker was found, everything after was part of it, causing misinterpretation of some data, like taking the wrong launch command. Thi

[PATCH 1/1] configure: fixed incorrect variable name that prevented --disable-xdnd to work

disable the feature, feature which was still not enabled. Signed-off-by: Christophe CURIS --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 589c7c9..2b0e16d 100644 --- a/configure.ac +++ b/configure.ac @@ -534,7 +534,7 @@ AS_IF

[PATCH 3/3] doc: include the "INSTALL-WMAKER" documentation in the repository

of it (the reference to the version number would be wrong). When the source file is modified, "make" will re-generate accordingly the file, so there should be no problem. Suggested-by: Carlos R. Mafra Signed-off-by: Christophe CURIS --- .gitignore | 1 -

[PATCH 2/3] WPrefs: fix conversion of old "Apercu" setting to the new keywords

. Reported-by: Josip Deanovic Signed-off-by: Christophe CURIS --- WPrefs.app/Icons.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/WPrefs.app/Icons.c b/WPrefs.app/Icons.c index 4e7f237..e68da56 100644 --- a/WPrefs.app/Icons.c +++ b/WPrefs.app/Icons.c

[PATCH 1/3] wmaker: fix detection of legacy Apercu configuration keywords

vely used. Reported-by: Josip Deanovic Signed-off-by: Christophe CURIS --- src/defaults.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/defaults.c b/src/defaults.c index 70fbeb5..c5a94c6 100644 --- a/src/defaults.c +++ b/src/defaults.c @@ -529,7 +529,7 @@ WDef

[PATCH 0/3] Fixes...

Hello, The first 2 patchs will fix the Apercu/Minipreview problems reported by Josip recently. The 3rd patch is including the generated INSTALL-WMAKER into the repository as suggested by Carlos. Carlos, I would also suggest to run this (before or after, it does not matter): git rebase -i HEAD

[PATCH 0/1] Update doc on automake version needed

As pointed by Josip, I missed the update of the documentation about the requirement for the Automake version, so this patch can be merged with the other one to fix that. Took opportunity to update the Debian file too because it costs nothing. Regards, Christophe. debian/control | 2

[PATCH 1/1] fixup! Configure: increased the version of Automake requested

--- debian/control | 2 +- doc/build/Compilation.texi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/control b/debian/control index ce41a77..b761636 100644 --- a/debian/control +++ b/debian/control @@ -3,7 +3,7 @@ Section: x11 Priority: optional Maintai

[PATCH 2/2] Configure: increased the version of Automake requested

The compilation of the WRaster library needs the keyword EXTRA_*_DEPENDENCIES in its Makefile so the configure.ac have been updated to require at least the version of automake in which it is added. Reported-by: Josip Deanovic Signed-off-by: Christophe CURIS --- configure.ac | 6 +- 1 file

[PATCH 1/2] wrlib: fixed gcc version needed for deprecated attribute support

The support for a custom message in the attribute 'deprecated' have been added only from gcc 4.5.0 and not 4.0, so the check was updated accordingly to avoid compilation error with version 4.0 to 4.4. Reported-by: Josip Deanovic Signed-off-by: Christophe CURIS --- wrlib/wraster.h

[PATCH 4/4] WRaster: fix unused variable warning when XShm extention is not enabled

Signed-off-by: Christophe CURIS --- wrlib/xutil.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/wrlib/xutil.c b/wrlib/xutil.c index 1c3f86d..8e90333 100644 --- a/wrlib/xutil.c +++ b/wrlib/xutil.c @@ -154,6 +154,9 @@ RXImage *RCreateXImage(RContext * context, int depth, unsigned width

[PATCH 3/4] WINGs: fix non-portable int conversion for printf in font panel size handling

, so the compiler knows what is happening and printf always gets the 'int' it expects. Signed-off-by: Christophe CURIS --- WINGs/wfontpanel.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/WINGs/wfontpanel.c b/WINGs/wfontpanel.c index 2d6f77f..019c

[PATCH 2/4] WINGs: ran spell checker on the NEWS file

The command used was: aspell --lang=en_GB check WINGs/NEWS Signed-off-by: Christophe CURIS --- WINGs/NEWS | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/WINGs/NEWS b/WINGs/NEWS index 1c94845..c5afb8d 100644 --- a/WINGs/NEWS +++ b/WINGs/NEWS @@ -223,8

[PATCH 1/4] WINGs: Updated news with the API changes that occured between 0.95.6 and 0.95.7

Signed-off-by: Christophe CURIS --- WINGs/NEWS | 45 + 1 file changed, 45 insertions(+) diff --git a/WINGs/NEWS b/WINGs/NEWS index d1bfa7b..1c94845 100644 --- a/WINGs/NEWS +++ b/WINGs/NEWS @@ -155,6 +155,41 @@ wshellquote ADDED

[PATCH 0/4] Minor updates for next release

Hello, Some minor updates which could be interresting for the forthcoming release: - 1 & 2 are documentation; - 3 & 4 are minor bug fixes. >From what I have checked, the library versions numbers in the API headers and in the configure.ac have already been incremented, so it should be ok for the

[PATCH 4/5] fixup! doc: Add manpage for wmiv.

--- doc/wmiv.1 | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/doc/wmiv.1 b/doc/wmiv.1 index 4f92f98..924c317 100644 --- a/doc/wmiv.1 +++ b/doc/wmiv.1 @@ -1,9 +1,9 @@ .TH wmiv "1" "June 2015" .SH NAME -wmiv: \- fast image viewer using wrlib +wmiv \- quick im

[PATCH 5/5] wmaker: replaced old email address with the official one

o not have it in the translation files (po) to ease the maintainer's task in case of future change. Signed-off-by: Christophe CURIS --- po/be.po | 8 +--- po/bg.po | 9 + po/ca.po | 9 + po/cs.po | 8 +--- po/da.po | 4 ++

[PATCH 3/5] fixup! wmiv: Improve help text.

--- util/wmiv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/wmiv.c b/util/wmiv.c index 2fb1e15..e99e3e3 100755 --- a/util/wmiv.c +++ b/util/wmiv.c @@ -731,10 +731,10 @@ int main(int argc, char **argv) " [L]rotate image on th

[PATCH 0/5] Minor fixes

Hello, This series of patch tries to improve a few things against the recently submitted patches: - patch 1: converting the encoding to UTF-8 in the Ukrainian translation, because this is what is used everywhere else, and because nowadays it is the right way to do if we do not want problems with

[PATCH 5/5] wrlib: changed Gamma Correction calculation to use single-precision float

: Christophe CURIS --- m4/wm_libmath.m4 | 1 + wrlib/context.c | 26 +++--- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/m4/wm_libmath.m4 b/m4/wm_libmath.m4 index 77ed8d7..5a8143c 100644 --- a/m4/wm_libmath.m4 +++ b/m4/wm_libmath.m4 @@ -70,6 +70,7 @@ AC_CACHE_CHECK

[PATCH 3/5] Added some explicit conversion to double precision

When the result of the operation is expected to use double precision, this patchs adds an explicit conversion to that type to tell the compiler that this is what we want, and not an unexpected side effect. Signed-off-by: Christophe CURIS --- WINGs/userdefaults.c | 2 +- WINGs/wbrowser.c

[PATCH 1/5] configure: Add compiler detection on non optimal floating point constant

Signed-off-by: Christophe CURIS --- configure.ac | 5 + 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index 40f76fb..c5d3167 100644 --- a/configure.ac +++ b/configure.ac @@ -153,6 +153,11 @@ AS_IF([test "x$debug" = "xyes"], dnl too com

[PATCH 4/5] Use single-precision math functions when available

Since C99 we have floating point functions available for single precision, so as it is what we need we detect them (configure) and use them when appropriate. The goal is to avoid unnecessary float->double + double->float conversion. Signed-off-by: Christophe CURIS --- m4/wm_libmath.m

[PATCH 2/5] Fixed floating point constants defined as double but expected as float

To preserve the accuracy of the operation, the C standard request that the mathematical operation is performed using double precision, but in many case this is not necessary so this patch fixes a few constants to avoid that conversion. Signed-off-by: Christophe CURIS --- WINGs/wcolorwell.c

[PATCH 4/4] doc: changed section for translated man pages from 1x to 1

Similarly to the previous patch that changed the section for the core man pages, this patch updates the translated man pages. Took opportunity to re-order alphabetically the files in the Makefile because it eases maintenance. Signed-off-by: Christophe CURIS --- doc/cs/Makefile.am

[PATCH 3/4] doc: do not install translated man pages if the language was not enabled in LINGUAS

to invite contributors to think about the man pages if contribute to translations. Signed-off-by: Christophe CURIS --- doc/Makefile.am | 3 ++- doc/build/Translations.texi | 25 + m4/wm_i18n.m4 | 9 - 3 files changed, 35 insertions(+), 2

[PATCH 0/4] Small updates to man pages

Hello, This series of patches is mainly changing the section from 1x to 1 for the man pages and take care of the wmmenugen tool. It was generated with the "-R" option as suggested by Carlos, because it both makes the patches smaller but also a lot more easy to review because changes to the files

[PATCH 2/4] util: improve the command line argument parsing in wmmenugen

ould be useful for people calling the program from a script; Took the opportunity to provide more information in the man page and to get it cross-checked against the program's option list during "make check". Signed-off-by: Christophe CURIS --- doc/Makefile.am | 8 +++- doc/wmmenug

[PATCH 1/4] doc: changed section for man pages from 1x to 1

d-by: Doug Torrance Signed-off-by: Christophe CURIS --- doc/Makefile.am | 60 ++--- doc/{WPrefs.1x => WPrefs.1} | 6 ++-- doc/WindowMaker.1 | 1 + doc/WindowMaker.1x | 1 - doc/{geticonset.1x => ge

[PATCH 3/3] fixup! wmaker: moved the list of Window Attributes into an array, for the Window Inspector

--- src/winspector.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/winspector.c b/src/winspector.c index 6b6e687..e947a14 100644 --- a/src/winspector.c +++ b/src/winspector.c @@ -67,45 +67,45 @@ static const struct {

[PATCH 2/3] fixup! wmaker: moved the list of Advanced Options into an array, for the Window Inspector

--- src/winspector.c | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/src/winspector.c b/src/winspector.c index 3255fe6..6b6e687 100644 --- a/src/winspector.c +++ b/src/winspector.c @@ -110,57 +110,57 @@ static const struct {

[PATCH 1/3] fixup! wmaker: moved the list of Application Attributes into an array, for the Window Inspector

--- src/winspector.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/winspector.c b/src/winspector.c index 0735caf..3255fe6 100644 --- a/src/winspector.c +++ b/src/winspector.c @@ -164,17 +164,17 @@ static const struct { #endif }, application_attr[] = { -

[PATCH 0/3] Fixes for incorrect I18N specifier

Hi Carlos, This 3 patches fixes the issue found by Alwin on "M_()" which should have been "N_()". I gave a try to a new method for merging the patch which should be easier for you: after the 'git am', you can use: git rebase -i --autosquash next~20 It will detect the 'fixup!' string and move t

[PATCH 3/4] wmaker: support providing ICCCM version, for compliance with the standard

The standard specify that the pseudo-selection which is used to cooperatively replace window managers should actually contain the version of the ICCCM standard which is supported. As this could be handy for compatibility checks in the future, let Window Maker comply. Signed-off-by: Christophe

[PATCH 4/4] doc: describe Iain Patterson's new feature for ICCCM compliance

Signed-off-by: Christophe CURIS --- NEWS| 11 +++ doc/Makefile.am | 1 + doc/wmaker.in | 3 +++ 3 files changed, 15 insertions(+) diff --git a/NEWS b/NEWS index 6561c4e..023ceb1 100644 --- a/NEWS +++ b/NEWS @@ -66,6 +66,17 @@ tell Window Maker to just ignore them. This

[PATCH 0/5] ICCCM window manager replace protocol

Hello, This series of patch re-introduce the Window Manager Replace protocol that was proposed by Iain in 2013. The first patch is Iain's code, updated to apply on current #next and including a more elaborate comment about it. The second patch is adding a configure option to enable this feature,

[PATCH 2/4] wmaker: make the '--replace' de-activable at compile time

ay want to enable the feature to provide users the ability to give a try of all the window managers. Suggested-by: Carlos R. Mafra Signed-off-by: Christophe CURIS --- configure.ac | 14 ++ doc/build/Compilation.texi | 6 ++ src/WindowMaker.h | 2 ++ s

[PATCH 1/4] wmaker: replace and be replaced (ICCCM protocol)

From: Iain Patterson Use the same logic used by xfwm4, metacity et al to replace an existing window manager on the screen and allow other window managers to replace us, as defined by the ICCCM 2.0: http://www.x.org/releases/X11R7.6/doc/xorg-docs/specs/ICCCM/icccm.html Communication with the Wi

[PATCH 1/1] wmaker-check: rewrote parsing of structure fields for callback checker

-by: Doug Torrance Signed-off-by: Christophe CURIS --- script/check-wmaker-loaddef-callbacks.sh | 88 +++- 1 file changed, 64 insertions(+), 24 deletions(-) diff --git a/script/check-wmaker-loaddef-callbacks.sh b/script/check-wmaker-loaddef-callbacks.sh index 1cc9541

[PATCH 9/9] Add a configuration option to ignore Decoration Hints from GTK-based application

dds a configuration option: Window Maker tries to detect for GTK-based windows and in this case ignore the decoration hints that were provided by the application. Suggested-by: Paul Jakma Signed-off-by: Christophe CURIS --- FAQ | 5 + NEWS| 10 ++ WPref

[PATCH 7/9] wmaker: fix clearing of window attribute that was not saved properly

l remember correctly the user choice. Reported-by: Nerijus Baliunas Signed-off-by: Christophe CURIS --- src/winspector.c | 61 +++- 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/src/winspector.c b/src/winspector.c index 966636

[PATCH 8/9] doc: describe the GNOME application issue in the FAQ

Now that Window Maker have been fixed to allow the user to properly control and save the title bar/resize bar/other decoration settings on the window, describe the problem reported (first) by Nerijus Baliunas, so more people may find the answer. Signed-off-by: Christophe CURIS --- FAQ | 20

[PATCH 3/9] wmaker: moved the list of Application Attributes into an array, for the Window Inspector

generic) and to make it evolve. Signed-off-by: Christophe CURIS --- src/winspector.c | 116 +++ 1 file changed, 57 insertions(+), 59 deletions(-) diff --git a/src/winspector.c b/src/winspector.c index 16ab168..edfa8d0 100644 --- a/src

[PATCH 6/9] WINGs: create a new type of Tri-State Switch Button (to doc)

Window Maker release. Signed-off-by: Christophe CURIS --- WINGs/WINGs/WINGs.h | 5 ++-- WINGs/WINGs/WINGsP.h | 10 WINGs/wbutton.c | 35 ++ WINGs/widgets.c | 69 4 files changed, 112 insertions(+),

[PATCH 5/9] wmaker: honour MWM Hint to have no border to a window

: Christophe CURIS --- src/motif.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/motif.c b/src/motif.c index 6537038..34f6847 100644 --- a/src/motif.c +++ b/src/motif.c @@ -93,13 +93,7 @@ static void setupMWMHints(WWindow *wwin, MWMHints *mwm_hints

[PATCH 4/9] wmaker: fix misuse of 'user_flags' instead of 'client_flags' for window attributes

using the wrong structure to save the attributes to (for example by using the WSETUFLAG macro) which was merely ok as the user_flags have priority, but when we want to provide a clean consistent behaviour to users, we need to get things in the right place. Signed-off-by: Christophe CURIS --- src

[PATCH 2/9] wmaker: moved the list of Advanced Options into an array, for the Window Inspector

evolve in the future. Signed-off-by: Christophe CURIS --- src/winspector.c | 311 ++- 1 file changed, 98 insertions(+), 213 deletions(-) diff --git a/src/winspector.c b/src/winspector.c index 8413836..16ab168 100644 --- a/src/winspector.c +++ b

[PATCH 1/9] wmaker: moved the list of Window Attributes into an array, for the Window Inspector

to make it evolve. Signed-off-by: Christophe CURIS --- src/winspector.c | 347 ++- 1 file changed, 163 insertions(+), 184 deletions(-) diff --git a/src/winspector.c b/src/winspector.c index 78b5cd0..8413836 100644 --- a/src/winspector.c +++ b

[PATCH 0/9] Fixes and improvements for GNOME applications

Hello, This series of patchs is improving a few fixes in the Window Inspector which should help forcing GNOME application to behave correctly under Window Maker. This have been reported by many people; it may also (or may not) improve the situation with some GNUstep panels that was reported by Ge

[PATCH 11/13] wmaker: moved the definition of the list of entries for the window menu to an array

a variable but not using it, which is not really good for maintainability. Signed-off-by: Christophe CURIS --- src/winmenu.c | 117 -- 1 file changed, 64 insertions(+), 53 deletions(-) diff --git a/src/winmenu.c b/src/winmenu.c index

[PATCH 13/13] wmaker: moved calculation of internal offset in handleDockMove outside the loop

e loop and then uses this result, which should make the code faster (although gcc may already optimise this kind of things), makes it compliant with coding style, and takes the opportunity to explain the reasons behind this offset. Signed-off-by: Christophe CURIS --- src/dock.c | 14

[PATCH 12/13] wmaker: moved the definition of the entries for the window menu options to an array

By defining the const array with everything at the beginning of the file, it is easier to maintain and to make evolve. Signed-off-by: Christophe CURIS --- src/winmenu.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/src/winmenu.c b/src

[PATCH 02/13] wmaker: fix incorrect type for variable in the global preference structure

. This patch changes the type for the appropriate one to avoid possible problems. Signed-off-by: Christophe CURIS --- src/WindowMaker.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WindowMaker.h b/src/WindowMaker.h index 0a1d81f..ccdb6c8 100644 --- a/src/WindowM

[PATCH 08/13] wmaker: remove one level of pointers for the function SlideWindows

ed into an inlinable function so the compiler can optimise it. Took opportunity to de-CamelCase the name of the functions to comply with the project's coding style. Signed-off-by: Christophe CURIS --- src/actions.c | 2 +- src/appicon.c | 6 +++--- src/dock.c| 14 +++--- src

[PATCH 09/13] wmaker: do not use strcmp twice on the same thing, in function appiconBalloon

It is not really efficient to call it twice because the strings will not change, and by using the appropriate trick it can make the code smaller, with less redundancy, so less prone to bugs and easier to maintain. Signed-off-by: Christophe CURIS --- src/balloon.c | 27

[PATCH 10/13] wmaker: removed dead code related to 'GLOBAL_SUBMENU_FILE'

was not touched anymore, this patch removes the dead code associated with it. Signed-off-by: Christophe CURIS --- src/rootmenu.c | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff --git a/src/rootmenu.c b/src/rootmenu.c index 8c0f0c6..499815f 100644

[PATCH 05/13] wmaker: fix warnings from compiler when animations are disabled

compiler it is ok to not use the parameters not needed, thus fixing the warnings. Signed-off-by: Christophe CURIS --- src/actions.c | 20 ++-- src/misc.c| 4 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/actions.c b/src/actions.c index d69f900

[PATCH 03/13] Code refactoring: replaced macro 'ANIMATIONS' by 'USE_ANIMATIONS' for consistency

The usual way to define a macro in is to name macro with 'USE_xxx' when they are used to enable a feature 'xxx'. Signed-off-by: Christophe CURIS --- src/actions.c| 28 ++-- src/misc.c | 2 +- src/wconfig.h.in | 2 +- 3 files changed,

[PATCH 04/13] configure: Added option to disable animations

The old behaviour was to expect the user to go modify manually a source file which is not a great idea because that's typically the kind of things in charge of the configure script. Signed-off-by: Christophe CURIS --- README | 3 ++- configure.ac

[PATCH 06/13] wmaker: took as much assignation as possible outside 'if' statements

easier to read. Signed-off-by: Christophe CURIS --- src/appmenu.c | 3 ++- src/dialog.c | 9 ++--- src/dock.c| 30 +- src/event.c | 6 -- src/monitor.c | 3 ++- src/osdep_bsd.c | 9 ++--- src/osdep_linux.c | 6 -- sr

[PATCH 07/13] wmaker: reorganisation of the control flow of the function 'findDock'

Changed the code to return as soon as the result is known because it makes the code simpler to understand, which is good for maintainability. Signed-off-by: Christophe CURIS --- src/dock.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/dock.c b

[PATCH 01/13] wmaker: add script to check the call-back function used when loading configuration

data corruption, which depends strongly on the configuration values and the architecture on which Window Maker is running. This patch introduces a script that checks the consistency where possible, to raise the issues when performing "make check". Signed-off-by: Christophe CURIS --- M

[PATCH 00/13] A bunch of random fixes

Hello, This series of patches is mainly code improvements, no real bug fixes but improvements to the code. Regards, Christophe. Makefile.am | 1 + README | 3 +- configure.ac | 12 + doc/build/Compi

[PATCH 10/13] wmaker: removed dead code related to 'GLOBAL_SUBMENU_FILE'

was not touched anymore, this patch removes the dead code associated with it. Signed-off-by: Christophe CURIS --- src/rootmenu.c | 31 +++ 1 file changed, 7 insertions(+), 24 deletions(-) diff --git a/src/rootmenu.c b/src/rootmenu.c index 8c0f0c6..499815f 100644

[PATCH 07/13] wmaker: reorganisation of the control flow of the function 'findDock'

Changed the code to return as soon as the result is known because it makes the code simpler to understand, which is good for maintainability. Signed-off-by: Christophe CURIS --- src/dock.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/dock.c b

[PATCH 12/12] wmaker: fix non-portable int argument for printf in error message

ways be ok, whatever platform Window Maker is compiled for. Signed-off-by: Christophe CURIS --- po/nl.po | 4 ++-- src/dialog.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/po/nl.po b/po/nl.po index 35cb850..674c642 100644 --- a/po/nl.po +++ b/po/nl.po @@ -346,9 +346,9

[PATCH 11/12] wmaker: fix crash when switching workspace with "Affiche.app"

ll back on another mechanism already in place for picking the window to focus. Signed-off-by: Christophe CURIS --- src/workspace.c | 20 1 file changed, 20 insertions(+) diff --git a/src/workspace.c b/src/workspace.c index 380ffec..69db16c 100644 --- a/src/workspace.c +++ b/src/w

[PATCH 06/12] wmaker: remove non-necessary allocation (Coverity #109609)

he dynamic memory allocation by a buffer on the stack, which also solves to de-allocation issue. Signed-off-by: Christophe CURIS --- src/defaults.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/defaults.c b/src/defaults.c index ee027dc..b6e855c 100644 --- a/src/defaul

[PATCH 08/12] WINGs: remove useless function call in WColorPanel (Coverity #109617)

As reported by Coverity, the function 'customSetPalette' is making a call to 'WMGetPopUpButtonSelectedItem', but this function does nothing to the widget but only return a value, which is not used at all, so this patch removes the call to the function. Signed-off-by: Christop

[PATCH 09/12] WUtil: fix improper use of de-allocated variable (Coverity #109618)

As pointed by Coverity, the variable 'path_dst' was first free'd, then it was used in the 'unlink' function. This patch fixes the call order to de-allocate the string only when it is no more needed. Signed-off-by: Christophe CURIS --- WINGs/findfile.c | 2 +- 1 file c

[PATCH 07/12] wmaker: remove useless null pointer check (Coverity #109612)

As pointed by Coverity, the pointer in wwin->frame have already been dereferenced many times in the function, so it is useless to include a check later; removing it makes the code smaller thus easier to maintain. Signed-off-by: Christophe CURIS --- src/actions.c | 2 +- 1 file changed

[PATCH 10/12] wmaker: converted macro 'SAME' into a static function

effect, this should also help Coverity in avoiding false positive bug reports (like #109605 and #109607). Signed-off-by: Christophe CURIS --- src/session.c | 20 +--- src/window.c | 19 --- 2 files changed, 33 insertions(+), 6 deletions(-) diff --git a/src

[PATCH 02/12] Handle NULL pointer as good as possible (Coverity #50099)

ing a NULL pointer check in the functions RScaleImage (wrlib) and WMCreatePixmapFromRImage (WINGs), so both can accept that NULL pointer to also return NULL, which means the existing check for "icon == NULL" in the WPrefs code will be useful. Signed-off-by: Christophe CURIS --- WINGs/wpix

[PATCH 05/12] wmaker: fix memory leak in the Workspace Map if there is no workspace (Coverity #109608)

workspace, the current one), but it is better to keep safety checks, so this patch is moving the check at the beginning so no leak will occur. Signed-off-by: Christophe CURIS --- src/wsmap.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/wsmap.c b/src/wsmap.c

[PATCH 03/12] WINGs: fix memory leak in WMSubtractPLDictionaries (Coverity #50128)

As pointed by Coverity, a temporary proplist is created with the list of keys to be removed from the source proplist, but this temporary proplist was not released at the end, leaking memory. Signed-off-by: Christophe CURIS --- WINGs/proplist.c | 1 + 1 file changed, 1 insertion(+) diff --git a

[PATCH 04/12] wmaker: fix incorrect size for memory allocation (Coverity #50207)

type) by the variable actually being used, fixing the size issue and making maintainability easier by tracking the type of the variable which is less prone to bugs in case of change. Signed-off-by: Christophe CURIS --- src/menu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 01/12] wmaker: check return value for XGetWindowAttributes (Coverity #50032)

As reported by Coverity, the return value for XGetWindowAttributes is usually checked in many places, because it is a good practice to ensure that it did work, but it was not checked when called in the function 'wClientCheckProperty'. Signed-off-by: Christophe CURIS --- src/client.c |

[PATCH 00/12] Bug fixes

Hello, This series of patches is fixing many bugs reported by Coverity, the bug reported by Martin which crashes Window Maker with Affiche.app, and a little bit more for portability. Regards, Christophe. WINGs/findfile.c| 2 +- WINGs/proplist.c| 1 + WINGs/wcolorpanel.c | 2 -- WING

[PATCH 1/1] merge with ae92bccb14432a8e4ab6619f5171a7b56506e5e6

(fix typo) --- doc/build/Compilation.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/build/Compilation.texi b/doc/build/Compilation.texi index cb19a6d..4db3ae0 100644 --- a/doc/build/Compilation.texi +++ b/doc/build/Compilation.texi @@ -224,7 +224,7 @@ Get the @emph{GN

[PATCH 1/1] texi2txt: add workaround for a known bug in "mawk"

It looks like the bug have been fixed in mawk, but Debian is still providing a broken version. To avoid problems, this patch is introducing a workaround in the matching pattern that causes the issue every time it is being used. Signed-off-by: Christophe CURIS --- script/generate-txt-from-t

[PATCH 1/1] doc: re-generate the top directory documentation when "make dist" is invoked

t" so it will re-generate the docs if needed. Because the "dist-hook" is run after Automake has copied the files to the temporary directory (distdir) then we also include an explicit copy of the files there to have the latest version. Signed-off-by: Christophe CURIS --- doc/b

[PATCH 3/3] merge with 418eb1f157c76ffc3db43f9a4fbf1a85f966d55c

--- doc/get-wraster-flags.1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/get-wraster-flags.1 b/doc/get-wraster-flags.1 index 95bd062..8abc35f 100644 --- a/doc/get-wraster-flags.1 +++ b/doc/get-wraster-flags.1 @@ -4,11 +4,11 @@ .PP .SH "SYNOPSIS" .B pkg-config -.R

[PATCH 2/3] merge with 4c86603b36ed91da0b1246a4f0b4093d4e75bf08

--- doc/get-wutil-flags.1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/get-wutil-flags.1 b/doc/get-wutil-flags.1 index 1e6641a..635c322 100644 --- a/doc/get-wutil-flags.1 +++ b/doc/get-wutil-flags.1 @@ -4,11 +4,11 @@ .PP .SH "SYNOPSIS" .B pkg-config -.R WUtil +WUt

[PATCH 1/3] merge with 46bc10e27b09cd7f9c149af982063fdf96a1a35f

--- doc/get-wings-flags.1 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/get-wings-flags.1 b/doc/get-wings-flags.1 index 7c04894..2ddd8b8 100644 --- a/doc/get-wings-flags.1 +++ b/doc/get-wings-flags.1 @@ -4,11 +4,11 @@ .PP .SH "SYNOPSIS" .B pkg-config -.R WINGs +WIN

[PATCH 19/23] doc: describe the "new" options to the "configure" script

As there are many options, they have been split into 5 sections; added documentation for all the legacy Window Maker options that were missing and for the new ones; added documentation for a few of the "autotools" standard options that can be considered interesting. Signed-off-by:

[PATCH 22/23] configure: Added option to disable Motif WM Hints support

f the feature when not used, instead of trying to compile an empty-looking file. Signed-off-by: Christophe CURIS --- configure.ac | 17 + doc/build/Compilation.texi | 4 +++- src/Makefile.am| 6 -- src/motif.c| 4 src/wconfig

[PATCH 02/23] WUtil: mark the script 'get-wutil-flags' as deprecated

spell-checked). Signed-off-by: Christophe CURIS --- .gitignore | 1 - WINGs/Makefile.am| 12 ++-- WINGs/get-wutil-flags| 33 + WINGs/get-wutil-flags.in | 31 --- doc/get-wutil-flags.1| 40

[PATCH 23/23] Code refactoring: replaced macro 'XDND' by 'USE_DOCK_XDND' for consistency

in the Installation Manual. Took opportunity to compile the corresponding file only when the feature is not disabled. Signed-off-by: Christophe CURIS --- configure.ac | 7 --- doc/build/Compilation.texi | 5 + src/Makefile.am| 4 +++- src/appicon

[PATCH 21/23] Code refactoring: replaced macro 'MWM_HINTS' by 'USE_MWM_HINTS' for consistency

The usual way to define a macro in is to name macro with 'USE_xxx' when they are used to enable a feature 'xxx'. Signed-off-by: Christophe CURIS --- src/dialog.c | 2 +- src/motif.c | 4 ++-- src/wconfig.h.in | 2 +- src/window.c | 6 +++--- 4 files changed

[PATCH 18/23] check the "configure" option list against the INSTALL-WMAKER documentation

also implies it will break a "make distcheck" operation when not in line. Signed-off-by: Christophe CURIS --- Makefile.am | 14 script/check-cmdline-options-doc.sh | 43 ++--- 2 files changed, 54 insertions(+), 3 deletion

[PATCH 20/23] check-doc: add an option to ignore some explicit options from the command's help

options because for a few of them the right place to document them is in the INSTALL file provided by Autoconf and not in our Window Maker specific doc. Signed-off-by: Christophe CURIS --- Makefile.am | 11 ++- script/check-cmdline-options-doc.sh | 23 +++

[PATCH 17/23] doc: removed a few deprecated stuff from the Installation Manual

versions is now specified in the configure.ac this situation should not arise. Signed-off-by: Christophe CURIS --- doc/build/Compilation.texi | 31 --- 1 file changed, 31 deletions(-) diff --git a/doc/build/Compilation.texi b/doc/build/Compilation.texi index 79376bd.

[PATCH 15/23] doc: convert INSTALL-WMAKER into a texinfo source processed by texi2txt

to get a consistent document. Apart from this, the document should not have seen any change on the content, because this deserves dedicated patches to show the evolution. Signed-off-by: Christophe CURIS --- .gitignore | 1 + INSTALL-WMAKER | 385 ---

[PATCH 13/23] texi2txt: add support for the @table command

The texinfo format provides a command '@table' which is useful to provide a list of object (function, variables, options, ...) with their associated description. As this will be very handy for the Installation Manual, this patch implements the command in the script. Signed-off-by:

[PATCH 14/23] texi2txt: add support for making cross-references in the document

ent when doing the replace; - there is a strict order to respect between @node and @chapter/@section, which is needed because we have to include a line offset to get it right when using the order given in the texinfo manual. Signed-off-by: Christophe CURIS ---

[PATCH 16/23] doc: update information in the Installation Manual

, inotify, boehm gc); - fixed a few strings here and there; - made an appropriate reference to the README.i18n for the troubleshooting of NLS. Signed-off-by: Christophe CURIS --- doc/build/Compilation.texi | 127 - 1 file changed, 91 insertions(+), 36

[PATCH 12/23] texi2txt: add support for enumerated lists

unordered lists. Signed-off-by: Christophe CURIS --- script/generate-txt-from-texi.sh | 45 +++- 1 file changed, 40 insertions(+), 5 deletions(-) diff --git a/script/generate-txt-from-texi.sh b/script/generate-txt-from-texi.sh index 8c51855..74f17b2 100755

[PATCH 11/23] texi2txt: fix support embedded item lists to allow nested lists

There are some cases where it can be useful to embed a list of item into another list; the script was almost ready to handle this case, this patch brings the missing stuff to get it to work properly. Signed-off-by: Christophe CURIS --- script/generate-txt-from-texi.sh | 9 - 1 file

[PATCH 09/23] doc: updated man pages for many tools

on may not be clear. Signed-off-by: Christophe CURIS --- doc/WPrefs.1x | 14 +++ doc/geticonset.1x | 18 + doc/getstyle.1x | 67 + doc/seticons.1x | 10 +++-- doc/setstyle.1x | 55 ++- doc/wdread.1x

[PATCH 10/23] doc: the man page for "wmsetbg" is now processed by a script

Because the tool's help page changes whether Xinerama support was compiled or not, its man page have to reflect this, so instead of being simply copied the file is processed with the 'replace-ac-keywords' script. Signed-off-by: Christophe CURIS --- doc/Makefile.am | 15 +---

  1   2   3   >