Re: [X2go-Dev] [PATCH] Allow users to edit their *own* sessions only

2011-07-25 Thread Mike Gabriel
Hi Reinhard, On Mo 25 Jul 2011 00:10:03 CEST Reinhard Tartler wrote: previously, users could create sessions under wrong uids or delete sessions from other users. This patch implements prevents this by checking the userid of the caller with the session id. +1 from me... [... patch ...]

Re: [X2go-Dev] [PATCH] Allow users to edit their *own* sessions only

2011-07-25 Thread John A. Sullivan III
On Mon, 2011-07-25 at 08:32 +0200, Mike Gabriel wrote: Hi Reinhard, On Mo 25 Jul 2011 00:10:03 CEST Reinhard Tartler wrote: previously, users could create sessions under wrong uids or delete sessions from other users. This patch implements prevents this by checking the userid of the

Re: [X2go-Dev] [PATCH] Allow users to edit their *own* sessions only

2011-07-25 Thread Mike Gabriel
Hi John, On Mo 25 Jul 2011 12:32:44 CEST John A. Sullivan III wrote: On Mon, 2011-07-25 at 08:32 +0200, Mike Gabriel wrote: Hi Reinhard, On Mo 25 Jul 2011 00:10:03 CEST Reinhard Tartler wrote: previously, users could create sessions under wrong uids or delete sessions from other users.

Re: [X2go-Dev] [PATCH] Allow users to edit their *own* sessions only

2011-07-25 Thread Reinhard Tartler
On Mon, Jul 25, 2011 at 12:32:44 (CEST), John A. Sullivan III wrote: On Mon, 2011-07-25 at 08:32 +0200, Mike Gabriel wrote: Hi Reinhard, On Mo 25 Jul 2011 00:10:03 CEST Reinhard Tartler wrote: previously, users could create sessions under wrong uids or delete sessions from other

[X2go-Dev] Clean sessions (Was: Allow users to edit their *own* sessions only)

2011-07-25 Thread Moritz Struebe
On 2011-07-25 13:37, Reinhard Tartler wrote: To be honest, I'd like to remove the cleanup daemon completely and integrate the cleanup into the listsessions command. The current implementation of the cleanup daemon in perl that runs as root and doesn't work properly anyway makes me feel quite

Re: [X2go-Dev] Clean sessions

2011-07-25 Thread Reinhard Tartler
On Mon, Jul 25, 2011 at 13:52:30 (CEST), Moritz Struebe wrote: On 2011-07-25 13:37, Reinhard Tartler wrote: To be honest, I'd like to remove the cleanup daemon completely and integrate the cleanup into the listsessions command. The current implementation of the cleanup daemon in perl that

Re: [X2go-Dev] Clean sessions

2011-07-25 Thread Moritz Struebe
On 2011-07-25 14:19, Reinhard Tartler wrote: On Mon, Jul 25, 2011 at 13:52:30 (CEST), Moritz Struebe wrote: On 2011-07-25 13:37, Reinhard Tartler wrote: To be honest, I'd like to remove the cleanup daemon completely and integrate the cleanup into the listsessions command. The current

Re: [X2go-Dev] [PATCH] Allow users to edit their *own* sessions only

2011-07-25 Thread John A. Sullivan III
On Mon, 2011-07-25 at 13:19 +0200, Mike Gabriel wrote: Hi John, On Mo 25 Jul 2011 12:32:44 CEST John A. Sullivan III wrote: On Mon, 2011-07-25 at 08:32 +0200, Mike Gabriel wrote: Hi Reinhard, On Mo 25 Jul 2011 00:10:03 CEST Reinhard Tartler wrote: previously, users could create

Re: [X2go-Dev] Clean sessions (Was: Allow users to edit their *own* sessions only)

2011-07-25 Thread Mike Gabriel
Hi Morty, On Mo 25 Jul 2011 13:52:30 CEST Moritz Struebe wrote: On 2011-07-25 13:37, Reinhard Tartler wrote: To be honest, I'd like to remove the cleanup daemon completely and integrate the cleanup into the listsessions command. The current implementation of the cleanup daemon in perl that