Re: [X2Go-Dev] Code formatting

2020-05-20 Thread Melroy van den Berg
Indeed Stefan! XFCE has even a docker image for their testing, check it out: https://hub.docker.com/r/schuellerf/xfce-test They capture actually a whole video and automatically post that on a YT channel: https://www.youtube.com/user/schuellerf/videos I found that fascinating. But maybe X2Go shou

Re: [X2Go-Dev] Code formatting

2020-05-20 Thread Melroy van den Berg
Hi Uli, Thanks for the links to Xorg. > As always this is quite difficult to achieve for a client/server setup > with interactive tools I don't agree. Unit testing is a test technique were you isolate the code from the rest of the context and create a stub/mock in place of that. This allows

Re: [X2Go-Dev] Code formatting

2020-05-20 Thread Stefan Baur
Am 20.05.20 um 22:09 schrieb Ulrich Sibiller: > Yeah, that's right. But I was referring to session start, ssh stuff and > interactive user input. Actually, I could imagine setting up something that starts X2GoClient, starts a session, fakes some user input and then takes a screenshot of the remote

Re: [X2Go-Dev] Code formatting

2020-05-20 Thread Ulrich Sibiller
Yeah, that's right. But I was referring to session start, ssh stuff and interactive user input. Uli Melroy van den Berg schrieb am Mi., 20. Mai 2020, 18:32: > Hi Uli, > > Thanks for the links to Xorg. > > > As always this is quite difficult to achieve for a client/server setup > > with interact

Re: [X2Go-Dev] Code formatting

2020-05-20 Thread Melroy van den Berg
Hi Dave, I'm afraid I was the cause of the start of the discussion. I'm also using VS Code now, which has a built-in way to auto format the code (incl C++). Using the shortcut: Ctrl + Shift + I (capital i) Yet there are otherwise, like [clang auto formatter](https://clang.llvm.org/docs/ClangFor

[X2Go-Dev] Bug#1469: Re: Bug#1469: But wait; there is more... patches!

2020-05-20 Thread Melroy van den Berg
Hi Mike, Thanks for your reply. Are are my thoughts. > Using (std::)endl is actually a bug Ah, thanks for the heads-up! I think in that case we should in fact remove all the endl instead of adding it :). > Strictly speaking, though, this should not cause any issues Why was I getting socket er

Re: [X2Go-Dev] Windows nightly crashes

2020-05-20 Thread Melroy van den Berg
Hi Uli, Try to debug the code using the debugger? Adding print lines is not the way to do it. I hope somebody can say how to re-compile the code with debug symbols and if gdb is good enough? Kind regards, Melroy van den Berg ‐‐‐ Original Message ‐‐‐ Op woensdag, mei 20, 2020 2:16 PM,

Re: [X2Go-Dev] x2goclient in focal ppa

2020-05-20 Thread x2go-dev
Hello Mike, On 2020-05-19 19:52 2, Mike Gabriel wrote: I'd rather suggest merging more of the official x2goclient DEB into upstream DEB packaging, in fact. Ideally, you should prefer Qt5 over Qt4 builds (swap build-dependencies around). thanks for you suggestion. After reverting my changes fro

Re: [X2Go-Dev] Code formatting

2020-05-20 Thread Ulrich Sibiller
On Wed, May 20, 2020 at 5:20 PM Melroy van den Berg wrote: > I'm afraid I was the cause of the start of the discussion. I'm also using VS > Code now, which has a built-in way to auto format the code (incl C++). > Using the shortcut: Ctrl + Shift + I (capital i) > > Yet there are otherwise, like c

Re: [X2Go-Dev] Windows nightly crashes

2020-05-20 Thread Ulrich Sibiller
On Wed, May 20, 2020 at 5:08 PM Melroy van den Berg wrote: > Try to debug the code using the debugger? Adding print lines is not the way > to do it. "the debugger" is something I don't know. I am not developing software on Windows (I am not even using Windows if I can avoid it). Therefore I also

[X2Go-Dev] Bug#1473: Cinnamon icon is loaded as a cog not the official Cinnamon logo

2020-05-20 Thread Dave Chamberlin-Kidd
Package: x2goclient Version: 4.1.2.3 Severity: wishlist Tag: patch When the original code to load the Cinnamon icon was implemented it appears there wasn't an official icon. There is now. There is no error message as the code works as is but an incorrect icon is used for Cinnamon. This patch repl

Re: [X2Go-Dev] Windows nightly crashes

2020-05-20 Thread Ulrich Sibiller
Running with --libssh-packetlog shows a bit more: [2020/05/20 14:08:36.287745, 2] ssh_socket_connect: Nonblocking connection socket: 2228 [2020/05/20 14:08:36.287745, 2] ssh_connect: Socket connecting, now waiting for the callbacks to work [2020/05/20 14:08:36.288743, 3] ssh_connect: Actual time

Re: [X2Go-Dev] Windows nightly crashes

2020-05-20 Thread Ulrich Sibiller
Running with --libssh-debug does not provide any further hint: x2go-DEBUG-../src/sshmasterconnection.cpp:805> Session port after config file parse: 22 [2020/05/20 13:49:23.492000, 2] ssh_connect: libssh 0.9.3 (c) 2003-2019 Aris Adamantiadis, Andreas Schneider and libssh contributors. Distributed u

Re: [X2Go-Dev] Windows nightly crashes

2020-05-20 Thread Ulrich Sibiller
Here's the output of the centos7 nightly build x2goclient-4.1.2.3-0.0x2go1.0.git20200520.1947.heuler.el7.x86_64 which is working with the same session setup: x2go-DEBUG-../src/sshmasterconnection.cpp:795> Session port before config file parse: 22 x2go-DEBUG-../src/sshmasterconnection.cpp:805> Sess

[X2Go-Dev] Windows nightly crashes

2020-05-20 Thread Ulrich Sibiller
Hi, both x2goclient for windows 4.1.2.2-20200213 and https://code.x2go.org/releases/binary-win32/x2goclient/heuler/mingw32-4.8/qt-4.8/x2goclient-4.1.2.3-2020.05.20-a1a2f62-setup.exe are crashing during connection establishment when using a proxy (output from the debug build): x2go-DEBUG-../src/on

[X2Go-Dev] Bug#1469: Bug#1469: But wait; there is more... patches!

2020-05-20 Thread Mihai Moldovan
* On 5/19/20 11:24 PM, Melroy van den Berg wrote: > As Mike suggested, I redone all changes (plus even some more bonus items). > Since I was in a separate git branch I could run the format-patch easily > via:git > format-patch master. Thanks for the suggestion. > > @Uli I'm using the auto-formatt

[X2Go-Dev] Processed: X2Go issue (in src:x2goclient) has been marked as pending for release

2020-05-20 Thread X2Go Bug Tracking System
Processing commands for cont...@bugs.x2go.org: > tag #1469 pending Bug #1469 [x2goclient] X2Go Client connection issue (Socket error) Added tag(s) pending. > fixed #1469 4.1.2.3 Bug #1469 [x2goclient] X2Go Client connection issue (Socket error) There is no source info for the package 'x2goclient'

[X2Go-Dev] Bug#1469: X2Go issue (in src:x2goclient) has been marked as pending for release

2020-05-20 Thread Mihai Moldovan
tag #1469 pending fixed #1469 4.1.2.3 thanks Hi! X2Go issue #1469 (src:x2goclient) reported by you has been fixed in X2Go Git. You can see the changelog below, and you can check the diff of the fix at: https://code.x2go.org/gitweb?p=x2goclient.git;a=commitdiff;h=56d82b912b3b92508fe21035e075