Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 03:25 +, Hu, Robert wrote: Though no harm as far as I see now, I cannot forcast any harm in the future. Anyway, this 'nestedhvm' is for a nested usage. Better to enable it when we are actually going enable a nested environment. Practically, we can do it in either

Re: [Xen-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Chen, Tiejun
On 2015/3/24 18:20, Ian Campbell wrote: On Tue, 2015-03-24 at 18:15 +0800, Chen, Tiejun wrote: On 2015/3/24 17:51, Ian Campbell wrote: On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: All guys, Thanks for your reply. Sorry to bother you. I have a question to two files,

Re: [Xen-devel] [PATCH 11/29] libxl: events: Make libxl__async_exec_* pass caller an rc

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:09 +, Ian Jackson wrote: The internal user of libxl__async_exec_start et al now gets an rc as well as the process's exit status. For now this is always either 0 or ERROR_FAIL, but with ao cancellation this will possibly be CANCELLED or TIMEDOUT too.

Re: [Xen-devel] [PATCH 20/29] libxl: cancellation: Note that driver domain task cannot be usefully cancelled

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: In practice, cancelling this task will cause all subsequent actual backend operations to fail, but will not actually cause the libxl_device_events_handler operation to complete. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com CC:

Re: [Xen-devel] [PATCH v2 7/7] tools: add tools support for Intel CAT

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 19:20 +0800, Chao Peng wrote: On Thu, Mar 19, 2015 at 12:51:19PM +, Ian Campbell wrote: On Thu, 2015-03-19 at 18:41 +0800, Chao Peng wrote: This is the xc/xl changes to support Intel Cache Allocation Technology(CAT). Two commands are introduced: - xl

Re: [Xen-devel] [PATCH OSSTEST 1/2] uboot: use readlink -f

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 11:45 +, Wei Liu wrote: If the path is not a symlink, readlink by default returns empty string. Use -f to always return canonical path. This fixes the problem that xenpolicy file not getting loaded (because it is not a symlink). Also change another spot that calls

Re: [Xen-devel] ocaml libxl bindings and KeyedUnion

2015-03-24 Thread Olaf Hering
On Fri, Mar 20, Ian Campbell wrote: On Fri, 2015-03-20 at 17:44 +0100, Olaf Hering wrote: + (dev, Struct(None, [(m, libxl_vscsi_hctl)])), + (wwn, Struct(None, [(m, string)])), + (hctl, Struct(None, [(m, libxl_vscsi_hctl)])), Aside: What is the difference

Re: [Xen-devel] [PATCH OSSTEST 2/2] uboot: make flask loading address host property

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 11:45 +, Wei Liu wrote: Signed-off-by: Wei Liu wei.l...@citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH OSSTEST] standalone: Add --dry-run option for run-job.

2015-03-24 Thread Ian Jackson
Ian Campbell writes ([PATCH OSSTEST] standalone: Add --dry-run option for run-job.): Signed-off-by: Ian Campbell ian.campb...@citrix.com Acked-by: Ian Jackson ian.jack...@eu.citrix.com ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [PATCH 1/3] libxl: check whether vcpu affinity and vnuma info match

2015-03-24 Thread Dario Faggioli
More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu also has, in its (hard or soft) affinity, some pcpus that are not part of the said pnode, print a warning to the user. Signed-off-by: Dario Faggioli dario.faggi...@citrix.com Cc: Ian Campbell

[Xen-devel] [PATCH 2/3] libxl: automatically set soft affinity after vnuma info

2015-03-24 Thread Dario Faggioli
More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu does not have any soft affinity, automatically build up one, matching the pcpus of the said pnode. Signed-off-by: Dario Faggioli dario.faggi...@citrix.com Cc: Ian Campbell ian.campb...@citrix.com

[Xen-devel] [PATCH 0/3] Automatically derive soft affinity from vnuma information

2015-03-24 Thread Dario Faggioli
Hi, This small series is meant at achieving the following two goals: - when building a vnuma enabled guest, if any vcpu hard or soft affinity is specified, and that does not match with the vnuma configuration supplied (e.g., vcpu X, belonging to vnode Y on pnode W, has affinity with pcpus

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Ian Campbell
On Fri, 2015-03-20 at 15:12 +, Jan Beulich wrote: ... and convert several gdprintk()-s to it, as the next patch will make them no-ops in non-debug builds. Note that as a non-debug facility this does not print file name and line number of the origin, to people are expected to use

Re: [Xen-devel] [PATCH V13 5/7] xen/arm: Instruction prefetch abort (X) mem_event handling

2015-03-24 Thread Tamas K Lengyel
On Mon, Mar 23, 2015 at 5:47 PM, Tamas K Lengyel tamas.leng...@zentific.com wrote: On Mon, Mar 23, 2015 at 5:22 PM, Ian Campbell ian.campb...@citrix.com wrote: On Mon, 2015-03-23 at 16:47 +0100, Tamas K Lengyel wrote: On Mon, Mar 23, 2015 at 4:18 PM, Ian Campbell

Re: [Xen-devel] [PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 12:37 +, Ian Jackson wrote: Ian Campbell writes ([PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs): We already arrange by more adhoc means to repeat a localhost migration 10 times. Assuming you have tested this and observed that it

Re: [Xen-devel] [PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs

2015-03-24 Thread Ian Jackson
Ian Campbell writes (Re: [Xen-devel] [PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs): From: Ian Campbell ian.campb...@citrix.com Date: Wed, 11 Mar 2015 10:08:57 + Subject: [PATCH] start/stop the guest 10 times in the standard test jobs Acked-by: Ian Jackson

Re: [Xen-devel] Xen unstability on HP Moonshot m400

2015-03-24 Thread Mark Salter
On Mon, 2015-03-23 at 23:58 +, Stefano Stabellini wrote: On Mon, 23 Mar 2015, Christoffer Dall wrote: On Mon, Mar 23, 2015 at 1:36 PM, Ian Campbell ian.campb...@citrix.com wrote: On Sat, 2015-03-21 at 13:34 +0100, Christoffer Dall wrote: Hi, I have been

Re: [Xen-devel] Xen unstability on HP Moonshot m400

2015-03-24 Thread Mark Salter
On Tue, 2015-03-24 at 09:54 -0400, Mark Salter wrote: On Mon, 2015-03-23 at 23:58 +, Stefano Stabellini wrote: On Mon, 23 Mar 2015, Christoffer Dall wrote: On Mon, Mar 23, 2015 at 1:36 PM, Ian Campbell ian.campb...@citrix.com wrote: On Sat, 2015-03-21 at 13:34 +0100,

[Xen-devel] [linux-3.16 test] 36613: regressions - trouble: broken/fail/pass

2015-03-24 Thread xen . org
flight 36613 linux-3.16 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36613/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 15 guest-localmigrate/x10fail REGR. vs. 34167 test-amd64-i386-pair

Re: [Xen-devel] [PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs

2015-03-24 Thread Ian Jackson
Ian Campbell writes ([PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs): We already arrange by more adhoc means to repeat a localhost migration 10 times. Assuming you have tested this and observed that it generates the right testid, Acked-by: Ian Jackson

Re: [Xen-devel] [PATCH OSSTEST] Arrange for core dumps to be placed in /var/core and collect them

2015-03-24 Thread Ian Jackson
Ian Campbell writes ([PATCH OSSTEST] Arrange for core dumps to be placed in /var/core and collect them): Refactor the $kvp_replace helper in ts-xen-install into a generic helper (which requires using ::EO and ::EI for namespacing) for use with target_editfile [etc.] Acked-by: Ian Jackson

Re: [Xen-devel] [PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 12:42 +, Ian Campbell wrote: On Tue, 2015-03-24 at 12:37 +, Ian Jackson wrote: Ian Campbell writes ([PATCH OSSTEST] start/stop the guest 10 times in the standard test jobs): We already arrange by more adhoc means to repeat a localhost migration 10 times.

[Xen-devel] [PATCH OSSTEST] standalone: Add --dry-run option for run-job.

2015-03-24 Thread Ian Campbell
Signed-off-by: Ian Campbell ian.campb...@citrix.com --- standalone | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/standalone b/standalone index caf3fd5..d8113e4 100755 --- a/standalone +++ b/standalone @@ -17,7 +17,7 @@ Operations: Setup dist path runvars for JOB

Re: [Xen-devel] [PATCH 2/2] make {,g}dprintk() a no‑op in non‑debug builds

2015-03-24 Thread Ian Campbell
On Fri, 2015-03-20 at 15:13 +, Jan Beulich wrote: As discussed before, code absolutely wanting to get something into the log should use {,g}printk() instead. Signed-off-by: Jan Beulich jbeul...@suse.com Acked-by: Ian Campbell ian.campb...@citrix.com

Re: [Xen-devel] [PATCH v19 07/14] x86/VPMU: Initialize PMU for PV(H) guests

2015-03-24 Thread Jan Beulich
On 17.03.15 at 15:54, boris.ostrov...@oracle.com wrote: @@ -263,14 +264,14 @@ void vpmu_initialise(struct vcpu *v) BUILD_BUG_ON(sizeof(struct xen_pmu_intel_ctxt) XENPMU_CTXT_PAD_SZ); BUILD_BUG_ON(sizeof(struct xen_pmu_amd_ctxt) XENPMU_CTXT_PAD_SZ); -if ( is_pvh_vcpu(v) ) -

Re: [Xen-devel] [PATCH OSSTEST] Arrange for core dumps to be placed in /var/core and collect them

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 12:40 +, Ian Jackson wrote: Ian Campbell writes ([PATCH OSSTEST] Arrange for core dumps to be placed in /var/core and collect them): Refactor the $kvp_replace helper in ts-xen-install into a generic helper (which requires using ::EO and ::EI for namespacing) for

Re: [Xen-devel] [PATCH v19 05/14] x86/VPMU: Interface for setting PMU mode and flags

2015-03-24 Thread Jan Beulich
On 17.03.15 at 15:54, boris.ostrov...@oracle.com wrote: Add runtime interface for setting PMU mode and flags. Three main modes are provided: * XENPMU_MODE_OFF: PMU is not virtualized * XENPMU_MODE_SELF: Guests can access PMU MSRs and receive PMU interrupts. * XENPMU_MODE_HV: Same as

[Xen-devel] [PATCH 3/3] libxl: cleanup some misuse of 'cpumap' as parameter

2015-03-24 Thread Dario Faggioli
in favour of the more generic 'bitmap', which is better since these are generic libxl_bitmap_* functions. Also fix a typo, and remove a stale (and wrong) comment. No functional change intended. Signed-off-by: Dario Faggioli dario.faggi...@citrix.com Cc: Ian Campbell ian.campb...@citrix.com Cc:

Re: [Xen-devel] [PATCH 2/2] x86: Don't use BAD_APICID for non-APICID fields

2015-03-24 Thread Boris Ostrovsky
On 03/24/2015 04:07 AM, Jan Beulich wrote: On 23.03.15 at 20:54, boris.ostrov...@oracle.com wrote: BAD_APICID is used by cpuinfo_x86's phys_proc_id, cpu_core_id and compute_unit_id even though these fields don't hold an APIC ID itself but rather its derivative. Provide appropriate macros for

Re: [Xen-devel] [PATCH v2] xen/passthrough: Support a single iommu_domain per xen domain per SMMU

2015-03-24 Thread Robert VanVossen
On 3/24/2015 7:07 AM, Manish Jaggi wrote: On Monday 23 March 2015 07:16 PM, Robbie VanVossen wrote: If multiple devices are being passed through to the same domain and they share a single SMMU, then they only require a single iommu_domain. In arm_smmu_assign_dev, before a new iommu_domain

Re: [Xen-devel] [PATCH v19 08/14] x86/VPMU: Save VPMU state for PV guests during context switch

2015-03-24 Thread Jan Beulich
On 17.03.15 at 15:54, boris.ostrov...@oracle.com wrote: Save VPMU state during context switch for both HVM and PV(H) guests. A subsequent patch (x86/VPMU: NMI-based VPMU support) will make it possible for vpmu_switch_to() to call vmx_vmcs_try_enter()-vcpu_pause() which needs is_running to

Re: [Xen-devel] [PATCH 02/29] libxl: Comment cleanups

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:09 +, Ian Jackson wrote: * Add two comments in libxl_remus_disk_drbd documenting buggy handling of the hotplug script exit status. * Add a section heading for async exec in libxl_aoutils.c * Mention the right function name (libxl__ev_child_fork, not

Re: [Xen-devel] [PATCH 01/29] libxl: Further fix exit paths from libxl_device_events_handler

2015-03-24 Thread Ian Campbell
On Wed, 2015-02-18 at 17:23 +0100, Roger Pau Monné wrote: El 10/02/15 a les 21.09, Ian Jackson ha escrit: On the success path, do not call GC_FREE explicitly. Instead, call AO_INPROGRESS. GC_FREE will free the gc underlying the long-term ao, which is then subsequently referenced in

Re: [Xen-devel] [PATCH 08/29] libxl: devstate: Use libxl__xswait*

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:09 +, Ian Jackson wrote: Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 28/29] libxl: ao: datacopier callback gets an rc

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: libxl__datacopier_* now provides its caller's callback function with an rc value. This relieves the caller of the need to figure out an appropriate rc value. Arrange that the `other internal failure' cases now get a valid positive errno

Re: [Xen-devel] [RFC PATCH v2 13/22] xen/arm: its: Add virtual ITS command support

2015-03-24 Thread Julien Grall
Hello Vijay, More questions/remarks about command processing. On 19/03/2015 14:38, vijay.kil...@gmail.com wrote: +int vgic_its_process_cmd(struct vcpu *v, struct vgic_its *vits) +{ +struct its_cmd_block virt_cmd; + +/* XXX: Currently we are processing one cmd at a time */ +

[Xen-devel] [PATCH v4] xen/arm: Add RESERVE option to reserve non-leaf level table entries

2015-03-24 Thread vijay . kilari
From: Vijaya Kumar K vijaya.ku...@caviumnetworks.com On x86, for the pages mapped with PAGE_HYPERVISOR attribute non-leaf page tables are allocated with valid pte entries. and with MAP_SMALL_PAGES attribute only non-leaf page tables are allocated with invalid (valid bit set to 0) pte entries.

[Xen-devel] [PATCH OSSTEST 0/2] Uboot patches for XSM test case

2015-03-24 Thread Wei Liu
Wei Liu (2): uboot: use readlink -f uboot: make flask loading address host property Osstest/Debian.pm | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) -- 1.9.1 ___ Xen-devel mailing list Xen-devel@lists.xen.org

[Xen-devel] [PATCH OSSTEST 2/2] uboot: make flask loading address host property

2015-03-24 Thread Wei Liu
Signed-off-by: Wei Liu wei.l...@citrix.com --- Please set host property 'UBootSetFlaskAddrR' to 0x120. --- Osstest/Debian.pm | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Osstest/Debian.pm b/Osstest/Debian.pm index b829878..9f7705e 100644 --- a/Osstest/Debian.pm

[Xen-devel] [PATCH OSSTEST 1/2] uboot: use readlink -f

2015-03-24 Thread Wei Liu
If the path is not a symlink, readlink by default returns empty string. Use -f to always return canonical path. This fixes the problem that xenpolicy file not getting loaded (because it is not a symlink). Also change another spot that calls readlink to get xen binary path in case in the future we

Re: [Xen-devel] [PATCH 18/29] libxl: cancellation: Provide explicit internal cancel check API

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: Some places in libxl which can't handle cancellation via a libxl__ao_cancellable callback might nevertheless benefit from being able to explicitly check for cancellation. Provide the (fairly trivial) internal API function to do this.

Re: [Xen-devel] Design and Question: Eliminate Xen (RTDS) scheduler overhead on dedicated CPU

2015-03-24 Thread George Dunlap
On Tue, Mar 24, 2015 at 3:50 AM, Meng Xu xumengpa...@gmail.com wrote: Hi Dario and George, I'm exploring the design choice of eliminating the Xen scheduler overhead on the dedicated CPU. A dedicated CPU is a PCPU that has a full capacity VCPU pinned onto it and no other VCPUs will run on that

Re: [Xen-devel] [PATCH 1/5] tools/mkrpm: improve version.release handling

2015-03-24 Thread Olaf Hering
On Mon, Mar 23, George Dunlap wrote: On 03/23/2015 06:49 PM, Olaf Hering wrote: release will be anything after a dash, or 0. And an optional .$PKG_RELEASE will be appended. Just trying to decode this: So if I were using PKG_RELEASE=$(date ...), then I'd get something like

Re: [Xen-devel] [PATCH 27/29] libxl: cancellation: Cancel libxc save/restore

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: Register the the save/restore helper interface with the cancellation machinery. When we are informed that save/restore should be cancelled, we make a note of the that in our rc variable, and send the helper a SIGTERM. It will die in due

Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 05:13 +, Pang, LongtaoX wrote: So, maybe I should write some code in 'ts-nested-setup' script to implement ssh into L1, edit sources.list and comment out the CDROM repo entry. Please do it in ts-debian-hvm-install, either as a postinst step or, better (IMHO), by

Re: [Xen-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 18:15 +0800, Chen, Tiejun wrote: On 2015/3/24 17:51, Ian Campbell wrote: On Tue, 2015-03-24 at 16:47 +0800, Chen, Tiejun wrote: All guys, Thanks for your reply. Sorry to bother you. I have a question to two files, tools/python/xen/lowlevel/xc/xc.c and

Re: [Xen-devel] One question to lowlevel/xl/xl.c and lowlevel/xc/xc.c

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 18:31 +0800, Chen, Tiejun wrote: NB, the libxl ones are broken and not even compiled right now, you can ignore them. Looks this is still compiled now. xc is, xl is not, I am sure of that. I don't know what the semantics of flag is, if it is per SBDF then I Yes,

Re: [Xen-devel] [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs

2015-03-24 Thread Ian Jackson
Ian Campbell writes (Re: [OSSTEST Nested PATCH 2/6] Add and expose some testsupport APIs): On Tue, 2015-03-24 at 03:34 +, Hu, Robert wrote: Make it an option to the function which creates the configuration in the first place. Quoting myself from earlier in this very thread: Then we

Re: [Xen-devel] [PATCH 21/29] libxl: cancellation: Make spawns cancellable

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: The libxl__spawn_spawn internal API permits the caller to specify .timeout_ms==-1, meaning to wait forever. Provide an explicit cancellable to allow spawns to be cancelled. AIUI this also lets spawns with timeout_ms -1 to be cancelled,

Re: [Xen-devel] [PATCH 29/29] libxl: cancellation: Make datacopiers cancellable

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: libxl__datacopier_* can now actually generate a callback with rc==CANCELLED. This provides cancellation during some corner cases, including (at least) copying the device model data during the end of domain save. Signed-off-by: Ian

Re: [Xen-devel] [PATCH 23/29] libxl: cancellation: Support cancellation where we spot domain death

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: Make an active libxl__domaindeathcheck contain an active libxl__ao_cancellable. Consequential changes are: * domaindeath callbacks now take an rc value. * libxl__domaindeathcheck_start takes an ao, not a gc. * bootloader_domaindeath

Re: [Xen-devel] [PATCH 26/29] libxl: cancellation: Handle SIGTERM in save/restore helper

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: During startup of the save/restore helper, set the disposition of SIGTERM appropriately. For restore, we can simply die immediately - there is no point trying to do any kind of cleanup on what is now going to be a trashed domain. For

Re: [Xen-devel] [PATCH 04/29] libxl: suspend: common suspend callbacks take rc

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:09 +, Ian Jackson wrote: Change the following functions to take a libxl error code rather than a boolean ok value, and translate that value to the boolean expected by libxc at the last moment: domain_suspend_callback_common_done} dss-callback_common_done

Re: [Xen-devel] [PATCH 17/29] libxl: cancellation: Provide public ao cancellation API

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: +/* + * It is sometimes possible to cancel an asynchronous operation. + * + * libxl_ao_cancel searches for an ongoing asynchronous operation whose + * ao_how is identical to *how, and tries to cancel it. I can see that you have arranged

Re: [Xen-devel] [PATCH 22/29] libxl: Introduce DOMAIN_DESTROYED error code

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: This is currently reported only by the bootloader code, if the domain is destroyed while the bootloader is running. In the future it would be nice to return it for other circumstances where the domain existed when the operation started

Re: [Xen-devel] [PATCH 03/29] libxl: suspend: switch_logdirty_done takes rc

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:09 +, Ian Jackson wrote: +int broke; +if (rc) { +broke = -1; +} else { +broke = 0; +} int broke = rc ? -1 : 0; ? But it looks like perhaps you are preparing to add other code in one or the other case, or maybe you just prefer

Re: [Xen-devel] [PATCH v2 7/7] tools: add tools support for Intel CAT

2015-03-24 Thread Chao Peng
On Thu, Mar 19, 2015 at 12:51:19PM +, Ian Campbell wrote: On Thu, 2015-03-19 at 18:41 +0800, Chao Peng wrote: This is the xc/xl changes to support Intel Cache Allocation Technology(CAT). Two commands are introduced: - xl psr-cat-cbm-set [-s socket] domain cbm Set cache capacity

Re: [Xen-devel] [PATCH 19/29] libxl: cancellation: Make timeouts cancellable

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: Make libxl__ev_time* register with the cancellation machinery, so that libxl_ao_cancel can cancel any operation which has a timeout. Signed-off-by: Ian Jackson ian.jack...@eu.citrix.com Acked-by: Ian Campbell ian.campb...@citrix.com

Re: [Xen-devel] [PATCH 17/29] libxl: cancellation: Provide public ao cancellation API

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: +/* + * For nested aos: + * Semantically, cancellation affects the whole tree of aos, + *not just the parent. + * libxl__ao_cancellable.ao refers to the child, so + *that the child callback sees the right

Re: [Xen-devel] [PATCH 24/29] libxl: Introduce FILLZERO

2015-03-24 Thread Ian Campbell
On Tue, 2015-02-10 at 20:10 +, Ian Jackson wrote: FILLZERO is a macro for memset(foo,0,sizeof(foo)). It eliminates the possiblity to make the error memset(foo,0,sizeof(foo)). but not: foo *p = allocate_a_foo() memset(p, 0, sizeof(p)) although that's probably less likely to go

Re: [Xen-devel] [libvirt] [PATCH 00/10] libxl: switch driver to use a single libxl_ctx

2015-03-24 Thread Jim Fehlig
Michal Privoznik wrote: On 18.02.2015 04:56, Jim Fehlig wrote: This series is a follow up to https://www.redhat.com/archives/libvir-list/2015-February/msg00024.html It goes a step further and changes the libxl driver to use one, driver-wide libxl_ctx. Currently the libxl driver has one

Re: [Xen-devel] 3.18 xen-pcifront regression?

2015-03-24 Thread Michael D Labriola
Bjorn Helgaas bhelg...@google.com wrote on 03/24/2015 01:27:02 PM: From: Bjorn Helgaas bhelg...@google.com To: Konrad Rzeszutek Wilk konrad.w...@oracle.com, Cc: Michael D Labriola mlabr...@gdeb.com, xen- de...@lists.xenproject.org, Stuart Wehrly sweh...@gdeb.com,

[Xen-devel] [qemu-upstream-unstable test] 36688: tolerable FAIL - PUSHED

2015-03-24 Thread xen . org
flight 36688 qemu-upstream-unstable real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36688/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-libvirt 9 guest-start fail like 33488

[Xen-devel] Outreachy (formerly OPW) application deadline extended to April 7

2015-03-24 Thread Lars Kurth
FYI: Will update the web pages and blog post Begin forwarded message: Subject: Re: [COORDINATION] Extend your applicant deadline? From: Lars Kurth lars.kurth@gmail.com Date: 24 March 2015 14:08:29 GMT Cc: outreachy-adm...@gnome.org, outreachy-l...@gnome.org To: Sarah A Sharp

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Ian Campbell
On Tue, 2015-03-24 at 15:12 +, Julien Grall wrote: Hi Ian, On 24/03/2015 14:20, Ian Campbell wrote: @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, break; default: { -#ifndef NDEBUG struct hsr_cp64 cp64 =

Re: [Xen-devel] [PATCH v3 7/7] libxl/vcpu-set - allow to decrease vcpu count on overcommitted guests (v3)

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 14:21 -0400, Konrad Rzeszutek Wilk wrote: We have a check to warn the user if they are overcommitting. But the check only checks the hosts CPU amount and does not take into account the case when the user is trying to fix the overcommit. That is - they want to limit the

[Xen-devel] [PATCH v2 2/2] iommu: add rmrr Xen command line option for misc rmrrs

2015-03-24 Thread elena . ufimtseva
From: Elena Ufimtseva elena.ufimts...@oracle.com On some platforms RMRR regions may be not specified in ACPI and thus will not be mapped 1:1 in dom0. This causes IO Page Faults and prevents dom0 from booting in PVH mode. New Xen command line option rmrr allows to specify such devices and memory

[Xen-devel] [PATCH v2 1/2] iommu VT-d: separate rmrr addition function

2015-03-24 Thread elena . ufimtseva
From: Elena Ufimtseva elena.ufimts...@oracle.com In preparation for auxiliary RMRR data provided on Xen command line, make RMRR adding a separate function. No functional changes. Signed-off-by: Elena Ufimtseva elena.ufimts...@oracle.com --- xen/drivers/passthrough/vtd/dmar.c | 125

Re: [Xen-devel] [PATCH 2/5] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

2015-03-24 Thread Ian Campbell
On Fri, 2015-03-20 at 18:24 +0100, Olaf Hering wrote: It is already used in the runlevel script and the service file. Signed-off-by: Olaf Hering o...@aepfle.de Acked-by: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Stefano Stabellini

Re: [Xen-devel] [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path

2015-03-24 Thread Ian Campbell
On Fri, 2015-03-20 at 16:19 +, Wei Liu wrote: +_hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t dm_domid, + uint32_t domid, + const char *format, ...); This should have the PRINTF_ATTRIBUTE

Re: [Xen-devel] [v3][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 09:17 +0800, Tiejun Chen wrote: Although we already have 'gfx_passthru' in b_info, this doesn' suffice ^t after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to

Re: [Xen-devel] [PATCH v3] xentop: add support for qdisks

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 20:55 -0600, Charles Arnold wrote: +/* Get up to 1024 active domains */ What I meant last time was, is this limitation a concern? What if there are 1025 domains? If this is a concern then perhaps refactor such that the qdisk stats gathering collection can happen from the

Re: [Xen-devel] [PATCH v3 1/7] libxl: Add ERROR_DOMAIN_NOTFOUND for libxl_domain_info when it cannot find the domain

2015-03-24 Thread Ian Campbell
Please remember to CC all the relevant maintainers, e.g. Wei and Ian in addition to me. MAINTAINERS is helpful here. On Mon, 2015-03-23 at 14:20 -0400, Konrad Rzeszutek Wilk wrote: And use that for all of its callers in the tree. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com

Re: [Xen-devel] [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path

2015-03-24 Thread Wei Liu
On Tue, Mar 24, 2015 at 02:32:42PM +, Ian Campbell wrote: On Fri, 2015-03-20 at 16:19 +, Wei Liu wrote: +_hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t dm_domid, + uint32_t domid, +

Re: [Xen-devel] [PATCH 3/3] libxl: cleanup some misuse of 'cpumap' as parameter

2015-03-24 Thread Wei Liu
On Tue, Mar 24, 2015 at 02:42:27PM +0100, Dario Faggioli wrote: in favour of the more generic 'bitmap', which is better since these are generic libxl_bitmap_* functions. Also fix a typo, and remove a stale (and wrong) comment. No functional change intended. Signed-off-by: Dario Faggioli

Re: [Xen-devel] [PATCH 2/3] libxl: automatically set soft affinity after vnuma info

2015-03-24 Thread Dario Faggioli
On Tue, 2015-03-24 at 14:32 +, Wei Liu wrote: On Tue, Mar 24, 2015 at 02:42:15PM +0100, Dario Faggioli wrote: More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu does not have any soft affinity, automatically build up one, matching the

Re: [Xen-devel] [PATCH v19 11/14] x86/VPMU: Handle PMU interrupts for PV guests

2015-03-24 Thread Boris Ostrovsky
On 03/24/2015 10:28 AM, Jan Beulich wrote: On 17.03.15 at 15:54, boris.ostrov...@oracle.com wrote: Changes in v19: * Adjusted for new ops interfaces (passing vcpu vs. vpmu) * Test for domain-max_cpu in choose_hwdom_vcpu() instead of 'domain-vcpu!=NULL' I suppose that's something that then

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Julien Grall
Hi Jan, On 24/03/2015 15:31, Jan Beulich wrote: On 24.03.15 at 16:12, julien.gr...@linaro.org wrote: Hi Ian, On 24/03/2015 14:20, Ian Campbell wrote: @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, break; default: { -#ifndef NDEBUG

Re: [Xen-devel] [PATCH v19 11/14] x86/VPMU: Handle PMU interrupts for PV guests

2015-03-24 Thread Jan Beulich
On 17.03.15 at 15:54, boris.ostrov...@oracle.com wrote: Changes in v19: * Adjusted for new ops interfaces (passing vcpu vs. vpmu) * Test for domain-max_cpu in choose_hwdom_vcpu() instead of 'domain-vcpu!=NULL' I suppose that's something that then should also be done in patch 7? ---

Re: [Xen-devel] [PATCH 2/3] libxl: automatically set soft affinity after vnuma info

2015-03-24 Thread Wei Liu
On Tue, Mar 24, 2015 at 02:42:15PM +0100, Dario Faggioli wrote: More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu does not have any soft affinity, automatically build up one, matching the pcpus of the said pnode. What about hard affinity?

Re: [Xen-devel] [PATCH 1/3] libxl: check whether vcpu affinity and vnuma info match

2015-03-24 Thread Wei Liu
On Tue, Mar 24, 2015 at 02:41:48PM +0100, Dario Faggioli wrote: More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu also has, in its (hard or soft) affinity, some pcpus that are not part of the said pnode, print a warning to the user.

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Jan Beulich
On 24.03.15 at 16:12, julien.gr...@linaro.org wrote: Hi Ian, On 24/03/2015 14:20, Ian Campbell wrote: @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, break; default: { -#ifndef NDEBUG struct hsr_cp64 cp64 = hsr.cp64;

[Xen-devel] [PATCH v3 2/3] libxc/xentrace: Replace xc_tbuf_set_cpu_mask with CPU mask with xc_cpumap_t instead of uint32_t

2015-03-24 Thread Konrad Rzeszutek Wilk
We replace the implementation of xc_tbuf_set_cpu_mask with an xc_cpumap_t instead of a uint32_t. This means we can use an arbitrary bitmap without being limited to the 32-bits as previously we were. Furthermore since there is only one user of xc_tbuf_set_cpu_mask we just replace it and its user in

[Xen-devel] [PATCH v3 3/3] xentrace: Implement cpu mask range parsing of human values (-c).

2015-03-24 Thread Konrad Rzeszutek Wilk
Instead of just using -c 0xsome hex value we can also use -c starting cpu-end cpu or -c cpu1,cpu2 or a combination of them. Also it can include just singular CPUs: -c cpu1, or ranges without an start or end (and xentrace will figure out the values), such as: -c -cpu2 (which will include cpu0,

[Xen-devel] [PATCH v3 1/3] libxl/cpumap: Add xc_cpumap_[setcpu, clearcpu, testcpu] to complement xc_cpumap_alloc.

2015-03-24 Thread Konrad Rzeszutek Wilk
We export the xc_cpumap_alloc but not the bit operations. One could include 'xc_bitops.h' but that is naughty - so instead we just export the proper functions to do it on the xc_cpumap_t typedef. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- tools/libxc/include/xenctrl.h | 9

Re: [Xen-devel] [PATCH 1/3] libxl: check whether vcpu affinity and vnuma info match

2015-03-24 Thread Dario Faggioli
On Tue, 2015-03-24 at 14:41 +, Wei Liu wrote: On Tue, Mar 24, 2015 at 02:41:48PM +0100, Dario Faggioli wrote: Currently all the checks that returns error are all guest visible mis-configurations. I'm trying to reason whether we should return an error or just print a warning. What is

Re: [Xen-devel] [PATCH 3/5] INSTALL: mention variables for reproducible builds

2015-03-24 Thread Ian Campbell
On Fri, 2015-03-20 at 18:24 +0100, Olaf Hering wrote: Mention two variables introduced by commit ac977f5 (use more fixed strings to build the hypervisor). Signed-off-by: Olaf Hering o...@aepfle.de Cc: Ian Campbell ian.campb...@citrix.com Cc: Ian Jackson ian.jack...@eu.citrix.com Cc: Jan

Re: [Xen-devel] [PATCH v19 11/14] x86/VPMU: Handle PMU interrupts for PV guests

2015-03-24 Thread Jan Beulich
On 24.03.15 at 16:47, boris.ostrov...@oracle.com wrote: On 03/24/2015 11:36 AM, Jan Beulich wrote: On 24.03.15 at 16:13, boris.ostrov...@oracle.com wrote: On 03/24/2015 10:28 AM, Jan Beulich wrote: On 17.03.15 at 15:54, boris.ostrov...@oracle.com wrote: Changes in v19: * Adjusted for new

Re: [Xen-devel] [PATCH v2] xen/passthrough: Support a single iommu_domain per xen domain per SMMU

2015-03-24 Thread Robert VanVossen
Hello Julien, On 3/23/2015 5:53 PM, Julien Grall wrote: Hello Robert, On 23/03/2015 13:46, Robbie VanVossen wrote: @@ -2569,7 +2570,9 @@ static int arm_smmu_assign_dev(struct domain *d, u8 devfn, { struct iommu_domain *domain; struct arm_smmu_xen_domain *xen_domain; -

[Xen-devel] 3.18 xen-pcifront regression?

2015-03-24 Thread Michael D Labriola
I'm having problems booting a 3.18 or newer domU w/ PCI devices passed through. It only seems to be the domU kernel that's upset (i.e., Behavior is identical whether I'm running 3.19 or 3.13 dom0). I'm running a 32bit dom0 (3.13.11) w/ 64bit 4.4.0 hypervisor and 32bit domU. I get the

Re: [Xen-devel] [PATCH v3 2/7] libxl: Add to libxl__domain_type a new return value (LIBXL_DOMAIN_TYPE_NOTFOUND)

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 14:20 -0400, Konrad Rzeszutek Wilk wrote: So that the callers can distinguish between an error and an domain not found. The exposed API calls that are effected by this are: libxl_domain_[remus_start,suspend,unpause,cdrom_insert, set_vcpuonline] We add an helper

Re: [Xen-devel] [PATCH v2] xen/passthrough: Support a single iommu_domain per xen domain per SMMU

2015-03-24 Thread Julien Grall
On 24/03/2015 15:07, Robert VanVossen wrote: Hello Julien, Hello Robert, On 3/23/2015 5:53 PM, Julien Grall wrote: But don't we need to handle the failure of attach_dev differently based on which fails? If the attach_dev fails on a new iommu_domain, then the iommu_domain should be

Re: [Xen-devel] [PATCH 2/3] libxl: automatically set soft affinity after vnuma info

2015-03-24 Thread Wei Liu
On Tue, Mar 24, 2015 at 03:06:24PM +, Dario Faggioli wrote: On Tue, 2015-03-24 at 14:32 +, Wei Liu wrote: On Tue, Mar 24, 2015 at 02:42:15PM +0100, Dario Faggioli wrote: More specifically, vcpus are assigned to a vnode, which in turn is associated with a pnode. If a vcpu does not

Re: [Xen-devel] 3.18 xen-pcifront regression?

2015-03-24 Thread Konrad Rzeszutek Wilk
On Tue, Mar 24, 2015 at 11:14:29AM -0400, Michael D Labriola wrote: I'm having problems booting a 3.18 or newer domU w/ PCI devices passed through. It only seems to be the domU kernel that's upset (i.e., Behavior is identical whether I'm running 3.19 or 3.13 dom0). I'm running a 32bit

Re: [Xen-devel] Design and Question: Eliminate Xen (RTDS) scheduler overhead on dedicated CPU

2015-03-24 Thread Meng Xu
2015-03-24 7:54 GMT-04:00 George Dunlap george.dun...@eu.citrix.com: On Tue, Mar 24, 2015 at 3:50 AM, Meng Xu xumengpa...@gmail.com wrote: Hi Dario and George, I'm exploring the design choice of eliminating the Xen scheduler overhead on the dedicated CPU. A dedicated CPU is a PCPU that

[Xen-devel] [linux-3.10 test] 36615: regressions - FAIL

2015-03-24 Thread xen . org
flight 36615 linux-3.10 real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36615/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-winxpsp3 7 windows-install fail REGR. vs. 26303 Regressions which are

[Xen-devel] [PATCH v2] tools/mkrpm: improve version.release handling

2015-03-24 Thread Olaf Hering
An increasing version and/or release number helps to update existing packages without --force as in rpm Uvh --force xen.rpm. Instead its possible to do rpm -Fvh *.rpm to update only already installed packages. The usage of --force disables essentials checks such as file conflict detection. As a

Re: [Xen-devel] [PATCH v19 07/14] x86/VPMU: Initialize PMU for PV(H) guests

2015-03-24 Thread Boris Ostrovsky
On 03/24/2015 10:08 AM, Jan Beulich wrote: On 17.03.15 at 15:54, boris.ostrov...@oracle.com wrote: @@ -263,14 +264,14 @@ void vpmu_initialise(struct vcpu *v) BUILD_BUG_ON(sizeof(struct xen_pmu_intel_ctxt) XENPMU_CTXT_PAD_SZ); BUILD_BUG_ON(sizeof(struct xen_pmu_amd_ctxt)

Re: [Xen-devel] [PATCH 1/2] introduce gprintk()

2015-03-24 Thread Julien Grall
Hi Ian, On 24/03/2015 14:20, Ian Campbell wrote: @@ -1709,7 +1707,6 @@ static void do_cp15_64(struct cpu_user_regs *regs, break; default: { -#ifndef NDEBUG struct hsr_cp64 cp64 = hsr.cp64; gdprintk(XENLOG_ERR, @@ -1718,7 +1715,6 @@ static

Re: [Xen-devel] [PATCH v3 5/7] libxl/vcpuset: Return error value if failed.

2015-03-24 Thread Ian Campbell
On Mon, 2015-03-23 at 14:20 -0400, Konrad Rzeszutek Wilk wrote: The function does not return any values at all. Convert the internal libxl errors (ERROR_FAIL, ..., etc) to -1. ITYM +1. Signed-off-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com Acked-by: Ian Campbell ian.campb...@citrix.com

  1   2   >