[Xen-devel] [libvirt test] 59688: regressions - FAIL

2015-07-17 Thread osstest service owner
flight 59688 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/59688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm5 xen-build fail REGR. vs. 58842 build-i386-pvops

[Xen-devel] [xen-unstable bisection] complete test-amd64-amd64-xl-qemut-debianhvm-amd64

2015-07-17 Thread osstest service owner
branch xen-unstable xen branch xen-unstable job test-amd64-amd64-xl-qemut-debianhvm-amd64 test guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/staging/qemu-xen-unstable.git Tre

[Xen-devel] [linux-3.4 test] 59664: regressions - FAIL

2015-07-17 Thread osstest service owner
flight 59664 linux-3.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/59664/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 6 xen-boot fail REGR. vs. 30511 Tests which are failing

[Xen-devel] [linux-next test] 59659: tolerable FAIL

2015-07-17 Thread osstest service owner
flight 59659 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/59659/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail blocked in 59606 test-amd64-i3

[Xen-devel] [xen-unstable test] 59654: regressions - FAIL

2015-07-17 Thread osstest service owner
flight 59654 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/59654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail REGR. vs. 58965 tes

Re: [Xen-devel] Fwd: [v3 14/15] Update Posted-Interrupts Descriptor during vCPU scheduling

2015-07-17 Thread Wu, Feng
> -Original Message- > From: Dario Faggioli [mailto:dario.faggi...@citrix.com] > Sent: Friday, July 17, 2015 6:14 PM > To: Wu, Feng > Cc: Jan Beulich; Tian, Kevin; k...@xen.org; George Dunlap; > andrew.coop...@citrix.com; xen-devel; Zhang, Yang Z > Subject: Re: [Xen-devel] Fwd: [v3 14/15]

Re: [Xen-devel] [PATCH v5 07/15] VMX: add VMFUNC leaf 0 (EPTP switching) to emulator.

2015-07-17 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Tuesday, July 14, 2015 7:04 AM > On 14.07.15 at 02:14, wrote: >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -1436,6 +1436,19 @@ static int hvmemul_invlpg( >> return rc; >> } >> >> +static int hvmemul_v

Re: [Xen-devel] [PATCH v3 05/13] x86/altp2m: basic data structures and support routines.

2015-07-17 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 16, 2015 2:02 AM > On 16.07.15 at 10:48, wrote: >>> From: Jan Beulich [mailto:jbeul...@suse.com] >>>Sent: Tuesday, July 14, 2015 1:53 AM >> On 14.07.15 at 02:01, wrote: >From: Jan Beulich [mailto:jbeul...@suse.com] >

Re: [Xen-devel] [PATCH v5 05/15] x86/altp2m: basic data structures and support routines.

2015-07-17 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 16, 2015 2:08 AM > On 16.07.15 at 10:57, wrote: >>> From: Jan Beulich [mailto:jbeul...@suse.com] >>>Sent: Tuesday, July 14, 2015 6:13 AM >> On 14.07.15 at 02:14, wrote: @@ -722,6 +731,27 @@ void nestedp2m_write_p2m_

Re: [Xen-devel] [PATCH v5 10/15] x86/altp2m: add remaining support routines.

2015-07-17 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 16, 2015 2:34 AM > On 16.07.15 at 11:16, wrote: >>> From: Jan Beulich [mailto:jbeul...@suse.com] >>>Sent: Tuesday, July 14, 2015 7:32 AM >> On 14.07.15 at 02:14, wrote: @@ -2965,9 +3003,15 @@ int hvm_hap_nested_page

Re: [Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-17 Thread Chris (Christopher) Brand
> It looks like the mail as been sent in HTML. Can you resend it in plain text? Re-sent, hopefully correctly this time. Chris ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] 3.18.17 Xen regression

2015-07-17 Thread Sasha Levin
On 07/17/2015 10:09 AM, Boris Ostrovsky wrote: > On 07/17/2015 09:59 AM, Ian Campbell wrote: >> On Tue, 2015-07-07 at 15:54 -0400, Boris Ostrovsky wrote: >>> Commit 63753fac67e1 ("x86: Store a per-cpu shadow copy of CR4") in >>> 3.18.y branch introduced a regression on PVH Xen guests. >>> >>> Pleas

[Xen-devel] ARM - why does setup_frametable_size() round frametable_size to 32MB ?

2015-07-17 Thread Chris (Christopher) Brand
Hi, I'm working on a platform with a mere 2GB of RAM, and trying to trim the Xen footprint down as much as possible. I've found two places where Xen uses more memory than it seems it needs to, one of which is the frametable. On a 2GB system, frametable_size is initially calculated as 16MB, but is

Re: [Xen-devel] [PATCH v5 06/15] VMX/altp2m: add code to support EPTP switching and #VE.

2015-07-17 Thread Sahita, Ravi
>From: Jan Beulich [mailto:jbeul...@suse.com] >Sent: Thursday, July 16, 2015 2:39 AM > On 16.07.15 at 11:20, wrote: >>> From: Jan Beulich [mailto:jbeul...@suse.com] >>>Sent: Tuesday, July 14, 2015 6:57 AM >> On 14.07.15 at 02:14, wrote: +static bool_t vmx_vcpu_emulate_ve(struct vcpu

Re: [Xen-devel] [PATCH v5 10/15] x86/altp2m: add remaining support routines.

2015-07-17 Thread Sahita, Ravi
>From: dunl...@gmail.com [mailto:dunl...@gmail.com] On Behalf Of George >Dunlap >Sent: Thursday, July 16, 2015 7:45 AM > >On Tue, Jul 14, 2015 at 1:14 AM, Ed White >wrote: >> Add the remaining routines required to support enabling the alternate >> p2m functionality. >> >> Signed-off-by: Ed White

[Xen-devel] [PATCH] xen: arm: Avoid reading beyond the last module

2015-07-17 Thread Chris (Christopher) Brand
nr_mods is set in add_boot_module() to the number of module array elements used. This function also ensures that nr_mods never exceeds MAX_MODULES (the size of the array). When looping through the array, the correct maximum index is "nr_mods-1", not "nr_mods". If the array is full, using the latter

Re: [Xen-devel] [PATCH v9 0/8] pci: add pci_iomap_wc() and pci_ioremap_wc_bar()

2015-07-17 Thread Luis R. Rodriguez
On Wed, Jul 08, 2015 at 06:54:11PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Ingo, > > Boris is on vacation, he picked up these patches on his bp#tip-mm tree [0] > and they have baked there for a while now. That tree receives 0-day > bot testing, but other than that its not

Re: [Xen-devel] [PATCH v2 0/6] add xsaves/xrstors support

2015-07-17 Thread Andrew Cooper
On 17/07/15 08:26, Shuai Ruan wrote: > Changes in v2: > * Address comments from Andrew/chao/Jan, mainly: > * Add details information of xsaves/xrstors feature. > * Remove XGETBV1/XSAVEC/XSAVEOPT out of 'else' in patch 3. > * Change macro name XGETBV to XGETBV1 in patch 4. > > This patchset enable x

[Xen-devel] Preface working plan for altp2m during freeze exception

2015-07-17 Thread Sahita, Ravi
Hi Maintainers, First - Thanks for all your reviews so far! As we head into this week of freeze exception for altp2m, we wanted to share our plan for addressing the remaining opens on this patch series. This may be the general operating procedure but we wanted to make sure we were operating w

Re: [Xen-devel] [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues

2015-07-17 Thread Andrew Cooper
On 17/07/15 20:05, Ting-Wei Lan wrote: > When using Linux >= 3.19 (commit 47591df) as dom0 on some Intel Ironlake > devices, It is possible to encounter graphics issues that make screen > unreadable or crash the system. It was reported in freedesktop bugzilla: > > https://bugs.freedesktop.org/show_

[Xen-devel] [PATCH] VT-d: add iommu=igfx_off option to workaround graphics issues

2015-07-17 Thread Ting-Wei Lan
When using Linux >= 3.19 (commit 47591df) as dom0 on some Intel Ironlake devices, It is possible to encounter graphics issues that make screen unreadable or crash the system. It was reported in freedesktop bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90037 As we still cannot find a prop

Re: [Xen-devel] PV-vNUMA issue: topology is misinterpreted by the guest

2015-07-17 Thread Boris Ostrovsky
On 07/17/2015 03:27 AM, Dario Faggioli wrote: On Fri, 2015-07-17 at 07:09 +0100, Jan Beulich wrote: On 16.07.15 at 18:59, wrote: And in general (both for PV and HVM) --- is there any reason to expose CPU topology at all? I can see it being useful if VCPUs are pinned but if they are not then it

Re: [Xen-devel] [PATCH v2 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-17 Thread Boris Ostrovsky
On 07/17/2015 12:43 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jul 17, 2015 at 11:36:29AM -0400, Boris Ostrovsky wrote: On 07/17/2015 11:21 AM, Konrad Rzeszutek Wilk wrote: On Thu, Jul 16, 2015 at 05:43:39PM -0400, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky --- Changes in v2: * Set s

Re: [Xen-devel] [PATCH] xl: fix vcpus to vnode assignement in config file

2015-07-17 Thread Wei Liu
On Fri, Jul 17, 2015 at 07:15:56PM +0200, Dario Faggioli wrote: > On Fri, 2015-07-17 at 17:08 +0100, Wei Liu wrote: > > On Fri, Jul 17, 2015 at 05:57:49PM +0200, Dario Faggioli wrote: > > > > Signed-off-by: Dario Faggioli > > > --- > > > Cc: Wei Liu > > > Cc: Ian Jackson > > > Cc: Ian Campbell

Re: [Xen-devel] [PATCH] xl: fix vcpus to vnode assignement in config file

2015-07-17 Thread Dario Faggioli
On Fri, 2015-07-17 at 17:08 +0100, Wei Liu wrote: > On Fri, Jul 17, 2015 at 05:57:49PM +0200, Dario Faggioli wrote: > > Signed-off-by: Dario Faggioli > > --- > > Cc: Wei Liu > > Cc: Ian Jackson > > Cc: Ian Campbell > > With two issues mentioned below fixed: > > Acked-by: Wei Liu > Thanks.

Re: [Xen-devel] [PATCH v4 2/3] libxl: localtime(3) can return NULL

2015-07-17 Thread Wei Liu
On Fri, Jul 17, 2015 at 06:05:45PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH v4 2/3] libxl: localtime(3) can return NULL"): > > Signed-off-by: Wei Liu > > > tm = localtime(&t); > > +if (!tm) { > > +LOG(ERROR, "Failed to call localtime"); > > localtime sets

Re: [Xen-devel] [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel

2015-07-17 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel"): > On 17/07/15 18:00, Ian Jackson wrote: > > No functional change. > Perhaps a comment stating that COMMON_LONG_OPTS must now be the final > entry in an option list? Previously it was te

Re: [Xen-devel] [PATCH v2 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Andrew Cooper
On 17/07/15 18:11, Ian Campbell wrote: > On Fri, 2015-07-17 at 18:01 +0100, Wei Liu wrote: >> On Fri, Jul 17, 2015 at 05:59:09PM +0100, Andrew Cooper wrote: >>> This bug causes a spurious failure if stdin happens to be an >>> appropriately readable/writeable pipe which receives a POLLHUP >>> >>> Si

Re: [Xen-devel] [PATCH v2 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Ian Campbell
On Fri, 2015-07-17 at 18:01 +0100, Wei Liu wrote: > On Fri, Jul 17, 2015 at 05:59:09PM +0100, Andrew Cooper wrote: > > This bug causes a spurious failure if stdin happens to be an > > appropriately readable/writeable pipe which receives a POLLHUP > > > > Signed-off-by: Andrew Cooper > > CC: Ian C

Re: [Xen-devel] [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel

2015-07-17 Thread Andrew Cooper
On 17/07/15 18:00, Ian Jackson wrote: > No functional change. > > Signed-off-by: Ian Jackson > --- > tools/libxl/xl_cmdimpl.c | 51 > -- > 1 file changed, 18 insertions(+), 33 deletions(-) > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cm

Re: [Xen-devel] [PATCH v4 2/3] libxl: localtime(3) can return NULL

2015-07-17 Thread Ian Jackson
Wei Liu writes ("[PATCH v4 2/3] libxl: localtime(3) can return NULL"): > Signed-off-by: Wei Liu > tm = localtime(&t); > +if (!tm) { > +LOG(ERROR, "Failed to call localtime"); localtime sets errno if it fails. So you mean LOGE. Ian.

Re: [Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-17 Thread Andrew Cooper
On 17/07/15 18:00, Ian Jackson wrote: > This adjust commit a49077e5 "Fix segfaults from `xl psr-cat-cbm-set` > command line handling": > > * Do not use the constant `required_argument' here (we simply use 1 >everywhere else). > > * Fix the minimum required arguments argument to SWITCH_FOREACH

Re: [Xen-devel] [PATCH v4 1/3] libxl: make libxl__strdup and libxl__strndup handle NULL

2015-07-17 Thread Ian Jackson
Wei Liu writes ("[PATCH v4 1/3] libxl: make libxl__strdup and libxl__strndup handle NULL"): > Signed-off-by: Wei Liu Acked-by: Ian Jackson ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 3/3] libxl: call libxl_cpupoolinfo_{init, dispose} in numa_place_domain

2015-07-17 Thread Ian Jackson
Wei Liu writes ("[PATCH v4 3/3] libxl: call libxl_cpupoolinfo_{init,dispose} in numa_place_domain"): > Call libxl_cpupoolinfo_init at the beginning. Change two returns to > goto out so that libxl_cpupoolinfo_dispose is called in failure path. Acked-by: Ian Jackson _

[Xen-devel] [PATCH 4/5] xl: Command line: Make COMMON_LONG_OPTS include sentinel

2015-07-17 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- tools/libxl/xl_cmdimpl.c | 51 -- 1 file changed, 18 insertions(+), 33 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 803c627..1fa98e6 100644 --- a/tools/libxl

[Xen-devel] [PATCH v4 1/3] libxl: make libxl__strdup and libxl__strndup handle NULL

2015-07-17 Thread Wei Liu
Signed-off-by: Wei Liu --- v4: add doc, also handle strndup variant. --- tools/libxl/libxl_internal.c | 12 ++-- tools/libxl/libxl_internal.h | 7 +-- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c index 24a

[Xen-devel] [PATCH 3/5] xl: Command line: Support -h everywhere

2015-07-17 Thread Ian Jackson
xl subcommands ought all to take -h. def_getopt and hence SWITCH_FOREACH_OPT already handles 'h' by calling helpstr. None of the call sites see the 'h'. In this patch: * Change SWITCH_FOREACH_OPT to always add a "h" to the short opts string, using string concatenation. * Remove the now-re

[Xen-devel] [PATCH v4 2/3] libxl: localtime(3) can return NULL

2015-07-17 Thread Wei Liu
Signed-off-by: Wei Liu --- v4: add logging --- tools/libxl/libxl_x86.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c index 8cd15ca..ce14a73 100644 --- a/tools/libxl/libxl_x86.c +++ b/tools/libxl/libxl_x86.c @@ -311,6 +311,12 @@ int li

Re: [Xen-devel] [PATCH v2 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Wei Liu
On Fri, Jul 17, 2015 at 05:59:09PM +0100, Andrew Cooper wrote: > This bug causes a spurious failure if stdin happens to be an > appropriately readable/writeable pipe which receives a POLLHUP > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > Acked-by: Wei L

[Xen-devel] [PATCH 5/5] xl: Command line: Support xl vcpu-set --help

2015-07-17 Thread Ian Jackson
This ended with a literal sentinel. Use COMMON_LONG_OPTIONS (which mentions --help) instead. Signed-off-by: Ian Jackson --- tools/libxl/xl_cmdimpl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 1fa98e6..337f805

[Xen-devel] [PATCH v4 0/3] xl/libxl: fix some issues discovered by coverity

2015-07-17 Thread Wei Liu
Wei Liu (3): libxl: make libxl__strdup and libxl__strndup handle NULL libxl: localtime(3) can return NULL libxl: call libxl_cpupoolinfo_{init,dispose} in numa_place_domain tools/libxl/libxl_dom.c | 5 +++-- tools/libxl/libxl_internal.c | 12 ++-- tools/libxl/libxl_internal.h |

[Xen-devel] [PATCH v4 3/3] libxl: call libxl_cpupoolinfo_{init, dispose} in numa_place_domain

2015-07-17 Thread Wei Liu
Call libxl_cpupoolinfo_init at the beginning. Change two returns to goto out so that libxl_cpupoolinfo_dispose is called in failure path. Signed-off-by: Wei Liu --- tools/libxl/libxl_dom.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_dom.c b/tools/l

[Xen-devel] [PATCH 2/5] xl: Command line: Remove maximum argument limit for network-attach

2015-07-17 Thread Ian Jackson
This limit of 11 has been in this function since it was written, but serves no purpose. The extra arguments are fed one by one to parse_nic_config, and it is possible to have as many as you like. Signed-off-by: Ian Jackson --- tools/libxl/xl_cmdimpl.c |5 - 1 file changed, 5 deletions(-

[Xen-devel] [PATCH 1/5] xl: Command line: Adjust "Fix segfaults from `xl psr-cat-cbm-set`..."

2015-07-17 Thread Ian Jackson
This adjust commit a49077e5 "Fix segfaults from `xl psr-cat-cbm-set` command line handling": * Do not use the constant `required_argument' here (we simply use 1 everywhere else). * Fix the minimum required arguments argument to SWITCH_FOREACH_OPT. Leave the separate check on optind, because

[Xen-devel] [PATCH v2 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Andrew Cooper
This bug causes a spurious failure if stdin happens to be an appropriately readable/writeable pipe which receives a POLLHUP Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- Correct writefd in libxl_stream_write.c --- tools/libxl/libxl_stream_read.c |1 + too

Re: [Xen-devel] [PATCH 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Andrew Cooper
On 17/07/15 17:55, Wei Liu wrote: > On Fri, Jul 17, 2015 at 05:51:18PM +0100, Andrew Cooper wrote: >> This bug causes a spurious failure if stdin happens to be an >> appropriately readable/writeable pipe which receives a POLLHUP >> >> Signed-off-by: Andrew Cooper >> CC: Ian Campbell >> CC: Ian Ja

Re: [Xen-devel] [PATCH 1/4] tools/libxc: Identify the path of the kernel image which cannot be found

2015-07-17 Thread Wei Liu
On Fri, Jul 17, 2015 at 05:51:15PM +0100, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu Acked-by: Wei Liu > > --- > This is rather quicker than using strace to find out that I had > forgotten to ./configure --prefix=/usr > --- > tool

Re: [Xen-devel] [PATCH 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Wei Liu
On Fri, Jul 17, 2015 at 05:51:18PM +0100, Andrew Cooper wrote: > This bug causes a spurious failure if stdin happens to be an > appropriately readable/writeable pipe which receives a POLLHUP > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu > --- > tools/libx

Re: [Xen-devel] [PATCH 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Ian Campbell
On Fri, 2015-07-17 at 17:51 +0100, Andrew Cooper wrote: > This bug causes a spurious failure if stdin happens to be an > appropriately readable/writeable pipe which receives a POLLHUP > > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu Acked-by: Ian Campbell

Re: [Xen-devel] [PATCH 1/4] tools/libxc: Identify the path of the kernel image which cannot be found

2015-07-17 Thread Ian Campbell
On Fri, 2015-07-17 at 17:51 +0100, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper > CC: Ian Campbell > CC: Ian Jackson > CC: Wei Liu Acked-by: Ian Campbell ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH 1/4] tools/libxc: Identify the path of the kernel image which cannot be found

2015-07-17 Thread Andrew Cooper
Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- This is rather quicker than using strace to find out that I had forgotten to ./configure --prefix=/usr --- tools/libxc/xg_private.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxc/

[Xen-devel] [PATCH 0/4] Fix to libxl migration v2 issue blocking OSSTest

2015-07-17 Thread Andrew Cooper
And three improvements to debugging. Note that there is still a bug in libxl__toolstack_save() which valgrind identified, but I do not wish to block this bugfix on that Andrew Cooper (4): tools/libxc: Identify the path of the kernel image which cannot be found tools/libxl: Log the subject

[Xen-devel] [PATCH 4/4] tools/libxl: Initialise the fd of the unused half of a datacopier

2015-07-17 Thread Andrew Cooper
This bug causes a spurious failure if stdin happens to be an appropriately readable/writeable pipe which receives a POLLHUP Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/libxl_stream_read.c |1 + tools/libxl/libxl_stream_write.c |1 + 2 fil

[Xen-devel] [PATCH 3/4] tools/libxl: Identify copywhat in stream v2 datacopiers

2015-07-17 Thread Andrew Cooper
This is an aid to debugging Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/libxl_stream_read.c | 18 ++ tools/libxl/libxl_stream_write.c |4 +++- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/tools/libxl/libxl

[Xen-devel] [PATCH 2/4] tools/libxl: Log the subject fd in datacopier messages

2015-07-17 Thread Andrew Cooper
This is a substantial aid to debugging Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu --- tools/libxl/libxl_aoutils.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tools/libxl/libxl_aoutils.c b/tools/libxl/libxl_aou

Re: [Xen-devel] [PATCH v1 05/10] xen/pt: Remove XenPTReg->data field.

2015-07-17 Thread Konrad Rzeszutek Wilk
On Fri, Jul 17, 2015 at 05:30:39PM +0100, Stefano Stabellini wrote: > On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > > We do not want to have two entries to cache the guest configuration > > registers: XenPTReg->data and dev.config. Instead we want to use > > only the dev.config. > > > > To do

Re: [Xen-devel] [PATCH v1 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size

2015-07-17 Thread Konrad Rzeszutek Wilk
On Fri, Jul 17, 2015 at 05:03:44PM +0100, Stefano Stabellini wrote: > On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > > It should never happen, but in case it does (an developer adds > > a new register and the 'init_val' expands past the register > > size) we want to report. The code will only w

Re: [Xen-devel] [PATCH OSSTEST 2/4] Toolstack: Add OpenStack as a toolstack.

2015-07-17 Thread Ian Campbell
On Fri, 2015-07-17 at 17:32 +0100, Anthony PERARD wrote: > > Given that and given that you introduce your own recipe to sg-run-job > > which doesn't/can't/won't try to do any of the usual stuff, I can't see > > any reason not to simply go with toolstack=libvirt for these test cases. > > That it is

Re: [Xen-devel] [PATCH v2 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-17 Thread Konrad Rzeszutek Wilk
On Fri, Jul 17, 2015 at 11:36:29AM -0400, Boris Ostrovsky wrote: > On 07/17/2015 11:21 AM, Konrad Rzeszutek Wilk wrote: > >On Thu, Jul 16, 2015 at 05:43:39PM -0400, Boris Ostrovsky wrote: > >>Signed-off-by: Boris Ostrovsky > >>--- > >>Changes in v2: > >>* Set segment selectors using loadsegment()

Re: [Xen-devel] Request a freeze exception for COLO in v4.6

2015-07-17 Thread Eddie Dong
> If I can take one example, 11/25 "tools/libxc: support to resume uncooperative > HVM guests". Based on my current understanding this is even a bugfix. Sadly > it > is not quite ready (or at least, wasn't last night). But with a few more > days we > can probably get much of this cleanup an

Re: [Xen-devel] Request a freeze exception for COLO in v4.6

2015-07-17 Thread Eddie Dong
> If I can take one example, 11/25 "tools/libxc: support to resume uncooperative > HVM guests". Based on my current understanding this is even a bugfix. Sadly > it > is not quite ready (or at least, wasn't last night). But with a few more > days we > can probably get much of this cleanup an

Re: [Xen-devel] [PATCH] xen/pt: Don't slurp wholesale the PCI configuration registers

2015-07-17 Thread Stefano Stabellini
On Wed, 8 Jul 2015, Konrad Rzeszutek Wilk wrote: > Instead we have the emulation registers ->init functions which > consult the host values to see what the initial value should be > and they are responsible for populating the dev.config. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stef

Re: [Xen-devel] [PATCH OSSTEST 0/4] Have OpenStack tested on top of xen's master and libvirt's master.

2015-07-17 Thread Ian Campbell
On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > I've introduce an extra Osstest::Toolstack which help to install extra > package, I've commented on this. > and use ballonning for Dom0, 500MB for Dom0 is definetly not > enough. This is for overriding Dom0MemFixed I think? I think go

Re: [Xen-devel] [PATCH OSSTEST 2/4] Toolstack: Add OpenStack as a toolstack.

2015-07-17 Thread Anthony PERARD
On Fri, Jul 17, 2015 at 04:58:16PM +0100, Ian Campbell wrote: > On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > > Having a separate toolstack help to configure the host specificly for > > "specifically" > > > OpenStack, and also helps to have a separate flight. > > Will any of the die

Re: [Xen-devel] [PATCH v1 05/10] xen/pt: Remove XenPTReg->data field.

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > We do not want to have two entries to cache the guest configuration > registers: XenPTReg->data and dev.config. Instead we want to use > only the dev.config. > > To do without much complications we rip out the ->data field > and replace it with an

Re: [Xen-devel] [PATCH 1/6] x86/xsaves: enable xsaves/xrstors for pv guest

2015-07-17 Thread Konrad Rzeszutek Wilk
On Fri, Jul 17, 2015 at 03:26:51PM +0800, Shuai Ruan wrote: > This patch emualtes xsaves/xrstors instructions and emulates > XSS msr access. > > As xsaves/xrstors instructions and XSS msr access > required be executed only in ring0. So emulation are > needed when pv guest uses these instructions.

Re: [Xen-devel] [PATCH v1 08/10] xen/pt: Make xen_pt_unregister_device idempotent

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > To deal with xen_host_pci_[set|get]_ functions returning error values > and clearing ourselves in the init function we should make the > .exit (xen_pt_unregister_device) function be idempotent in case > the generic code starts calling .exit (or for

Re: [Xen-devel] [PATCH OSSTEST 3/4] ts-devstack: Deploy OpenStack then test it with Tempest

2015-07-17 Thread Ian Campbell
On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > +sub deploy() { > + # This clone many repos and may take sometime until the GitProxyCache is > + # filled Can we find those repos and therefore record the version actual in use via store_vcs_revision? Even without the ability to contro

Re: [Xen-devel] [v9][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-17 Thread Chen, Tiejun
On 2015/7/18 0:06, Jan Beulich wrote: On 17.07.15 at 17:54, wrote: +for ( i = nr-1; i > memory_map.nr_map; i-- ) Before you add memory_map.nr_map, you should be able to iterate from 0 to (not inclusive) nr. At least as far as I recall the original patch. Sorry, I really don't understa

Re: [Xen-devel] [PATCH OSSTEST 4/4] Create a flight to test OpenStack with xen-unstable and libvirt.

2015-07-17 Thread Ian Campbell
On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD > --- > ap-common| 4 > ap-fetch-version | 4 > ap-fetch-version-old | 5 + > ap-print-url | 3 +++ This all looks correct, but since you hardcode master in make-flig

Re: [Xen-devel] [PATCH v1 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > It should never happen, but in case it does (an developer adds > a new register and the 'init_val' expands past the register > size) we want to report. The code will only write up to > reg->size so there is no runtime danger of the register spillin

Re: [Xen-devel] [PATCH] xl: fix vcpus to vnode assignement in config file

2015-07-17 Thread Wei Liu
On Fri, Jul 17, 2015 at 05:57:49PM +0200, Dario Faggioli wrote: > In fact, right now, if the "vcpus=" list (where the > user specifies what vcpus should be part of a vnode) > has multiple elements, things don't work. > E.g., the following examples all result in failure > to create the guest: > >

Re: [Xen-devel] [v9][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-17 Thread Jan Beulich
>>> On 17.07.15 at 17:54, wrote: >> > +for ( i = nr-1; i > memory_map.nr_map; i-- ) >> >> Before you add memory_map.nr_map, you should be able to iterate >> from 0 to (not inclusive) nr. At least as far as I recall the original >> patch. >> > > Sorry, I really don't understand what you want.

Re: [Xen-devel] [PATCH OSSTEST 3/4] ts-devstack: Deploy OpenStack then test it with Tempest

2015-07-17 Thread Ian Campbell
On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > +cd $builddir/devstack > +>local.conf > +echo >>local.conf '[[local|localrc]]' > +echo >>local.conf ADMIN_PASSWORD=`pwgen 20 1` > +echo >>local.conf DATABASE_PASSWORD=`pwgen 20 1` > +echo >>local.conf RABBIT_PASSWORD

Re: [Xen-devel] [PATCH v1 04/10] xen/pt: Use xen_host_pci_get_[byte, word, long] instead of xen_host_pci_get_long

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > Otherwise we get: > > xen_pt_config_reg_init: Offset 0x0004 mismatch! Emulated=0x, > host=0x2300017, syncing to 0x2300014. > xen_pt_config_reg_init: Error: Offset 0x0004:0x2300014 expands past register > size(2)! > > which is not surprising

Re: [Xen-devel] [PATCH OSSTEST 2/4] Toolstack: Add OpenStack as a toolstack.

2015-07-17 Thread Ian Campbell
On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > Having a separate toolstack help to configure the host specificly for "specifically" > OpenStack, and also helps to have a separate flight. Will any of the die()s here ever become real commands? I think not because that's not how OpenSta

[Xen-devel] [PATCH] xl: fix vcpus to vnode assignement in config file

2015-07-17 Thread Dario Faggioli
In fact, right now, if the "vcpus=" list (where the user specifies what vcpus should be part of a vnode) has multiple elements, things don't work. E.g., the following examples all result in failure to create the guest: [ "pnode=0","size=512","vcpus=0,2","vdistances=10,20" ] [ "pnode=0","size=51

Re: [Xen-devel] [PATCH v1 02/10] xen/pt: Sync up the dev.config and data values.

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > For a passthrough device we maintain a state of emulated > registers value contained within d->config. We also consult > the host registers (and apply ro and write masks) whenever > the guest access the registers. This is done in xen_pt_pci_write_c

Re: [Xen-devel] [v9][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-17 Thread Chen, Tiejun
+for ( i = nr-1; i > memory_map.nr_map; i-- ) Before you add memory_map.nr_map, you should be able to iterate from 0 to (not inclusive) nr. At least as far as I recall the original patch. Sorry, I really don't understand what you want. Before we add memory_map.nr_map, e820[0, nr) don't i

Re: [Xen-devel] [PATCH OSSTEST 0/4] Have OpenStack tested on top of xen's master and libvirt's master.

2015-07-17 Thread Ian Campbell
On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > For the last patch, I've tried to have ./standalone make-flight have only > the necessary jobs to run test-amd64-amd64-devstack, but there is still > build-xsm in the list. In my Debian distro series there is patch to add "mfi-common: Allo

Re: [Xen-devel] [PATCH OSSTEST 1/4] ts-kernel-build: Enable CONFIG_NETFILTER_XT_TARGET_CHECKSUM

2015-07-17 Thread Ian Campbell
On Thu, 2015-07-16 at 12:18 +0100, Anthony PERARD wrote: > This iptables target CHECKSUM is used by OpenStack. > > Signed-off-by: Anthony PERARD Acked-by: Ian Campbell > --- > ts-kernel-build | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/ts-kernel-build b/ts-kernel-build > in

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Julien Grall
On 17/07/15 16:34, Ian Campbell wrote: > On Fri, 2015-07-17 at 16:15 +0100, Julien Grall wrote: > Also, you have to translate the col_id into to a VCPU ID. >>> >>> This is virtual collection id which itself is vcpu id. isn't it? >> >> No. A collection can move between CPU, so you will en

Re: [Xen-devel] [PATCH v1 01/10] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > During init time we treat the dev.config area as a cache > of the host view. However during execution time we treat it > as guest view (by the generic PCI API). We need to sync Xen's > code to the generic PCI API view. This is the first step > by r

Re: [Xen-devel] pre-cursor email to incremental rev6 of altp2m patch series

2015-07-17 Thread Sahita, Ravi
>From: Wei Liu [mailto:wei.l...@citrix.com] >Sent: Friday, July 17, 2015 4:25 AM > >On Fri, Jul 17, 2015 at 11:51:16AM +0100, Andrew Cooper wrote: >> On 16/07/15 22:36, Sahita, Ravi wrote: >> > Hi Wei and Maintainers, >> > >> > While we continue to work on the maintainer review comments - we >> > p

Re: [Xen-devel] RFC on deprivileged x86 hypervisor device models

2015-07-17 Thread Jan Beulich
>>> On 17.07.15 at 17:19, wrote: > On 17/07/15 15:20, Jan Beulich wrote: >> If not, then method 2 would seem quite a bit less troublesome than >> method 1, yet method 3 would (even if more involved in terms of >> changes to be done) perhaps result in the most elegant result. > I agree that method

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-17 Thread Chen, Tiejun
I think Andrew means you (or someone else) improves that algorithm later. No need to provide a perfect solution next week. Yes, I understand what he mean. But I still want to further ask if he have such a good idea right now, maybe we can try to address that directly :) Thanks Tiejun _

Re: [Xen-devel] [PATCH v2 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-17 Thread Boris Ostrovsky
On 07/17/2015 11:21 AM, Konrad Rzeszutek Wilk wrote: On Thu, Jul 16, 2015 at 05:43:39PM -0400, Boris Ostrovsky wrote: Signed-off-by: Boris Ostrovsky --- Changes in v2: * Set segment selectors using loadsegment() instead of assembly arch/x86/xen/enlighten.c | 15 ++- 1 file chang

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Ian Campbell
On Fri, 2015-07-17 at 16:15 +0100, Julien Grall wrote: > >> > >> Also, you have to translate the col_id into to a VCPU ID. > > > > This is virtual collection id which itself is vcpu id. isn't it? > > No. A collection can move between CPU, so you will end up to have vCPUID > != vCID. Specificall

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-17 Thread Wei Liu
On Fri, Jul 17, 2015 at 11:26:30PM +0800, Chen, Tiejun wrote: > >The PCI allocation code is in a state, but it was in a similarly bad > >state before. I agree with Jan's point of the risk that these new > >changes cause a regression in booting guests, although we can mitigate > >that somewhat by t

Re: [Xen-devel] [PATCH v1 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > If XEN_PT_LOGGING_ENABLED is enabled the XEN_PT_LOG macros start > using the first argument. Which means if within the function there > is only one user of the argument ('d') and XEN_PT_LOGGING_ENABLED > is not set, we get compiler warnings. This i

Re: [Xen-devel] [v9][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-17 Thread Jan Beulich
>>> On 17.07.15 at 17:22, wrote: > Do you mean I should check low/high mem before we add the hypervisor > supplied entries Yes. > like this? Not exactly: > +for ( i = nr-1; i > memory_map.nr_map; i-- ) Before you add memory_map.nr_map, you should be able to iterate from 0 to (not inclusi

Re: [Xen-devel] [PATCH v1 5/6] xen/pt/msi: Add the register value when printing logging and error messages

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > We would like to know what the MSI register value is to help > in troubleshooting in the field. As such modify the logging > logic to include such details in xen_pt_msgctrl_reg_write. > > Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Stefano

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-17 Thread Chen, Tiejun
The PCI allocation code is in a state, but it was in a similarly bad state before. I agree with Jan's point of the risk that these new changes cause a regression in booting guests, although we can mitigate that somewhat by testing. I feel at this point that we shouldn't block the RMRR bugfix on

Re: [Xen-devel] [PATCH v1 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap

2015-07-17 Thread Stefano Stabellini
On Thu, 2 Jul 2015, Konrad Rzeszutek Wilk wrote: > In Xen 4.6 commit cd2f100f0f61b3f333d52d1737dd73f02daee592 > "libxc: Fix do_memory_op to return negative value on errors" > made the libxc API less odd-ball: On errors, return value is > -1 and error code is in errno. On success the return value >

Re: [Xen-devel] [v9][PATCH 07/16] hvmloader/e820: construct guest e820 table

2015-07-17 Thread Chen, Tiejun
On 2015/7/17 18:50, Jan Beulich wrote: On 17.07.15 at 11:09, wrote: And then of course there's the question of whether "nr" is really the right upper loop bound here: Just prior to this you added the hypervisor supplied entries - why would you need to iterate over them here? I.e. I'd see this b

Re: [Xen-devel] [PATCH v2 5/6] xen/x86/pvh: Add 32-bit PVH initialization code

2015-07-17 Thread Konrad Rzeszutek Wilk
On Thu, Jul 16, 2015 at 05:43:40PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk > --- > Changes in v2: > * Some code reshuffling due to changes in patch 1. > > arch/x86/xen/enlighten.c | 4 > arch/x86/xen/smp.c | 16 +

Re: [Xen-devel] [PATCH v2 4/6] xen/x86/pvh: Set up descriptors for 32-bit PVH guests

2015-07-17 Thread Konrad Rzeszutek Wilk
On Thu, Jul 16, 2015 at 05:43:39PM -0400, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > --- > Changes in v2: > * Set segment selectors using loadsegment() instead of assembly > > arch/x86/xen/enlighten.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > di

Re: [Xen-devel] RFC on deprivileged x86 hypervisor device models

2015-07-17 Thread Ben Catterall
On 17/07/15 15:20, Jan Beulich wrote: On 17.07.15 at 12:09, wrote: Moving between privilege levels The general process is to determine if we need to run a device model (or similar) and then, if so, switch into deprivileged mode. The operation is performed by d

Re: [Xen-devel] [PATCH v4 07/17] xen/arm: ITS: Add virtual ITS commands support

2015-07-17 Thread Julien Grall
On 17/07/15 15:12, Vijay Kilari wrote: > Hi Julien, Hi Vijay, > On Wed, Jul 15, 2015 at 6:27 PM, Julien Grall wrote: >> On 10/07/2015 09:42, vijay.kil...@gmail.com wrote: >>> >>> From: Vijaya Kumar K >>> >>> Add Virtual ITS command processing support to Virtual ITS driver >>> >>> Signed-off-by:

Re: [Xen-devel] Requesting for freeze exception for RMRR

2015-07-17 Thread Andrew Cooper
On 17/07/15 15:01, Wei Liu wrote: > On Fri, Jul 17, 2015 at 02:43:05PM +0100, Jan Beulich wrote: > On 17.07.15 at 15:21, wrote: >>> The major concern seems to be around the PCI allocation algorithm. Jan >>> has different opinion from George. George provided a simple solution >>> that will not

  1   2   >